- 21 Jul, 2020 40 commits
-
-
Gavin Williams authored
Using on-blur simplifies closing the dropdown for clicks registered outside of print preview. And now that we don't have to specifically listen for clicks outside of print preview, on-click can be used instead of pointerdown. Bug: 1059607 Change-Id: I9225ec9e06e3197b9f2eae4ac078b29fa232a791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303368 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#790384}
-
Michele Mancina authored
Change-Id: Ia351a4496c5e782c283e2aea08e6d20393979391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297562 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#790383}
-
Richard Stotz authored
Bug: 1097126 Change-Id: I3775c97543b4603e910f5cf4ec1f5a7207fd7276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308420Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Richard Stotz <rstz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790382}
-
arthursonzogni authored
All of this is put behind a flag disabled by default. This is mostly based on the initial prototype: https://chromium-review.googlesource.com/c/chromium/src/+/2223934/24 Partially implement the QueueAccessReport function. A simple report is sent containing: - disposition - effective-policy - property but missing for now: - blocked-window-url - source-file - line-no - col-no - violation-type COOP access reporting: [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [4/N] this patch. Bug: chromium:1090273 Change-Id: Ib5ed9fc598f437459a6b57e35875be6fbf5a63b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273120 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790381}
-
Mugdha Lakhani authored
This is so WebLayer can use it to support NoStatePrefetch. Bug: 1096088 Change-Id: Iedae9f5248d37da9aacd9c739719c9889c1949bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236482Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#790380}
-
Marc Treib authored
It was referencing a closed bug. Bug: 1107741 Change-Id: I54d8c4a7eff4ebc555943ba0436f725f9da46c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309690 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#790379}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e875f72dc66f..c1eb58de32c0 2020-07-21 reed@google.com MallocPixelRef should always allocate as large as computeByteSize() says 2020-07-21 robertphillips@google.com Convert more tests to GrRecordingContext/GrDirectContext 2020-07-21 adlai@google.com Reland "Remove more GrContext imports & usage" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1103827 Tbr: robertphillips@google.com Change-Id: I55a75abf9a0d247acbb41268e81b0b52b84f2443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790378}
-
Mark Brand authored
Removes support for the legacy Ptr, Request, AssociatedPtr, AssociatedRequest types. This will break while there are .mojom files that use any of these types. Change-Id: I221115bc89989a73beebb2d5fcdd7fc51d60cfd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247727 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#790377}
-
Justin Cohen authored
This reverts commit 3fef6172. Reason for revert: This is still failing downstream. https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/12473 Brief investigation shows it may be related to the page loading under the toolbar. Original change's description: > [ios] Fix and reenable testChildTabOrdering EG test > > The fix was copied from context_menu_egtest.mm which is to add a matcher > for context menu button. > > Bug: 1106739 > Change-Id: I1e89c3ccbc081aa0ff254a0a8bef535ed02054a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304963 > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Auto-Submit: Eugene But <eugenebut@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790046} TBR=eugenebut@chromium.org,michaeldo@chromium.org Change-Id: I81452aa5c8521f5f0b33ee7efb7db83873ce3f62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309070Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790376}
-
Shelley Vohr authored
https://chromium-review.googlesource.com/c/chromium/src/+/2295780 added UKM around prefetch accuracy stats, which involved an added line in PreconnectManager::TryToLaunchPreresolveJobs() that did not check the WeakPtr before using it. This fixes that. Change-Id: I3cdf84d0f84fb9cc59811817efb1bdd42d15cf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309029Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#790375}
-
Jérôme Lebel authored
Adding UIBlockerManager protocol (implemented by AppState) and UIBlockerTarget protocol (implemented by SceneState), so ScopedUIBlocker is not dependent anymore to: //ios/chrome/app/application_delegate:application_delegate_internal //ios/chrome/browser/ui/main:scene And moving scoped_ui_blocker into its own target: //ios/chrome/browser/ui/scoped_ui_blocker Fixed: 1103565 Change-Id: I6cdb35bd0f9eda11b0c8033eede6f5d97a0ed588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288853 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#790374}
-
Andrew Grieve authored
Mentions: * disable_android_lint * use_errorprone_java_compiler * treat_warnings_as_errors TBR=docs update Change-Id: I4bf1e320058357bbf878aedacaa9641bfa169daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308272Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790373}
-
Andrew Grieve authored
Bug: 1103108 Change-Id: I2d4fe20bfcd92b01913b99ab857f4da52e830a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309571 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#790372}
-
Stephen Nusko authored
After http://crrev/c/2256225 we had two classes of flakes. 1) The impl_destoryed_ CopyOutputResult would be non empty. 2) The callback_count_ would be incorrect. The cause of 1) was in the change that introduced the flake we called SetViewportRectAndScale() after RunUntilIdle(), but SetViewportRectAndScale() was what prevented the CopyOutputResult returned to the impl callback from being non-empty. So if we RunUntilIdle() fast enough we would still prevent the drawing and the test would pass. So the fix is to immediately call SetViewportRectAndScale() after destroying the main to ensure its always fast enough. The cause of 2) was that RunUntilIdle() runs JUST the currently posted tasks, so there was a race between RunUntilIdle() being called and during the deconstruction of the layer PostTasking the callback. The fix is to only wait for the main callback in frame 3 so we can verify that it will happen before we destroy the impl layer. And wait for the impl at the end of the test. Bug: 1096962 Change-Id: Iad066a2316f2e4df3bdf53379c87a4697d6da8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294981Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#790371}
-
Ben Kelly authored
This CL consists of the following changes: * Plumbing to remember the request method used to load a fetch Response. * Storing the request method alongside the Response in cache_storage. * Using this information in the padding computation. * Black box http web test. Bug: 1039882 Change-Id: Ifcf4a638b1de857260bf44e5683224410dc7bf26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303770Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#790370}
-
Maksim Sisov authored
This patch resolves mostly to the following pattern: #if defined(USE_X11) DoThis(); #elif defined(USE_OZONE) OzonePlatform::DoThat(); #endif Two ifdefs are combined to a single ifdef now with if (IsUsingOzonePlatform()) condition is added. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Ie8f8560ffb9ab7ab24b10412a5a612c3cc279373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250250 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#790369}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1a073785503..0bc68bd16484 2020-07-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision be103000..abd2dc65 (790129:790286) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I532e7ffb44b83fdfa0d9ab253e320234b700b25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309976Reviewed-by:
-
Hyunjune authored
getPointAtLength[1] on SVGGeometryElement should throw InvalidStateError for with non-rendered, so this patch throws InvalidStateError if there is no LayoutObject on the target element. [1] https://svgwg.org/svg2-draft/types.html#__svg__SVGGeometryElement__getPointAtLength Bug: 972979 Change-Id: I26eb5330127ebbca9fbf55d796ce8159a09bfcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147168 Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#790367}
-
Vasilii Sukhanov authored
Fixed: 1066048 Change-Id: I37daeeec01b97dd14246635322b44b9649e32cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308716 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#790366}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d9818fd6fc72..0dd63428948f 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from dd3511549b18 to bfe4f378aee6 (1 revision) 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 717e7877cac1 to 8b5ed4448dfe (3 revisions) 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ea6f21a052c9 to 97f9923235cf (4 revisions) 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from b1346703979e to 7cc0ead05174 (5 revisions) 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 9eef54b2513c to b99a6a727318 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I57cf82e25ebb906497eeaea20fd9a2c89dc8446c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309287Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates FrameHostMsg_DidStopLoading to content's FrameHost interface. The existing OnDidStopLoading is renamed to DidStopLoading. This CL moves BrowserTest.RenderIdleTime test to WebContentsImplBrowserTest.RenderIdleTime and calls mark_child_process_activity_time() through DidStopLoadingInterceptor to support the test. Bug: 1102421 Change-Id: I1bc9ea2de247637350c4081f752c5dea8eef0917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306502 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#790364}
-
Maria Kazinova authored
Got rid of duplicated arguments and combined two methods that did the same ting at one. Change-Id: I5990718aa6201bc4e10f21d5cda4a4c9521dee2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307369 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#790363}
-
Dave Tapuska authored
For some odd reason I felt it correct to add two methods named very similar that had different functionality. Remove the TextInputType method that does not query the pepper text input type and use the GetTextInputType method that actually does. BUG=1106562 Change-Id: I5adf9722e6483e23b25324c66365a9236157c0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307649 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790362}
-
Anders Hartvoll Ruud authored
This reverts commit 07fcd1a4. Reason for revert: Test become super-flaky (score:1568) after deflake-attempt Original change's description: > Update controls-strict.html. > > Initially meant to reduce flakiness but may not be related. However, the > rewrite itself may not be a bad idea for readability. > > Bug: 1103820 > Change-Id: I16420d0bbccd9665df6b3abd48139ed774ab934b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304447 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790180} TBR=mlamouri@chromium.org,steimel@chromium.org Change-Id: I2ca5e6698585e40f469e1a1ad0d5291393f129eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308421Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#790361}
-
Leo Lai authored
With preparation status as true by default in fake attestation client this test item doesn't suffer from repeationg loop and can pass now. Bug: 1107426 Change-Id: I12ccbbb323f530c19c5dc60d046af613758a3a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308626Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#790360}
-
Victor Hugo Vianna Silva authored
Bug: 1090931 Change-Id: Ia9780192a2ff860f1d59834e61ca5ab89443b9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309432 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#790359}
-
Mohamed Amir Yosef authored
Bug: 1107422 Change-Id: Ib3f37fa164053f4afacf9db646bf62fef8007cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308714 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
Also adds support for interrupts (currently untested). Interrupts in general appear to have very poor coverage. I created b/161652848 to track this independently. Bug: b/145043394 Change-Id: I48a4cdaf9a0bf45b0e206f8bf2787a13122c45d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306037Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#790357}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595310726-5356636057416b4e4d905dcd6e997d2e9409d66f.profdata to chrome-mac-master-1595330901-a1487ea0e73c84091ecbf3f0440329cfe99905ef.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7a793f4c809ebcd6ddba8d5d9c639cf61d16d4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309973Reviewed-by:
-
Omer Katz authored
Incremental marking can get steps that are entirely consumed by flushing of v8 references. This steps contribute to time spend processing worklists on the main thread, but don't contribute any marked bytes. This thus affects our marking speed computation and results in lower than actual marking speed. The lower speed leads to longer step duration which causes marking to do more work than actually needed on the mutator thread. Step duration for minimum steps (i.e. step meant to mark just 64kb) could reach over 0.5ms due to this and similar issues. Ignoring flushing time in the speed computation prevents these uncontrolled false drops in marking speed and maintains a mostly consistent minimum step duration. Bug: 986235 Change-Id: I23132d65680ef19bedad8d8efffd0b92d439af1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297500 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790355}
-
Eric Leese authored
The test needs to be temporarily disabled, but I previously set the test expectation based on an earlier version of the cl I am trying to check in. (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2266998) Bug: chromium:1094436 Change-Id: I85389a4db43630f2948f0677e5537483dbcb300d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308413 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#790354}
-
Anders Hartvoll Ruud authored
There seems to be no reason to copy it. Change-Id: I89779533927d3b3d2a3ca912226eba723d9bc5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306149 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790353}
-
Ian Barkley-Yeung authored
Add unit tests for FileEnumerator::GetInfo(), since it didn't have any. Change-Id: Ia15f59c89349943b4f44ef7eeb7ba0d561ace45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297816 Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/596f21fb..c29401c0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia5e61888d307477909227e073034c3906b26d526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309740Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790351}
-
Hiroki Nakagawa authored
As a part of the OnionSoup project, this CL moves transferrable_url_loader.mojom from content/public/common/ to third_party/blink/public/mojom/loader so that subsequent CLs can move content::ChildURLLoaderFactoryBundle that depends on this mojom file into third_party/blink/. This is a mechanical change, and doesn't affect functional behavior. Bug: 860403 Change-Id: I83c77e2d2dfd2da4068580b75b953d0c83e12f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306123Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Mark Brand authored
Change-Id: Ic2a90c5348e7f23366ff7325d418ce6ba53ca81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302057Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#790349}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e687db2bbe11..e875f72dc66f 2020-07-21 rmistry@google.com Add documentation link for canary bots If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I85e19904878037852738f4c75cb9d8e5a2ecea56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309285Reviewed-by:
-
Eliot Courtney authored
This CL moves a bunch of code to WaylandSurface. It also tries to minimize access to the underlying wl_surface* but it's not always possible - some code locations need to access the pointer to create other wayland objects. This CL also tries to reduce the assumption that a single WaylandSurface corresponds to a single WaylandWindow - hence adding root_surface etc everywhere. Bug: 1099838 Test: unit tests; running chrome still works Change-Id: If2c9fb028d7494003c493cda761c643a98b0b23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299662Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#790347}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I3311290b6fe2d59b9f4fedbce9f0e5bb2a06a102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309435Reviewed-by:
-
Andreea Costinas authored
This CL implements requesting proxy authentication credentials from the NetworkService instance of the primary user Profile's default StoragePartition when System-proxy signals that it requires credentials. System-proxy is a new system service on CrOS that performs authentication and connection setup for CrOS services and ARC apps that are proxy aware, but can't perform the authentication challenge themselves. Bug:1042642 Test:unittests, services_unittests, manually on DUT Change-Id: I1d79da46ee9537c75131ff5e734fb39e525e0d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279193 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#790345}
-
