- 15 May, 2020 10 commits
-
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/587a3f48499d..5c42ec0fc575 $ git log 587a3f484..5c42ec0fc --date=short --no-merges --format='%ad %ae %s' 2020-05-14 dalecurtis Update patches file for fixes. 2020-05-14 dalecurtis [mov] Don't allow negative sample sizes. 2020-05-14 dalecurtis [utils, mathematics] Fix overflow in compute_pkt_fields(). 2020-05-14 dalecurtis [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample(). 2020-05-14 dalecurtis [oggparsetheora] Use av_sat_sub64() when updating pts by duration. 2020-05-14 dalecurtis Use av_sat_add64() when updating start_time by skip_samples. 2020-05-01 dalecurtis Use gcc/clang builtins for av_sat_(add|sub)_64_c if available. 2020-04-30 dalecurtis Add saturated add/sub operations for int64_t. Created with: roll-dep src/third_party/ffmpeg TBR=sandersd Fixed: 904094, 915518, 930106, 1069327, 1073260, 1061648 Change-Id: I07505bd5094cca7e5f68c24dd3e2f15553c9e55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203141Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#769069}
-
Brian Sheedy authored
Switches the new GPU CrOS builders off the gpu_fyi_tests mb mixin, as we don't want to build the internal gles conform tests. Bug: 1080424 Change-Id: I7d73e04304e3e49abd2fa3e1167bbbc604192f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203220 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#769068}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3e36f6883143..2da665244251 git log 3e36f6883143..2da665244251 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 tsepez@chromium.org Retain owning layout items earlier in CXFA_FFField 2020-05-14 thestig@chromium.org Remove unreachable code in ProgressiveDecoder. 2020-05-14 thestig@chromium.org Remove non-const reference params in ProgressiveDecoder. 2020-05-14 thestig@chromium.org Rename ModuleIface to ProgressiveDecoderIface. 2020-05-14 thestig@chromium.org Add another test case for FPDFImageObj_GetImageMetadata(). 2020-05-14 thestig@chromium.org Remove fx_freetype_warnings config. 2020-05-14 thestig@chromium.org Remove JpxModule. 2020-05-14 thestig@chromium.org Remove an unused flag in fx_lcms2_warnings config. 2020-05-14 thestig@chromium.org Limit fx_libopenjpeg_warnings config. 2020-05-14 nigi@chromium.org Fix FPDFAnnotEmbedderTest.AddAndModifyText for Skia. Created with: gclient setdep -r src/third_party/pdfium@2da665244251 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1082597 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I49c33a1fb1f965fc82d6a4ba20037a42218cc76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203179Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769067}
-
David Bertoni authored
tests. The SelectTargetWithoutExtension and SelectTargetWithExtension tests were disabled on TSAN configurations because they flaky. I ran these tests for 3000 iterations on TSAN bots without any failures. Bug: 859317 Change-Id: Ie8031f79b8725229d7dc5294855ef89730084d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199996 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#769066}
-
Garrett Beaty authored
Change-Id: Idf1d385aa82f73079ca1409c986be3ac1778efe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199926 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#769065}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/114e8f0ee53b..b585f051c365 $ git log 114e8f0ee..b585f051c --date=short --no-merges --format='%ad %ae %s' 2020-05-14 martin checkasm: arm: Offset the location of the stack canary reference 2020-05-13 martin checkasm: arm32: Take the number of stack arguments into account when checking for stack clobbering 2020-05-13 martin checkasm: arm64: Take the number of stack arguments into account when checking for stack clobbering 2020-05-13 gramner checkasm: Cosmetics 2020-05-12 gramner checkasm: Skip printing the seed when using --list-functions 2020-05-12 matthieu.bouron checkasm: arm64: Avoid overwriting the v0/q0/d0/s0 register 2020-05-12 martin checkasm: arm: Don't use blx to call checkasm_fail_func 2020-04-29 code CI: Add 32 bit instruction set test 2020-04-29 code CI: Optimise multi-threading tests 2020-04-11 code CI: Optimise instruction set tests 2020-04-10 code CI: Add multi-threading to conformance tests 2020-04-03 code CI: Run conformance tests with different instruction sets 2020-05-11 martin checkasm: filmgrain: Fix benchmarking in 16 bpc mode 2020-05-10 gramner cli: Reduce fps fraction in ivf parsing 2020-05-10 gramner x86: Use 'test' instead of 'or' to compare with zero 2020-05-10 gramner x86: Unconditionally compile msac_init.c 2020-05-10 gramner x86-64: Do msac refill before calling dav1d_msac_init_x86() 2020-05-10 gramner msac: Avoid attempting to refill after eob has already been reached 2020-04-11 martin arm64: itx: Add NEON implementation of itx for 10 bpc 2020-05-05 martin arm: Mark global symbols hidden 2020-04-09 martin arm64: itx: Prepare for other bitdepths 2020-04-11 martin itx: Add a bpc parameter to the itx dsp init function 2020-05-05 martin arm64: itx: Share code for the three horz_16x8 functions 2020-05-04 martin arm64: itx: Fix the eob checking for dct_dct_64x16 2020-05-03 martin arm64: itx: Simplify inv_txfm_horz_dct_32x8 2020-04-28 martin arm64: itx: Minor optimizations for the 8x32 functions 2020-04-28 martin arm64: itx: Cosmetic fix up 2020-05-04 martin arm64: itx: Remove an unused constant 2020-05-05 martin arm64: itx: Remove a todo comment about more special cased functions 2020-04-12 martin arm64: itx: Remove a now unused macro 2020-05-06 martin arm64: Explicitly forbid using the x18 register 2020-05-05 martin checkasm: arm32: Check for stack overflows 2020-05-05 martin checkasm: arm64: Check for stack overflows Created with: roll-dep src/third_party/dav1d/libdav1d TBR=tguilbert Change-Id: I8614895a7c08f6dc3ba0d54dee84a214faa78b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202531Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#769064}
-
Charlene Yan authored
This CL includes the following: - data plumbing for the collapsed boolean - logic for showing collapsed based on the flag - updating the tab bounds if collapsed Change-Id: Iadcba24738eab795945134a8b77b98076fe59491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159931 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#769063}
-
Li Lin authored
This CL includes: - Generate user intent based on text annotation result. Fallbacks to generate translation intent based on language detection result if no other intent is generated. - Only send query to server if there is a supported intent generated. - Rewrite query based on generated intent. - Notify client with preprocess output. The output will be used to conditionally trigger Quick Answers view in a follow up CL. Bug: b/150249535 Test: unit tests Change-Id: I702f1f65dd73bb8ff5d36fafb65e8409230d3028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198115Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#769062}
-
Lijin Shen authored
- Limit test to P+ as it fails on O for unknown reason. - Fix the typo in tab persistence policy Bug: 1081912 Change-Id: I9e8b9203dfac4fb359c9e9b4d337323950dc9324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202508Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#769061}
-
Alexander Hendrich authored
This is a reland of 88854e15 Original change's description: > Whitelist Imprivata extensions for networking.onc API > > Whitelisting the Imprivata extensions so that they can send their local > IP + MAC address to the Imprivata server, which are being used in the > Imprivata admin consoleto assign the device to a specific "site" and > also to assign computer policies to specific devices. > > Bug: 1075877 > Change-Id: Id3a14b2ac5618dfcbc6c476da555153792debe57 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169888 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Auto-Submit: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768029} Bug: 1075877 Change-Id: I73fcce371de0568ea470ca518b856b8e52ba1914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203376 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#769060}
-
- 14 May, 2020 30 commits
-
-
Theresa Wellington authored
Introduce a new BrowserControlsStateProvider interface and migrate ChromeFullscreenManager to use this interface where possible. Subsequent CLs will add additional browser controls interfaces for APIs with more controlled access (e.g. browser controls visibility manipulation). BUG=995914 Change-Id: Ia9654d45e8ffcb1c683215ceec35bb174bd093cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198117 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#769059}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d748e1651af8..c9625f1660da git log d748e1651af8..c9625f1660da --date=short --first-parent --format='%ad %ae %s' 2020-05-14 srisser@google.com Fix asserts due to missing texture formats Created with: gclient setdep -r src/third_party/swiftshader@c9625f1660da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3330a594db6aa7672fad6efff09993f36cf6e514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202494Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769058}
-
Tommy Li authored
This CL highlights the section header row when the user tabs to the associated chevron button. The implementation looks kind of big to do something so simple, but given our exotic / bespoke focus model, I couldn't do it smaller. Bug: 1078183, 1052522 Change-Id: Ibffd26183b5f182bf42a874797bf161187476759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202669 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#769057}
-
edchin authored
This reverts commit 525a4a22. Reason for revert: Fixed missing @end Original change's description: > Revert "[ios] Reduce pointer boilerplate in Credential Provider" > > This reverts commit ca2e472b. > > Reason for revert: breaks compile, see https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/4247? > > Original change's description: > > [ios] Reduce pointer boilerplate in Credential Provider > > > > crrev.com/c/2199891 introduces a reusable class for pointer > > interactions for non-button views. This class internally handles > > all the delegate callbacks. So usage is simplified to a single line. > > > > This CL should have no impact/change on the UI. > > > > Bug: 1073961 > > Change-Id: I28904804916d0c112f73fe6e372bea6aede504d0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199727 > > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Commit-Queue: edchin <edchin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#768924} > > TBR=edchin@chromium.org,javierrobles@chromium.org > > Change-Id: Ib4e9c99203d3dbb673d49f302b342d2055561b3d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1073961 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203138 > Reviewed-by: Dana Fried <dfried@google.com> > Commit-Queue: Dana Fried <dfried@google.com> > Cr-Commit-Position: refs/heads/master@{#768987} TBR=edchin@chromium.org,javierrobles@chromium.org,dfried@google.com # Not skipping CQ checks because this is a reland. TBR=javierrobles@chromium.org Bug: 1073961 Change-Id: I8534dd58ff1f7ba9f2ad2567bea894ed200b8597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202687 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#769056}
-
Andreea Costinas authored
The address of the local proxy is sent via a dbus signal when a local proxy worker becomes active. The local proxy url is sent to the system services on Chrome OS via Chrome's proxy resolution service. System services will connect to the local proxy and the local proxy will setup the connection through the remote web proxy and perform proxy authentication on behalf of the CrOS services. BUG=chromium:1042642 TEST=browser_test ProxyResolutionServiceProviderSystemProxyPolicyTest Change-Id: I73a1c36bb265cba7e6dce0c59431d010a3f096ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192655 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#769055}
-
Toby Huang authored
This CL adds histogram and user action UMA metrics for supervised users using the Extension Install and Parent Permission Dialogs to install extensions. There are also histograms for tracking how much time the user spends on these two dialogs. Bug: 1022620 Change-Id: I24436d8c6548577f18baa098481192c2d750d395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181226Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#769054}
-
Antonio Gomes authored
blink.mojom.LocalFrameHost and blink.mojom.RemoteFrameHost are the target mojo interfaces. Similarly to https://crrev.com/c/2111133, this CL added a lookup method RenderFrameHostImpl::FromFrameToken, similarly to RenderProxyHostImpl's. Also, this conversion has allowed a couple of layer to be eliminated in the existing flow: Previously - <callees> - LocalFrameClient - WebLocalFrameClient - RenderFrameImpl - old IPC Now - <callees> - LocalFrame|RemoteFrame - mojo IPC Note that this CL did not migrated FrameMsg_UpdateOpener IPC together with it. It will be done in a follow up step, either as a mojo completion callback (ie using the => construction from the mojo syntax) or as an independent mojo message. BUG=1051144 Change-Id: Id379a120899212d93841fce5ec2542273a8632fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196860 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#769053}
-
Tibor Goldschwendt authored
Third-party themes can configure the styling (e.g. tiling, placement) of their background images. To support that, this CL adds a new chrome-untrusted://new-tab-page/custom_background_image helper that behaves similar to chrome-untrusted://new-tab-page/background_image but allows for custom styling. The custom styles can be passed via URL query params. Internally, this new helper uses the same HTML as background_image. However, background_image sets the styles to the values we have used previously for first-party background images. The styling properties are passed to the NTP JS via mojo. And the JS forwards the styling to the custom_background_image helper. That way first- and third-party themes share as much code as possible. Bug: 1081441 Change-Id: I943806aa9ab61c402217f8658ce548a9b85a435f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202502 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#769052}
-
Noel Gordon authored
Bug: 1002391 Change-Id: I592eb1d0482da82b78f47b8e8f69b85211494515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203076 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#769051}
-
Xianzhu Wang authored
They are flaky on many CQ bots, regardless of composite-after-paint: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=external%2Fwpt%2Fhtml%2Fuser-activation%2Fconsumption-crossorigin.sub.tentative.html%20external%2Fwpt%2Fhtml%2Fuser-activation%2Fnavigation-state-reset-crossorigin.sub.tentative.html%20%20external%2Fwpt%2Fhtml%2Fuser-activation%2Fpropagation-crossorigin.sub.tentative.html Move the failure expectations from composite-after-paint into TestExpectations. TBR=mustaq@chromium.org Bug: 1064422, 1066178, 1066190 Change-Id: Iffa9df6e6607f85772d65d2969e3d0964790fe30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203276Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#769050}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/37120ab59d1f..42748d8e22aa git log 37120ab59d1f..42748d8e22aa --date=short --first-parent --format='%ad %ae %s' 2020-05-14 danilchap@webrtc.org In rtc_base/ and api/ replace mock macros with unified MOCK_METHOD macro 2020-05-14 marinaciocea@webrtc.org Add GetMetadata() to TransformableVideoFrameInterface API. 2020-05-14 danilchap@webrtc.org In video/ replace mock macros with unified MOCK_METHOD macro Created with: gclient setdep -r src/third_party/webrtc@42748d8e22aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1069295 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I65ff4f414633216d520483d57e7a8c8c650f2423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202495Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769049}
-
Carlos IL authored
This function was only used for overlay interstitial, and is dead code now. Bug: 1076947, 1077074 Change-Id: Ieb208b0c617852cc8f74402ffed89d02d4e7219a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202675 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#769048}
-
Brian Sheedy authored
Catches CalledProcessErrors when running Intel Power Gadget during GPU tests and logs its output before re-raising the exception. This is so that we can get more useful information about the failure than just the exit code. Bug: 1079387 Change-Id: I1da82b0772643a3161966d052682239617f0ff81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202940 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#769047}
-
John Abd-El-Malek authored
Bug: 1025603 Change-Id: I48762b17e485ba636e880525dfda63324955330c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202963 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#769046}
-
Edward Lesmes authored
We want to turn CheckTranslationScreenshots into an error, but allow developers to skip it without skipping all presubmit tests (e.g. because they are external contributors and don't have access to the images). We make it possible to skip this check by setting `Skip-Translation-Screenshots-Check: True` as a git footer. See this commit message as an example. Bug: 1082901 Skip-Translation-Screenshots-Check: True Change-Id: I3c6572b59611ba7cfd2da4a6498b973d8e0e2233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203180Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#769045}
-
Hesen Zhang authored
- Added response code/error code/manager status/fetcher status metrics in backend. Bug: 1068683 Change-Id: Ia55c2daca5c937f8ebd6c5a3864d45cb74458d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200253 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#769044}
-
Robert Liao authored
The widget assumes ownership of the notification view in NotificationViewMDTest. Effort was also made to remove as many direct pointers to the widget as possible to demonstrate the linkage. BUG=1044687 Change-Id: I010d2cf742c043b5e257f22abb6a4688e3707877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203019 Commit-Queue: Tim Song <tengs@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#769043}
-
Tim Song authored
This CL also updates the expiry dates of existing system tray metrics. BUG=1073536 Change-Id: I9dc40194004415ab0eb22be26009eb50cef0aca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198539Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#769042}
-
Carlos IL authored
A previous bug fix resulted in the path being trimmed from the URL shown in PageInfo on Android. This CL fixes that bug. Bug: 1082051 Change-Id: I193d7e044d412504478f3240ed94464c13c26f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199989Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#769041}
-
Justin Donnelly authored
kNewSearchFeatures is a kill switch intended for a long-term holdback of all search-related launches. See https://crrev.com/c/2132641 and https://crrev.com/c/2161357 for earlier uses of this Feature. Bug: 1073606 Change-Id: Ic9ea4394892496c43c6096b22d8236a031f4db6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202119 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#769040}
-
Tibor Goldschwendt authored
The logging flow for simple doodles looks as follows: 1. On image load -> fetch image_impression_log_url and download additional params for later logging. 2. On image click -> open on_click_url with image_click_params from 1. appended. 3. On doodle share -> ping gen_204 url with share_id from 1. appended. For animated doodles the flow is: 1. On CTA load (i.e. preview image) -> same as 1. for simple doodles. 2. On CTA click -> ping interaction_log_url from 1. 3. On animation load -> same as 1. but with animation_impression_log_url. 4. On animation click -> same as 2. for simple doodles but with image_click_params from 3. here. 5. On doodle share -> same as for simle doodles but with share_id from either 1 or 3 depending on when sharing. JS drives the logic for these flows since it owns the required state. However, JS cannot make the network requests directly since it lives in a WebUI process. Therefore, JS delegates networking to the browser process through mojo. Fixed: 1070762 Change-Id: I786a9cf977d7bce978ab9ccfa4d6e9b00c616656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200420Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#769039}
-
Nicholas Hollingum authored
panel_rotation() is the difference between the buffer and hardware's scanlines as opposed to rotation() which is the "logical" uprightness of the screen. This matters on devices where the logical orientation does not match the hardware orientation. There are two cases where exo uses the wrong rotation which means: - cursor images are drawn in the wrong orientation - the screen orientation is reported incorrectly to clients. This is ~fine~ until you start using applications which refuse to handle events which are "offscreen". We model this CL after changes in crrev.com/c/1911344. Bug: 1081085 Change-Id: Ia3a01b8dd5d745dbdb6a5b2220cae44061088a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195341Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#769038}
-
John Abd-El-Malek authored
The removal of the UI->IO thread hop in r768133 seems to cause some tests in the PFQ to flake. Add extra hops (now UI->IO->UI) to avoid flakiness in the PFQ. This should be reverted once the test issue is tracked down. Bug: 1082298 Change-Id: I64e3e27461a73bf269c8193d9d5c7a65cb3a072a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202671 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#769037}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ce925b4cbe60..fecd1afcb287 git log ce925b4cbe60..fecd1afcb287 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 timvp@google.com Vulkan: Move necessary members from ProgramState to ProgramExecutable 2020-05-14 timvp@google.com Update Program[Pipeline]State to hold a ProgramExecutable Pointer 2020-05-14 ianelliott@google.com Vulkan: Create a test to debug Android pre-rotation Created with: gclient setdep -r src/third_party/angle@fecd1afcb287 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@chromium.org Change-Id: I4de870579b5bc5e895341756dcb99becd715e4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202485Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769036}
-
Ionel Popescu authored
Scenarios that we are interested in: - how often is the popup exceeding the owner window bounds - how often does the popup receive tap/mouse down/ mouse wheel events outside the owner window bounds This CL has no user visible behavior changes. Bug: 1066241 Change-Id: I0f88e75b452a2c7490045b31f0b9e773314a2d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200425 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#769035}
-
Raymond Toy authored
copyFromChannel can produce overlapping areas when the source array is the same as the channel data array. Use memmove instead of memcpy to handle this case. copyToChannel has the same issue, so fix that too. Manually tested the repro case with a local asan build. The issue no longer reproduces. Bug: 1081722 Change-Id: I168ef418fccf45646bb4d8a01c22cecfbd5da20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202394Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#769034}
-
Hirokazu Honda authored
We want to be able to run a VA-API driver in Constant Quantization Parameter mode for vp9 encoding. VaapiVideoEncodeAccelerator needs to tell VP9Encoder about the bitrate control. This CL adds enum of BitrateControl in AcceleratedVideoEncoder interface so that VaapiVEA can configure vp9 encoder with the enum. Bug: 1060775 Test: video.EncodeAccel.* Change-Id: I16db7bafcee0642e71bc36ef3e2bce257e33c7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159669Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#769033}
-
Matt Swartwout authored
This was causing some -Wshadow compiler errors in Chromecast builds. Change-Id: I2ebdd629e3472302db5d4d05e340c89223d690eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197490Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Matt Swartwout <mwswartwout@google.com> Auto-Submit: Matt Swartwout <mwswartwout@google.com> Cr-Commit-Position: refs/heads/master@{#769032}
-
Chris Hamilton authored
This will be used by upcoming frame and process priority logic. BUG=1077217 Change-Id: I817a8af44306598d1294068042b924c7832d434a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199397 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769031}
-
Erik Jensen authored
Bug: 1082919 Change-Id: Ia90e3bd3d428d941842147dcb5dce8440f16b5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202389 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#769030}
-