- 24 Oct, 2019 40 commits
-
-
Dominik Röttsches authored
Preparation for UMA logging failure reasons on why extracting font file and name information failed for individual indexed font files. Bug: 1009402 Change-Id: Ia6133d2646b9f1610edd5f1e8b4a43a3a0143486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875106Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#709140}
-
Bo Liu authored
Change-Id: I95df3ea154bb0a73b8842bd485129c4269d1eff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879707Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709139}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2c37032b. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Iaaad527fbb79df9ea9d0f299baab29ce297dd418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878948Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709138}
-
George Burgess IV authored
We want to start running tidy as a part of Tricium. In order to do so, we need to figure out the set of clang-tidy checks we want to run. The checks here are sourced from the 'Y' column of: https://docs.google.com/spreadsheets/d/16_z3pQFvTEzQocfWpch54GSykziTxVJMEcaDb5xW0YA/comment#gid=0 Ignoring google-explicit-constructor and modernize-use-auto (since the former has code that relies on it, and the latter requires changes to clang-tidy to meet Chromium's style guidelines). We can add more (bugprone-*, ...) as time goes on, but those appear to be the defaults that Chromium wants initially. Please note that subdirectories can override all of this whenever they want (e.g., v8 has a .clang-tidy file already, so any files inside of v8/ will entirely obey that), so this is meant to be a generally valuable and applicable set of checks. Teaching `gn` about all of this might have some value eventually, but for now, the goal is to see how far we can get with the simpler solution. Bug: 633856 Change-Id: I7b52e6a313ace8a91e9041313b222da737ef47fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808532Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#709137}
-
Etienne Bergeron authored
This CL is adding more unittests for the first round of text split of the RenderTextHarfBuzz::ItemizeTextToRuns(..) algorithm. There is no behavior changes, no new bugs found. Adding more unittests to have coverage for recent change: https://chromium-review.googlesource.com/c/chromium/src/+/1865673 Bug: 1014119 Change-Id: I30a09e0576063b123a1ae0abd917e49a7c053a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877666Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
minch authored
Changes in this cl: 1. Update the arrow color while COMPLETEING from SK_ColorWhite to gfx::kGoogleGrey100. 2. Add shadow for the circle background. The shadow is the same as overscroll affordance. 3. Add burst ripple animation on drag release. The radius of the ripple will grow from 40dips to 48dips on this process. See recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiY1JWREN4aW1hSWlocktCOVlwdDV4ZHZyNERN/view?usp=sharing Bug: 1002733 Change-Id: I96e7836a315c83cbcae415bbd4b359cf6d607501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876797 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#709135}
-
Aleks Totic authored
Edge case for "have aspect ratio, but no intrinsic size" If there was no intrinsic size, we treated it as no size at all. But, if there is a css size, we should use that instead. Bug: 1015311 Change-Id: Ia8f12bd23cda5c18b9aae318eee91906840475d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877595 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#709134}
-
Devlin Cronin authored
The ToolbarActionsBar should never be constructed, at all, with the kExtensionsToolbarMenu feature enabled. Make the DCHECK in the ToolbarActionsBar constructor stricter to make this clear, and catch any cases where we erroneously construct one. Bug: None Change-Id: I5ddef89f249435b0fcfe97459b5c09bd88936075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877449Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709133}
-
Lukasz Anforowicz authored
There was quite a bit of code duplication related to copying OpenURLParams into LoadURLParams. Some callsites didn't copy all the navigation properties (leading to the DCHECK reported in https://crbug.com/1007041 and possibly also to some of renderer kills reported in https://crbug.com/1014483). This CL tries to improve the situation, by moving the copying code into a new constructor of LoadURLParams and reusing the constructor from as many places as possible. Bug: 1007041, 1014483 Change-Id: Ibeefd97118a78f5a2b3779e51d83731c546fd113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853910 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709132}
-
Jonathan Backer authored
Renderer4.renderPassCount is the number without any flattening at all. Soon GLRenderer and SkiaRenderer will flatten differently. We want to instrument this so that we can measure the difference. Renderer4.renderPassCount is still useful to measure the effectiveness of SkiaRenderer flattening. It can be removed post launch. Bug: 1013735 Change-Id: I9abf94c62ab5172230ebf223dbb672629d42356e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874193Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#709131}
-
Stephen McGruer authored
TBR=dmurph@chromium.org Bug: 925325 Change-Id: I7cbc37cbcc0134a6204781e66b137f4b537832c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879147Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#709130}
-
Bo Liu authored
Add thread check to all embedder to implementation calls. Change-Id: Ifac0c0de5b2ea365313d151451cbff8ade7ab818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879428Reviewed-by:
-
Gyuyoung Kim authored
This CL applies the new Mojo types to the callback of OnStart in Service interface. - Convert FooRequest to mojo::PendingReceiver. - Convert FooAssociatedPtr to AssocitedRemote. - Convert FooAssociatedRequest to PendingAssociatedReceiver. - Convert AssociatedBindingSet to AssociatedReceiverSet. Bug: 955171 Change-Id: I7e3efc212a5272ef8c29977e150126c75ea0fc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875009Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#709128}
-
Evan Stade authored
Bug: 998625 Change-Id: Ic2b813a6197b20ed8c4c962fcd6757055cac6f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857599Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#709127}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b8943e033650..151f5fbf383d git log b8943e033650..151f5fbf383d --date=short --no-merges --format='%ad %ae %s' 2019-10-24 vapier@chromium.org cros_install_debug_syms: switch to outcap 2019-10-24 vapier@chromium.org run_tests: invert python3 support logic Created with: gclient setdep -r src/third_party/chromite@151f5fbf383d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7555a4dd5bb57a760ded98314955849133fca6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879508Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709126}
-
Owen Min authored
Default search provider maybe null when it's disabled by policy. Make sure the touch bar search button can handle this case with an empty button. User is still able to press the button to enter URL. Screenshot: https://drive.google.com/file/d/1Sw8xd2bl4MGfF2p2qrT7PKF4bQ2jczRC/view?usp=sharing Bug: 1011260 Change-Id: Iba221a4d65baff7cc5485de43f4b145481c2d1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841837 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#709125}
-
Stephen McGruer authored
TBR=estade@chromium.org Bug: 1017819 Change-Id: I8d5f2acbe8c30c5998e8c5a4ebd83c95a555a8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879692Reviewed-by:
-
Xing Liu authored
The option "Always open with system viewer" should be following the option "Open with system viewer". Bug: 574090 Change-Id: I3c75924ef9878b4ea3aa299af14a6c03330141b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879429Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709123}
-
David Dorwin authored
Change-Id: I730f54915f7a4f219d6b970ff4651fa20eb07b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866928 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709122}
-
Tao Bai authored
MetricsWebViewContentObserver assumed WillStartNavigationRequest() and DidFinishNavigation() is sequencially called for main frame, it isn't true, since both callbacks are post task, calling sequence isn't guaranteed. Bug: 1010034 Bug: 937528 Change-Id: Ia7fc892a599f789aa56b613409815f45d36e4223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865268Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#709121}
-
Min Qin authored
DragDownloadFile is used on UI thread, no need to use scoped_refptr. This CL also cleans up the unused DataObjectImpl::Observer class BUG=1008188 Change-Id: I9ba7596c69450df23e3dbe7b5bf7e56fb80ecc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825890Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709120}
-
Henry Jian authored
For browser installed WebAPKs, v109 has adaptive icon support Bug: 977173 Change-Id: Ic3b5e1b118dbe5ddb05fdaa662ae1ed9e81c6340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879547Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Henry Jian <hzjian@google.com> Cr-Commit-Position: refs/heads/master@{#709119}
-
Friedrich Horschig authored
Before this CL, the touch to fill sheet was intially shown in a very high PEEK state (which provides pixel-exact height control). The PEEK state had the side effect that the scrim view wasn't brought up reliably (see linked bug). Therefore, it is skipped now and instead, the half state is invoked right away. To the user, this looks and behaves exaclty the same but triggers the scrim view more reliably. Additionally, there is a small fail-safe that would have fixed the issue on its own (just not as clean). The fail-safe ensures the sheet is dismissed as soon as there the BottomSheet enters the HIDDEN state, even if the observer wasn't notified that is was closed beforehand. Minifix: the bottom sheet vertical size seems to align with Chrome now, so set the margin of the "Manage Passwords" button back to 8dp. Bug: 1017727 Change-Id: I66ddef169a96d43a059bd7f065195c03783d595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879447Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#709118}
-
Gyuyoung Kim authored
This CL replace mojo::Binding with mojo::Receiver in |binding_|. Then, renames |binding_| with |receiver_|. Bug: 955171 Change-Id: I24a49f57e58397c74beed9105ac8eb0347e5f3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875349Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
-
Christopher Cameron authored
The funciton UpdateAppProfileMenu should only be hit when in multi-profile mode. TBR=dominickn Bug: 1017755 Change-Id: Ib35aeb8ed4da2ff2af669c01d4996e4c278adfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879687Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#709116}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ab4e641f151..4a4400d9e9fa git log 4ab4e641f151..4a4400d9e9fa --date=short --no-merges --format='%ad %ae %s' 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 herb@google.com Fix fuzzer bug in SkDescriptor::isValid 2019-10-24 fmalita@chromium.org Slightly faster hsl_to_rgb stage 2019-10-24 robertphillips@google.com Revert "Allow direct readback for formats in non-ES OpenGL" 2019-10-24 csmartdalton@google.com Don't keep "outResultsFile" open in nanobench 2019-10-24 mtklein@google.com restore _DXDY image shader on ARM 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 bsalomon@google.com Allow direct readback for formats in non-ES OpenGL Created with: gclient setdep -r src/third_party/skia@4a4400d9e9fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: chromium:b/143074513 Change-Id: Iebc12a2367684d181b48c642cd64595de72bb997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879310Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3671a6a21726..1906f405ba0f git log 3671a6a21726..1906f405ba0f --date=short --no-merges --format='%ad %ae %s' 2019-10-24 bpastene@chromium.org gclient: When deleting untracked files, gracefully handle symlinks that point to dirs. Created with: gclient setdep -r src/third_party/depot_tools@1906f405ba0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:991276 Change-Id: I30e26ef2a8121cbe837bec64f4b9369e423b2651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879309Reviewed-by:
-
Philip Rogers authored
The inspector has a feature for "Scrolling performance issues" under the bottom console's "Rendering" tab which shows reasons for non-fast scrolling. This feature did not include main-thread scrolling reasons such as background-attachment: fixed. This patch adds main-thread scrolling reasons to the scrolling performance issues visualization. Bug: 1015918 Change-Id: I46039b4fc8ba3400cab1c2633da31e427865ce3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868660Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709113}
-
Evan Stade authored
Re-write the math in GetSizeForLabelWidth and GetWidthBetween (nee WidthMultiplier) so that the tween is correctly calculated for the in-out animation. Bug: 1005837 Change-Id: I729b6bb43265fdb7cb0aab52e6ae10e3c41a0702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863351 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#709112}
-
Ana Salazar authored
This change delegates the gesture events happening in the navigation widget to the shelf Fixed: 1016931 Change-Id: I4c91612ff5d4283a2f4b2d21a6c890dd33f34532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877140 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#709111}
-
meacer authored
This CL removes clickjacking.launch_url which was added back in 2009. I suspect nobody is actively looking at it, so it seems safe to delete. Change-Id: I088c115e2811c18a993385d86ca44a58ed449da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873110Reviewed-by:
-
Anastasiia Nikolaienko authored
Change black background to semi-opaque (60% #202124) for 'Add Account' dialog. This is a short term fix until crbug/1016828 is resolved. Bug: 997479, 1016828 Change-Id: I4741e2847f25b30a5ca3ee295569ea0c1c81cf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847274 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#709109}
-
Miriam Zimmerman authored
The "Details" text in the system & app information dialog was too low-contrast. BUG=chromium:1005543 TEST=Took screenshots in linked bug and checked contrast ratios. Change-Id: Ic0862a00c7ddb3dbbb4e46be8468e2e70a318afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877648Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#709108}
-
Hans Wennborg authored
And make sure that the 'n' prefix gets used properly. TBR=thakis Bug: 1017736 Change-Id: I9d65fd468ec4d58ab7ddf3ce35160e13f518514e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879227Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#709107}
-
Taylor Woll authored
Add a reference to the libclang package to the list of packages which should be uploaded from the staging bucket to the production bucket when the clang toolchain is rolled. See this commit for details on the new libclang package: http://crrev.com/c/1874450 Change-Id: I2f0264e95a5fad4dc370647d60f894c30d26fd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877605Reviewed-by:
-
Mikel Astiz authored
IsExitConditionSatisfied() now allows callers to provide details about why the condition wasn't satisfied. This is expected to be helpful to debug flake occurrences in the future, since it's often the case that the flake cannot be reproduced locally. Coupling the evaluation of the satisfaction predicate together with outputting a human-friendly explanation is a lot more natural than having a separate GetDebugMessage(), and aligned with common practice in testing frameworks (e.g. gMock). This patch updates all subclasses semi-mechanically with minor behavioral changes. Bug: 1017645 Change-Id: Ic3eb3d071758d71cae669ca50f022b0d3b141dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878072 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#709105}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/56d4da0510a5..3a8b8908605b git log 56d4da0510a5..3a8b8908605b --date=short --no-merges --format='%ad %ae %s' 2019-10-24 geofflang@chromium.org GL: Follow-up primitive restart emulation fixes. Created with: gclient setdep -r src/third_party/angle@3a8b8908605b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1017337 Change-Id: Icb669833691e6be9a505241540e525ad9654777a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879167Reviewed-by:
-
Tao Wu authored
This reverts commit 78abc7fa. Reason for revert: Break the build: ../../chromeos/services/assistant/platform/audio_stream_handler.cc:31:43: error: no viable conversion from 'typename remove_reference<InterfacePtr<AssistantAudioDecoderClient> &>::type' (aka 'mojo::InterfacePtr<chromeos::assistant::mojom::AssistantAudioDecoderClient>') to 'mojo::PendingRemote<AssistantAudioDecoderClient>' mojo::MakeRequest(&audio_decoder_), std::move(client), Original change's description: > Migrate AssistantAudioDecoderFactory to new Mojo types > > This CL applies the new Mojo types to CreateAssistantAudioDecoder > in AssistantAudioDecoderFactory interface. > > - Convert FooRequest to mojo::PendingReceiver. > - Convert FooPtr to mojo::PendingRemote or mojo::Remote. > > Bug: 955171 > Change-Id: I2de4cb0561c69201335817ec6a873258a30d9a00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871503 > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709059} TBR=sammc@chromium.org,wutao@chromium.org,gyuyoung@igalia.com,oksamyt@chromium.org Change-Id: I3890551d694ab28db3ba476e0771c99993c3b270 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879690Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#709103}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87002bea1174..21b8d3ff0a35 Created with: gclient setdep -r src-internal@21b8d3ff0a35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7415a8f83b5b92fd9de07d37b38587c7fbdad943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878873Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709102}
-
Etienne Bergeron authored
This CL is replacing the previous cache by an MRUCache. The previous cache was an 'std::map' and was unbounded. It was not an issue since typically the amount of typeface loaded is low on the browser side. Unfortunately, that was not the case when expensive fallback fonts were used and lot of fonts were installed on the user computer. The GlyphCache is still an std::map, but it is bounded to the max amount of glyphs that a font can have (e.g. 16-bits). Bug: 890298 Change-Id: I1148ea7ebfc285dfcc05e8da454db830e809ebb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874246 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
