- 27 Oct, 2020 1 commit
-
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/83e50af3e0bd..2837c9f0c416 2020-10-26 miu@chromium.org Add StringPrintf() wrapper utility. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I3acac321cb930b632ff7ef973c439862aa319877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820979}
-
- 26 Oct, 2020 39 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/546b189d859d..6b0ecd8197ff 2020-10-26 kimanh@chromium.org Add linear memory inspector viewer component 2020-10-26 jalyn@microsoft.com Settings: Add reset button for shortcut editor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I412dac67caa4232e747896c5b092bde8ced3a148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500361Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aaea0d98fb64..36af02d2efd7 2020-10-26 kjlubick@google.com Add define to WASM GM build 2020-10-26 robertphillips@google.com Add additional GrThreadSafeCache test case 2020-10-26 herb@google.com add API for Op creation 2020-10-26 mtklein@google.com tweak build for msan swiftshader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: jcgregorio@google.com Change-Id: I895e46f05bfecf42f382a1c34c1390a6ece64ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500045Reviewed-by:
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/d84ef00c9666..d15ae2bf593a $ git log d84ef00c9..d15ae2bf5 --date=short --no-merges --format='%ad %ae %s' 2020-10-23 bnc Move protocol flags out of platform so that they are included in QUICHE. 2020-10-23 mattm Move num_failed_authentication_packets_received to QuicConnectionStats and fix QuicConnectionTest.IntegrityLimitDoesNotApplyWithoutDecryptionKey 2020-10-23 vasilvv Replace QUIC_FALLTHROUGH_INTENDED with ABSL_FALLTHROUGH_INTENDED. 2020-10-23 wub If B2SL option is set in QUIC BBR2, when STARTUP exits due to loss, it will set the inflight_hi to the max of bdp and max_bytes_delivered_in_round. 2020-10-23 mattm Add QuicConfig::KeyUpdateSupportedRemotely getter. 2020-10-23 dschinazi Add code counts for building version negotiation packets 2020-10-23 dschinazi Remove unused QuicPacketCreator::SerializeVersionNegotiationPacket 2020-10-23 haoyuewang Reduce quic::ConnectionId size from 24 bytes to 16 bytes on 64 bit system. This reduces some memory usage of connection & session on the server side. 2020-10-23 mattm Add QuicFramer::PotentialPeerKeyUpdateAttemptCount() method. 2020-10-23 vasilvv Downgrade a QUIC_BUG to a warning. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ic48658bba769f3090639334f314f09053f9db28e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495402 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820976}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3a9e594e784e357b2690e74ab618b272a63e252f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499821Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820975}
-
Daniel Cheng authored
All uses have been migrated to use the //base helpers directly instead. Bug: 1047547 Change-Id: I3a293faba3d894dcf8af420e58159116bb518f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500001 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#820974}
-
Boris Sazonov authored
Adds MobileIdentityConsistency to testing/variations/fieldtrial_testing_config.json and adds explicit @DisableFeatures to the affected tests. Bug: 1128916, 1142467 Change-Id: I25afb6de05d2ce232f1006a8497884f9db18d52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489895 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#820973}
-
Andrew Xu authored
In RoundedImageView, we expect to get the size of the stored image via GetPreferredSize(). However, RoundedImageView may have its preferred size. As a result, CalculatePreferredSize() overridden by RoundedImageView is never called. It makes the area to paint the image bigger than the size of the image. Meanwhile, the canvas function to paint the image uses tiling flag as default. It is why a small image is tiled. This CL uses GetImageSize() in replace of GetPreferredSize(). The side effect is handled. Add DCHECK to verify. Bug: 1139498 Change-Id: Ia03c3366f22c8ce7d2c9326fd1097cab3e4ba563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499170 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820972}
-
Bo Liu authored
Webview currently crashes on context loss: https://source.chromium.org/chromium/chromium/src/+/master:android_webview/browser/gfx/output_surface_provider_webview.cc;drc=8bab2d6d39d8399e64d5f8369226403495e86d98;l=38 So that provides a shortcut for enabling vulkan for webview without having proper clean up. Move the kWebViewEnableVulkan to gpu/config, and use it to enable vulkan for in-process gpu, only on android. Bug: 1095744 Change-Id: Idcf0df6f2776012c2ea695d161f457ad48dde203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499219 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#820971}
-
Torne (Richard Coles) authored
The metric for re-initializing WebView showed that this is indeed what a small number of apps are doing in a very small proportion of cases. While we don't make any guarantees that this will work and the app might just crash in other ways, there's no benefit to it failing in AwDataDirLock in particular, so it seems preferable to just tolerate it here. So, just allow init to continue if we're already holding the lock, and if we already opened the file but didn't acquire the lock, reuse the already open file to try again, so that we don't end up racing with the finalizer of the old file object and potentially cause more problems. This should prevent us from hitting the OverlappingFileLockException in this code, though apps that are in this state may simply crash somewhere else in initialization later. Fixed: 1054774 Change-Id: I8aade5278a7fad10433a97068e36fbf63196e67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498109 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#820970}
-
chrome://media-appDavid Lei authored
Change-Id: I12f5c4bf407cc397803c31fdcf50d28ef606ee10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497940 Auto-Submit: David Lei <dlei@google.com> Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#820969}
-
Patrick Noland authored
Bug: 1138739 Change-Id: Iecab6daf9b8caa37abb55ca2f7d4998768dec1a6 TBR: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500312Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#820968}
-
Yuly Novikov authored
This is the only bot targeting 10.13.6, so we are upgrading the rest of machines to 10.14.6 TBR=bsheedy Bug: 1142558 Change-Id: I45ec3e6347f546090ad53011ff63857a73f55cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499346Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#820967}
-
Hoch Hochkeppel authored
Adding a class to represent the Windows UriRuntimeClassFactory class within tests, as well as basic unit tests to validate the test class behaviors. The class behaves similarly to the Windows equivalent, except it includes additional validations for expected usage. Bug: 1035527 Change-Id: I8296dc31596e2331f63250c303fbfe29f6e35713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498950 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#820966}
-
Meilin Wang authored
This CL polishes the Phone Hub panel including: - Relayouts the continue browsing chip. - Removes the separators. Screenshot: https://screenshot.googleplex.com/8uHj96SrADLFmAc.png Misc: removes unused headers. BUG=1106937,1126208 Change-Id: I0c1c2bef1883c6a8a188fde7c287a0a1bddbdf5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494023 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#820965}
-
Martin Robinson authored
This value was exposed via the name "AXHasPopupValue", while WebKit exposes this value via "AXPopupValue." Fix the attribute name, which in turn fixes an issue with how popup buttons are announced in VoiceOver. Bug: 1129678 Change-Id: Iede26b2fd6ddb9d7717fcb47fd1dd1cce5b74075 AX-Relnotes: Fix an issue with the announcement of popup buttons in VoiceOver. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489985 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820964}
-
Rakib M. Hasan authored
Android expectations files This will remove developer pain while we work on setting up permanent builders that run WPT on Android and figure out a more concrete solution for crbug.com/1141061. Bug: 1141061 Change-Id: I19b8a65d0c5a4753013f57026f69fef9b5038247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499176Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#820963}
-
Alex Moshchuk authored
Currently, if a sad frame becomes visible on a tab that's being reloaded, the sad frame is recorded as kShownAfterCrashing. Since we mark hidden tabs for reload if they contain a sad frame, activating that reload when the user switches to such a tab, and since the tab reload is going to wipe out the old document along with the sad frame, it's misleading to count that sad frame in that category, since it's going to disappear momentarily and thus has a lower impact on user experience. Instead, count such sad frames in a new category, kShownWhileAncestorIsLoading. This category is used whenever there's a pending cross-document navigation in an ancestor frame which would wipe out the sad frame that was just shown. Bug: 1132938 Change-Id: Ibd32919af28f8a1545cbbb3e2964a19e921e8f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482425Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#820962}
-
Jon Mann authored
Previously when details on the active row changed, users with a screenreader were not notified. This change allows the screenreader to announce changes as they happen. In order to determine which row is focused, this also adds an an isFocused property to FocusRowBehavior. Bug: 720274 Change-Id: I3ba1d41200c0fdd1383ec548870ec71e395b2edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489959Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iacfa17c939b8ccddb5ed49cbc4eb39689753f7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499702Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6f9b1bfd4849..c54539538ed6 2020-10-26 chanli@chromium.org [depot_tools] Roll led to latest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141272 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I215bacbfcb335ebf6a0701f81d96161dd1f03d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498852Reviewed-by:
-
David Tseng authored
Scenario: - TtsService calls GoogleTtsInitBuffered/GoogleTtsReadBuffered and an error is returned - TtsService communicates this error to the component extension via mojo TtsEventObserver.onError - in js, the onError handler calls window.close (yet to be sent out for review) - the non-persistent background page closes - in TtsService, mojo::PendingReceiver<mojom::TtsStream> is disconnected, causing the process to exit - on the next call to speak() from any client api (extension, web speech), the component extension is re-awakened by the extension system - in js, a new TtsStream connection is requested/established kicking off the rest of the initialization in TtsEngineExtensionObserver - before re-launching the service, ref keep alive counting logic gets called (accounting for the presence of ChromeVox or STS) to keep the newly opened background page alive - the TtsService process is re-launched R=dmazzoni@chromium.org Test: force TtsService to call onError after 20 utterances after calling GoogleTtsInitBuffered. Observe tts restarts and keeps working with ChromeVox. Change-Id: Id54db152fc5aa1e069ae9de8a603ee41435c1059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496287Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820958}
-
Tommy Nyquist authored
fgorski@chromium.org has shown over a long time that they're able and willing to be a steward of //chrome. Bug: None Change-Id: Ic13fe9ce75b27dd34d77cf26e518d4bbf11eb2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485046Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#820957}
-
Lei Zhang authored
It has been #ifdef'd out for several years. Bug: 662501 Change-Id: Id3c36148e2cc07e084e8280493e5c5da28149973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496501 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
minch authored
Screenshot for IDS_ASH_SCREEN_CAPTURE_TOOLTIP_SCREENRECORD was used before. Bug: 1142099 Change-Id: Ia54a7b34a23ce412f73b9e08a71cc377ec579b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499802 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#820955}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/1bafdc3c45e7..57694c8dab3c 2020-10-26 rharrison@chromium.org Change test terminology to reflect WebGPU spec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: I13656e89d74d3f278a921a265fdab1efbd52aa6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499701Reviewed-by:
-
Etienne Pierre-doray authored
Ablation study to evaluate impact of Jobs API. This CL splits job specific behavior in several features: - worker wake up strategy (with additional serial strategy) - yield - fair scheduling - priority update Additional study specific to Jobs: wakeup after getwork: This has the potential benefit of reducing lock contention when workers wakeup. Bug: 1139440 Change-Id: I5397977352650ee30557dc8972f32df34798b398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481522 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#820953}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5dafe107a36e..5d0458fa5c2d 2020-10-26 m.maiya@samsung.com Vulkan: Add OES_shader_multisample_interpolation support 2020-10-26 jmadill@chromium.org Capture/Replay: Test improvements. 2020-10-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7d11021098f2 to 03f6ffd1dc46 (27 revisions) 2020-10-26 geofflang@google.com GL: Use ANGLE_GL_TRY for draw calls. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I8e32ca8fdc3dc3c8151055f13bf166c499e1c867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499601Reviewed-by:
-
tby authored
Right now, the search providers for apps and arc apps create a single ChromeSearchResult object for each search result. This result is given the display type kTile, which then shows up in the app tiles and the suggestion chips. We want to apply different scoring and ranking logic to these two UI surfaces, so we can do things like incorporate files into the suggestion chips. However to do this, we need to be able to assign different scores to results destined for the app tiles or chips. This requires we create two independent ChromeSearchResult objects. This CL: 1. Changes the meaning of ash::SearchResultDisplayType::kTile to refer to only the app tiles, not both the app tiles and suggestion chips. kChip continues to refer to just the chips. 2. Modifies the SuggestionChipContainerView to filter on only kChip. 3. Make the AppSearchProvider and ArcPlaystoreSearchProvider create two objects for each result, with a display type of kTile and kChip. 4. Increase the max results of the providers to account for double the number of results (nb. max result limits are going to be removed soon). Bug: 1028447 Change-Id: Ifd261cba9c03fdc31d4bc38964b3101df20cf841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474081Reviewed-by:Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#820951}
-
Mohsen Izadi authored
It is possible to have nested event loops (e.g. in html <select> tag window.print() dialog). Therefore, EventsMetricsManager should support nested scoped monitors to be able to handle nested event loops. Luckily, this hasn't caused an issue because a nested event loop is normally initiated after an event handling causes an update and by the point the nested event loop starts, EventsMetricsManager has already copied the active metrics object due to that update. However, since we want to postpone this copying until the event processing has ended, this will cause issues in future. Bug: 1054009 Change-Id: I8fb160ce0140cdda35071946d470f884d00a3e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491935Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Auto-Submit: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820950}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f0fe38b2..af722073 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7468cd3604eaa81955fb492e0feba65e92040ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499325Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820949}
-
Patrick Noland authored
Bug: 1142576 Change-Id: I412849d1be5f0545b94987f468f4890184e7a394 TBR: yusufo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499624Reviewed-by:
-
Dirk Pranke authored
We're removing the relative_cwd and command support in isolate files in swarming as part of moving to the RBE-CAS backend. //tools/run-swarmed.py currently depends on that to work. This CL extends mb.py to be able to easily extract the command line that the target would use in the isolate, and modifies run-swarmed.py to use that to pass the command (and the relative_cwd) to the task instead. Bug: 1119643 Change-Id: Icf81faa1c1293ffbf13160e4d3ee1b7f2d636797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495797Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#820947}
-
Moe Ahmadi authored
- Shows the search loupe icon not only for repeatable query tiles, but all query tiles including query custom links when repeatable queries are enabled. This is for UI consistency when a repeatable query tile becomes a shortcut and the info about the source of the tile is lost. - Does not show the toast buttons when a query tile is removed unless it is a custom link. Removal is not reversible for non custom link query tiles. Also disables Ctrl+Z when toast buttons are not showing. Bug: 1138578 Change-Id: Ib26ad07ce8d12da70c7916f2aaf79f65fabc3dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491991Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820946}
-
Sky Malice authored
The previous policy of CCTToSDialogEnabled assumed a default of true to show the ToS. It was intended to only disable the ToS when specifically intended. However, we believe some UEMs are setting all booleans to false by default, which caused significantly undesirable behavior for this policy. To address this, replaced the boolean policy with an int-enum policy. Then make sure the default value of 0 is mapped to the old behavior. Note that this only changes only updates the policy and pref code. All of the FRE logic in Java code is still using the old boolean and is-enabled nomenclature. This is effectively tech debt, and could be cleaned up, but if we decided to do so, should be as a follow up. Bug: 1141198 Change-Id: I4b9792e6bb111d334a78e9a979d40aaf462f00b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491405 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820945}
-
Daniel Libby authored
When adding out-of-flow results to a fragmentainer, we currently are not setting up the break token sequence number on the NGBoxFragmentBuilder for the NGSimplifiedOOFLayoutAlgorithm. This results in painting different fragments with the same fragmentainer identifier in NGBoxFragmentPainter::PaintBlockChildren, which causes a DCHECK in display item caching code. Instead, use the previous fragment's BreakToken when creating the NGSimplifiedOOFLayoutAlgorithm. This gets the sequence numbers correct, whether we replace or create new fragments (for the former we could just use the existing break token/sequence number). This adds a WPT test for the unit test that exposed this issue: NGOutOfFlowLayoutPartTest::PositionedFragmentationWithOverflow Bug: 1134763 Change-Id: I48a230f8153b8ea63c3a376629c645656423fc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490209 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820944}
-
Bruce Dawson authored
During local testing of minidump_unittests occasional timeouts were seen so this change increases the timeout on Navigate from 5 to 10 seconds. It also adds logging on the RestartBrowser call to make it clearer in interactive testing that the browser is, in fact, not restarting. Finally a couple of missing spaces are added to logging commands. Bug: 1084931 Change-Id: Idc43b9c551effc99b8888491c680c949f1a1c170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496285 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Piotr Bialecki authored
Change-Id: I3e5327e70bc910f3eaa7b33eea1c0f1ddeda2fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495970Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#820942}
-
Daniel Hosseinian authored
Currently, there is only one instance of a PluginController at a time, but references to it only live inside PDFViewerBaseElement and derived classes. Therefore, descendants of the <pdf-viewer> element fire an event handled by the PDFViewerElement. Making the controller a singleton allows other elements to directly access the controller using PluginController.getInstance(). In making PluginController a singleton, the body of the constructor is moved to an init() method, because getInstance() creates a new object using the default constructor. Consumers of the PluginController would need to make sure the singleton has been initialized before using it. Eventually, InkController will also be altered to be a singleton, similarly to PluginController. Bug: 1134208 Change-Id: I5f8a6b565e6fd565e67c41d841ab92fec43e46c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495504Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#820941}
-
Sky Malice authored
When this in product help bubble is displayed, if the user immediately clicks on the tab switcher, then the new tab page button on the overview mode will be temporarily highlighted as well. This should have no effect when there is no tab switcher button on the top toolbar, like on tablets. Bug: 1130752 Change-Id: I88475d9f5330ed430a9182b0f3e90620f75ea737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450809 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
-
