- 20 Dec, 2019 40 commits
-
-
Sergey Ulanov authored
Previously FuchsiaVideoDecoder was requesting 8 buffers for in-flight output frames. Reduce that number to 6. Bug: 1034692 Change-Id: I303b5012541b7c291b4b945091a73a291afe4a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977386 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
John Bauman <jbauman@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726678}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/104d95744f44..95d876ef330f git log 104d95744f44..95d876ef330f --date=short --first-parent --format='%ad %ae %s' 2019-12-20 fancl@chromium.org Return only private sheriff when matched both public and private Created with: gclient setdep -r src/third_party/catapult@95d876ef330f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: nuskos@google.com Change-Id: Id0a0c6c082e1b9f17f2cb9f622850983f549c8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977785Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726677}
-
Andrey Kosyakov authored
MessageLoopImpl was removed by crrev.com/c/1440828, but there are still somce forward declarations around. Change-Id: I39d1e18632b97aa6a7aa2e59fca61db997651034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974817 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#726676}
-
Kunihiko Sakamoto authored
This reverts commit 6f0c3820. Reason for revert: StackSamplerImplTest.CopyStackTimestamp is crashing on MSan bots. https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/21249 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/16883 Original change's description: > [Sampling profiler] Provide timestamp with sample > > Records timestamps along with samples and plumbs them through to > the ProfileBuilder interface. The CallStackProfileBuilder subclass > will be updated in a following CL to record the timestamps, to > support retrospective tagging of metadata on the samples. > > Bug: 1034758 > Change-Id: Ic631d47773db5ce8ed5117c08aba5d5931cb7884 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972931 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726526} TBR=thestig@chromium.org,wittman@chromium.org,oysteine@chromium.org,etiennep@chromium.org Change-Id: I752676dd15b9a6e2aad897c4c9442eaad1dda9b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977893Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726675}
-
Johannes Henkel authored
The interfaces in content/public currently use const std::string& for devtools messages. This requires client code as well as implementation code to use an std::string for representing the messages (depending on the code that's providing the const std::string&). Moving to base::span allows code to use any container that gives access to a sequence of bytes without having to make a copy, including: - std::string (just like now) - std::vector<uint8_t> (base::span<const uint8_t>'s implicit constructor takes it). - the BigBuffer from Mojo (provides a base::span<const uint8_t> already). - base::span<const uint8_t> - crdtp::span<uint8_t> (base::span<const uint8_t>'s implicit constructor takes it). - base::StringPiece (going to / from this one requires a reinterpret_cast, but at least it's efficient). The switch removes a few copies of byte sequences (e.g. from BigBuffer to std::string). It introduces a few conversions between the non-owning representations, but these are cheap. This PR includes a roll of third_party/inspector_protocol. New revision is: 3b0551d3904f7fc067e78905ce697002187fa7a5 Change-Id: I4bea62307378f72ae95fa631db42c3bc95694d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965407Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#726674}
-
Jiahe Zhang authored
Change-Id: Ie2fe348928333e7a8162fc891fb53d2acb87f574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975451 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#726673}
-
Isabella Scalzi authored
The transferBetweenVolumes function adds the file to be moved into the list of expected files after the move, only runs if the flag "isMove" is false. Because of this, the file that was moved was not added to the list of expected files, and the test can fail. Removes this condition, and do not add the file to be moved to the list when the source is the same as the destination, or if the test is expected to fail. All tests that use transferBetweenVolumes now pass in step-by-step mode, to complete issue 1035220. Bug: 1035220 Change-Id: If9031eab26340af6af2440f2fd9e30d48b5a248d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976138Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Isabella Scalzi <isabellascalzi@google.com> Cr-Commit-Position: refs/heads/master@{#726672}
-
Alan Screen authored
Printing on Windows involves a two-step process, first converting pages to the Windows metafile format (EMF) and then later playing that metafile to print to the destination device. The PrintedPage objects which contain this metafile data are retained in the PrintedDocument until the document completes. This has caused the extra metafile representation to stay in memory well after it's required lifetime has passed. For jobs with many pages that include full page rasters this triggers a memory spike that subsides only once the last page is sent and the document is destroyed. Avoid such memory spikes by dropping the PrintedPage object from the document as soon as the page has been rendered to the destination, so that its destructor can run and release the associated |metafile_| memory. Bug: 1031438 Change-Id: If6ff81f63e11989bc7ef1b341ee37be0cd8d4af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975993Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726671}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 03dfdf62. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." 9899425d "[css-layout-api] IntrinsicSizes Implementation" d75fede5 "[EventTiming] Fix crossiframe test" 93b03639 "Roll WebGPU CTS" d0d26288 "CSP: Parse and report violations from Content-Security-Policy-Report-Only headers in the browser process." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2e5e26ebb3132f77954736753529434f27b8562c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977756Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726670}
-
Demetrios Papadopoulos authored
Not removing the files from settings_resources.grd yet, because they are still referenced by about_page.html. Bug: 990106 Change-Id: Ia030e2f5f71d6cd8b4fe276082c569d136e0b235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977004 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#726669}
-
Ryan Hansberry authored
Record to boolean metric if KeepAliveOperation was successful, in order to track improvements to Instant Tethering session stability. Also add respective logs for future debugging of this issue. Trial run: I connected to an Instant Tethering host and let it remain connected as long as possible (until underlying bugs broke connection). The results are: * Total session time: 1 hour and 12 minutes (not great!). * Success count: 15, Failure count: 4. * Success rate: 78.9% (not great!). Bug: b:143982534 Change-Id: I69723abb1e6f86713a3919a7e4e453e51e686abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970830Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#726668}
-
Wei Wang authored
service_worker_browsertest.cc ServiceWorkerBrowserTest is a simple fixture, it is unnecessary for ServiceWorkerVersionBrowserTest to inherit from it. This patch extracts ServiceWorkerVersionTest and relevant tests from service_worker_browsertest.cc to service_worker_version_browsertest.cc Bug: 931094 Change-Id: I571680beb4af9ad7c01a039bf9ea557e9e9c038c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966582 Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#726667}
-
Stephen Nusko authored
These tests were recently added/reenabled and haven't been really green since. So just disable them and we'll pass this off to the owners to handle and reenable if needed. NOTRY=true TBR=crouleau@chromium.org CC=mythria@chromium.org,ulan@chromium.org,charliea@chromium.org,sullivan@chromium.org,tdresser@chromium.org,chrome-speed-metrics-dev@chromium.org,pasko@chromium.org,crouleau@chromium.org,chrome-android-perf-status@chromium.org BUG=1036141,1036143 Change-Id: I18076c71276353dffe632b155a8fdbc3ebd93c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977996Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#726666}
-
Azeem Arshad authored
This CL fixes issue with cellular technology icon not being consistent across all UI. This seems to be caused because we do not check for network technology changes when triggering active network change notifications. Fixed this by adding check for network technology as well. Fixed: 994445 Change-Id: I69a24af8efd6dd2888631811723333cf276465f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977309Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#726665}
-
Ryan Hamilton authored
Change-Id: I72e1cacf310884720870043d263045181e1d3744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975995Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#726664}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I96e9719daf91ebb84a57e05e9982b4c2cfd345e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972734Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#726663}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7f890a8e..3a72085d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I43d3bfa8e0fb28198b785f058b1959fe2e93c3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977280Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726662}
-
John Budorick authored
Change-Id: I2d8894b19ac6f697059bc8ce1c2f64358a051826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977002Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726661}
-
Kunihiko Sakamoto authored
This reverts commit f5232c5d. Reason for revert: Broke linux-chromeos-chrome build. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/531 Original change's description: > Create base class for AssistantUiElement views. > > This is part of a multi-CL effort to clean up the AssistantUiElement > modeling/rendering pipeline. Once complete, UiElementContainerView will > only know about AssistantUiElementViews, not inheriting subclasses. > > More details in the bug. > > Bug: b:145003512 > Change-Id: I6b9b96af2f7f7e73a19785d58104049f287616df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953700 > Commit-Queue: David Black <dmblack@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726629} TBR=xiaohuic@chromium.org,dmblack@google.com Change-Id: I20b002539e39ca441bda91a3e4ffa4169b49dd38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:145003512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977881Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726660}
-
Kunihiko Sakamoto authored
This reverts commit 7511f14a. Reason for revert: The previous CL crrev.com/c/1953700 broke linux-chromeos-chrome build. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/531 Original change's description: > Remove animator implementations from UiElementContainerView. > > This is part of a multi-CL effort to clean up the Assistant UI element > modeling/rendering pipeline. This CL simply moves the ElementAnimator > implementations that were previously in UiElementContaienrView into > AssistantUiElement. In the future, UiElementContainerView will have no > concept of AssistantTextElementView or AssistantCardElementView, it > will only understand AssistantUiElementView. > > More details of the effort in the bug. > > Bug: b:145003512 > Change-Id: I0228556d5837f5466ca8fd5f9fc59c6ffd1239a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954666 > Commit-Queue: David Black <dmblack@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726636} TBR=xiaohuic@chromium.org,dmblack@google.com Change-Id: Ib1e0546a266a5c516bdb646d552dba950b1829ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:145003512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977880Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726659}
-
Eric Karl authored
Adds thread safety annotations to SharedImageBacking and SharedImageManager. These should make it much harder to forget to take locks (or to double-lock) in the future. Bug: 1003686 Change-Id: Ia50ed5e1bfa599d8d363c275f039f2e57609ba79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977301 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#726658}
-
Gyuyoung Kim authored
This CL replaces .mojom.h with .mojom-forward.h in some sub-directories of chrome/browser to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - chrome/browser/autofill - chrome/browser/background_sync - chrome/browser/banners - chrome/browser/battery/ - chrome/browser/bitmap_fetcher - chrome/browser/browsing_data This CL has no behavior changes. Bug: 1001360 Change-Id: I946d6b412c598116a76a4618f4366919d7c2186d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971292 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#726657}
-
Fergal Daly authored
Problem: When a tab navigates away from a page and then back again, if the page goes into bfcache, JS dialogs no longer appear. Cause: In SwapOutOldFrame, before deciding whether the page goes into bfcache we call SuppressFurtherDialogs but if the page is going into bfcache, this prevents all future dialogs from appearing. Fix: Replace IsWaitingForUnloadACK with !is_active() on the renderer side when deciding whether to show a dialog or immediately drop it and reply to the renderer as if the dialog was dismissed. After discussion and digging, altimin@ thinks this is safe. We will stop showing new dialogs as intended. The concern about nested event loops at the point of entry to bfcache is not a worry as the dialog nested event loop does nothing except handle the dialog response IPC, everything else is queued for the outer loop. Dialogs already stop blocking in JS when the user switches tabs (the dialog stays on-screen but the JS call to e.g. window.alert() returns. So no site should be relying on their dialog being dismissed by real user interaction. This adds a will_enter_back_forward_cache_callback_for_testing_ callback to allow more control of the timing of the JS run. The test that uses it fails if I replace !is_active with IsWaitingForUnloadACK. Bug: 1030133 Change-Id: I25ab4518399d82187028bbefb22b5722475d0cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955245 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726656}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. Bug: 1035074 Change-Id: I71ba271c9752c3b3224a84dcb846868de66079b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977302Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#726655}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. Bug: 1035074 Change-Id: I3923e1d2ee851e491ec35cd07186405b979bd0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977197Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#726654}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. Bug: 1035074 Change-Id: I0599344d6f00b9a2668dc4fc8cb3b8acab50c819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977195Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#726653}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. Bug: 1035074 Change-Id: Iac1b3ad1d3acd47e895cc6b0283a89bbd2f63c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977379Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#726652}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. Bug: 1035074 Change-Id: Ibf2cefba17f5570a5869c2122646b261ae26f296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977303Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#726651}
-
Hirokazu Honda authored
crrev.com/c/1949841 introduces VideoEncoderInfo. The info may be useful for libwebrtc. The goal is to acquire VideoEncoderInfo of hw encoders running in GPU process. This CL is the second step, which enables to pass VideoEncoderInfo via mojo. Bug: 1031965 Test: webrtc.DecoderPerf.h264_hw Test: webrtc.PeerConnection* Change-Id: I55e985a92637f16e888c88e1682d5ec7178101f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973440Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#726650}
-
John Lee authored
This CL is a temporary solution to tabs not animating in when using the new tab button in the tab strip. This produced 0 bugs out of 150 tabs. Bug: 1035678 Change-Id: Id31233ae07356a798a3897f5c7043248819639fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975070 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#726649}
-
Hitoshi Yoshida authored
PathManager kept paths in absolute paths (to be precise, relative paths from out/Default). But in case of code generation, we frequently use paths relative to project's root ("//" in GN) or generated root (out/Default/gen), e.g. include paths and include guards. This CL makes PathManager to keep most paths in relative styles, and adds an API to convert to absolute paths. Bug: 839389 Change-Id: I83ebd5b5a63a673e1ca25d821100b99816c08510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973433 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#726648}
-
Kunihiko Sakamoto authored
This reverts commit 8e917b47. Reason for revert: Causing presubmit failure with messages about the chromium.gpu waterfall configuration. Example: https://ci.chromium.org/p/chromium/builders/try/chromium_presubmit/691375 Original change's description: > [code coverage] Bot definitions for Windows coverage tryjob > > Add definitions for tester machines for Windows coverage. > > Add buildbot definitions so the tryjob can run tests. > > Bug: 1033753 > Change-Id: I3d933b1beaedd24ad206c9e5d2528ed5e4496b67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972753 > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726609} TBR=ynovikov@chromium.org,agable@chromium.org,kbr@chromium.org,nodir@chromium.org,liaoyuke@chromium.org,jbudorick@chromium.org,sajjadm@chromium.org Change-Id: Ib343ed787d0324d1eaf796fe2ee9ca2742d1cdc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976145Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726647}
-
Jason Lin authored
We by default use the webui installer. In addition, the deprecated CrostiniInstallerView has been removed. So, this flag is useless now. Bug: 1026199 Change-Id: I99d45670f39bc032cc017bfe03a4117b294040b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963595 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#726646}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e6b4dd7d3e2..7e2dea568299 git log 6e6b4dd7d3e2..7e2dea568299 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 mtklein@google.com SkColorFilter::onProgram() 2019-12-19 bsalomon@google.com GrGLSLShaderBuilder::appendTextureLookupAndBlend 2019-12-19 fmalita@chromium.org [skottie] Treat unknown effects as warnings Created with: gclient setdep -r src/third_party/skia@7e2dea568299 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I651c8c88a914d86517f69190758f7d070cf368c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726645}
-
Hirokazu Honda authored
libwebrtc can know the information about encoders that are not contained in the library, by webrtc::EncoderInfo. In the current chrome implementation, the structure stops in RtcVideoEncoder and thus the filled information doesn't respect the hw encoders. This Cl introduces VideoEncoderInfo. It is similar to webrtc::EncoderInfo. The information is filled in and dealt with the structure in chrome code. Bug: 1031965 Test: webrtc.DecoderPerf.h264_hw Test: webrtc.PeerConnection* Change-Id: I5305d69be7ff8b7406be6493125f535cd5473ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972742Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#726644}
-
Leon Han authored
Previously, when a non-NDEF tag comes in proximity, NDEFWriter#push() does nothing and still keeps in pending state. This CL switches to reject NDEFWriter#push() in such case so that WebDev can get a sense of what's happening. BUG=520391 Change-Id: I17569910466e75f12ff4e37c29180e2a9af9db13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967745 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#726643}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/330a8816909a..21b29fed64d8 Created with: gclient setdep -r src-internal@21b29fed64d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028270,chromium:866147 Tbr: jbudorick@google.com Change-Id: I5008b43a7841f43bd9e51c71c1719b871053b545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977679Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726642}
-
Sharon Yang authored
Added browser tests for hit testing, implemented in 1927578. Bug: 973095 Bug: fuchsia:16642 Change-Id: I1b4b6638b53b2aa604ac98fc0765266090fa4e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929977Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#726641}
-
Gyuyoung Kim authored
This CL removes unnecessary .mojom.h includes in chrome/browser/chromeos/app to reduce the pre-processed size of header files and shorter build time. This CL has no behavior changes. Bug: 1001360 Change-Id: I21c9d79b222af1e4ab397d5b0e7ef0c033029242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975373Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#726640}
-
Chris Lu authored
TBR=olivierrobin@chromium.org Bug: 1036071 Change-Id: I8e6896706e05aa197aa763bba9e7c85d2a01d3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976136 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#726639}
-