- 03 Apr, 2018 40 commits
-
-
Justin DeWitt authored
OfflinePageTabHelper implements a Mojo service that is notified of the URL and creation date of the MHTML main resource at the time that the MHTML document is installed by ResourceLoader. The information is discovered during MHTML parsing. OfflinePageTabHelper records that the metadata was derived from the MHTML content of an archive and that it should not be trusted. Change-Id: I4890c003caf3687777917743f02b48c2b315ca4b Reviewed-on: https://chromium-review.googlesource.com/946729 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#547830}
-
Adrienne Walker authored
Bug: 790915 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3f1455a61d27e59ac2b5dc49da049044119b6245 Reviewed-on: https://chromium-review.googlesource.com/990236 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#547829}
-
Filip Gorski authored
Bug: 824182 Change-Id: I928f8c010ab4b2f51efb9d5599c4a48fcca4b30b Reviewed-on: https://chromium-review.googlesource.com/993593Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#547828}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c7d0b34084e5..668c1d8d1f1a $ git log c7d0b3408..668c1d8d1 --date=short --no-merges --format='%ad %ae %s' 2018-04-03 agable Reland "Remove Rietveld support from presubmit" Created with: roll-dep src/third_party/depot_tools BUG=chromium:770408 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I53ce76b816ba6f936c0e1bbf43218203325f1cca Reviewed-on: https://chromium-review.googlesource.com/992856Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547827}
-
Christopher Grant authored
If a file URL has a hostname, treat it like an http/https hostname. In other words, don't special-case the file scheme, and ensure we show the rightmost portion of the hostname if present. BUG=805026 Change-Id: I609198db5523d0ec9085e4a4942e7276ee2c273e Reviewed-on: https://chromium-review.googlesource.com/993496Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#547826}
-
khmel@google.com authored
This replaces external reference of Play Store logo in ARC OOBE OptIn to internal static icon. Test: Manually Bug: 824952 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I351967a7b8738dbc1a7bd64adf0cf8c4d6b68926 Reviewed-on: https://chromium-review.googlesource.com/991470 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#547825}
-
James West authored
Stop calling a second AppendExtraCommandLineSwitches() method from CastContentBrowserClient::AppendExtraCommandLineSwitches(). Bug: 67735190 Test: None Change-Id: Ifc045882cb48c92a67631bec60a3ddb6044cb34e Reviewed-on: https://chromium-review.googlesource.com/969623Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: James West <jameswest@chromium.org> Cr-Commit-Position: refs/heads/master@{#547824}
-
Jao-ke Chin-Lee authored
BUG=790709,790645 Change-Id: Id016975e6dc286b8b48d368980e5d27c7e273d59 Reviewed-on: https://chromium-review.googlesource.com/993352Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#547823}
-
sebsg authored
Bug: 827797 Change-Id: Ib5e0e272844961704d1565293e4401bec8c1077c Tbr: mathp@chromium.org Reviewed-on: https://chromium-review.googlesource.com/993693Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#547822}
-
Klaus Weidner authored
The WebVR frame lifecycle transition from "animating" to "processing" was confusing due to use of deferred SubmitFrame. Add a new ProcessWebVrCall at the end of SubmitFrame that can be deferred if needed. A frame counts as "animating" until that executes. Refactor VSync logic. WebVrCanAnimateFrame checks if all necessary resources are available. All the places that provide resources call WebVrTryStartAnimatingFrame which runs SendVSyncNow if CanAnimateFrame returns true. Resources include pending_vsync_ and get_vsync_callback_ along with the ShouldSkipVSync heuristics and the ui_->CanSendWebVrVSync() check. It should be generally equivalent, but with reduced wait time if not VSync aligned since it now reschedules after webvr_deferred_start_processing_ becomes false instead of waiting for the next OnVSync. Change-Id: I32f920d3147b0032037b03f72b18df6cf7195751 Reviewed-on: https://chromium-review.googlesource.com/985652 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547821}
-
Min Chen authored
animation after 'Power off' item has focused for a while after showing. focus related spec: https://drive.google.com/file/d/1JNH0ZDknXSvV00C7TeT4xT_rFx48OdZd/view changes in this cl, - Set pre_shutdown_timer_ in PowerButtonController to start the cancellable pre-shutdown animation after power menu has been shown for 650ms. And remove the previous shutdown_timer_ which will start the clean shutdown after pressing power button for 3s. - Add power button menu item focus. Focus on the 'Power off' item after menu is shown. - Since we add the cancellable pre-shutdown animation back in this cl. Add the related tests in LockStateControllerTest back which removed in the previous cl https://chromium-review.googlesource.com/c/chromium/src/+/916838 - Modify related tests. Bug: 826064 Change-Id: Ibefb22067f5bd37849eb1b8c3fb3143f5d3b8dc8 Reviewed-on: https://chromium-review.googlesource.com/991398 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#547820}
-
Robert Liao authored
ProfileHelperTest.DeleteInactiveProfile and UkmBrowserTest.HistoryDeleteCheck need the waiting thread to process tasks or they will deadlock. BUG=749312 Change-Id: I9d18fd55647d32e6e6a33a72be2a0fa8fcd89524 Reviewed-on: https://chromium-review.googlesource.com/988243 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#547819}
-
Leonard Grey authored
The right command key shares a key code with the windows context menu key. For key event purposes, we don't want to collapse it together with the left command key in case users have remapped it. Instead, disable the entire keyboard context menu code path, since neither of those shortcuts should work on Mac. Bug: 827618 Change-Id: I05123bde9cd43cf5ba01aaf33d406d8300cbe27b Reviewed-on: https://chromium-review.googlesource.com/988392 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547818}
-
Stephen Martinis authored
Bug: 818832 Change-Id: If7ff297aeed7f138fbf79769d04981bfbb5f6d47 Reviewed-on: https://chromium-review.googlesource.com/985193 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#547817}
-
Stephen Martinis authored
Bug: 782863 Change-Id: If74a5d771c96eb1d6047f657f863562392ff697a Reviewed-on: https://chromium-review.googlesource.com/988816 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#547816}
-
Koji Ishii authored
15 rebaselines from manual review of 960 IMAGE and IMAGE+TEXT failures in: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_layout_tests_layout_ng/4542 As in CL:986036, round borders and transformed lines are not included. TBR=eae@chromium.org, mstensho@chromium.org, atotic@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic36a11decbfa29e7cb623e93ff48f13a01165221 Reviewed-on: https://chromium-review.googlesource.com/993212 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547815}
-
Justin Cohen authored
Also removes fakebox calls within UI Refresh, since there is only one omnibox visible at any given time the ::FAKEBOX focus source should not be used. Bug: 823862 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7c68cdbf5cf6ca2cfbfa3e446b9bdb66390f8335 Reviewed-on: https://chromium-review.googlesource.com/976395Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547814}
-
Eric Lawrence authored
By shortening "Developer Tools" to "DevTools", we make it easier for a user to distinguish multiple instances in the Windows task bar, and better align to DevTools branding. Bug: 729910 Change-Id: I961cdd9890ca3569d67cf6ed98697f5dbed79086 Reviewed-on: https://chromium-review.googlesource.com/949781Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#547813}
-
Benjamin Pastene authored
https://chromium-review.googlesource.com/c/chromium/tools/build/+/988694/ will turn it on for the simple chrome bots (Right now they invoke all of gclient inside the chrome-sdk.) Bug: 732531, 828392 Change-Id: I1f892970cd19fd8f64dcfb6615d3033301ac2fcb Reviewed-on: https://chromium-review.googlesource.com/989235 Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#547812}
-
https://chromium.googlesource.com/catapult.git/+log/29a751ceced1..1fcfd9b6d53d $ git log 29a751cec..1fcfd9b6d --date=short --no-merges --format='%ad %ae %s' 2018-04-03 bsheedy Add start service functionality on Android 2018-04-03 simonhatch Dashboard - Add default filters back to skip_files. Created with: roll-dep src/third_party/catapult BUG=chromium:828190,chromium:828405 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I9315a557b61fd7e3028cd623a9839640bddd7215 Reviewed-on: https://chromium-review.googlesource.com/992863Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547811}
-
Dave Schuyler authored
This CL adds members and update handlers to OmniboxSeparatedLineView. This code is currently inactive. Bug: None Change-Id: I5e601c17eb00e815269c9682a29105164d1f86c4 Reviewed-on: https://chromium-review.googlesource.com/991462Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#547810}
-
Ryan Sleevi authored
Remove the SSLConfig flag to enable RFC 6962 support, since it's always set to true. BUG=none Change-Id: I35c8002d3e4b68ed498f1707cd4c8f3d0ea66949 Reviewed-on: https://chromium-review.googlesource.com/993072 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#547809}
-
Katie D authored
Actually remove the Select-to-Speak event handler instead of trying to add it a second time. TBR=dmazzoni@chromium.org Change-Id: Ie8a8dd15adfa16e58ef8d46c60ba3f9b3471b0e6 Reviewed-on: https://chromium-review.googlesource.com/993473Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#547808}
-
Koji Ishii authored
When line breaker hits the end edge and looking for trailing items such as trailing spaces, close tags, forced break, etc., under certain conditions, it only includes trailing spaces and assume it's done. When a forced break follows trailing spaces, this behavior sends the forced break to the next line, causing an unnecessary empty line inserted. This patch fixes by setting the LineBreakState properly after it handled trailing spaces. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idf591de35800479fe2be18dc5fc3a31f205b76b2 Reviewed-on: https://chromium-review.googlesource.com/992832Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547807}
-
Mitsuru Oshima authored
VK_APPS is mapped to context menu key, which activates legacy menu on Android Bug: b/822960 Test: manually tested with app in the solitia CQ app Change-Id: Ic4ce4c5c0d3f0408cc2d1cb4c8601ec1a84c68df Reviewed-on: https://chromium-review.googlesource.com/992355Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#547806}
-
Ryan Sleevi authored
This updates the root stores for the 2018-01 update from Microsoft, the macOS 10.13.0, 10.13.1, and 10.13.2 releases, the NSS CKBI 2.20 root store (part of NSS 3.35), and Android Oreo MR1. This also introduces the concept of a 'legacy' SPKI, which is an SPKI that is not trusted in the current Android or ChromiumOS root store. This can be used to set more permissive policies for legacy Enterprises that have relied on certain CAs being publicly trusted, despite not adhering to the expectations of a publicly trusted CA. BUG=none Change-Id: Id2b358f1e46503deceaf9cd83256c8cd53ffe556 Reviewed-on: https://chromium-review.googlesource.com/990496Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547805}
-
jonross authored
Some more tests have started flaking on Windows in viz_browser_tests with unknown timeouts. This disables them. TBR=kylechar@chromium.org TEST=viz_browser_tests Change-Id: I7cc2c4a589d9517fcaf787f4a6aaa1642a1d6485 Reviewed-on: https://chromium-review.googlesource.com/993633Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#547804}
-
Robert Sesek authored
This may resolve crashes seen in the WindowServer on swarming. Tbr: miu@chromium.org Bug: 828031 Change-Id: Iadbb4bcd74b03ab6abe75efc9b1f02a704ca3b74 Reviewed-on: https://chromium-review.googlesource.com/992453 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547803}
-
Fredrik Söderquist authored
This works around a crash where a layout box references a filter that contains a feImage filter primitive, which in turn reference content that has a mask applied. Bug: 814815, 825538 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib2433b3ba48b3ea56462a1eb64209d36aa37cfa4 Reviewed-on: https://chromium-review.googlesource.com/982114Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#547802}
-
Pete Williamson authored
In this part, we add the code to actually move the offline page, update ADM, update the OfflinePageModel, and call back to the java side code. There is also a small refactoring to use the same symbol everywhere for our database table name, it has moved into offline_store_utils.h. Bug: 758690 Change-Id: Ia540cfdd9f94ac93a1211eb8b7184507b3906080 Reviewed-on: https://chromium-review.googlesource.com/985208 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#547801}
-
Elly Fong-Jones authored
Mac menus don't use a margin around the contents at all - the menu items (especially their highlights) draw hard up to the menu edge. TBR=sky@chromium.org Bug: 828117 Change-Id: I0165bc8987d0f7d6c1ba29660098f91ad9478984 Reviewed-on: https://chromium-review.googlesource.com/993418Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547800}
-
Andrew Grieve authored
gn analyze does not use depfile information, which causes it to not know that builds need to happen when proguard flags change. To work around this, this change marks the proguard_configs as inputs to (somewhat arbitrary) java actions. Bug: 827197 Change-Id: I1522daa0e3782ac1989cf4e234d8409663bf1357 Reviewed-on: https://chromium-review.googlesource.com/985900Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#547799}
-
arthursonzogni authored
The race condition happens when UrlLoader::OnReceiveResponse() is received, but the request is canceled in the meantime. In this case, there are no more request and we must abort the loading. It fixes the Android test: android.webkit.cts.WebViewTest#testSetDownloadListener in the Android compatibility test suite (CTS). Bug: 828156 Change-Id: I6bd6c2e89ab055f05ddab51b5cddebf4ff93bb47 Reviewed-on: https://chromium-review.googlesource.com/993057 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#547798}
-
Changwan Ryu authored
I haven't landed a lot of CLs in this directory, but when the other owners aren't around, I can step up and review not-too-complex CLs. Here are the list of CLs I've landed - most of them are for IME and tests though. 9195b0a9 Expose onCheckIsTextEditor correctly through WebView object c1134a86 Allow user agent to be overridden in popup webview creation 68ee851d [WebView] Set up resources on non-UI thread in start up eb8a057e Fix autofill focus handling for webview a3970dd7 Add guarded logging for debugging webview autofill 2508b5fb Fix AwAutofillTest failure on L 00fe5149 More autofill tests for triggering, input types, and blur 9210616d Fortify autofill tests for WebView ee89226f Revert of Migrate IME state update flow (patchset #4 e54ccdb9 Workaround for Samsung email issues 56ededfe Disable thread checking for LGE email app f99c4ade Prevent thread assertion for HTC mail apk 5a6c5bf0 Overhaul WebView IME test fcc3fbf1 Fix webview memory leak when keyboard was shown 945f5e29 Ensure input connection to be created on pressing next button cbfdec91 Resume cursor blinking on closing context menu e04b8f53 Remove Android support for out-of-process KeyStores id: 100001 of https://codereview.chromium.org/2777223004/ ) Change-Id: Ie9deb6e59fdc8d26af2da316c75c8c29eb87ebfc Reviewed-on: https://chromium-review.googlesource.com/991402 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#547797}
-
Xiaocheng Hu authored
This reverts commit 802df057. Reason for revert: suspected for causing memory regressions crbug.com/828026 and crbug.com/828027 Original change's description: > Make CapurePageText capture textContent only on dirty layout > > This is a partial revert for r536969 Change TranslateHelper to use a > TextContent-like text dump. > > r536969 is a workaround for a lifecycle violation bug that layout is > still dirty after running layout update. > > It turns out that textContent is not a good text dump for > TranslateHelper, as pages may hide arbitrary content (e.g., JSON) in > invisible text nodes, which can't be reliably filtered without checking > element style or layout. > > Since we don't always run CapturePageText() with dirty layout, there is > no need to always dump textContent. Hence, this patch partially reverts > r536969 that, we still dump innerText as long as layout is clean. We > dump textContent only when layout is dirty, which is enough to get > around the lifecycle violation bug. > > Bug: 826174 > Change-Id: I63e97832caa9858e67992847fb9a22f6405183cb > Reviewed-on: https://chromium-review.googlesource.com/984474 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Rachel Blum <groby@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547334} TBR=groby@chromium.org,tkent@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 826174, 828026, 828027 Change-Id: I4c3200e5c7de0e6b3838ddcc40d53e751538f915 Reviewed-on: https://chromium-review.googlesource.com/992818Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547796}
-
Mostyn Bramley-Moore authored
https://chromium-review.googlesource.com/c/chromium/src/+/893401 added a MockPlatform class in SourceKeyedCachedMetadataHandlerTest.cpp which conflicts in jumbo builds with ResourceTest.cpp. Let's rename one. TBR=japhet@chromium.org Bug: chromium:823663 Change-Id: I044cf979281fe4009601c3024139c57435fb4762 Reviewed-on: https://chromium-review.googlesource.com/992235 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#547795}
-
Adrienne Walker authored
Don't ask another function to do conditionally something the caller could just do. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2fc0d8cf581f57ece9051a0a85bf0c2ac65dfabf Reviewed-on: https://chromium-review.googlesource.com/993155Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#547794}
-
Robert Ogden authored
Adds an experimental param on the connection robustness mechanism to disable proxy bypass when the via header is missing. Bug: 724704 Change-Id: I56286a06485b70c0c746850de14d79b2da755366 Reviewed-on: https://chromium-review.googlesource.com/990775 Commit-Queue: Robert Ogden <robertogden@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#547793}
-
https://pdfium.googlesource.com/pdfium.git/+log/75304f915c5c..232b918d1f0f $ git log 75304f915..232b918d1 --date=short --no-merges --format='%ad %ae %s' 2018-04-03 tsepez Re-arrange so inline vectors come last in structs. 2018-04-03 thestig Roll pdfium/third_party/freetype/src/ 713d68ee9..7109495c5 (21 commits) 2018-04-03 tsepez Off-by-one in CPDF_StreamParser::ParseNextElement() Created with: roll-dep src/third_party/pdfium BUG=chromium:828049 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2892003f57e749fed8957a758722ec702d166bfd Reviewed-on: https://chromium-review.googlesource.com/992888 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547792}
-
Becca Hughes authored
If the media starts playing whilst the loading panel is either showing or cooling down we should hide it immediately as we are obscuring the video. BUG=827482 Change-Id: Ie0fb8159469fcc6740f624d052ac4b176f4f6876 Reviewed-on: https://chromium-review.googlesource.com/990192 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#547791}
-