- 22 Jul, 2020 40 commits
-
-
Victor Vasiliev authored
This has been previously blocked on https://bugs.chromium.org/p/chromium/issues/detail?id=1046390. Change-Id: I1c0d68dc56d109be6189df0cfb8fc04230949a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302721 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791073}
-
Meredith Lane authored
This reverts commit 780e443e. Reason for revert: Suspected Culprit for tree closure: https://ci.chromium.org/p/chromium/builders/ci/mac-arm64/2964? Original change's description: > Update core items for macOS Big Sur. > > - Update the base::mac::IsOS*() functions. Introduce a parallel set > of IsOS#() functions to match the IsOS10_#() functions. Update all > tests to match, and update callers where appropriate. > - Turn on the CFAllocator OOM killer for Big Sur, as the > internals of CFAllocator have not changed. > > BUG=45650, 1101439 > TEST=base_unittests > > Change-Id: I57438eb025316e3cb899a0fa5aef35f4d297855f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285930 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791051} TBR=avi@chromium.org,mark@chromium.org,kelvinjiang@chromium.org Change-Id: I86460b6921c2b141d69d44351c6c2702e85dff67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 45650 Bug: 1101439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315357Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#791072}
-
Austin Eng authored
The WebGPU API provides facilities to create mapped GPUBuffers backed by shared memory. This makes it very easy for JavaScript to make large transfer buffer allocations which fail allocation and instantly lose the context. This CL adds an option to CommandBuffer::CreateTransferBuffer and MappedMemoryManager::Alloc to not lose the context on OOM but instead fail gracefully. Bug: dawn:450 Change-Id: I7311dd2ab685a150574056fbe9df5fa1724e4b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310831Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#791071}
-
zhaoyangli authored
Simulators created within test runner should be removed. However this was lost when migrating to xcodebuild_runner. Bug: 1108012 Change-Id: Ib59f1c4a580acad28fb3829238f6601a460af3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310673Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#791070}
-
Scott Violet authored
This function is only used in chrome, and should be moved there. BUG=1076463 TEST=covered by tests Change-Id: I5916d68e5761635839e6ce1db680d45116ea0331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311520Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#791069}
-
Devlin Cronin authored
Add support for a "match_data_urls" field in content scripts specified in an extension's manifest. This CL adds the parsing logic and related unittests, behind a base::Feature. Future CLs will add support for the actual injection of scripts into these data URLs, as well as expanding the support to include dynamic script injections. Bug: 55084 Change-Id: I288c66dfb901e9cb77d09562cf943a223adcb8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292697Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791068}
-
Ilya Sherman authored
This header contains serialized and base64-encoded protocol buffers. This utility simply base64-decodes the serialized data, and then parses the proto via compiled JSPB parsing. R=mathias@chromium.org, yangguo@chromium.org Bug: 1103854 Change-Id: I233683468fdb189f206c819f650c07eae34525d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301121 Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#791067}
-
Nick Harper authored
Change-Id: I3f5bd166da9b104128ade1891e427e8953083c83 Bug: 855690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314556Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791066}
-
Ahmed Mehfooz authored
Ux specs are attached in the bug. Bug: 1106054 Change-Id: Ie8982f5b07a6330e16d76da19b3e36f48fc9731a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300633 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#791065}
-
Ian Struiksma authored
Bring up win1909 to tests before rolling out to larger machine pool. Bug: 990885 Change-Id: Id3900e8f04a386bd2e6fe81dee4799bc747cdfb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311124 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#791064}
-
Tommy Li authored
We've always returned the current page's URL as a verbatim default match for ZeroSuggest (with the exception of on the NTP). However, we don't need this anymore on Desktop. This CL preserves the most-visited mode's behavior, but removes the verbatim match from all remotely fetched (from the suggest server) ZeroSuggest results on Desktop. We leave Android and iOS alone. Android needs the verbatim match for the Search Ready Omnibox edit widget. iOS we're leaving alone because there's no strong reason to change it. Bug: 1095843, 1106096 Change-Id: Iac6c1ee401a93cda05df7cc96d5e176e3d36f3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308944 Reviewed-by: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#791063} -
Ahmed Mehfooz authored
UX required a few tweaks to the battery icon and badges. Bug: 1106382 Change-Id: Ic29f812d0254b01223e6709750ac74792b6ce8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304724Reviewed-by:
-
Eric Lawrence authored
Most CSP directives are ignored for PDF responses, but the frame-ancestors directive should remain supported. Test that CSP can be used to prevent embedding of a PDF file. Also test that a CSP can allow embedding even if an X-Frame-Options: DENY directive is present. Bug: 1107535 Change-Id: I3fbe5fca5e591bb670e0ad79babde191c83be0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313999 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#791061}
-
Dana Fried authored
This is a local fix to the larger problem of scaled bitmaps rendered in ImageViews at non-integral DIP scaling factors (125%, 133%, 175%, etc.) It solves the specific bug, but does not solve the larger problem of the ways we scale bitmaps and Views canvases being sometimes different. More info is available on the issue cited. I am looking for feedback - if this is an acceptable fix for right now or if we should drive towards a more comprehensive approach. Probably both. Bug: 1094566 Change-Id: I024e216542cee057cd4198a5a65344ffa0cd999d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306751Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#791060}
-
Edward Lesmes authored
Bug: 1108541 Change-Id: Id56dce83803e6389c8112be9bf7b1b057c78e58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314132Reviewed-by:
-
Edward Lesmes authored
gn check was failing because a header listed in sources (src/src/loader/xr_generated_loader.h) didn't have the right name (it should be .hpp, not .h). Bug: 1108481 Change-Id: I7f0df8a8efcd1d8e0b82591fb63f9062713dc20a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314163Reviewed-by:
-
Pavel Feldman authored
Before this change, postData was annotated as text, but was used as binary string in the code. This change annotates it as binary, which means that it'll be base64-encoded in the JSON wire. This is a breaking change to the experimental Fetch.continueRequest method, but since implementation was never correct, we believe that fixing, documenting and testing it is the right way to go. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1107728 Change-Id: Ic8022035875ff3d66e75d1d0266cbf9488f10673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315239Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Auto-Submit: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791057}
-
Jeffrey Cohen authored
screenshot: https://hsv.googleplex.com/5667084082085888 Bug: 1106145 Change-Id: I51655f571ba9e4c61da5807a7c208b9c163de788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307648 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#791056}
-
Maksim Ivanov authored
Make the TestCertificateProviderExtension's test extension have a fixed extension ID (by putting its public key into the manifest.json file), and update the class to expose this ID as a constant. This is a preparation step for getting rid of the TestCertificateProviderExtensionLoginScreenMixin (in favor of ExtensionForceInstallMixin). Bug: 1090941 Change-Id: Ic27ed9f0161631b6415a07d3a8e73b8329ec34eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312817 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791055}
-
Maksim Ivanov authored
Fix the problem with the DCHECK in TestBackgroundPageFirstLoadObserver::OnBackgroundHostCreated() being hit in case when the extension's background page host gets destroyed and recreated. The DCHECK was fired because the class didn't expect to observe more than one host at the same time. The underlying issue was that the class didn't stop observing the deleted host, leading to the DCHECK hit and a potential use-after-free (in tests). Bug: 1090941 Test: stress-test the "CertificateProviderApiTest.LazyBackgroundPage" browser test after applying crrev.com/c/2312817 Change-Id: I91cf8f3bb0126a04b63e3a73d3f39259c621f330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312799Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#791054}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9faf0cdcd0c6..ffb31229fce4 2020-07-22 m.maiya@samsung.com Capture/Replay: Enable capturing slingshot scenes 2020-07-22 jmadill@chromium.org Fix trace tests auto-generation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I618689ae0512ec0267c255bd97c515a99efc431e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791053}
-
Yi Xu authored
This is the last cl in the theory. I moved all perf_tests/canvas that contains frame changes to rendering benchmark. TBR=fserb@chromium.org Bug: 1077148 Change-Id: I52a9e98d9e70dfdb4fa4337dc9174dad38d42ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290703Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#791052}
-
Avi Drissman authored
- Update the base::mac::IsOS*() functions. Introduce a parallel set of IsOS#() functions to match the IsOS10_#() functions. Update all tests to match, and update callers where appropriate. - Turn on the CFAllocator OOM killer for Big Sur, as the internals of CFAllocator have not changed. BUG=45650, 1101439 TEST=base_unittests Change-Id: I57438eb025316e3cb899a0fa5aef35f4d297855f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285930Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791051}
-
Josh Nohle authored
Add a contact manager implementation class, where the overridden methods are currently marked as NOTIMPLEMENTED(). We also include a fake implementation and factory for use in unit tests. The full implementation will happen in a follow-up CL. For now, these classes unblock consumers of the contact manager. Bug: b/154863722 Change-Id: I1fe9813fe0578f72aa50f13d402995ed4a46b6d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308948Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#791050}
-
Maksim Moskvitin authored
SecureBox provides a set of simple interfaces for performing encryptions and decryptions, by using a public key owned by the recipient and/or a secret shared by the sender and the recipient. Bug: 1101813 Change-Id: I9ced4c91a8d31b0b395096ad6045b5075df899f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279971 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791049}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/deded62426ed..c3e7ab19bbf9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com,wjmaclean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kelvinjiang@google.com,wjmaclean@google.com Change-Id: Ib0c1b168a336f1ccb94b20b758a5fa0bf7e0cbb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314441Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791048}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/026b1e2be09a..f9803e14b0fb 2020-07-22 fmayer@google.com Merge "Fix non-Unix build for local_symbolizer" 2020-07-22 aninditaghosh@google.com Move vendor specific functionality to seperate file 2020-07-22 treehugger-gerrit@google.com Merge "Refactor heapprofd end to end test." 2020-07-22 treehugger-gerrit@google.com Merge "Add thermal events" 2020-07-22 lalitm@google.com Merge "ui: update cpu frequency track to also use proper counter quantization" 2020-07-22 lalitm@google.com Merge "ui: fix counter track quantization" 2020-07-22 lalitm@google.com Merge "tp: label pid 0 thread as "swapper" without cpu suffix" 2020-07-22 treehugger-gerrit@google.com Merge "ui: fix computation of resolution" 2020-07-22 fmayer@google.com Fix compile error for non-Linux trace processor. 2020-07-22 treehugger-gerrit@google.com Merge "Add a version file for Chromium protos autoroller" 2020-07-21 aninditaghosh@google.com Load trace_processor binary if the path to it is defined 2020-07-21 aninditaghosh@google.com Merge "metric() returns proto message instead of bytes" 2020-07-21 oksamyt@google.com Merge "Add host_app_package_name to ChromeProcessDescriptor" 2020-07-21 fmayer@google.com Allow to index symbol files by build ID. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:161235574 Tbr: perfetto-bugs@google.com Change-Id: I1493ccd14ad4e3663398f3f2776f363c83258787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314796Reviewed-by:
-
Maksim Ivanov authored
Provide test coverage for the scenario when the Ash PIN dialog, appearing during a challenge-response login (a.k.a. smart card based login), is canceled by the user. Bug: 1033936 Change-Id: Iba1bebb12b3883a496bec360539b33a109e83ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310493 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#791046}
-
Ken Buchanan authored
This adds a startup metric on Mac, Windows and ChromeOS to report whether the current system has a platform authenticator available. Understanding prevalance of platform authenticators is useful for planning WebAuthn-related features, especially around payment flows. Bug: 1104229 Change-Id: I4f0d141c8eb0cf390a3aafe50c83f081715d4aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293070Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#791045}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8bd3bcf43431..9061d5d154bc 2020-07-22 rharrison@chromium.org Remove deprecated use_relative_hooks reference If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia11dffe45e2b976aac2e10cd055ef2ffa804ba7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315116Reviewed-by:
-
Gabriel Charette authored
And remove the PreventMessagePumpHangs experiment. It was initially planned to be used for more than this experiment but has since reached its expiry date without this version showing side-effects on metrics (as intended). I'll add it back if/when doing further MessagePump experiments. R=chromium-metrics-reviews@google.com, fdoray@chromium.org Bug: 1074019 Change-Id: I5b19e80380202133afa3f494268a27e6ffd06c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312839 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791043}
-
Will Harris authored
Also, move win7-rel from master-only to chromium so it will continue to run on the branches. BUG=None Change-Id: I46ee1c2095cccd9ba23332d8a94dc354f3ed3354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315181Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791042}
-
Alan Cutter authored
This CL removes the system theme check for web apps in ShouldUseTheme(). This logic now lives in BrowserFrame::GetThemeProvider() as of: https://chromium-review.googlesource.com/c/chromium/src/+/2239912 Bug: 1087693 Change-Id: Icd006bccab2fe08112990f8c856ecf4c75fef0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309993 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#791041}
-
Karandeep Bhatia authored
Instead of merely bypassing the CSP in the isolated world, enforce the isolated world CSP. Also, plumb the correct DOMWrapperWorld for ResourceLoaderOptions in PreloadHelper::PreloadIfNeeded. BUG=1099975 Change-Id: I00ca5376c21692a547d2665533e4237e8609a843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276649 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#791040}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e4e1fb30c836..caa2f149fb8b 2020-07-22 nodir@chromium.org Roll dirmd to 6c4507c0 2020-07-22 guterman@google.com Add explicit "python" to script for Windows compatibility If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106176,chromium:923016 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Id61e673a2891dceee3b9aac19fd5eb60e7217504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314800Reviewed-by:
-
Brandon Wylie authored
Bug: 1041576 Change-Id: I0b326b558e4578765ac1c20ee43402d758335a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314020Reviewed-by:
-
Nico Weber authored
Bug: 989095 Change-Id: I238f929bcf655a2be953bbb4d65a560d1452937a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310189 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Vasiliy Telezhnikov authored
This CL fixes two problems with WebView/SkiaRenderer/GL with vulkan hwui: * Missing allocator, chrome introduced one to use single instance with Skia. * Wrong fboid for query alpha capabilities. Bug: 984955 Change-Id: Ib8e9fb57bcf9b11557aac5a412abb91556819038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314419Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#791036}
-
Kelvin Jiang authored
This subtest is currently flaking and I am disabling it (for now). Bug: 1108534 Change-Id: I7bf50d77a841a87f13b5e1a579d59ed6217dd737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314787Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791035}
-
Henrique Nakashima authored
Modularize the interface and its dependencies: - AsyncTabParams - AsyncTabCreationParams Change-Id: I5b785cae99907b43dc4188f1aa09c240ae3b47ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305116 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
