- 20 Aug, 2019 40 commits
-
-
Alexander Hendrich authored
This CL updates the config dir policy loader to also apply the loaded extension policy to login screen extensions. Bug: 928334 Change-Id: If16447393f05f9d9fb78e885eaa50478d4d342ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728587 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#688527}
-
Peng Huang authored
Bug: 995343 Change-Id: Id9638c41db2c208ba8f12fa0a8d90610aae574f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761062Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#688526}
-
Elly Fong-Jones authored
It is not just flaky on Mac. TBR=marinaciocea@chromium.org Bug: 988248 Change-Id: Iad51b21d0f85900f2fd0fabe3da1f21a6ea21862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761145Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#688525}
-
Javier Ernesto Flores Robles authored
Sets the tint color of the cell so when the accessory view is created it is tinted with the right color. Sets the tint color of the table view to blue so the index uses it. Screenshots: https://drive.google.com/file/d/1xfOJVT6ZqqOiSb_pEX_uWqeLeEcxpc2F/view?usp=sharing https://drive.google.com/file/d/1-HwGeIh1d-vk3fSDfsLVxWTm0y64kRfG/view?usp=sharing Bug: 976675 Change-Id: I3f1b4990060a1db29eb119c271d3402c8e1706b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749010 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#688524}
-
Ken Buchanan authored
Change the expiry for the flag to turn on BLE support for Web Authentication to M-82, to prevent its removal from chrome://flags. Change-Id: I8c50aeded7a28aea2af4dbbd3460757e59767ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762268 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#688523}
-
Takuto Ikuta authored
Owners file generation took more than 25% of full build times in CQ. Let me enable that only in fuzzing engine build. Bug: 995151 Change-Id: I4f490ef946ddeb729991cafbf21dd21bb5059920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761889 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#688522}
-
Connie Wan authored
This was left hanging here: https://chromium-review.googlesource.com/c/chromium/src/+/1717271/7/chrome/browser/ui/views/tabs/tab_strip_layout_helper.cc Bug: 966627 Change-Id: I162ee3a5e0f575fd3b180befbf296b7335f1cdbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761290Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#688521}
-
Finnur Thorarinsson authored
Bug: 989210, 860467 Change-Id: I9b4d498d585a67c13175cbaec186fef0959a3dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762077 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#688520}
-
Lindsay Pasricha authored
https://chromium.googlesource.com/external/github.com/facebook/fishhook.git/+log/d172d5247aa5..80fe593736ac $ git log d172d5247..80fe59373 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 facebook-github-bot OSS Automated Fix: Addition of Contributing (#58) 2019-03-27 facebook-github-bot OSS Automated Fix: Addition of Code of Conduct (#59) 2018-04-02 jmarg Prevent nullptr derefence on failed allocation 2018-03-31 jmarg Replace #import with #include to compile on VisualStudio 2018-03-31 jmarg Save 2ms at app startup by inlining strlen (from @swolchok) 2018-02-03 rosen0510 fix memory leak in rebind_symbols_image (#49) 2017-03-03 dair Add explicit casts from void*. 2016-08-01 davelee.com Make fishhook symbols hidden by default (#29) 2016-04-25 davelee.com Move symol length check out of rebinding loop (#27) 2016-04-02 ocrickard Improve performance of perform_rebinding_with_section Created with: roll-dep src/ios/third_party/fishhook/src Bug: 992021 Change-Id: Ia8c72aaa1a1b23d629ed2956e24910b9e1c8951e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758432Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#688519}
-
Xida Chen authored
Some functions in this class calls APIs in cc::TransformOperations, which all take floats. But those functions provide doubles, and that causes float-cast overflow. This CL solves the problem by using SkDoubleToMScalar, and layout tests are added. Bug: 995038 Change-Id: Ic1b73c31d6090f38c7c6f342d9e953c58567604c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761733 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#688518}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9781db33..5c6b118c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I14fb9279a90260b571b58ce3736068d9276e9ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757860Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688517}
-
Oleh Lamzin authored
Document that for the Custom setting of DeviceBatteryChargeMode, the Start value must be at least five percentage points below the Stop value. BUG=b:138795980 TEST=none Change-Id: Ie9580bab609598dba10bec916a3867d6ab33ed9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761595Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#688516}
-
gogerald authored
The tabs are ordered from the most recent to the least recent ones in the tab grid and carousel in start surfaces. Bug: 982018 Change-Id: I974c492555751c5f2d7eebe8c6d871d05a41fb22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746907Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#688515}
-
Jeremy Roman authored
Changed NULL to nullptr where the presubmit complained (due to new line wrapping). Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216 Bug: 981415 Tbr: gab@chromium.org Change-Id: I9c7ea90816e2a2418981108f657bc52cee8c06ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703541 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#688514}
-
Xida Chen authored
Currently in this function, we apply a roundf on a double value. We should never do a roundf on a double value, it should just be round. Bug: 994800 Change-Id: I6208d9db51661b2587ba54f949b9945ec47dcf3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761690 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds a UI flag for the password leak detection feature. Bug: 986298 Change-Id: I0dde3c0afa4464bd97bd11c57b8fa7b5de7a8600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761605 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#688512}
-
Morten Stenshorne authored
This didn't serve any purpose anymore, since fragmentation of inline-level floats is currently broken (no pun intended). See crbug.com/915929 Change-Id: Ib852e68daae9d0ebe47f844d7395ae897100d047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761274Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#688511}
-
Kenichi Ishibashi authored
This is the same as crrev.com/c/1724754 but for android webview. We need a didicated connector for the IO thread to create {URLLoader,WebSocketHandshake}ThrottleProviders. Bug: 989781 Change-Id: Ia0c883d243e8f856ede2d2747e124b80c2253dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760646Reviewed-by:Bo <boliu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#688510}
-
Stefan Zager authored
Looking at the flakiness dashboard, all of the failures are due to timers running within 200ms of the expected time. The test is intended to detect the difference between timers running at 100ms intervals and at 1000ms intervals, so the greater tolerance still provides adequate coverage. BUG=971590 R=alexclarke@chromium.org Change-Id: I7b9ea31ad6dce2ba3c2cbfb9f3afa0eb8ea29ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758662Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#688509}
-
Mohamed Abdelhalim authored
Keeping the manual reset of navigation_handle as discussed in: https://chromium-review.googlesource.com/c/chromium/src/+/1751983 Bug: 916537 Change-Id: I83c3da139d4932d712f1a39d55aabea210a5989a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761281Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688508}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ebcc14092998..5288d5c6c2d9 Created with: gclient setdep -r src-internal@5288d5c6c2d9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:954450,chromium:956776 Change-Id: Ibad1efa24cf8c19f92077dcfd1bf04c90e3bd1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762193Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688507}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b35d45fc. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ide81c522b3dbdb313b6f685150f16da99dac85a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757859Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688506}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e21f3f574b59..a85492181380 git log e21f3f574b59..a85492181380 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 titovartem@webrtc.org Enable custom metrics gathering from stats API in PC framework. Created with: gclient setdep -r src/third_party/webrtc@a85492181380 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I5c1e1fffd4a71d85603df7a81723d2010b68a72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762194Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688505}
-
Dominik Röttsches authored
Synchronize with HarfBuzz' removal of the back-conversion/multiplication from "ptem" to "CoreText points", in other words, synchronize with a change in HarfBuzz in how the unit of hb_font_set_ptem is interpreted. More details in [1]. https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/60485ab04736..bbad1b829812 $ git log 60485ab04..bbad1b829 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 ebrahim [trak] minor, use roundf instead round to normalize the use 2019-08-20 ebrahim [readme] add oss-fuzz badge 2019-08-20 ebrahim [test] Rebase 10.14 trak related test 2019-08-19 behdad Minor touch-up for recent change 2019-08-07 ebrahim [avar] Implement inverse map, unmap 2019-08-07 ebrahim [fvar] Implement inverse normalize, unnormalize 2019-08-19 behdad Minor 2019-08-18 ebrahim Remove continuous development helper script 2019-08-16 khaledhosny [ot-shape] Keep horizontal_features array sorted 2019-08-16 khaledhosny [ot-shape] Enable abvm/blwm features by default 2019-08-16 khaledhosny [ot-shape] Enable dist feature by default (#1908) 2019-08-14 ebrahim Move HB_NO_VAR to a better place in hb-font.cc 2019-08-14 ebrahim minor 2019-08-14 ebrahim Minor, remove trailing spaces in hb-font.{cc,h} as .editorconfig 2019-08-14 ebrahim Fix caret_count value when AAT is disabled 2019-08-14 ebrahim [lcar] Use multiformat convention 2019-08-14 ebrahim [opbd] Use multiformat convention on the table 2019-08-14 ebrahim [opbd] Turn OpticalBounds fields to FWORD 2019-08-13 behdad 2.6.0 2019-08-13 behdad Rename hb_ot_meta_get_entries() to +hb_ot_meta_get_entry_tags() 2019-08-13 behdad [pool] Fix alignment assertion 2019-08-11 ebrahim Increase subset fuzzer timeout to 16s 2019-08-11 ebrahim [ci] Disable vcpkg thus running the test suit in Windows 2019-08-11 ebrahim Implement opbd table parsing 2019-08-10 ebrahim [os2] Replace null pool addr compare by checking vital fields (#1896) 2019-08-07 ebrahim [fvar] Use roundf instead hardcoding round logic 2018-12-17 tor.arne.vestbo Remove assumption about Core Text working in 96 DPI [1] https://github.com/harfbuzz/harfbuzz/pull/1484 Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 995721 Change-Id: I1eea18a1f1e4e3bad86fede7291f4acf0b4bef71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761282 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#688504}
-
Tanisha Mandre authored
Aim: Remove the QR Scanner Specific methods out of the camera controller so that a similar subclass of the generic camera controller super class can be implemented for the credit card scanner. Architecture: Superclass - cameraController Subclasses - qrScannerCameraController Methods shifted: 1. - (void)continueLoadCaptureSession:(AVCaptureVideoPreviewLayer*)previewLayer; Modifies the method to move the section that configures the QR scanner metadata output to a separate method 'configureScannerWithSession', implemented in the QR Scanner Camera Controller. 2. - (void)captureOutput:(AVCaptureOutput*)captureOutput didOutputMetadataObjects:(NSArray*)metadataObjects fromConnection:(AVCaptureConnection*)connection; Moves this method to the QR Scanner Camera Controller. It reads and processes the scanned QR code data. Bug: 990744 Change-Id: If07340c62b0c5c11c70a1e6c4d0a6782dd2c774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754008 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
If an inner multicol container had a fixed height so large it required an outer fragmentation break, we might fail to break and would instead let it overflow the outer fragmentainer. We relied on child content being present in order to be able to break. Share code between NGBlockLayoutAlgorithm and NGColumnLayoutAlgorithm to fix this. This fix also changed how the NGColumnLayoutAlgorithmTest.Nested unit test got laid out. It turned out that the expectations were wrong there. There was a 100px tall inner multicol with top and bottom padding of 1px each. This should give a border box of 102px. It was fragmented across three outer columns, with room for 30px in the first, 50px in the next, and the rest would fit in the third one. We used to expect 23px in the third outer column, but 30px + 50px + 23px is 103px, not 102px. This change makes the web test fast/multicol/nested-very-tall-inside-short-crash.html time out (actually just incredibly slow), since we'll now create millions of fragments, as we should. Not sure if it's worth it to get it to perform decently. Skipping for now. Bug: 829028 Change-Id: If38b2c028ca33d2f4e8fd7d4b8d533a24cd75438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760958 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
David Benjamin authored
We were still waiting on the middleboxes of the world to update so we can enforce this. However, the reminder is much appreciated since it looks like the numbers got dramatically better than the last time we looked, so perhaps this'll be the last time! Bug: none Change-Id: Ice4d465cb4c80a90d6631d0151c1b3d653a8431d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761137 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Khushal authored
OOPR is still in the process of being launched on desktop platforms and SurfaceControl will be rolled out with Android Q release. R=ellyjones@chromium.org Change-Id: I28f9c3f3c18c1e33dcd80bda768d93e948f4b194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761321 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Clark DuVall authored
Change-Id: I6716b187bcbdaf10bbe547ec0124a272977175cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761136 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Marc Treib authored
This is still useful for some ongoing rollouts, so let's keep it a while longer. Bug: 984279 Change-Id: I5aedc343a5c6a7c77f7f935a35b6959fa97efd20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760917 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#688498}
-
Ben Kelly authored
Bug: 954442 Change-Id: I589d5aa4c78bdfb582017db3bdecb7890a7baa7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760418Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#688497}
-
Gabriel Charette authored
Found by presubmit checks for https://chromium-review.googlesource.com/c/chromium/src/+/1756247. Not cleaned up then by fear of other files using this include implicitly relying on it. Bug: 992483 Change-Id: I6ed169ff70b1f36b4a54f00caf5b3dbb9b5b88e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760272 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#688496}
-
Brian Salomon authored
This is a reland of 23a46517 These tests will be changing slightly again. Original change's description: > Suppress two canvas layout tests to roll Skia rect blur changes > > Bug: 990918 > Change-Id: I766e507d5173f847b95ae94bdc2b3857913ec9bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754542 > Auto-Submit: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> > Cr-Commit-Position: refs/heads/master@{#686955} Bug: 990918 Change-Id: I88ca5e26e889e588f84c0abfabd4a842a98a4e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758337Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#688495}
-
Stefan Zager authored
The hack is no longer necessary. Also remove some other obsolete TODO's. BUG=796145 R=yukishiino@chromium.org Change-Id: Ie84e143759d8e882f7403da48da6f882a962998a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760984Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#688494}
-
Marc Treib authored
...instead of re-implementing the same logic. Note that the unconsented primary account is supported on exactly those platforms (Win, Mac, Linux) for which kSyncSupportSecondaryAccount was enabled, so this brings no behavior difference. After this CL, the feature kSyncSupportSecondaryAccount has no effect (and some tests which used to explicitly set it need to be #ifdef'd to the right platforms now). Cleaning the flag up is left for a follow-up. Bug: 990745, 983182 Change-Id: Ic720439de2cc04a1ce6aa6c16f16d1b98721c25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752826Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688493}
-
Morten Stenshorne authored
The trybot was failing consistently. Some failures were introduced by CL:1757606 - rebaselined expectations. One failure was caused by CL:1757165 - added to expectations file. The remaining tests had been failing for some time already (but prior to the bot rename [1] this wasn't a problem for landing, apparently), so I just added those to the expectations file as well. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1754528 TBR=cbiesinger@chromium.org,eae@chromium.org,kojii@chromium.org Bug: 995713 Change-Id: I9035114153cd81e8c65938299bf454d106a62f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761278Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#688492}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/93d4c10ffccc..e21f3f574b59 git log 93d4c10ffccc..e21f3f574b59 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 nisse@webrtc.org Revert "Delete mac_utils.h and mac_utils.cc" 2019-08-20 tommi@webrtc.org Make the callbacks to PollStats for RampUp* tests more regular. 2019-08-20 nisse@webrtc.org Delete mac_utils.h and mac_utils.cc 2019-08-20 peah@webrtc.org Removing all external access to the integer sample data in AudioBuffer Created with: gclient setdep -r src/third_party/webrtc@e21f3f574b59 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:993688,chromium:None Change-Id: I66d7b5127df296ab6cfa68fbd6d246e88ddfb178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761831Reviewed-by:
-
Ivana Zuzic authored
Observer for the password list in PasswordEntryViewer should be removed while the view still exists, to avoid calling findViewById on an empty View. Previously, the observer was removed in onDestroy() which happens when the View is already gone and passwordListAvailable could call setRowText which uses findViewById. Bug: 994010 Change-Id: I10fbea31dd6faad777b24ec8783c7572e91484ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761589Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#688490}
-
Christopher Gunadi authored
Add tests to ensure the "Install with Linux" context menu item is shown/hidden when Crostini root access is allowed or disallowed by kUserCrostiniRootAccessAllowedByPolicy policy preference control. The feature flag kCrostiniAdvancedAccessControls is enabled for file manager browser tests always and its associated pref is set "on" by default. FilesApp test JS can send a message to the browser test C++ set the pref on/off as needed with the setCrostiniRootAccessAllowed command adding in this CL. Test: browser_tests --gtest_filter="ContextMenu*Install*DebianFile*" Bug: 983997, 993369 Change-Id: I8a5ee0cb21e43937a0f4a80cd68b7916ee2343c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752825 Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#688489}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d07afa7409e5..ebcc14092998 Created with: gclient setdep -r src-internal@ebcc14092998 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3dda691872934d01459fe1be8e7b9f76e91bd18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761830Reviewed-by:
-
