GitLab

This moves WILL_START_REQUEST and CANCELING to
NavigationRequest::NavigationState. And removes INITIAL and uses
navigation_handle_id instead.

Bug: 916537
Change-Id: Ibe078a9d2947adb5baead6c5d499d79a7fff201f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816507Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711249}

https://webrtc.googlesource.com/src.git/+log/de365955dc6a..159b417c9827

git log de365955dc6a..159b417c9827 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 jakobi@webrtc.org Keep the video send stream alive if the encoder drop frames.
2019-10-31 mbonadei@webrtc.org Add RTC_EXPORT_TEMPLATE_{DECLARE,DEFINE} macros.

Created with:
  gclient setdep -r src/third_party/webrtc@159b417c9827

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I03861a202b35cf07aaf185a7e940a24a78f1562c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893177Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711248}

https://android.googlesource.com/platform/external/perfetto.git/+log/fcfd69546437..b094d526c20b

git log fcfd69546437..b094d526c20b --date=short --no-merges --format='%ad %ae %s'
2019-10-31 treehugger-gerrit@google.com Merge "Increase trace duration of runtime HeapprofdCtsTest."

Created with:
  gclient setdep -r src/third_party/perfetto@b094d526c20b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Idfb00c6216972eeb145e614ad483f1dd833f76e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893175Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711247}

The reason for the crash and the reason for the flaky layout tests are
the same, we didn't check the |layout_object| in that function.

Locally when I run the flaky layout tests, I can get at least 1 crash
every 10 runs. With this CL, I got no crash with 20 runs for each test.

Bug: 1018027, 1018596
Change-Id: Ib9113324d42950f280ef0125b34e453db1427282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883621Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711246}

TBR=caseq@chromium.org

Bug: 1020046
Change-Id: I4cac925b8de98484b030966719f71b72550f5e1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893280
Commit-Queue: Armando Miraglia <armax@chromium.org>
Reviewed-by: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711245}

When default search provider is disabled by the policy, user can still
press the touch bar search button to enter URL in the omnibox. Add a
text to the button for better UX.

Bug: 1011260
Change-Id: I6d35f853336c567f260579a1ee7d54e9b640a8ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891331Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711244}

https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/6791abc9c696..8fbc948c8479

$ git log 6791abc9c..8fbc948c8 --date=short --no-merges --format='%ad %ae %s'
2019-10-29 tirodkar Keyboard tutorial fix for iOS 13 iPads.
2019-10-25 tirodkar Rolling back iOS 13 fix.
2019-10-25 tirodkar Duplicate Matcher for UITextField iOS 13 fix.
2019-10-24 tirodkar Revert back UIKeyboardImpl check
2019-10-24 tirodkar Automartion Setup related Cleanups.
2019-10-24 tirodkar UIWebView deprecation.
2019-10-23 sskhandp Use variable to store sharedInstance and reuse.
2019-10-23 tirodkar Cleanup of semi-colon.
2019-10-22 tirodkar Fix rotation from UIDevice to XCUIDevice.
2019-10-22 tirodkar iOS 13 System Alert fixes.
2019-10-21 tirodkar Fix build
2019-10-21 tirodkar Internal
2019-10-16 tirodkar Fix failure.
2019-10-16 tirodkar Internal Change.
2019-10-15 tirodkar Remove UI_USER_INTERFACE_IDIOM completely.
2019-10-15 tirodkar UI_USER_INTERFACE_IDIOM/UIDevice.
2019-10-10 tirodkar iOS 13 Stepper fix.
2019-10-09 tirodkar Disambiguate name
2019-10-07 tirodkar Fix GREYWaitFunctions compilation failure.
2019-10-07 tirodkar Support description glossary in non-tactile actions
2019-10-06 sskhandp Fix some documentation.
2019-10-04 tirodkar Config Cleanup by rm'ing unused method and expanding check.
2019-09-17 tirodkar CocoaPods Setup Doc link.
2019-09-11 tirodkar Spelling fix.
2019-09-09 tirodkar Expose app to idle api.
2019-09-06 tirodkar Fix.
2019-09-06 tirodkar Remote Executor Refactor
2019-09-05 tirodkar Move automation setup to the test.
2019-09-04 tirodkar Rm unused private method interface.
2019-09-03 tirodkar Search Action Error cleanup.
2019-09-03 tirodkar Delete grey_performSearchActionWithError:
2019-08-30 sskhandp Minor formatting.
2019-08-28 tirodkar Move NestedErrorMake to the AppFramework.
2019-08-27 mobile-devx-github-bot Experiment for temporarily fixing the flakiness on visibility checker.
2019-08-27 tirodkar System Alert Cleanup.
2019-08-26 tirodkar Added App side check to System Alerts.
2019-08-26 tirodkar System Alerts Stability Update
2019-08-21 mobile-devx-github-bot Added helper method to get windows above a given window, including itself.
2019-08-21 tirodkar Remove alpha blurb.
2019-08-20 mobile-devx-github-bot GREYUIWindowProvider making the parameters nonnull and adding light weight generics.
2019-08-20 tirodkar Shake API iOS 13 fix.
2019-08-19 tirodkar Docs update.
2019-08-19 mobile-devx-github-bot Optimizing visibility checker by only drawing portions necessary for screenshots.
2019-08-19 tirodkar Project on Device bitcode fix.
2019-08-19 tirodkar Add shake device to EarlGrey.swift.

Created with:
  roll-dep src/ios/third_party/earl_grey2/src

Change-Id: I09ff68dce97ae7a4271c35d4e85ff6c0690529a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892157Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711243}

blink::WebNativeScrollBehavior is only used in
//third_party/blink/renderer/core. Move it to
//third_party/blink/renderer/core/page/scrolling/scroll_state_callback.h
as blink::NativeScrollBehavior.

Bug: 919392
Change-Id: I8dac59f7b1a778508ee7c1dbed5abdf15f0e371a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886677
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711242}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ac12db7d..287957ea

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie1227c76b1e8ad63d5364c192e3cdba47dafa6ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893291Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711241}

Bug: 839389
Change-Id: Ib07f7d22f6b5d64e7d3e83e16c38ae304f34d7f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887210Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711240}

Bug: 1890430
Change-Id: I9acbc480aab5a8ef520a0c8e5e0761eccf851cc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890411
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711239}

Bug: 268984
Change-Id: I6bfa723fed79ef8d371b33a53595273237f3e3bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891584Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711238}

A WebContentsViewCocoa can have several RenderWidgetHostViewCocoas
added as subviews. Each view, when added as a subview, in the function
WebContentsViewMac::CreateViewForWidget, is put behind all other
subviews (in contrast to the default behavior of -[NSView addSubview],
which puts the new subview in front).

The analogous code in the app shim, in the function
RenderWidgetHostNSViewBridge::SetParentWebContentsNSView, orders the
subviews in the default way, which does not match the behavior of the
browser.

As a result, the NSView ordering can get messed up, resulting in
un-clickable contents. This is vaguely similar to the issue in
crbug.com/859834, which also involve the login page. The login page
hits these sorts of bugs because RenderWidgetHostViewMacs are added
to a single WebContentsViewMac at the login page.

Bug: 1017446
Change-Id: I11425603b258b47e84c6e3df55ec966cf5246191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892577Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711237}

The ScopedTempDir must outlive anything that holds file(s) open within
it; otherwise, it is unable to delete itself.

BUG=546640

Change-Id: I09d5fe93f6ed0620087b9360a6922ff919221e0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891191Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711236}

Ping does not have a particular success URL -
it just redirects back to the "returnurl" on success.

We can detect this if we listen for a POSTed request
to the password change URL, and then for a response that
redirects us to the returnurl, and not back to the
password change URL again.

This involves listening for redirects, not just URLs -
since visiting the returnurl normally would not mean
success.

I have modified all such success detection attempts to
listen for redirects - even when we have a success URL
to listen for eg "?status=0" - it is a bit more certain
to listen for a redirect *from* the password change URL
*to* the success URL, instead of just listening for a
visit to the success URL by itself.

Bug: 930109
Change-Id: Idfd081a603ca402367de774f6253e4af9b84bbdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878489Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711235}

Sync paused:
- Show text "Not signed in" instead of email
- Remove "Manage your Google Account" button

Signin or sync disallowed:
- Remove sync info section

Bug: 1020146
Change-Id: I853d52f3e586a74414b7e368e4cb73f9e617b172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893277Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711234}

The root cause here was that the UIImage returned from the
qr_scanner_app_interface was nil on iOS 12, even though it was non-nil
in iOS 13. I'm not sure why this happened.

In the end, just passing the icon's accessibility label worked and is
probably better for the test, so I switched to that.

I could reproduce the failure, and the tests now pass locally, so
it should be fixed.

TBR=eugenebut@chromium.org

Bug: 1019211
Change-Id: I70e63d5143b8fd7f02ca4b0f62f845196590f282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893253
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711233}

https://chromium.googlesource.com/devtools/devtools-frontend/+log/c7284e19a2..736b04307a

TBR=aerotwist@chromium.org

Change-Id: I2cbca164dd59c9a361b708094dd0261cb98147d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893153Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711232}

DevTools will soon support block coverage again, and this
metric tracks how often it gets used.

Bug: chromium:1004203
Change-Id: I002d48361d5c8b5a130b3d444f89e8b7edae3d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891295Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711231}

ScopedTempDirs must outlive anything that holds file(s) open within
them; otherwise, they are unable to delete their backing directories.

BUG=546640


Change-Id: I9a47962d2f4fae44da1882d25383af6b6b3839a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893274
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711230}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/26f97a5e96ce..8cd154b2c0ca


Created with:
  gclient setdep -r src-internal@8cd154b2c0ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ie3477f364b9708720e6e681a78da87f9110dfc28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893173Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711229}

Request and Response's formData() urlencoded parsing uses "UTF-8 decode
without BOM" which should not strip BOMs.

Bug: 796192
Change-Id: I76491af9a3331268d28375169d2c22dd31b7a4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669298
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711228}

This patch changes |NGOutlineUtils::ShouldPaintOutline| to
support FragmentItem. This fix is needed to compute ink
overflow (WIP crrev.com/c/1771360).

This patch also discovered a bug in |NGInlineCursor| where
|MoveTo(const LayoutObject&)| does not work if the root is
not given, when FragmentItem is enabled. This patch adds a
test for the case and fix this.

This patch fixes ~260 tests and regresses ~80. The ~80 used
to pass accidentally, revealing these failures is a progress.
I will update FlagExpectations separately to avoid conflict
as the change is large.

Bug: 982194
Change-Id: Ia4cf6b15624c0ef73bb90c76a57ef326d19c5d26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890374Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711227}

https://webrtc.googlesource.com/src.git/+log/32913c128aec..de365955dc6a

git log 32913c128aec..de365955dc6a --date=short --no-merges --format='%ad %ae %s'
2019-10-31 yura.yaroshevich@gmail.com Added new Apple devices.

Created with:
  gclient setdep -r src/third_party/webrtc@de365955dc6a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I57a5b66b65895c0e1ecafd8fa1ddc507bf30de0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893171Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711226}

The fixes to the Rec.601 and Rec.709 matrices affect a handful
of layout tests.

See also: https://skia-review.googlesource.com/c/skia/+/251771/

Bug: skia:9543
Change-Id: Ia6ffa7742e945348bc7af68d6c2214fd66a50a96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890956
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#711225}

CSP: Allow port upgrade when the both expression's scheme and port is 'http' and '443' when the scheme is upgradable

<meta http-equiv="Content-Security-Policy" content="script-src 'unsafe-inline' http://example.com:443;">
<script src="https://example.com"></script>

In the above example, the source should be allowed because the URL is matched to the CSP expression because all the rules are satisfied including the port-part matching rule.

See https://www.w3.org/TR/CSP3/ section 6.6.2.6. "Does url match expression in origin with redirect count?" and 6.6.2.9 "port-part matching".

Chromium's current CSP implementation blocks the source because scheme-part matching function returns 'kMatchingUpgrade' but port-part matching function returns 'kMatchingExact' not 'kMatchingUpgrade'.

This fix the port-part matching function to return 'kMatchingUpgrade' where both expression's scheme and port is equal to "http" and "443" when the scheme is upgradable(http->https).

Bug: 892084
TEST: build and run blink_unittests
Change-Id: Ic611b6b1e298a9c4f0457ba4a474475ae0b66250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890451Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711224}

Using wpt-import in Chromium 43ca4361.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
f701be68 "[css-pseudo] Restrict the properties allowed in ::marker"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I6f709f11246eba8e16d1528dcb8dba5b4863ac65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892913Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711223}

TBR=sadrul@chromium.org

Bug: 1020136
Change-Id: I978673a0da380eac20df2dea2fa8361b48341d9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893154Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711222}

This reverts commit 65bc021c.

Reason for revert: This is breaking Mac too (https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/44138)

Original change's description:
> Reland "WebApp: Check pixel at the center of the generated icon."
> 
> This is a reland of 5a0adcbe
> 
> Let's exclude Win platform for now. This is a useful finding which
> requires investigation.
> 
> Original change's description:
> > WebApp: Check pixel at the center of the generated icon.
> >
> > We generate an icon placeholder using a letter with some solid
> > background color.
> >
> > Let the test check if letter_color is actually presented in the icon.
> >
> > This is a follow up test enhancement for the previous CL:
> > https://chromium-review.googlesource.com/c/chromium/src/+/1888234
> >
> > Bug: 1019102
> > Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816
> > Commit-Queue: Alexey Baskakov <loyso@chromium.org>
> > Reviewed-by: Alan Cutter <alancutter@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#711143}
> 
> Bug: 1019102
> Change-Id: I2d01c2a9f5eb94107a4dfc4fea041bdb18871fc3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892651
> Commit-Queue: Alexey Baskakov <loyso@chromium.org>
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711164}

TBR=alancutter@chromium.org,loyso@chromium.org

Change-Id: I99a31ce879eed7ef5e79d6e1a68e119ff2e8f153
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019102
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893275Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711221}

Unittests are added for incognito poolsize, when dynamic quota feature
is enabled or disabled.

Bug: 1017120
Change-Id: Ib0ef8528cc4550c1556645d39312451b0fa3a58b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890055
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711220}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: I70427b411668bc2fff803983f74199c4291e7bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892677Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711219}

Moves default Crostini configuration steps from CrostiniManager to
AnsibleManagementService. Introduces test helper class so that
crostini_manager_unittest.cc and ansible_management_service_unittest
don't duplicate code.

--gtest_filter="Ansible*" && manually via deploying Chrome to DUT

Test: unit_tests --gtest_filter="Crostini*" and unit_tests
Bug: 998124
Change-Id: Ie7b1d185fe556a416abde5cb0e3979d0b4adc010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884851Reviewed-by: Nic Hollingum <hollingum@google.com>
Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org>
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711218}

Using libxml directly in the browser process is strongly discouraged.

Bug: 699306
Change-Id: I82a976bfa578cc89e855079aadcfed95abdffe95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890819Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711217}

During sheriffing I have attempted to determine the reason for failing for two
tests in SafetyTipPageInfoBubbleViewBrowserTest but did not manage. I am
hence disabling for later further investigation.

TBR=estark@chromium.org

Bug: 1020109
Change-Id: I78419a0101cfbcad04f9b4c09553de6ea442c18c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891175Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711216}

This CL moves all but one header from t_p/blink/public/web/modules/peerconnection
to t_p/blink/renderer/modules/peerconnection.

The only remaining one is peer_connection_dependency_factory.h that
is still being included from
content/renderer/renderer_blink_platform_impl.cc

BUG=787254, 919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ia21ecc977363fd03734e63a809cba3187279c633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876488Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711215}

Bug: 1014899
Change-Id: Ib93a32e91b1fb6fb4dff5e3501e8289dc9271a69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868872
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711214}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/185ae4c0..ac12db7d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib8721109747d4d83c1da36e07cb2a78f3684627d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892831Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711213}

https://chromium.googlesource.com/angle/angle.git/+log/6946043676e7..133be10311f8

git log 6946043676e7..133be10311f8 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader e1cda3916cee..fda994c63075 (2 commits)

Created with:
  gclient setdep -r src/third_party/angle@133be10311f8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: chromium:None
Change-Id: If2f9d9c874323c237764e244c70dec87009f1e1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892757Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711212}

With this CL, credentials in the autofill dropdown will have an
additional, right-aligned G logo if they originate from the account
store.
Screenshots are in the linked bug.
The order of suggestions and the signed-out/no-flags experience are
untouched.

Bug: 1018699, 1018700
Change-Id: I84894614665ea18546f9c686f5dad477d418b59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881562
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711211}

This reverts commit 2de3b7e6.

Reason for revert: root cause should be fixed by CL:1868769

Original change's description:
> Disable flaky AssistantOptInFlowTest.WAADisabledByPolicy
> 
> TBR=updowndota
> 
> Bug: 1013824
> Change-Id: Ibbeb425fe2511f0dadaa93bb4dd3cbfde476877b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857130
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705491}

TBR=droger@chromium.org,updowndota@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1013824
Change-Id: I0cd2c2b8119876ff2ed7b1866236783611b65a2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892593Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711210}