- 10 Sep, 2019 40 commits
-
-
Dominik Röttsches authored
Reland after reason for printing test timeouts has been identified in issue 996185. This will prefer performing DWrite API based font fallback on all Windowses, particularly on Windows 8.0 and below, where API based fallback was previously not available and hard-coded lookup tables were used. A content feature is used to flip the switch on this as a last-resort deactivation method, should this lead to unexpected fallback problems. Sheriffs, if there are individual layout tests failing with differences in arrow icons or different fonts used for Chinese, Japanese or Korean text, please disable the test and assign it to me - I will add the new baselines. Bug: 976737 Change-Id: I8546d1cb095af4691f6848209ba521b96d0b3cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778604 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695069}
-
Sergio Villar Senin authored
It's unused so there is no point in passing it. Bug: 994811 Change-Id: Ib7923897beaaf7b302c3d49b23d5da9fe11e32e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792892Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#695068}
-
Jérôme Lebel authored
Updating the header image in the user consent view to support dark mode. https://drive.google.com/open?id=1lZj0o-kIoTZsa5bMnRirKr-YfSUXEo_D Bug: 1002075 Change-Id: I09acf58a8c236a24f5c10c488896f85206083f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790111Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#695067}
-
Maksim Sisov authored
Now, the DWTHPlatform just minimally responsible for setting the window into fullscreen/maximized state or even restoring its state. Most of the functionality has been moved from DWTHX11 to X11Window instead. What is more, AdjustSize has been moved to X11Window and is Linux/X11 specific now. Show/Hide methods have also been reworked and DWTHPlatform determines inactivity now and is responsible for for window state changes. Also, the WindowManagerTogglesFullscreen test has been changed in such a way that it expects that Chromium reacts on fullscreen changes made from a window manager side. This is what we have already been doing in Wayland, btw. Last, SetBoundsInPixels method has been removed from the DWTHX11. Instead, the WTHPlatform::SetBoundsInPixels is used. And, as said previously, AdjustSize for that method is implemented in the X11Window now. Bug: 990756 Change-Id: Ia4a7d4859a4b42bd7de99eb7c4309ac55e34e9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769450 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#695066}
-
Maksim Sisov authored
This CL moved the Get/SetZOrderLevel to DWTHPlatform. This method is useful for both Windows(if it eventually starts to use this path) and Linux. Also, SetAlwaysOnTop and IsAlwaysOnTop have been added to the PlatformWindow interface. However, default implementation is also added to avoid messing much with other platforms, which do not support that on the PlatformWindow level like Ozone/Drm. Instead, ChromeOS sets a property on an aura::Window. Both Windows and X11 support setting the always on top value. In case of Wayland, we'd need to add gtk_shell support and use it whenever Chromium is run on gtk. Thus, I've added NOTIMPLEMENTED to those PlatformWindows, which could potentially support that. Bug: 990756 Change-Id: Id69cca5ac59556384f1a7e01d59ab021370f19a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774454Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#695065}
-
Daniele Castagna authored
viz::BufferQueue currently implements partial swap reading back from the previously swapped buffer contents that are outside the current swapbuffer damage. This introduced a dependency on a GPU API, that we want to get rid of (crbug.com/958670). This technique also assumes it is safe to read back from a buffer that is used from another driver (crbug.com/457511). This CL removes the readback and solves the same problem exposing a rectangle that the compositor needs to redraw to make sure contents damaged during all the swapbuffers before the current one are recomposited. Bug: 958670, 457511 Test: BufferQueueTest.PartialSwapCurrentBufferDamage Change-Id: Icda39c42053c2d1134f739485357009271b80634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761708 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#695064}
-
Ricky Liang authored
Also changes GfxBufferFormatToVideoPixelFormat to return nullopt when the input GFX format is invalid instead of crashing through LOG(FATAL). Bug: 982201, 997581 Change-Id: Id98fe66dbc82dc9d520623296f92107bd1dc8707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792362 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695063}
-
Tao Bai authored
This reverts commit 9c44fedd. Reason for revert: broke https://ci.chromium.org/p/chromium/builders/ci/android-jumbo-rel/13515 Original change's description: > Cleanup Android video targets > > Fixes WebView component build issues. > > Previous CLs introduced a number of new targets including > texture_owner_android and shared_image_video. These were causing build > problems due to duplicate file compilation which led to DCHECKs. > > Moved most of these files into gpu/command_buffer/service:gles2, as > they all depended on this target (so no new transitive deps), and it's > probably a good place for them for now and simplifies dependency > management. > > Bug: 996285 > Change-Id: Ic5a9cced7e67500cfd5fff8809d4ee5e17bbab8b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787165 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: vikas soni <vikassoni@chromium.org> > Auto-Submit: Eric Karl <ericrk@chromium.org> > Commit-Queue: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695006} TBR=kinuko@chromium.org,nasko@chromium.org,liberato@chromium.org,ericrk@chromium.org,vikassoni@chromium.org Change-Id: Ib51ec09046ecfa51543836755b6b830d76fbce94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793931Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#695062}
-
Gyuyoung Kim authored
This CL applies pending_receiver to CreateFaceDetection() in FaceDetectionProvider interface. Bug: 955171 Change-Id: I13702984c7b183eb0f58a994fbd8d00a1ba8db40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792032 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695061}
-
Chih-Yu Huang authored
Currently we always set a "just-enough" frame number. In usual usage there is no stale frames. This CL remove the frame purging logic to simplify the code and reduce the periodically cleanup time. BUG=none TEST=media_unittests --gtest_filter=PlatformVideoFramePoolTest TEST=Run video_decode_accelerator_tests on Kevin Change-Id: I1542c97ed2a492776bc6ec7a2e1d48fdc12467a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786706 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#695060}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b388a9a81e11..c7b6bab50170 Created with: gclient setdep -r src-internal@c7b6bab50170 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I829340c3cc43e3797052f67a107a57ddecfdcf33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794031Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695059}
-
Peter Kasting authored
Bug: 23697 Change-Id: Id6eeb2b255a653668d57df0aa44c454784786ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792004 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#695058}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I0422306175fb40eefa22b58028266414d5485bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792953 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695057}
-
Jan Wilken Dörrie authored
This change introduces several overloads for base::Value::Append, supporting boolean, integer, double and string arguments. This change is in preparation for no longer returning a mutable std::vector reference from GetList(), making the previous advice to use emplace_back no longer relevant. Bug: 646113 Change-Id: I10607d14de336ef026a73689e2cae144cc5fec92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793083Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#695056}
-
Takashi Toyoshima authored
This patch updates the webRequest API documents on a plan for behavior changes caused by OOR-CORS. There could other changes, but will be handled in a separate CL. Bug: 1000554 Change-Id: I631dc3bbf93e041810f2f2016067376ed7b1e352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784258Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695055}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8cae1e95a23b..008a1db55909 git log 8cae1e95a23b..008a1db55909 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a0cef9f5..340a17ae (385 commits) Created with: gclient setdep -r src/third_party/skia@008a1db55909 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:None Change-Id: I7f356cdb995a06ec2fabded6e25e6b401d185349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793885Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695054}
-
Kent Tamura authored
An existing forward declaration is enough. Bug: 242216 Change-Id: I1e2c60acf3aac2c90666d916dd92ad187d909900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794326Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#695053}
-
Miyoung Shin authored
This CL converts BluetoothSystem{Ptr, Request} in ash and services to the new Mojo type, and uses pending_receiver<BluetoothSystem> in bluetooth_system.mojom. Bug: 955171 Change-Id: I764daf49604184341812fbb3b3249590b29b7d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787663Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#695052}
-
Charles Zhao authored
(1) If ScoreTabs is called with type_ == KPairwiseScorer, then more sophisticated ScoreTabsWithPairwiseScorer is used for scoring. (2) The ScoreTabsWithPairwiseScorer puts all tabs without TabFeatures first, and then sort the result with MRU. After that, best candidate for each position j is picked one by one (3) In unit tests, we directly call ScoreTabsWithPairwiseScorer with type_ = kFrecencyScorer, so that the tests can be independent with the ML model. (This won't happen from public interface in real applications.) Bug: 999908 Change-Id: I85302cda11fc0fc754f5402fdacd1e3796a41b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788774Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Auto-Submit: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#695051}
-
Julie Jeongeun Kim authored
It converts RenderWidgetHostNSViewAssociatedRequest and RenderWidgetHostNSViewAssociatedPtr to new Mojo types. These are replaced with mojo::PendingAssociatedReceiver, mojo::AssociatedReceiver and mojo::AssociatedRemote. Bug: 955171 Change-Id: I1658a50da87f9e494a57bbb26e548373fa562268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792463 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#695050}
-
James Hawkins authored
This is modeled after the same functionality in the internet detail page implementation. R=stevenjb@chromium.org Bug: 999474 Test: none Change-Id: If5dcac633d5881aa04878b0e57223a437c9af4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793808 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695049}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46c88567d52f..58c5b07b47cf git log 46c88567d52f..58c5b07b47cf --date=short --no-merges --format='%ad %ae %s' 2019-09-10 timvp@google.com Replace Issue 3221 with 2672 in deqp_gles3_test_expectations.txt Created with: gclient setdep -r src/third_party/angle@58c5b07b47cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: Ie1bbf0ad193f92949ba767647e59f6383dfd69f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695048}
-
Eric Willigers authored
Values in the following grammar are tested: [ [ <'font-style'> || <font-variant-css2> || <'font-weight'> || <font-stretch-css3> ]? <'font-size'> [ / <'line-height'> ]? <'font-family'> ] | caption | icon | menu | message-box | small-caption | status-bar https://drafts.csswg.org/css-fonts-4/#font-prop Change-Id: I5180df5bff0e477e08a40197f8886fc8d8cc66c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789217 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#695047}
-
siyua authored
This CL adds the blue round circle highlight animation around the avatar button. It reuses the ink drop hover animation but with a different color. Whenever the animation is visible, hide the avatar sync paused/error state, even if there is no autofill icon visible in the status chip. Controlled by experiment flag kAutofillCreditCardUploadFeedback: No event will be sent to avatar icon if flag is disabled. The animation will be shown when any credit card is saved. Animation for password save will be added later. Bug: 964127 Change-Id: Icc386241e244a6bf9f3db271928ca19029348f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784138 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#695046}
-
Scott Violet authored
This way we get build bot coverage. BUG=none TEST=none Change-Id: Ibce3b2be48420e70a839545a950d105d956477fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790743Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#695045}
-
Dirk Pranke authored
ad9e442d Rename typefdefs for C++17 dba3084e Define StringPiece in terms of std::string_view 102cdd4b Define string16 in terms of std::u16string. b3fefa62 Compile with C++17. 2a6c4e12 [windows] Update Windows SDK to 2019-09-06 2a5b5ca0 Fix typo in linker section of docs. 2f527608 [cleanup] Remove stale documentation from get_target_outputs. fc2f07a8 Add reference to the mailing list to the README. ad9054d1 gen.py: Allow linking libstdc++ dynamically 6f3dad1a Don't use a nested scope for BUILDCONFIG. d9bbb45c Teach gn to handle systems with > 64 processors bac5bd0b Do not use the root scope for BUILDCONFIG.gn. 8dc294d0 Write Rust deps even if there are only non-Rust ones 21242330 Make "gn format" honor the global -q switch 570aaed1 Process transitive dependecies for externs 4dc0ce4d Update quick start guide to reference tutorial files f0a6900f Include Rust proc-macros as externs 1556546b [filesystem_utils] Fix a bug in MakeAbsolutePathRelativeIfPossible dca877f3 Support output_dir for Rust 0a73c484 Fix crash when sources is set to a non-list value 0bc16a82 [args] Ensure gn tracelog is processed when non-fatal error happens. Change-Id: I4ef0406f0deb636eb3213a480f73dff06059d971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793533Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#695044}
-
Steve Kobes authored
Bug: 1000716 Change-Id: Iee211fd0cdb5466fcdaf308a48031f039aaf8258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792581Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#695043}
-
Zhenyao Mo authored
BUG=1002269 TEST=bot R=kbr@chromium.org,jonahr@google.com Change-Id: I268882f668534903fe781ea482975ea37fbbd601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793786 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#695042}
-
Hiroki Sato authored
Previously, Android's AccessibilityEvent.TYPE_VIEW_SELECTED is handled as an event of changing value in ProgressBar or Slider in ARC++. However, this event is usually used when selecting an item in AdapterView (like ListView or GridView). This CL modifies to handle both patterns of the event. app that ListView items can be selected and read by ChromeVox Bug: b:130187244 Test: unit_tests --gtest_filter="ArcAccessibilityHelperBridgeTest.*" Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manually test with ag/9191465 using PlayStore and TalkBack test Change-Id: If3af1bdc28490d00399fa89bd18258ff89731d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746326 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#695041}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/43652ca1735a..fa2746c4a1fd $ git log 43652ca17..fa2746c4a --date=short --no-merges --format='%ad %ae %s' 2019-09-09 fayang gfe-relnote: False deprecate gfe2_reloadable_flag_quic_fix_adaptive_time_loss. 2019-09-09 fayang gfe-relnote: False deprecate gfe2_reloadable_flag_quic_eighth_rtt_loss_detection. 2019-09-09 wub gfe-relnote: (n/a) Fix a use-of-uninitialized-value in QuicFramerTest.GetRetransmittableControlFrameSize. Test only. 2019-09-06 wub gfe-relnote: (n/a) Update QuicIetfFramerTest.(Application|Connection)Close to use the new QuicConnectionCloseFrame constructor. Test only, not protected. 2019-09-06 dschinazi Deprecate quic_drop_invalid_small_initial_connection_id 2019-09-06 vasilvv Support the use of MESSAGE/DATAGRAM frames in QBONE. 2019-09-06 vasilvv Switch QuicMakeUnique to std::make_unique, part 1: //third_party/quic 2019-09-06 renjietang Remove QuicSession::RegisterStaticStream() and merge it into QuicSession::ActivateStream(). 2019-09-06 fkastenholz Add version-aware QuicConnectionCloseFrame constructor 2019-09-06 renjietang Use QuicSession::transport_version() instead of QuicConnection::transport_version() to make code cleaner. 2019-09-06 fayang gfe-relnote: n/a (TODO added) 2019-09-06 fkastenholz Change Application and Transport ConnectionClose codes to uint64_t 2019-09-06 wub gfe-relnote: (n/a) Only increment flag count for quic_simple_inflight_time when the flag is true. Flag count only. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ia3ce56d19b01f84adb574f29c1c5c8b6aef0c176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793246 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#695040}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5aec10b3bcd4..b388a9a81e11 Created with: gclient setdep -r src-internal@b388a9a81e11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1e93ba7a641faf94a991ee5099b1f6e910a54ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794029Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695039}
-
Zhenyao Mo authored
This reverts commit 15cbe81d. Reason for revert: crbug.com/1001364 Original change's description: > Add a FrameSequenceTracker for video. > > This feature allows tracking frame throughput during video playbacks. > This frame sequence tracker is a special case in that its tracking > process occurs in video_frame_submitter, unlike most other frame > sequence trackers that operate mainly in layer_tree_host_impl. > > Sample tracing report: > > https: //drive.google.com/file/d/1B9AZCsbLmOyIzIFxFGzDOgINISx7p3lk/view?usp=sharing > Bug: chromium:986300 > Change-Id: I9a41861e59bbe16d652b49de6b802ccc89833906 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755978 > Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693808} TBR=sadrul@chromium.org,liberato@chromium.org,schenney@chromium.org,mjzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. NOTRY=true Bug: chromium:986300 Change-Id: Idbae19675b1ded245ba93ea839c722a34e4a6d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794264 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#695038}
-
Jason Lin authored
More specifically, this CL: * Adds a mojom file to connect the web frontend part and c++ backend. * Adds c++ classes implementing web ui controller and some mojom interfaces. * Adds html and js files implementing the skeleton of the web page, including BrowserProxy, which connects the Renderer JS to the backend C++. * Adds code to display the web page at chrome://crostini-installer if feature CrostiniWebUIInstaller is enabled * Adds skeleton for browser test. Bug: 929571 Change-Id: Ie9b0931862ec5e40bc21ea7683ffc873e4034f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778884Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#695037}
-
Yoichi Osato authored
Added why the value is not a power of 2. Change-Id: I987c50197d8535b2020e9576bdefe3c3ba71c1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792509 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#695036}
-
John Chen authored
The --force-fieldtrials switch, added by ChromeDriver to work around https://crbug.com/996865, is no longer necessary. Removing it by default. Bug: 996865 Change-Id: I580b42397961e348626b6fc0d5ee8af9d4d21cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788487 Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
Rohan Pavone <rohpavone@chromium.org> Cr-Commit-Position: refs/heads/master@{#695035}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/487f9a17e426..c77df78931bc git log 487f9a17e426..c77df78931bc --date=short --no-merges --format='%ad %ae %s' 2019-09-09 qingsi@webrtc.org Revert "Improve performance of RtpPacketHistory" Created with: gclient setdep -r src/third_party/webrtc@c77df78931bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ibfa14c76f87d99794a35728ab9f10f8a246a773d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794145Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695034}
-
Hitoshi Yoshida authored
IDL Compiler has been ignoring the validity of extended attributes on dictionaries, callback functions, and their membmers. This CL makes to do it. Bug: 999690 Change-Id: Idcb88c6a346989e553a3bbe23e1273e00f8a04da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781902 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#695033}
-
Hiroki Nakagawa authored
This CL renames ServiceWorkerSubresourceLoaderUpdater interface to SubresourceLoaderUpdater because the interface is now also used for dedicated workers. Along with that, this moves the interface from service_worker/ to worker/. Bug: 945101 Change-Id: Ic56d5b372452981b6649b119f3406e168f7f4711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786365 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#695032}
-
Miyoung Shin authored
This CL converts FakeBluetoothChooserRequest, FakeBluetoothChooserFactoryRequest and FakeBluetoothChooserClient{AssociatedPtr, AssociatedPtrInfo} in content to the new Mojo type, and uses pending_receiver<FakeBluetoothChooser> and pending_associated_remote<FakeBluetoothChooserClient> in fake_bluetooth_chooser.mojom Bug: 955171 Change-Id: I73cce0dec73868dbf3b6a0f72d3cab0acd73eade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788964 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695031}
-
Tsuyoshi Horo authored
This CL do the following refactoring: - Move PrimaryURLRedirectLoader to anonymous namespace. - Remove unnecessary methods, arguments, casting. And this CL sets encoded_data_length = 0 for redirect response. This is because we have "DCHECK_GE(redirect_response.EncodedDataLength(), 0)" check in resource_timing_info.cc. Bug: 966753 Change-Id: I35e877c0e928e596596d3743175d65241ca7bed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792413Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#695030}
-