GitLab

This change updated the 'Upgrade' logic in the CRD host WXS file
so that it no longer blocks downgrades.  I've run through several
upgrade and downgrade scenarios and it looks like everything gets
cleaned up and re-registered correctly with this change.

I looked into a few options to constrain the version window where
downgrades are allowed.  I think the most promising would be to
add a wxs param which takes a 'max_downgrade' var based on the
'chrome_version_full' + max version skew and use that for
blocking downgrades.  I'm not convinced this is necessary though
since we don't have any version checking for our MacOS package
and we haven't had any issues related to downgrading when using
Keystone.

Bug: 1148967
Change-Id: I4b36541ff901eb10f4c26c7652654f43f77762c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538202
Commit-Queue: Joe Downing <joedow@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827456}

Ideally this conversion should happen in the XR service and off the JS
thread, but that's an optimization that can happen later. The actual
conversion may need some tweaking in the future, for things like better
tone mapping, but for the time being this gives a usable result.

Bug: 1147569
Change-Id: I0407eee6e4c8337bd376bd43ca0f32987a471055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535915
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827455}

Parse the existing icon_index of the
shortcut icon to preserve when the shortcut
is being reset.

Bug: 1116017, 1148962
Change-Id: Ia6528161bf4302e7abb5c5223c238ddb31856791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536033Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827454}

We were previously using file storage until LevelDB storage was
available. LevelDB storage requires a profile so some tweaks were
made to PersistedTabDataConfiguration. One of which is the factory
pattern was used to ensure we acquire LevelDBPersistedTabDataStorage
based on the current profile and that we only have one
LevelDBPersistedTabDataStorage instance per profile.

Bug: 1129626
Change-Id: Ia1f14c9c2b6f2da02bac27ccd255152e45a4218c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533843Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827453}

https://webrtc.googlesource.com/src.git/+log/c4ad6062fd17..f42a94a7f50d

2020-11-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6e17f939..5cee6c65 (827170:827322)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I8aa5d6c4aabcf8e85d7b81cb4926f71ccff42978
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537056Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827452}

It doesn't need to be done for each profile in the multi-profile
session restore case, since --app-id should always have an associated
--profile-directory, since apps are profile-specific.

Bug: 1132578
Change-Id: I1a898b2b911c8962dd6400fc821d4b05cf85fb08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520220
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827451}

Also removing static_cast accidentally left in previously.

Bug: 1128169
Change-Id: Ica92357953149aa19bdb2ffc300f81363662fe94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537923
Auto-Submit: Jonathan Freed <freedjm@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827450}

Spec isn't clear on this, but when we are doing short term ref pic sets
that are relative to existing ones, these can keep chaining and then
grow their size without bound. Seems reasonable to constrain this value
for the delta based ones just as for the fully declared ones.

Also fixes range validation for cpb_cnt.

Also fixes zero valued NumPicTotalCurr.

Also fixes overflow in SPS parsing.

BUG=b:153111783,chromium:1148504,chromium:1148698,chromium:1148863,
chromium:1148910
TEST=Fuzzer no longer crashes

Change-Id: I430f1fe2d4e4e5affe6caea80be6d01b84896b14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536851Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#827449}

This reverts commit 5d6ecbfb.

Reason for revert: expected to be causing ui.ShelfLaunchedApps flakes
"Unexpected apps in the shelf. Expected only Chrome"
from:
https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/47952
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863730536929393584/+/steps/chrome_all_tast_tests/0/logs/Deterministic_failure:_ui.ShelfLaunchedApps__status_FAILURE_/0


Original change's description:
> CrOS: Add Files app to default shelf pins in second position
>
> This adds the Files app to the spot after the Chrome icon, for new users
> only. There's also some variations of the default pin layout controlled
> by a Finch experiment, I've moved the Files app up in those layouts for
> consistency.
>
> This change was requested for M88 and will be merged back.
>
> Bug: 1148519
> Change-Id: Iae54561fec599b813ba97e82a5678fa834a02db2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537214
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Auto-Submit: Tim Sergeant <tsergeant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827272}

TBR=xiyuan@chromium.org,tsergeant@chromium.org,dominickn@chromium.org

Change-Id: Ic86ed4ca44b70a2357395be9a44f5ace6997bd14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1148519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538145Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827448}

print-preview-destination-dialog is being forked for Chrome OS, but
the invitations logic is largely the same across platforms. Moreover,
this logic is unlikely to diverge going forward, given that cloud
print is deprecated. Split out invitation promo UI and invitations
logic into a new invitation-promo element.

Bug: 1148906
Change-Id: I51f4013867808748ffa9f39c9c8613019bc9fe5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536041
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827447}

Bug: 1148885
Change-Id: Ic517dddf9d4521cbe5b7338b47d74f84e251ee3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537935Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827446}

Some client resources (video, etc) will need to wait on a ResourceFence
before returning them to client. That fence is released when all GPU
work for the root render pass are finished on GPU. However, on macOS,
there isn't a root render pass for every frames, and all related client
resources will never be released. To fix the problem, we have to release
the fence for each GPU tasks (drawing non root render passes, drawing
render pass overlays, etc).

Bug: 1143042
Change-Id: I335e4a7c4a36557315cede7edd834b028c7b015d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537112Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827445}

- supply CaptureParams as an argument of IsCaptureAllowed().

Bug: 1145606
Test: Manual test
Change-Id: If73b39eff906ce1b44253522aedcde69bab444fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530290Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827444}

This CL further improves the algorithm of color selection to:
 1) Disallow colors with very low saturation (currently the first line
    in the color picker).
 2) Prefer colors with lightness similar to the lightness of the current
    profile (this disallows the very dark colors for the very light
    colors and vice versa).

Bug: 1108295
Change-Id: I3adcc347b84285d5d2659f1972f075e992e0bebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532565
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827443}

Enables intervention by default in the Chrome binary, and removes
it's associated testing config which is no longer needed.

Bug: 959849
Change-Id: I5963aebd84894a94d37af053a99b8050394f3426
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535550Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827442}

When a cancel completes, run the cancel callback instead of the
completion callback. This prevents clients from having to wait for and
handle two separate callbacks when canceling a scan.

Bug: 1059779
Change-Id: I80083a1aed002abbdbf117ddad527c531e32bfba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537052Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827441}

1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.
2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered.
3. Set `hide_scrollbars` to avoid artificial scrollbars.
4. Set `record_whole_document` to force the whole page to be rendered.
5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight".

Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37

Screenshots:

- Before: https://i.imgur.com/yt6WZRx.png
- Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars.
- Patchset #3:
  * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view.
  * https://imgur.com/MXpgHOl
  * https://imgur.com/haxemcr - not aligned with the node.
  * https://imgur.com/RbdlYVT
- Patchset #18:
  * https://imgur.com/EWUmn0O
  * https://imgur.com/DUrQ1yF
  * https://imgur.com/cT5oBSi - perfectly aligned.
  * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended).

Bug: 1003629
Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876
Commit-Queue: Maksim Sadym <sadym@chromium.org>
Auto-Submit: Maksim Sadym <sadym@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827440}

This CL queries the driver for the encoding quality range and, if
available and the device is considered "low power" (celeron, pentium
and Core -Y devices), sets it to its maximum value, for highest speed
and lowest power consumption, albeit at lower encoding quality. The
quality difference should not be noticeable for video conference
scenarios.

I followed the code in both of Intel's VA backends.
For the legacy i965:
- VP8 supports values 1-2 [1]. (ENCODER_LOW_QUALITY is 2 so at least
 this CL can supersede the patch in [2] which is what it was set off to
 do).
- AVC1 and VP9 support 1-7 [3,4], ENCODER_QUALITY_RANGE_(AVC,VP9) == 7
 see [5], but this only on Gen9 [6a, 6b] (VP9 encoding is only
 available in Gen9+ FTR).

For the modern intel-media-driver iHD, values are configured with
names, 1 being TARGETUSAGE_BEST_QUALITY ([7] and its following lines).
By default, the TARGETUSAGE_RT_SPEED == 4 is used, and 7 would be
TARGETUSAGE_BEST_SPEED.

Improvements depend on the input content. I measured kohaku with
EncodeAccelPerf.h264_1080p_i420 and when ToT is ~204fps, 4.75W, with
this CL I see ~220 fps, 4.42W.

[1] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1151
[2] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/chromiumos-overlay/x11-libs/libva-intel-driver/files/vp8-encoder-Workaround-to-force-perforamce-mode-enco.patch;l=36
[3] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1142
[4] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1149
[5] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_drv_video.h#L76
[6a] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1599
[6b] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1653
[7] https://github.com/intel/media-driver/blob/105f0341a21324ae3bc458cfa6c25c7df0517f3a/media_driver/agnostic/common/codec/shared/codec_def_common.h#L333

Bug: b:141147405
Change-Id: I7e5c54f1e5a7ac7a51c5503f37168db16f9e99f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344526
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827439}

Max suggested I join components/payments/OWNERS :)

Also update the component since UI>Browser>Payments was removed in favor
of Blink>Payments.

Change-Id: I604bb739dab79bc13652993299bca7e839fd0421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536900Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827438}

This reverts commit 9912841b.

Reason for revert: The linker has started segfaulting consistently: https://ci.chromium.org/p/chromium/builders/ci/Mac%20Builder/124684

Original change's description:
> mac: Use response files instead of -filelist, but just a little bit.
>
> This is a partial reland of
> https://chromium-review.googlesource.com/c/chromium/src/+/2530350
>
> For reasons not yet understood, that change sometimes makes the
> linker segfault -- but only hours after it goes in. But once it
> happens, it's sticky.
>
> So reland a smaller version of this change to see if it still happens.
> - Use `-Wl,@rsp` instead of `@rsp` so that the clang driver doesn't
>   read the response file just to write it out again -- instead we
>   pass the response file to the linker directly for now.
> - Only put {{inputs}} in the response file for now, not yet
>   {{frameworks}} {{swiftmodules}} {{solibs}} {{libs}}
>
> Bug: 1147968
> Change-Id: If5c03c881e2469fa2a3c1d3297975ef4c3d19587
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538011
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Brett Wilson <brettw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827424}

TBR=thakis@chromium.org,brettw@chromium.org,mark@chromium.org

Change-Id: Ibdb3f64f745e89d63ab5df2dec2c6bda55bdf7d7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1147968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538177Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827437}

Roll Chrome Win64 PGO profile from chrome-win64-master-1605255855-dc6a80021d99bde94e7af4afa11767b88ac6fee3.profdata to chrome-win64-master-1605268075-daeeb1bc6080c8b4d9f48b3dab7bc22bf5a02dcb.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie1a82ebeb7d6021f9550c82363074eeab4f13459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538091Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827436}

- Added WheelEventRegions runtime feature flag.
- Changed mouse coordinates in wheel-event-target.html test to
  accommodate for rounding per [1].
- Changed wheel event handler region in layer-scroll-rects-get.js
  to enforce not empty wheel handler region.

[1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/graphics/paint/paint_controller.cc;l=49;bpv=1;bpt=1?q=RecordHitTestData&ss=chromium%2Fchromium%2Fsrc

Bug: 1136588
Change-Id: I437c87d7c8a53f107f676b647d737ce1de7827f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521354Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Sam Fortiner <samfort@microsoft.com>
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#827435}

BUG=1146734
TEST=Ran locally.

Change-Id: Iba08d7f3c205c023b3b93b15e8e49f50ce3d5424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536577Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827434}

Updated based on Legal's recommendation.

Bug: 1138603
Change-Id: I7383f2c95d5bee73ef899cab08aa9eca136a27cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535660
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827433}

This change disables supports_multiple_windows by default to
Webview controller, in order to open new window navigations
in the current view.

Bug: b/170218696
Test: Sample website on Chromecast navigates on the current view.
Change-Id: I44cb7d7e9c8ffa42789f7019779fc9c87935ba92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533679Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Jiaqi Han <jiaqih@google.com>
Cr-Commit-Position: refs/heads/master@{#827432}

The parsing patterns currently in autofill_regex_constants.{h,cc) are
about to be migrated to regex_patterns.json. This JSON file is loaded
asynchronously by the component updater.

However, tests need to load the JSON synchronously to avoid race
conditions. This CL compiles the JSON file to C++, so that the default
patterns are available from the start.

With this CL, the JSON is not loaded at all during runtime. Enabling
the component updater is left for a follow-up CL.

The growth of the binary size will be compensated when
autofill_regex_constants.{cc,h} are removed.

Bug: 1147608
Change-Id: Ibbdc9161ae253a80917cc7dd6154342e8fd7ed47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532562
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: Matthias Körber <koerber@google.com>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827431}

Bug: b/173015334
Test: run Tongol on device and check available processors.
Change-Id: I4acfe6b02c364a6b2e57d91d76c7bb58f98f47c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533554Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Mingyu Kang <kenkangxgwe@google.com>
Cr-Commit-Position: refs/heads/master@{#827430}

Bug: 1148445
Change-Id: I01c5e75559f9d00a264d3330edb81811ab149ec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533549Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Vincent Boisselle <vincb@google.com>
Cr-Commit-Position: refs/heads/master@{#827429}

Configure them to:
1. run on any changes to //chrome/updater.
2. list under `Choose Tryjobs` for luci.chromium.try

Bug: 1120836
Change-Id: I519c632b6b99fa41f256b2f6a70d8e300f4941a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536032
Commit-Queue: Anjali Doneria <adoneria@google.com>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827428}

This CL adds a check to prevent binding the speech recognition context
if the mojo pipe to the speech recognition service is not bound. This
can occur if the Speech On-Device API (SODA) files were not found.

Bug: 1147226
Change-Id: I86fe0a4b9fe80de0449e196b451423cbcf2b8a60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538054Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#827427}

Collapse common implementation of HandleKeyEvent into one. There is a
path that checks for embeds that support keyboard focus and a tab
character, ensure this code is kept. fast/plugins/keypress-event.html
tests that condition.

BUG=1097816

Change-Id: Ic9c88a6c0a768f26980bb97645f853f651caf9ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536151
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827426}

Bug: 1148926
Change-Id: I7b1c44967147d3674479544871973f9b39032bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538163
Commit-Queue: Chong Gu <chonggu@google.com>
Auto-Submit: Chong Gu <chonggu@google.com>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827425}

This is a partial reland of
https://chromium-review.googlesource.com/c/chromium/src/+/2530350

For reasons not yet understood, that change sometimes makes the
linker segfault -- but only hours after it goes in. But once it
happens, it's sticky.

So reland a smaller version of this change to see if it still happens.
- Use `-Wl,@rsp` instead of `@rsp` so that the clang driver doesn't
  read the response file just to write it out again -- instead we
  pass the response file to the linker directly for now.
- Only put {{inputs}} in the response file for now, not yet
  {{frameworks}} {{swiftmodules}} {{solibs}} {{libs}}

Bug: 1147968
Change-Id: If5c03c881e2469fa2a3c1d3297975ef4c3d19587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538011
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827424}

NightModeStateProvider is owned by ChromeBaseAppCompat so most usages
cast a Context or Activity in order to retrieve the object.
ColorUtils#inNightMode, in contrast, just needs a Context.

Replaces usage of NightModeStateProvider with ColorUtils and makes
ChromeBaseAppCompatActvity#getNightModeProvider protected. Also
removes references to ChromeBaseAppCompatActvity from night_mode
package.

Bug: 1139525, 1148614
Change-Id: I9768c3c4a686e4df3e0b71d29ba631e0c2cbb458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537230Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827423}

For both IsInRemoveFirstRunPromptGroup() and IsInFirstRunModalGroup()
experiment groups the native location prompt should not show after First
Run finishes. The prompt will show after the user taps the action button
in the modal.

Bug: 1146456
Change-Id: I65dad9dcd3e46e45d783df79e1f3fe9aa5d2ea52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537922
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827422}

Before the CL, only the non-minimal UIs invokes the "onCompleteCalled"
"onCompleteReplied" callbacks on the test observers. Since the callback
names indicate that they are agnostic to minimal UI, they should be
applied to all UIs.

After the CL, the minimal UIs also invokes these callbacks.

This CL also cleans up the PaymentUiService#onPaymentRequestComplete
javadoc.

Bug: 1131059

Change-Id: Ic0b1a381083f9ad024c4bd84eb85e8500c034617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535872
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827421}

The IDL file is split in three parts: public, internal, and legacy
definitions.

This is a fairly straightforward change, which consists of suffixing
the path to the typelib in the executable file with a //<index> where
the index matches one of the there source IDLs above.

Further work is needed to properly generate the GUIDs depending on
the which IDL the GUIDs belong to. Some of the GUIDs must depend on
branding, and some of the GUIDs must depend on branding and version.


Bug: 1140562
Change-Id: I6030977d3961ff24bbc8bc33392415d59884feec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527822Reviewed-by: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827420}

Bug: 1007807
Change-Id: I979b461f6d1ef5b6a9f01a9b272683d01112cc96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533732
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827419}

The session rules are not indexed and evaluated yet. This will be done
in a follow-up.

Skipping presubmit since this seems to be hitting crbug.com/956368.

BUG=1043200
Doc=https://docs.google.com/document/d/1_I6jHA_jCa0UbR2QVUZsBApt_GqEuMz7qnpQdt1LEv0/edit?usp=sharing (Internal only)

No-Presubmit: True
Change-Id: Id15783af14ff1f4a88900680d29d71d07794b4e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495511
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827418}

This is a reland of dde3defc

The fix here is too disable MediaKeysListenerManagerImplTest on CrOS
since MediaKeysListenerManager is disabled too.

Original change's description:
> Reland "[Media Session] Fix for Lacros"
>
> This is a reland of ddb531f7
>
> There is a fix in media_session_service.cc to allow the tests to pass
> when ash-chrome is not running.
>
> Original change's description:
> > [Media Session] Fix for Lacros
> >
> > At the moment in Lacros there are two instances of the
> > Media Session Service (MSS) one hosted in ash-chrome and
> > the other in lacros-chrome. This means that sessions in
> > either browser process cannot see sessions from the other.
> >
> > This changes it so when a client asks for lacros-chrome
> > MSS instead of providing a locally hosted MSS it binds
> > the MSS in ash-chrome.
> >
> > BUG=1140215
> >
> > Change-Id: Ic155a6cd928f0735095f849f309f9075dbb1d36f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485850
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Reviewed-by: Tommy Steimel <steimel@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Erik Chen <erikchen@chromium.org>
> > Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#825016}
>
> Bug: 1140215
> Change-Id: I64834d9be778998b42bf3447444a6955265215ef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525851
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825439}

Bug: 1140215
Change-Id: I43d916d2d5726a02baf5fc9307e86a36e99b67fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529730Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827417}