GitLab

BUG=413679

Review URL: https://codereview.chromium.org/546213005

Cr-Commit-Position: refs/heads/master@{#297139}

loop should break after match as values are getting reset to empty
rect after match.Changes done so that loop breaks after match.

BUG=417621

Review URL: https://codereview.chromium.org/603903002

Cr-Commit-Position: refs/heads/master@{#297138}

* When PLAY request for casted video is skipped, this.playInProgress_ was not cleared and this inconsistent state prevented the video from being played. I cleared the flag in this case.
* When PAUSE reqeust is in progress, incoming PLAY request should not be skipped. So I added a condition to skip the PLAY request.

BUG=417520,417538
TEST=manually tested the steps described in both bugs.

Review URL: https://codereview.chromium.org/603413003

Cr-Commit-Position: refs/heads/master@{#297137}

Previously we were using the plugin context when converting objects during calls
into the plugin from JS. As decided previously in https://codereview.chromium.org/555583003/
we should always use the caller's context in these circumstances.

This CL also separates the checks in PepperPluginInstanceImpl::GetContext to
help diagnose crbug.com/416311.

BUG=416311

Review URL: https://codereview.chromium.org/588083002

Cr-Commit-Position: refs/heads/master@{#297136}

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/598393002

Cr-Commit-Position: refs/heads/master@{#297135}

BUG=None

Review URL: https://codereview.chromium.org/609153002

Cr-Commit-Position: refs/heads/master@{#297134}

BUG=None

Review URL: https://codereview.chromium.org/612693002

Cr-Commit-Position: refs/heads/master@{#297133}

* s/NULL/nullptr/g
* Fix lint errors

BUG=None

Review URL: https://codereview.chromium.org/610223002

Cr-Commit-Position: refs/heads/master@{#297132}

register() resolves to a ServiceWorkerRegistration, so we no longer need
to pass a ServiceWorkerVersion around.

This also cleans up a couple TODOs in RegisterJob:
- In ContinueWithRegistrationForSameScriptUrl, the TODO made sense when
register resolved to a version not a registration.
Now, the current behavior seems OK.
- In UpdateAndContinue, the TODO was misleading. We don't have to handle
an existing installing worker within RegisterJob since each job either
succeeds with a waiting/active worker or fails and cleans up the
installing worker.

BUG=406240

Review URL: https://codereview.chromium.org/605163002

Cr-Commit-Position: refs/heads/master@{#297131}

This prepares for landing of
http://crrev.com/530663002

which now requires a three-sided change due to changes in how Blink accesses
private script resources.

Part 1: http://crrev.com/583753003

BUG=408887
TEST=n/a; no code changes

Review URL: https://codereview.chromium.org/588473003

Cr-Commit-Position: refs/heads/master@{#297130}

Implements several new checks in the plugin, gated behind a flag:
- Only one of {virtual,override,final} should be ever used.
- Destructors must also be annotated correctly.
- A virtual final method that doesn't override anything should be
  devirtualized.

The test harness for the Chrome plugin has also been updated to stop
it from littering the source tree with object files, and to make the
golden files easier to update.

BUG=417463

Review URL: https://codereview.chromium.org/597863002

Cr-Commit-Position: refs/heads/master@{#297129}

Brett prefers we go with foo_unittests, it makes Windows users life
easier. And others easier, so they don't need to know/remember the other
possibility: /path/to:unittests

BUG=None
TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug aura_unittests
ui_unittests
R=brettw@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/601753003

Cr-Commit-Position: refs/heads/master@{#297128}

Revert of Fixed flakiness in PolicyTest.FileURLBlacklist. (patchset #5 id:80001 of https://codereview.chromium.org/551323003/)

Reason for revert:
It's causing lots of flakiness on trybots, now that you added logging look at the past flakiness for more info:

http://chromium-try-flakes.appspot.com/search?q=PolicyTest.FileURLBlacklist

Original issue's description:
> Re-enabled PolicyTest.FileURLBlacklist.
>
> This test flakes on the Mac. This CL adds additional logging to help diagnose the source of flakiness.
>
> BUG=339240
>
> Committed: https://crrev.com/82405166f151d0d0be73d040aa5b77d309034aa0
> Cr-Commit-Position: refs/heads/master@{#295956}

TBR=pneubeck@chromium.org,joaodasilva@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=339240

Review URL: https://codereview.chromium.org/608153002

Cr-Commit-Position: refs/heads/master@{#297127}

Cr-Commit-Position: refs/heads/master@{#297126}

Cr-Commit-Position: refs/heads/master@{#297125}

BUG=418369
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/607313002

Cr-Commit-Position: refs/heads/master@{#297124}

We converted this target to GN already, so app_list can depend on it as
is. This should address the TODO(GYP) in the BUILD.gn file.

BUG=None
TEST=None
R=brettw@chromium.org
TBR=xiyuan@chromium.org,mark@chromium.org

Review URL: https://codereview.chromium.org/590863002

Cr-Commit-Position: refs/heads/master@{#297123}

Reworks DepsIterator so it is compatible with STL iterators enough to work with range-based for loops. The iterator is now created by a target rather than taking a target as an argument, which makes the loops more natural.

I also changed some loops around code I was touching to use range-based.

Review URL: https://codereview.chromium.org/610043002

Cr-Commit-Position: refs/heads/master@{#297122}

Say you have class A and subclass B.

Previously it was required to PassAs() a scoped_ptr<B> into a
scoped_ptr<A>. This is no longer needed, so just use Pass(). For newly
created scoped_ptrs, you can just use make_scoped_ptr always now.

And when you want to return or assign an empty scoped_ptr(), you can
now use nullptr directly.

Also adds PRESUBMIT checks for:
- return scoped<T>(foo). This should be return make_scoped_ptr(foo).
- bar = scoped<T>(foo). This should be return bar = make_scoped_ptr(foo).
- return scoped<T>(). This should be return nullptr.
- bar = scoped<T>(). This should be return bar = nullptr.

This also replaces p.reset() with p = nullptr; But it does not add a
PRESUBMIT check for that because there are things other than scoped_ptr
with a reset() function.

R=enne@chromium.org

Committed: https://crrev.com/7bb3dbede19d87f0338797756ffd738adc6bca08
Cr-Commit-Position: refs/heads/master@{#297096}

Review URL: https://codereview.chromium.org/609663003

Cr-Commit-Position: refs/heads/master@{#297121}

Review URL: https://codereview.chromium.org/609103002

Cr-Commit-Position: refs/heads/master@{#297120}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/611733002

Cr-Commit-Position: refs/heads/master@{#297119}

Review URL: https://codereview.chromium.org/612643002

Cr-Commit-Position: refs/heads/master@{#297118}

BUG=418369
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/613553002

Cr-Commit-Position: refs/heads/master@{#297117}

This adds support to use nullptr to construct, assign, or return a
scoped_ptr<T> and scoped_ptr<T[]>. Support for this requires the use
of a move-only constructor.

The changes are:

- Add a constructor that takes decltype(nullptr) as a parameter. This
allows behaviour such as scoped_ptr<T>(nullptr), but also allows a
function with return type scoped_ptr<T> to "return nullptr;" instead
of "return scoped_ptr<T>();".

- Add an operator=(decltype(nullptr)) that resets the scoped_ptr to
empty and deletes anything it held.

- Add/Modify a constructor to take a scoped_ptr<U,E>&& parameter for
constructing a scoped_ptr from another using move-only semantics. This
piece is critical for allowing the function returning nullptr to be
assigned to some other scoped_ptr at the callsite. In particular, take
the following code:
  scoped_ptr<T> Function() { return nullptr; }
  scoped_ptr<T> var = Function();
In this case the constructor which takes a nullptr allows Function() to
be written, but not to be used. The move-only constructor allows the
assignment from Function() to var. See "C++11 feature proposal:
Move-only constructors" on chromium-dev for more explanation why.

The scoped_ptr<T> class already had a constructor which took
scoped_ptr<U,E> as an argument, so this was changed to be
scoped_ptr<U,E>&& instead. The scoped_ptr<T[]> class had no such
constructor, so a scoped_ptr&& constructor was added. These match
the constructors found on the unique_ptr class.

- Remove the RValue type and the contructor that constructs a
scoped_ptr from an RValue. Change Pass() to return a scoped_ptr&&
instead of a scoped_ptr::RValue, to avoid the type conversion and
remove some complexity. This is done with a new emulation macro that
still provides Pass() and makes the type go down the MoveOnlyType
path in base::Callback code.

This adds base_unittests to demonstrate and use these changes.

The use of Pass() remains unchanged until std::move() is written
or allowed. At that time std::move() could be used instead of Pass.

R=brettw@chromium.org, jamesr@chromium.org

Committed: https://crrev.com/2299e91d3508f8d5d18ef990cf6024ea4371250a
Cr-Commit-Position: refs/heads/master@{#297072}

Review URL: https://codereview.chromium.org/599313003

Cr-Commit-Position: refs/heads/master@{#297116}

R=cmumford@chromium.org, jsbell@chromium.org, michaeln@chromium.org
BUG=418297

Review URL: https://codereview.chromium.org/594403005

Cr-Commit-Position: refs/heads/master@{#297115}

Derived from worksheet attached to https://code.google.com/p/chromium/issues/detail?id=369206#c17

BUG=369206
TEST=Manual, see bug.

Review URL: https://codereview.chromium.org/611693002

Cr-Commit-Position: refs/heads/master@{#297114}

Since Cast disables all user interaction, gesture requirement/infobar are
not useful.

The other flags are for protected content playback.

R=xhwang@chromium.org,byungchul@chromium.org
BUG=400876

Review URL: https://codereview.chromium.org/597813002

Cr-Commit-Position: refs/heads/master@{#297113}

It seems that it's possible that GDK events happen while we're going
to unregister the GDK event handler, and the code must be thread-safe.
(A gpointer |data| in the old code seems pointing to the deleted object.)

This CL removes use of |data| pointer and makes the code thread-safe
without adding any mutex.

BUG=417210

Review URL: https://codereview.chromium.org/610523002

Cr-Commit-Position: refs/heads/master@{#297112}

BUG=414483

Review URL: https://codereview.chromium.org/587153002

Cr-Commit-Position: refs/heads/master@{#297111}

This will make easy to tell when the main thread is
in a high latency mode without having to infer based
on the surrounding context.

BUG=none

Review URL: https://codereview.chromium.org/561043002

Cr-Commit-Position: refs/heads/master@{#297110}

Revert of Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder. (patchset #1 id:1 of https://codereview.chromium.org/606143003/)

Reason for revert:
scoped_ptr nullptr support was reverted.

Original issue's description:
> Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder.
>
> R=jamesr@chromium.org
>
> Committed: https://crrev.com/1b198fa11edbe68701e12c27d5f4981398f5ca71
> Cr-Commit-Position: refs/heads/master@{#297093}

TBR=jamesr@chromium.org,viettrungluu@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/593313006

Cr-Commit-Position: refs/heads/master@{#297109}

Revert of Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. (patchset #2 id:20001 of https://codereview.chromium.org/610083002/)

Reason for revert:
scoped_ptr nullptr support was reverted.

Original issue's description:
> Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}.
>
> R=jamesr@chromium.org
>
> Committed: https://crrev.com/a60566701028a7344d17826076780eeb84b63052
> Cr-Commit-Position: refs/heads/master@{#297095}

TBR=jamesr@chromium.org,viettrungluu@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/609033002

Cr-Commit-Position: refs/heads/master@{#297108}

Revert of Add nullptr support to scoped_ptr. (patchset #7 id:180001 of https://codereview.chromium.org/599313003/)

Reason for revert:
This CL broke several scoped_ptr tests.

Original issue's description:
> Add nullptr support to scoped_ptr.
>
> This adds support to use nullptr to construct, assign, or return a
> scoped_ptr<T> and scoped_ptr<T[]>. Support for this requires the use
> of a move-only constructor.
>
> The changes are:
>
> - Add a constructor that takes decltype(nullptr) as a parameter. This
> allows behaviour such as scoped_ptr<T>(nullptr), but also allows a
> function with return type scoped_ptr<T> to "return nullptr;" instead
> of "return scoped_ptr<T>();".
>
> - Add an operator=(decltype(nullptr)) that resets the scoped_ptr to
> empty and deletes anything it held.
>
> - Add/Modify a constructor to take a scoped_ptr<U,E>&& parameter for
> constructing a scoped_ptr from another using move-only semantics. This
> piece is critical for allowing the function returning nullptr to be
> assigned to some other scoped_ptr at the callsite. In particular, take
> the following code:
>   scoped_ptr<T> Function() { return nullptr; }
>   scoped_ptr<T> var = Function();
> In this case the constructor which takes a nullptr allows Function() to
> be written, but not to be used. The move-only constructor allows the
> assignment from Function() to var. See "C++11 feature proposal:
> Move-only constructors" on chromium-dev for more explanation why.
>
> The scoped_ptr<T> class already had a constructor which took
> scoped_ptr<U,E> as an argument, so this was changed to be
> scoped_ptr<U,E>&& instead. The scoped_ptr<T[]> class had no such
> constructor, so a scoped_ptr&& constructor was added. These match
> the constructors found on the unique_ptr class.
>
> - Remove the RValue type and the contructor that constructs a
> scoped_ptr from an RValue. Change Pass() to return a scoped_ptr&&
> instead of a scoped_ptr::RValue, to avoid the type conversion and
> remove some complexity. This is done with a new emulation macro that
> still provides Pass() and makes the type go down the MoveOnlyType
> path in base::Callback code.
>
> This adds base_unittests to demonstrate and use these changes.
>
> The use of Pass() remains unchanged until std::move() is written
> or allowed. At that time std::move() could be used instead of Pass.
>
> R=brettw@chromium.org, jamesr@chromium.org
>
> Committed: https://crrev.com/2299e91d3508f8d5d18ef990cf6024ea4371250a
> Cr-Commit-Position: refs/heads/master@{#297072}

TBR=brettw@chromium.org,jamesr@chromium.org,thakis@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/603353005

Cr-Commit-Position: refs/heads/master@{#297107}

Revert of cc: Remove use of PassAs() and constructor-casting with scoped_ptr. (patchset #6 id:120001 of https://codereview.chromium.org/609663003/)

Reason for revert:
scoped_ptr nullptr support needs to be reverted

Original issue's description:
> cc: Remove use of PassAs() and constructor-casting with scoped_ptr.
>
> Say you have class A and subclass B.
>
> Previously it was required to PassAs() a scoped_ptr<B> into a
> scoped_ptr<A>. This is no longer needed, so just use Pass(). For newly
> created scoped_ptrs, you can just use make_scoped_ptr always now.
>
> And when you want to return or assign an empty scoped_ptr(), you can
> now use nullptr directly.
>
> Also adds PRESUBMIT checks for:
> - return scoped<T>(foo). This should be return make_scoped_ptr(foo).
> - bar = scoped<T>(foo). This should be return bar = make_scoped_ptr(foo).
> - return scoped<T>(). This should be return nullptr.
> - bar = scoped<T>(). This should be return bar = nullptr.
>
> This also replaces p.reset() with p = nullptr; But it does not add a
> PRESUBMIT check for that because there are things other than scoped_ptr
> with a reset() function.
>
> R=enne@chromium.org
>
> Committed: https://crrev.com/7bb3dbede19d87f0338797756ffd738adc6bca08
> Cr-Commit-Position: refs/heads/master@{#297096}

TBR=enne@chromium.org,jamesr@chromium.org,vmpstr@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/608503005

Cr-Commit-Position: refs/heads/master@{#297106}

For offTheSideButton, animation was always enabled regardless of nodeMoved/
nodeRemoved. Enable animation only when it is called from -nodeRemoved:,
decided by 'animate' parameter.

BUG=60628
R=asvitkine@chromium.org

TEST=
1. Launch chrome and add more bookmarks and folders so that chevron is seen.
2. Drag and adjust items so that there is atleast one folder and one or more bookmarks under chevron.
3. Drag a bookmark(within chevron) and drop it under the folder(within chevron) and observe.
4. There should be no poof animation/sound presented to see/hear.

Review URL: https://codereview.chromium.org/599793002

Cr-Commit-Position: refs/heads/master@{#297105}

We're currently not passing the request context or frame type correctly
when performing redirects, which breaks our mixed content checking
functionality for those requests. This is the Chromium side of a fix.
Blink side to follow.

BUG=417841

Review URL: https://codereview.chromium.org/605103003

Cr-Commit-Position: refs/heads/master@{#297104}

Also remove logic for 401 errors. I don't think this is the correct thing to do, and covers up the real failure.

BUG=418225
TEST=None.
R=tonyg

Review URL: https://codereview.chromium.org/608933002

Cr-Commit-Position: refs/heads/master@{#297103}

Memory for WriteInto() should be greater than the url length,
As in the WriteInto() it reserve the memory of size 'length_with_null'
and then resize it to "length_with_null-1'
Chnage done to give memory 1 greater than the url length size.

BUG=417732

Review URL: https://codereview.chromium.org/599373003

Cr-Commit-Position: refs/heads/master@{#297102}

R=dpapad@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/print_preview/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/575333002

Cr-Commit-Position: refs/heads/master@{#297101}

BUG=418190

Review URL: https://codereview.chromium.org/607013003

Cr-Commit-Position: refs/heads/master@{#297100}