- 08 May, 2018 40 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/21cb8d2c..9c5f77a1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I08596995e9157faa8b330851cc468344f7b9b435 Reviewed-on: https://chromium-review.googlesource.com/1050473Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556986}
-
Maks Orlovich authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia0dec7ee73750261b1e19a425ad2d00742962770 Reviewed-on: https://chromium-review.googlesource.com/1016669 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#556985}
-
Mohammad Refaat authored
This reverts commit cbab9a8e. Reason for revert: Keep iTunes handler enabled for M68 Original change's description: > Disable iTunes URL handling feature by default > > Bug: 840903 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ic40fdc4ad194301c51d1c9b4d06720cf63a9aac1 > Reviewed-on: https://chromium-review.googlesource.com/1050569 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556938} TBR=eugenebut@chromium.org,mrefaat@chromium.org Change-Id: Ic56c79148b1cf44c8ff83a9b761126971418b286 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840903 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1050750Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#556984}
-
Muyuan Li authored
This is a reland of CL: https://chromium-review.googlesource.com/c/chromium/src/+/1014464 which was reverted by: https://chromium-review.googlesource.com/c/chromium/src/+/1043187 due to compilation error. Original commit message: > Refactor AXSnapshotNodeAndroid into mojo. > > Test: browser_tests --gtest_filter=ArcVoiceInteractionArcHomeServiceTest.* TBR=dmazzoni@chromium.org,sky@chromium.org,dcheng@chromium.org Change-Id: Ieca4bf35f3aa913683e8d1ce34160731317a797f Reviewed-on: https://chromium-review.googlesource.com/1045487Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#556983}
-
Abhishek Arya authored
R=mmoroz@chromium.org,liaoyuke@chromium.org Change-Id: Ief1e5de05febdf6c6ffd1d9fefb99c5b953b87b2 Reviewed-on: https://chromium-review.googlesource.com/1050747 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#556982}
-
Morten Stenshorne authored
No behavior changes are intended. This is just to document and illustrate what goes on when we have to apply clearance to an empty block. In this case we actually have to calculate the clearance, as defined in the spec. It's truly bizarre, but nevertheless spec-compliant. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I579593f87a452c79fa87631f88e97122d30fb3fa Reviewed-on: https://chromium-review.googlesource.com/1049966Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#556981}
-
Alex Newcomer authored
Part 2 of "Add Actionable Submenus To Extension App Context Menus" This part adds the actionable submenu option to the AppList. Also in this cl: - Re-ordered function in extension_app_context_menu.cc to match the header. - Fixed a mis-placed separator (incidental fix due to restructuring the context menu option ordering). Bug: 829940 Bug: 830339 Change-Id: If3f369260b4883206a6014754e08fcbae697b7ae Reviewed-on: https://chromium-review.googlesource.com/1050406Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#556980}
-
Dmitry Gozman authored
Bug: 836511 Change-Id: I9ac2c9613235758f47b7b44d9b5f8c46b5a35734 Reviewed-on: https://chromium-review.googlesource.com/1048843Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556979}
-
Dave Schuyler authored
This reverts commit bd3d1ea0. Reason for revert: Crash on relaunch after changing about:flags. See http://crbug.com/841006 Original change's description: > Disable Channel ID on all platforms except Android > > Change-Id: I481ee17e83c2eef8433fa774285cf68e0b7c4ac8 > Reviewed-on: https://chromium-review.googlesource.com/1041139 > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556899} TBR=rch@chromium.org,nharper@chromium.org Change-Id: Ia4d92cb00471baa0824226bfd48037c3a002606b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1050646Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#556978}
-
Andrey Lushnikov authored
This patch implements Target.getBrowserContexts() method that returns all the contexts created with Target.createBrowserContext() calls. R=dgozman, alexclarke, caseq BUG: 836272 Change-Id: Ib39f947c5591ddb2d6158d8417bc1c8b82561d15 Reviewed-on: https://chromium-review.googlesource.com/1049266 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#556977}
-
dpapad authored
This is in preparation of updating cr-toggle's style for MD refresh, as well as removing paper-toggle-button from third_party/polymer. Bug: 768073 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9deb661359b3e61de873f46d0ab201c2d3ff1502 Reviewed-on: https://chromium-review.googlesource.com/1050579Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556976}
-
Jonathan Backer authored
Discardables are only used for GPU raster. We do not plan to support GPU raster in RasterInterface because GPU raster requires a GrContext (which is roughly a full GL context). Bug: 834313 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib99c788565c48d9f312c79e2b3a2b5dcd4ce9721 Reviewed-on: https://chromium-review.googlesource.com/1050391Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#556975}
-
Lei Zhang authored
BUG=792308 Change-Id: Id5b4b80b72160b76f377134fc536ca1820c1f514 Reviewed-on: https://chromium-review.googlesource.com/1049271 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#556974}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dcab7155. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17162 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing TBR=danyao No-Export: true Change-Id: Ic866ce543017d9f00708b050fe79a75d832e7d9c Reviewed-on: https://chromium-review.googlesource.com/1050197 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556973}
-
Matt Menke authored
I believe these most likely broken by https://chromium-review.googlesource.com/1048133 TBR=japhet@chromium.org, jam@chromium.org NOTRY=true Bug: 729848, 706331 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4b3525af8d2f06fbccf311e40a9f64e7af70ffcd Reviewed-on: https://chromium-review.googlesource.com/1049831 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#556972}
-
Lei Zhang authored
Change the method to validate all the input before recording metrics. To better organize the code, use an enum for the user action, instead of having many booleans. Change-Id: Ie7f13e073a10687a8fc170251aac3670617c0f6d Reviewed-on: https://chromium-review.googlesource.com/1045506 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#556971}
-
https://pdfium.googlesource.com/pdfium.git/+log/9ec0bca735b5..b7c41498ac1f $ git log 9ec0bca73..b7c41498a --date=short --no-merges --format='%ad %ae %s' 2018-05-08 thestig Add some basic tests for FPDF_VIEWERREF_GetPrintPageRange(). 2018-05-08 thestig Split CCodec_FlateScanlineDecoder in two. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibf11fa15f242c5a2608c9487a6cf81c6deb8c62d Reviewed-on: https://chromium-review.googlesource.com/1050574 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556970}
-
Aldo Culquicondor authored
Also, making sure that scrolling events that don't hit any target are discarded. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I1326b799cfdc6765fb1eece3f225739085e1b53e Reviewed-on: https://chromium-review.googlesource.com/1048289 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#556969}
-
Adrienne Walker authored
Skia caches the results of SkPictureShaders internally based on its fUniqueId. In order to correctly hit that cache, the gpu process needs to cache and reuse SkPictureShader objects where possible. One possibility is to use the transfer cache for this (as was done for SkPaths). However, paint record shaders can transitively include images, paint records, other paint record shaders, paths. Using the transfer cache would mean having to support transfer cache dependency graphs, which would make future parallelization more complicated. Maybe we can punt on this forever, but definitely punt for now. This patch deliberately chooses a hacky workaround to avoid this design snag. In particular, we always serialize the entire PaintRecord in the shader along with images (at the correct scale). On the gpu service side, if this shader matches the same scale and colorspace of the last time we used it, we use the cached SkShader, otherwise we'll build a new one. Matching the scale is for visual correctness (as images at different scales might look visually worse). Matching the colorspace is for performance (to avoid unnecessary colorspace conversions) but also for visual correctness (colorspace conversion causing quality degradation). Performance for this is tricky to test. Animometer has no picture shaders at all. One bug that regressed when shaders were not being cached was the test case attached in http://crbug.com/788075. Switching images back and forth on that test page had the following results: * gpu raster: 32.7ms/frame * oop raster: 29.7ms/frame * oop raster + patch: 26.0ms/frame (18% improvement over gpu raster) Bug: 815022, 788075 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I350b1ed6ad90f8c660b1a47444f984ef309ae555 Reviewed-on: https://chromium-review.googlesource.com/1037770 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#556968}
-
Dan Beam authored
Bug: 840024 Change-Id: I4e30f8e2565e6f77cb20b28f5c5d2f5ce066f57a Reviewed-on: https://chromium-review.googlesource.com/1045546 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556967}
-
Elly Fong-Jones authored
These aren't used in Mac apps. They aren't *shown* in MacViews, but they were still used, which meant that trying to prefix search could instead activate an item by mnemonic. Test: Manual 1) Open the app menu 2) Press "N" Before this CL, "New Window" is activated; after it, "New Tab" is prefix-selected. Bug: 836964 Change-Id: Id672a1e17589e3ebd09e6bff473341947bd2df2a Reviewed-on: https://chromium-review.googlesource.com/1050305 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#556966}
-
rbpotter authored
- Allow alternative commas in the Print Preview UI for the pages field - Migrate tests for pages syntax - Fixes to match behavior of current UI (i.e. show error for 2 commas in a row, 0 is invalid syntax instead of out of bounds). Bug: 814860, 814861 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ied57eaf87b68cd712fe50970a37a71401c977a0c Reviewed-on: https://chromium-review.googlesource.com/1048468 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556965}
-
Nicolas Pena authored
This CL changes resource-timing-worker.js to use a generated response. This means Chrome no longer passes the test. Change-Id: Ib983e4fba9e81ddbee7f9572b6a06b3c1825577a Reviewed-on: https://chromium-review.googlesource.com/1050383 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#556964}
-
Dan Beam authored
R=dpapad@chromium.org BUG=none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I24e67468d56714b1d071bb228a9b754ac363197b Reviewed-on: https://chromium-review.googlesource.com/1050696Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#556963}
-
Raymond Toy authored
These tests pass on Firefox or fail due to bugs in Firefox. The remaining tests are somewhat Chrome-specific and aren't moved. Bug: 745778 Change-Id: Idb1e9ce94339032d7e2866232424c458635db646 Reviewed-on: https://chromium-review.googlesource.com/1042858 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#556962}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/60c67490a1f2..71a6995084bd $ git log 60c67490a..71a699508 --date=short --no-merges --format='%ad %ae %s' 2018-05-07 brianosman Only enable noperspective with ES3 shading language 2018-05-07 bungeman SkBlurMask to blur all the things. 2018-05-08 halcanary sk_sp: check for self-assignment 2018-05-03 herb Use device and key descriptors Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I105ce83536280d2cbbf7fb281fe42fa2d1c6e67c Reviewed-on: https://chromium-review.googlesource.com/1050725Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556961}
-
Evan Stade authored
5d480c70 broke this test because it moved the code that sets the icons from //chrome/ into //ash/. These targets duplicate //ash/public/vector_icons (when using the component build), so it's not valid to directly compare icon addresses. Compare by identifier (name) instead. Bug: 704942,836992 Change-Id: I47a916a265c976afb61058be569283623d773c10 Reviewed-on: https://chromium-review.googlesource.com/1050379 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#556960}
-
Hiroshige Hayashizaki authored
Bug: 829084 Change-Id: I2d36e8bc8c74f2c3158ecb4ccc4d2a8ca6e35cc1 Reviewed-on: https://chromium-review.googlesource.com/1045085 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#556959}
-
Raymond Toy authored
Firefox passes these tests. The remaining tests that weren't moved all use oac.suspend which Firefox doesn't have (incorrectly), so they weren't moved. Bug: 745778 Change-Id: Ic8e758896cfdd2abfccf29b6444c20f13c0be3f2 Reviewed-on: https://chromium-review.googlesource.com/1042853Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#556958}
-
Fady Samuel authored
There are parent allocated IDs plumbed through cc and occasionally cc will allocate LocalSurfaceIds. We should distinguish between the two. This CL makes the appropriate rename to disambiguate. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iadce752be4617bb100f8bd774df59e23b94e5459 Bug: 672962 TBR: junov@chromium.org for third_party/blink, sky@chromium.org for ui. Reviewed-on: https://chromium-review.googlesource.com/1050549 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#556957}
-
kylechar authored
SoftwareOutputDeviceWin has two code paths to draw currently. With OOP-D there will additional implementations needed. Instead of shoehorning everything into one class, split into two separate classes and provide a function to get the correct one. This doesn't really reduce code now but it will make it simpler to add implementations for OOP-D and to remove implementations in the future after OOP-D is launched. There is shared base class with some simple logic and DCHECKs. There are then two implementations, one that draws directly the HWND and one that draws using layered window APIs. Landed in https://crrev.com/c/1044291 originally. I had logic inside of a DCHECK which of course never runs with DCHECKs off. The tests relying on that logic failed as a result. Bug: 826633 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic982aed50963b45cb0bb92a86da7dc9fbc0038ba Reviewed-on: https://chromium-review.googlesource.com/1050608Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#556956}
-
Finnur Thorarinsson authored
This fixes the issue with window activation not functioning correctly when notifications are activated while Chrome is running but in the background. Bug: 837796, 734095 Change-Id: I8eac14403850a13d60e7a50c3c795fed96205d7e Reviewed-on: https://chromium-review.googlesource.com/1049984Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#556955}
-
Ryan Landay authored
We currently don't have any UMA events for entering the Android tab switcher by swiping down on the toolbar. In https://chromium-review.googlesource.com/c/chromium/src/+/1048042, I am updating the MobileToolbarShowStackView logging to include this case. In this CL, I am adding a new MobileToolbarSwipeOpenStackView event specifically for this case so we can measure how many people are entering the tab switcher by swiping on the toolbar. Bug: 828224 Change-Id: I2b2f7e4dafd08192355618273d7069a03b4d9e4e Reviewed-on: https://chromium-review.googlesource.com/1048308Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#556954}
-
Katie D authored
Bug: 753018 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icd14d6f7e4f9608d35fcbedbee47ad090b3b5c63 Reviewed-on: https://chromium-review.googlesource.com/1043250 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556953}
-
Jungshik Shin authored
See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1041578 for details. Note that there's ~90kB size increase for desktop Chrome. Cq_Include_Trybots: master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel Bug: 838383 Test: base_unittests:*Conv*,*Format*,*Break* Test: components_unittests: *IDN*, *URL*, *Format* Test: gfx_unittests: *Word* Test: Blink tests, layout tests, accessibility_unittests: *Boundar* Change-Id: Icabbeeec9c5233c1f7a9ba703b2a7ce72ae41b53 Reviewed-on: https://chromium-review.googlesource.com/1038226Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556952}
-
Sergey Ulanov authored
Enabled the following tests: ProcessUtilTest.CloneAlternateDir ProcessUtilTest.KillSlowChild ProcessUtilTest.SelectivelyClonedDir The problem that broke these tests was fixed in crrev.com/556610 . Also removed ProcessUtilTest.LaunchNamespaceMap because it overlaps with the tests enabled in this CL. Bug: 826018 Change-Id: I211edb31ff6482e16ebad0967a5749e1dc353327 Reviewed-on: https://chromium-review.googlesource.com/1048880 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556951}
-
Fabrice de Gans-Riberi authored
This cleans up multi-platform code paths selection and prepares for the removal of OS_POSIX for the Fuchsia build. Bug: 836416 Change-Id: I45af4ff9525a3129c077101ad4e365c79490299e Reviewed-on: https://chromium-review.googlesource.com/1033969Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#556950}
-
Siddhartha authored
Bug: 734705 Change-Id: I4ea5cfb28ff531353fc78db0f7d248bd8e963170 Reviewed-on: https://chromium-review.googlesource.com/1036535 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Hector Dearman <hjd@chromium.org> Cr-Commit-Position: refs/heads/master@{#556949}
-
Scott Chen authored
Bug: 836391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9a62435e04983cbd28df474c20162423ac75df54 Reviewed-on: https://chromium-review.googlesource.com/1036785 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556948}
-
Fabrice de Gans-Riberi authored
This cleans up multi-platform code paths selection and prepares for the removal of OS_POSIX for the Fuchsia build. Bug: 836416 Change-Id: Iaedf38b0b5d82121b28b1603233f43553bc5fdf0 Reviewed-on: https://chromium-review.googlesource.com/1033578Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#556947}
-