- 04 Oct, 2019 40 commits
-
-
Maggie Chen authored
The majority of the GPU watchdog V2 crashes happen within the first 60 seconds after launch. Extend the timeout so the GPU can finish the initialization on a slower machine. Bug:949839 Change-Id: I173f0b6d9fd707b239e9f5598ff883e2054a054f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836973 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#702908}
-
Scott Little authored
This CL enables automatic lazy image and iframe loading by default. Note that by default, automatic lazy image and iframe loading is restricted to users with Lite Mode (aka Data Saver) turned on, and in practice, this also restricts automatic lazy loading by default to Android, since Lite Mode is only accessible through UI on Android. Bug: 989246, 954324 Change-Id: Iad30e42061838941d73a0742c1d2fd442d79f98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838679Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#702907}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f83d0ef0859c..7536bc539500 git log f83d0ef0859c..7536bc539500 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 nisse@webrtc.org Account for IP and UDP headers in emulated network 2019-10-04 hbos@webrtc.org Update RTC_LOGs in DtlsTransport to be able to distinguish errors. Created with: gclient setdep -r src/third_party/webrtc@7536bc539500 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iccbfc60493ba329057b8cafeb862dd0dbcd464a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841371Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702906}
-
Ryan Daum authored
Upstreams a utility which draws roundy corners on aura windows. Bug: internal b/141369549 Test: manual Change-Id: Ibbc57c6e15529ebc69fb294fc391cf349e9bb305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841573Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#702905}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ce0e2c0a426..23149ef7ce0b Created with: gclient setdep -r src-internal@23149ef7ce0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8d42a91840c3a33489a95dcb681d8226052cecb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841731Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702904}
-
Armando Miraglia authored
BUG=796964 Change-Id: I69cd354a43b51639234ae5e6b3aa15cc646b022d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841431Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#702903}
-
Alison Maher authored
If certain flags are enabled, NativeThemeMac may return a different NativeTheme instance for NativeTheme::GetInstanceForWeb(). This will cause NativeTheme::GetInstanceForWeb() on Mac to be out of sync in terms of dark mode and high contrast. To fix this, NativeTheme::GetInstanceForWeb() is added as an observer of NativeTheme::GetInstanceForNativeUi() in these cases. Bug: 970285 Change-Id: I832d182647f81491a761a071bc5633c2efdeedb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834028Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702902}
-
Rob Schonberger authored
Add a fix to the recent neural utils where devices don't report X or Y resolution appropriately, by setting to the correct number (1). Add a unittest with a genuine touchscreen DeviceCapabilities to show this off. Bug: 1009290 Change-Id: I18af8c02e4a68d024be8f73581cda4c2329ca177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839271Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#702901}
-
Ana Salazar authored
Bug: 1005171 Change-Id: Ib89421a831edecce2c9eb3d35ab6b477557127a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838914Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702900}
-
danakj authored
RenderFrameImpl wants to scale the position of a context menu by the emulator scale, if the position wasn't specified by the browser (this seems suspect). It can do this through the PageProperties directly instead of going through RenderWidget. R=avi@chromium.org Bug: 1006052 Change-Id: I72b5b684b2279902fca6cbcfa0920f0ba021cd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834766Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#702899}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6021fbd09b1c..6fff5122a23e git log 6021fbd09b1c..6fff5122a23e --date=short --no-merges --format='%ad %ae %s' 2019-10-04 bclayton@google.com libVulkan: Wrap the marl scheduler in a shared_ptr. Created with: gclient setdep -r src/third_party/swiftshader@6fff5122a23e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141380274 Change-Id: Iac2236642c773a5bc860bdc52a84eb92a894e1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841711Reviewed-by:
-
Shawn Gallea authored
This will allow for custom framerate, to eventually be used to lower framerate for headless devices. Bug: b/139299756 Test: Compile cast_shell for headless device Change-Id: Ib08559a3101d55c7b004a7356f78a2f01010af4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814318 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Mark BoxedV8Module as final to avoid problems when having no virtual destructor which depends on TraceWrapperV8Reference. Change-Id: Ibab44d1c52f87bc099c0eca7602b175345e4cb2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841632 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#702896}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/97565d8a9687..f77a4786a334 git log 97565d8a9687..f77a4786a334 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 treehugger-gerrit@google.com Merge "docs: Add tip about ccache" 2019-10-04 lalitm@google.com Merge "Expose full gpu_slice (with slice columns)" 2019-10-04 lalitm@google.com Merge "trace_processor: fix resize bug" 2019-10-04 lalitm@google.com trace_processor: improve logic of best index 2019-10-04 eseckler@google.com Merge "processor: Stitch chunks of legacy user json traces for export" 2019-10-04 lalitm@google.com Merge "Improve logging of GetCmdlineForPID." 2019-10-04 treehugger-gerrit@google.com Merge "CI: Add Bazel coverage" 2019-10-04 lalitm@google.com Merge "trace_processor: significantly improve performance of bitvector resize" 2019-10-04 tneda@google.com API for drawing flamegraph for selected heap profile 2019-10-04 primiano@google.com Merge "Add yapf python formatter and format all files" Created with: gclient setdep -r src/third_party/perfetto@f77a4786a334 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I508392c1e529bdd2166ae9f10b890dd752324574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841652Reviewed-by:
-
Robbie Gibson authored
For a Voice Control name, the "1 unread reading list item" isn't useful. The name should still be just "Reading List." Bug: 1004319 Change-Id: I64e968a57c8aa027977220dbf8a62bc638baa07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837792 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702894}
-
Victor Fei authored
Fix for AXRange::GetScreenRects to not return bounding boxes for ranges that are offscreen. Previously, we assumed ranges that are offscreen will have empty bounding rects, this is incorrect because offscreen rects has its width/height clipped to 1 rather than 0; so bounding box is not empty. See doc: https://cs.chromium.org/chromium/src/docs/accessibility/offscreen.md Instead, GetScreenRects now looks at the offscreen status from the bounds API to ignore offscreen ranges. This fix is one of a series of fixes need for bug:964078. Bug: 964078 Change-Id: Ibfb4d245845b7e18d59724b8c7fd09f9cc3de793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824061 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702893}
-
Anastasia Helfinstein authored
Instead of re-calculating whether the virtual keyboard is open every time auto-scan changes, cache the value and explicitly set it when the keyboard is entered or exited. Bug: None Change-Id: Ia86a95f6552df4f919d6e583829f5d3f15077cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829767Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#702892}
-
Lei Zhang authored
Found using tools/check_grd_for_unused_strings.py. Change-Id: Ib94967bb7045e9de1c97f96f5ece96b7435eb04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839632Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#702891}
-
Lei Zhang authored
- Refactor GetValue() to use an existing struct. - Make the parameter names in the .cc / .h files match for GetValue(). - Mark GetValue() and GetStringValue() const. - Make all ::VerQueryValue() callers consistent. - Add a comment to note |fixed_file_info_| is never nullptr. - Fix various nits. Change-Id: I4e73bf5791045005c2cfdeb6a039815c39e953ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837490 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#702890}
-
Jordan Demeulenaere authored
Change-Id: Ife5804b2897aac9463d91a5e20e154678ce274bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841633 Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#702889}
-
Mitsuru Oshima authored
Bug: 1007397 Test: covered by unittest Change-Id: Ib6b5ed47c3368133d0dcccf7a9be202570d0f541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833007 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#702888}
-
Alexander Timin authored
At the moment AppBannerManager disables bfcache when committing the initial navigation and prevents every frame from being cached. Fix this by requiring state to be not INACTIVE. R=arthursonzogni@chromium.org TBR=dominickn@chromium.org BUG=1001087 Change-Id: I5c63a35d2a56872b36f79e738d4db90c554a9caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840233Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702887}
-
Lei Zhang authored
Test to make sure no_version_info.dll, which has no version info, causes base::FileVersionInfo::CreateFileVersionInfo() and CreateFileVersionInfoForModule() to return nullptr. no_version_info.dll is just an one-off component build of pdfium.dll, with everything stripped out. Change-Id: I3e4b527f1d2f52dcec55c2c38af369a651608175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838268Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/485edf28..666d4144 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I86327aa0af90495cb06d3524a8864cef7cee652b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841311Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702885}
-
Fergus Dall authored
In crrev.com/c/1454156 the checks in AppsGridView::ReparentItemForReorder and AppsGridView::ReparentItemToAnotherFolder to see if a folder would be deleted by removing an app was broken for persistent folders. This would cause the model for the folder to be deleted, while the view remained in place. Interacting with the empty folder would then cause a null dereference and crash chrome. Bug: 1009989 Change-Id: Ief7bc007683b38d536aabb1418d8142e5c0f7702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837556Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#702884}
-
Samuel Huang authored
This reverts commit 3dd37620. Reason for revert: Suspected of causing webkit_layout_tests in http/tests/credentialmanager/credentialscontainer-get-with-virtual-authenticator.html on "Win10 Tests x64". Original change's description: > Reland "[iOS] Make the leak detection backend available on iOS" > > This is a reland of 74640a89 > > TBR=vasilii@chromium.org > > Original change's description: > > [iOS] Make the leak detection backend available on iOS > > > > Bug: 986317 > > > > Change-Id: I9d799cd24551f13bc58eac91c843d2da19aa7851 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832267 > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#702059} > > Bug: 986317 > Change-Id: I490b8d96074e1786b74905a083f0554fe914b4c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840771 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702835} TBR=vasilii@chromium.org,ioanap@chromium.org Change-Id: Ic28424989edd62fb5eed9b1b15c409406fd267df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841754Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702883}
-
Tommy Steimel authored
This CL relands the interactive UI tests for the global media controls. The original CL was flaky for the ShowsMetadataAndControlsMedia test because sometimes it checked for toolbar icon visibility after media started but before the media starting caused the icon to appear. This CL fixes that by waiting for the icon to appear. TESTED=Was locally flaking about once every 20 runs before the fix. After the fix, I ran it 300 times and it passed every time. Description from original CL (crrev.com/c/1753690): This CL adds some basic interactive UI tests for the global media controls. This ensures we have better coverage than just unit tests. Bug: 993879, 999297 Change-Id: I7abf36e4f82b64b262d3d0a7eb9d426e8ae1c5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814671Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#702882}
-
Yue Zhang authored
* Modify tab group naming related methods to make them easier to use. * Add unit tests for TabGroupTitleEditor. Bug: 1001738 Change-Id: I42591d5b73e1b9c5dd00798939a48da92dede4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837979 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702881}
-
Anastasia Helfinstein authored
Some methods (i.e. center, unionAll) are not used in this change, but will be in a followup change. Bug: None Change-Id: I2fe31bdfa1e02d609813e352a51e8b105631660c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830361Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#702880}
-
Josh Nohle authored
This class handles the BatchSetFeatureStatuses portion of the CryptAuth v2 DeviceSync protocol. While the BatchSetFeatureStatuses API allows for setting multiple feature statuses for multiple devices, we restrict our interface to a single feature for a single device. This is for simplicity as well as consistency with the CryptAuth v1 DeviceSync interface. CryptAuthFeatureStatusSetter::SetFeatureStatus() is the v2 DeviceSync analog of SoftwareFeatureManager::SetSoftwareFeatureState(). A future change will introduce a SetFeatureStatus() method into the DeviceSync mojo service, which will use CryptAuthFeatureStatusSetter. Bug: 951969 Change-Id: I57b315cb4a1853120f4ccf26bb7cdfd0f18e022c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833317 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#702879}
-
Alex Turner authored
Given that CPU usage is now reported to AdsPLMO, this updates the criteria for when an ad frame is recorded. Specifically, it is recorded iff it has either non-zero bytes or non-zero CPU usage. This change also fixes an issue where metrics would still be collected for resources blocked by the Subresource Filter. PageLoad.FrameCounts.AnyParentFrame.AdFrames is versioned to PageLoad.FrameCounts.AdFrames.Total. The other affected metrics have not been versioned as the increase in the number of ad frames recorded should be small (~5%). Bug: 1000810 Change-Id: I7ec57326ca93f6e6686d84869bb7f4dfbf58bf15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824124Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#702878}
-
Ian Clelland authored
Reporting and Document Policy are going to be using SH, and it is more generally useful as a building block for new features than just Web Packages. This CL moves it into blink/[public/]common/http, and removes the http_ prefix from individual files and directories. Bug: 993790, 1011101 Change-Id: I344e4aad6ebeb6956e441a7ab75478d98d7f60a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835998Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#702877}
-
Jeremy Roman authored
These have no need to use array buffers and are a minor nuisance to those who refactor the Blink-side array buffer code. We can just use the Skia type for the paths that only ever want to pass the data back to Skia anyways. Change-Id: I9bd9d056c79c4819628aae243f7a333f08dbcaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835659Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702876}
-
Mugdha Lakhani authored
We currently create a BackgroundSyncNetWorkObserverAndroid object to monitor changes in network connectivity. We also rely on JobScheduler to run a task that fires all ready (periodic)sync events when we have network connectivity. The latter has better network detection, given that it validates connectivity before running the task. This means that we don't attempt to fire sync events when the device is behind a captive portal, or hasn't yet authenticated to a locked network. It also respects Data saver mode, and doesn't run the task if the user has prohibited the browser from consuming data in the background. This change adds a BackgroundSyncParameter to ignore network changes coming from BackgroundSyncNetworkObserverAndroid. This means that we only fire ready events when the JobScheduler task tells us to, relying entirely on Android's network detection logic. Note that this won't have any effect on sync events that are ready to fire as soon as they're registered, since JobScheduler isn't involved at that point. This ensures we don't introduce any delays for the first attempt. Second attempt onwards, JobScheduler can be involved on Android M+. It is also always used when there's no connectivity at the time of registration of sync events, and for all periodicsync registrations. So the change is a net improvement. The plan is to enable this parameter through a Finch study on Android M and above where we can rely on JobScheduler for this task. Bug: 529351, 574478, 529351 Change-Id: I482b2a6eb59a073fa0cde2a5d6bb58d55e8691ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833590 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#702875}
-
Gauthier Ambard authored
When a page load is cancelled, the pending navigation shouldn't necessarly be discarded because another navigation could be the current pending navigation (if there is a delay). This CL makes sure to check that the cancelled navigation is the pending navigation before discarding the pending navigation. Bug: 1007243 Change-Id: Iae01e31bea3e40ae4ff08f1dbcc4a28c9f70198c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837931Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#702874}
-
Alex Chau authored
Bug: 1010998 Change-Id: I7f389c9e36fb672f727acec914c4f97dde3e3133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838191 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702873}
-
Xida Chen authored
Bug: 900581 Change-Id: Id7b0a8dbc03457343ce7fa8d25f30ee0da39f901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841071Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702872}
-
Samuel Huang authored
TBR=jbudorick@chromium.org Bug: 1011225 Change-Id: I3b5e5789da0a6d0a7a19f333ffab11e36b5fe0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841572Reviewed-by:
-
Sky Malice authored
Bug: 995480, 995482, 995488, 995489, 995497, 995499, 995500, 995505, 995512, 995516, 995519 Change-Id: I7dc1aaab76b498c35a57cbfdcad35f87f98dd098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829648Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#702870}
-
Ben Wagner authored
This makes it much easier to roll expat. It automates calling rolldep, updating the README.chromium, updating the expat_config.h configuration header, and adds the OWNERS to the review. Bug: chromium:1004341 Change-Id: I9e19e0016cedc12b1f2079cd54b95bd7e3d3f25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829677Reviewed-by:
-
