- 24 Feb, 2020 40 commits
-
-
Anastasia Helfinstein authored
Simplify BackButtonNode.findAutomationNode() to be more in line with the rest of the Switch Access code. Bug: None Change-Id: Ibccfc0bfd65c45120226b3ce3e976c832d5ade6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065312 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#744087}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1773f37de61e..f95054fa7d04 git log 1773f37de61e..f95054fa7d04 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 yiwzhang@google.com Roll bb tool to @36780e0 Created with: gclient setdep -r src/third_party/depot_tools@f95054fa7d04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1054982 Tbr: agable@chromium.org Change-Id: I941c083df93e33b2d36c9a872cade81088f17006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070775Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744086}
-
Brian Sheedy authored
There is an issue when building //third_party/breakpad:dump_syms in cross-compiled builds. Since dump_syms is unused in Telemetry on Windows anyways, remove the dependency entirely on that platform. TBR=crouleau@chromium.org Bug: 1055301 Change-Id: Ic78db0dff8fe6ffe008cd4610393b654775593d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070200Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#744085}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/659cc1c90705..bfe5a68c1e31 git log 659cc1c90705..bfe5a68c1e31 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 westont@google.com Move Pixel2XL Android_DDL1_Vulkan and Android_DDL3_Vulkan jobs to NVIDIA_Shield. 2020-02-24 nihohit@gmail.com Remove docs for macros that don't exist in the code. 2020-02-24 csmartdalton@google.com Remove SWAP_PER_DRAW from GrGLGpu Created with: gclient setdep -r src/third_party/skia@bfe5a68c1e31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I5db7abd448bbd8eae3df5434fd7f852b175f61c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068626Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ie2e412295126077b9762f69b9acd993f870a8e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068832 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#744083}
-
wutao authored
Bug: b/145218971 Test: manual Change-Id: Idbafcf175286ebbd933cd1228931fe511e74bc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070114Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#744082}
-
Toni Barzic authored
BUG=1021773 Change-Id: I10b0f70f41f5c067049757ec093424c5a8641d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070689 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#744081}
-
Daniel Clark authored
Fix an issue where focusing the 'This month' button in a month input popup and pressing 'Enter' would close the popup but not switch to the current month. The problem was that the MonthPicker.onKeyDown_ handler was receiving the event first and submitting the popup with the current value (which was the correct behavior for an 'Enter' keypress anywhere else in the popup). With this fix, the onKeyDown_ handler skips the event if the target was the 'This month' button so that MonthPicker.onTodayButtonClick_ can handle it correctly. An alternative solution that I explored was to move the element for the 'This month' button under the YearListView so that the button's event handler would be triggered before the keydown handler on the MonthPicker, but this caused problems with the popup layout while leaving other issues with the event ordering, so I chose to go with the simpler solution found in this CL. Bug: 1054469 Change-Id: I4f32b6ca8b71b7e700e63c8e2d45429df74dce27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067718Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#744080}
-
Filip Gorski authored
Bug: 1055466, 1054072 Change-Id: I36d21fc5d28c4144b788e204f33b4f66fdae0b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066585 Commit-Queue: Filip Gorski <fgorski@chromium.org> Auto-Submit: Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#744079}
-
Patrick Monette authored
Change-Id: Ie279dd645e59380dd7d771e36888d1381d153b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067195 Auto-Submit: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#744078}
-
Rachel Carpenter authored
Previously we served the sandboxed iframe at chrome://help-app-guest. Now the untrusted scheme is ready, using chrome-untrusted://help-app. Bug: b/149713277 Change-Id: If474995c39dbcce85d868535fa33effd9592d5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066373Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#744077}
-
Samuel Attard authored
On some windows machines we were seeing errors "ImportError: No module named name_style_converter" This error appears to be caused by the strange interactions in module imports in generate_bindings.py, potentially some kind of circular dependency. However, just changing the order of these imports fixes the issue. Change-Id: Icf0a6f36db726ffa25dbbc46fe41b8d8d09f2f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070668Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#744076}
-
Demetrios Papadopoulos authored
Specifically, when the PrivacySettingsRedesign flag is on: - Split content settings types to two categories "permissions" and "content settings" - Within each category show 5 items by default, and place all remaining items within an expandable section. Achieved by introducing a new settings-site-settings-list custom element, and moving some logic previously in site-settings-page to the new element. The old codepath where PrivacySettingsRedesign is off, is also leveraging the newly introduced settings-site-settings-list element. Bug: 1032584 Change-Id: Id7c7b3d01aa319371374ae1379ea617703934abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065338 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#744075}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 01dabee6. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" ea6dba31 "Align <pattern> and <*Gradient> attribute collection" 7d52b1d5 "[v8][wasm] Fix WebAssembly streaming tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/resources mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I5ee8bcc66072dc9fff1f1e1085f7009f234575c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070391Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744074}
-
nancy authored
ChromeLauncherController::LaunchApp could be called from AppServiceAppItem::Activate, which is not from Shelf as the launch source, so convert and get the correct launch source from the LaunchApp function's parameter. BUG=1043205 Change-Id: I9ca32bc50340b861938afffadfd5c8a823d83f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066503Reviewed-by:
-
Henrique Nakashima authored
These flags are default enabled and can be removed to simplify a ton of code. Bug: 1012975, 1018268 Change-Id: I606ea81d3cef3f9bead86276467c1aeb27fce350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068864 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#744072}
-
Michael Sun authored
CRAS registered a media player with the Chrome OS Bluetooth stack (BlueZ) following the Bluetooth AVRCP (Audio/Video Remote Control Profile). The media player is capable of providing media status, track information, metadata, and etc to the remote Bluetooth device. This patch (as a part of more changes) adds new functions to support Playback Status, Player Identity, and Player Position information flow to the lower level through DBUS. BUG=b:147365563 Cq-Depend: chromium:2067192 Change-Id: Ib6255a455d97200ba1c7ee2fadb6905f5a6b46d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069273 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Auto-Submit: Michael Sun <michaelfsun@google.com> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744071}
-
Tom Anderson authored
The new constants are necessary because GTK differentiates between dropdowns (which it calls comboboxes) and menus. On the Ambiance theme (the default on Ubuntu), dropdowns are light but menus are dark, so this change is necessary for consistency with GTK apps. BUG=914974 R=pkasting Change-Id: I4805526eee93322c4e7d57b879e0528b0998c933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069021 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#744070}
-
Chong Gu authored
Create exceptions so that the CI Fuchsia bot does not run the test suites yet. Bug: 1054545 Change-Id: I27e777ac691d290c2ce3f9ce9a4c6b4573e1f5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067451Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#744069}
-
Bruce Dawson authored
Numbers like 0xC0000005 and 0x80000003 are easily recognizable in hex (access violation and breakpoint respectively) but confusing and unrecognizable in decimal. So, print these in hex. This change is based on crrev.com/c/1962589 Bug: 803617, 1007013 Change-Id: I53db7e6cadaaa41315180021bcaff84f540de990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067652Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#744068}
-
Patrick Monette authored
Bug: 1048332 Change-Id: Ic8da15679fdc89ee4304a28ec14ca235618ae07b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065311 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
-
Peter Kasting authored
Create(Default,Square)InkDropHighlight() are never called. Removing these removed the only caller of set_explode_size(), which meant the explode size was always the same as the nomal size. This in turn allowed removing the scaling transform machinery. Bug: none Change-Id: I63e6dca81db75ec16d2d1c079de4bdc0e6589625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067550Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#744066}
-
Sergey Poromov authored
This reverts commit ecf7a6f3. Reason for revert: Chrome OS side CL (crrev/2043892) not landed yet. Original change's description: > Drop "enterprise.owned" install attribute support. > > |enterprise.owned| == true is the same as > |enterprise.mode| == "enterprise" || > |enterprise.mode| == "enterprise_ad" || > |enterprise.mode| == "demo_mode" from M19: > https://crrev.com/9403010 > > All such old devices (pre-2012) are EOL: > mario(56), alex(58), zgb(58), lumpy(65), stumpy(65), > snow(75), parrot(69), stout(69). > So we effectively can deprecate the field. > > See https://crrev.com/c/2043892 for Chrome OS change. > > TBR=antrim@chromium.org > > Bug: 725918 > Test: Unit tests updated. > Change-Id: I9c07991d09d1016b819015e5b8a3157de5d24e12 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043836 > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Igor <igorcov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742162} TBR=antrim@chromium.org,emaxx@chromium.org,igorcov@chromium.org,poromov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 725918 Change-Id: Idd957178e2170afc59f55cb84086127ee227bf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070164Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#744065}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings multidevice page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I706428944be8facb40b69ebb4eea0ff6e77cda1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067677 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#744064}
-
Xinghui Lu authored
Move url_lookup_service to UI thread because it is now managed by keyed service on a per profile basis. Obtain it at chrome level and pass it to the caller in IO thread. The caller will hop to UI thread if real time url lookup is enabled. Previously url_lookup_service is managed by database_manager. Remove this dependency in the CL. The next step is to clean up the parameters passed into safe_browsing_url_checker_impl. Since each profile has its own url_lookup_service object, their dependencies such as identity_manager and cache_manager can be self-contained in url_lookup_service. For more details, see: go/chrome-protego-refactor-profile. Bug: 1050859 Change-Id: Ie42ba990be6f83c02382d33dad684ecb4de6a335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049027 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744063}
-
Patrick Monette authored
Bug: 1041093 Change-Id: Idc9c23461a794c736f230d79391f7f37e738f8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065313 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#744062}
-
Varun Khaneja authored
Bug: 963165 Change-Id: I782470e37747c460da3ba167a966af6d21023306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069478 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744061}
-
bttk authored
The previous patch missed a file. See: https://chromium-review.googlesource.com/c/chromium/src/+/2019479 Bug: 1046181 Change-Id: I3b8f76acd34adb61430b134eedd82e460e49827c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067931Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#744060}
-
Piotr Bialecki authored
This adds logic into the ArImmersiveOverlay to keep track of multiple pointers present in MotionEvent & propagates this information to ArCoreGl. ArCoreGl will still send only the touch event information about the primary pointer to the renderer. Part 1/2(?). Changes: - ArImmersiveOverlay now keeps track of the state of all the pointers. - Switch ArImmersiveOverlay to use MotionEvent.getActionMasked() - some ACTION_* values contain pointer information that need to be discarded for the purposes of comparing with ACTION_* constants. - Propagate the information about primary pointer and pointer id from ArImmersiveOverlay to ArCoreGl through OnScreenTouch. - ArCoreGl now maintains an unordered map from input source ID to event data, and from pointer id to input source ID assigned to it. Pointer IDs are recycled by Android when it passes MotionEvents to the application - ArCoreGl ensures that the input source IDs are assigned appropriately. Bug: 1048329 Change-Id: I8834adfc5b601eb883993114636b551fe0bf8fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067538 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#744059}
-
Jiawei Li authored
In certain cases, second DidStartNavigation event will occur prior to prior navigation's DidFinishLoad, leading to that CastWebContentsImpl would drop second main frame loading event. DidStartNavigation -> DidStartNavigation -> DidFinishLoad -> DidFinishLoad. (LOADING->ignore same LOADING -> LOADED -> IGNORE SAME LOADED event). Ignored event won't be broadcasted to CastWebContents::Observer. BindingsManagerCast might not work as intended under this specific circumstance. To resolve that, another page loading notification should be added on ReadyToCommitNavigation. Bug: Internal b/149898650 Test: Verified with manually build. Change-Id: Ie119b21495fde6db7b4dd24515ceac3a080c5166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067870Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#744058}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/02497d40161f..659cc1c90705 git log 02497d40161f..659cc1c90705 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 herb@google.com Make the strike cache hash table own the strike 2020-02-24 robertphillips@google.com Remove SkDDLTmpRedirect.h 2020-02-24 dmazzoni@chromium.org Allow passing multiple node IDs per PDF structure node. 2020-02-24 bsalomon@google.com Fix GrTextureEffect with kRepeat/kRepeat/kBilerp. 2020-02-24 jvanverth@google.com Reland "Create D3D device and queue" 2020-02-24 jcgregorio@google.com [assets] Add CockroackDB as an asset for testing. Created with: gclient setdep -r src/third_party/skia@659cc1c90705 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:607777 Tbr: jlavrova@google.com Change-Id: I0970029a43a5ebe58681d57d2be2b09c28099cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069334Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/33466973bc4c..1249ada986fc git log 33466973bc4c..1249ada986fc --date=short --first-parent --format='%ad %ae %s' 2020-02-24 cwallez@chromium.org Vulkan: Load promoted extensions or core entrypoint as needed Created with: gclient setdep -r src/third_party/dawn@1249ada986fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I313dc996811446d08e11e6ef88e5d22e7eaa5573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070323Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e0897515da03..b3a40936b9f0 git log e0897515da03..b3a40936b9f0 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 brcui@microsoft.com Add high contrast support to the What's New tool (Help module) Created with: gclient setdep -r src/third_party/devtools-frontend/src@b3a40936b9f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib54a9140c354e8eb4ce8731be88e544f16f8126c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069049Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/207c622c1ef0..fd7c149eef90 Created with: gclient setdep -r src-internal@fd7c149eef90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040143,chromium:1041701,chromium:1050094,chromium:1054683 Tbr: jbudorick@google.com Change-Id: I31bc04afc7c5ce844001cbdb3f85234a73deadbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069047Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744054}
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: Ia34aad31bf40f5ba5dfbfa52c41982666b3335d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066791 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#744053}
-
Sebastien Marchand authored
This removes several entries from fieldtrial_testing_config.json for features that are in the FEATURE_ENABLED_BY_DEFAULT state. Methodology: - Make a script that list all the features listed in fieldtrial_testing_config.json - Run git grep for all these features in the chrome codebase, save the first line of the output in a file (this could be improved for features that wrap over multiple lines). - Find the line containing FEATURE_ENABLED_BY_DEFAULT, check if the entry is trivial (no param changes etc) and if the feature isn't behind a #ifdef block, remove it if it sounds safe. A follow up CL will remove all entries that don't have a corresponding feature in the codebase. Bug: 1053702 Change-Id: Ifb526b74d988bdf18f8997f536463956a4d9578e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062697Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#744052}
-
Victor Costan authored
This CL fixes all currently-enabled clang-tidy warnings in //content/browser/appcache. The main benefit here is to prevent distractions while pursuing further refactoring in AppCache. This CL introduces no functional changes. Change-Id: I81176a48ac8a3362d75cdde6672e462590cb397f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069849 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#744051}
-
Kramer Ge authored
This reverts commit a799e280. Reason for revert: <Android crashes blocking M-82 crbug.com/1055463> Original change's description: > Release GrContext during OnBackgroundCleanup on low end device > > To reduce Gpu memory on low end device, GrContext and associated > resources should be released. Abandoning GrContext directly results > in resources associated to theVkDevice becoming lost. It's preferable > to destroy entire vulkan context during background cleanup and > re-initialize when chrome is foregrounded. > > Bug: 1048692 > Change-Id: I6bb0740edee72413f0ac083d847d06e4427133ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047828 > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742815} TBR=penghuang@chromium.org,fangzhoug@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048692 Change-Id: Ice1010228ccade56edbb4b3a7b54ba40cbd8dd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070663Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#744050}
-
Dale Curtis authored
Now that all processes which can launch from the zygote are doing so, we should ensure future launchers are safe by default and that exceptions are intentional. Additionally adds file://sandbox/OWNERS for relevant files. Fixed: 22703 Test: All existing tests pass. Change-Id: I188f4314fbf5cf4659bf555b14b572f657a8720c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067541 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#744049}
-
Jan Wilken Dörrie authored
This change implements StartBulkLeakCheck() and StopBulkLeakCheck() in the BulkLeakCheckServiceAdapter and makes it listen to the OnEdited() event issued by the SavedPasswordsPresenter. Bug: 1047726 Change-Id: I043edbdcaf901eff784ffe1d7740fedfee462d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070198 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#744048}
-
