- 28 Jul, 2020 40 commits
-
-
Ben Pastene authored
Backlog of tasks is too large, we need to shed some load. Bypassing the CQ freeze to fix the CQ... sigh. TBR=martiniss No-Try: true Ignore-CQ-Freeze: true Bug: 1109999 Change-Id: Icea0bd75b11115cc44e8fe829f177951d3227eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324642Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#792352}
-
Anastasiia N authored
Currently GetInstance() has a DCHECK for the instance pointer and CreateInstance() overrides the current pointer, so there is no way to check if CreateInstance() was already called. We need to get a pointer to TestNetworkConnectionTracker in IdentityTestEnvironment. Since some tests create it (e.g. if they use TestingBrowserProcess) and others don't, we need a way to know if CreateInstance was called. Bug: 1068240 Change-Id: I99bb1dc64a170203beaae71d76de73d0b4483af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307249 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#792351}
-
Tommy Li authored
Fixes a layout bug with the suggestion button view, see the bug for screenshots. I'm not sure if this fixes all instances, but this fixes at least one. Bug: 1091354 Change-Id: I3e98c9f7ba6aeec24561ad377d6bde484a2fd12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321145 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#792350}
-
Devlin Cronin authored
ScriptContext::GetEffectiveDocumentURL() is used to 1) Classify javascript contexts (e.g., associating about:blank frames with an extension context), and 2) Determining an "effective" URL for script injection (to allow content scripts to run in about:blank frames if an extension has access to the parent). However, these have different traits. For instance, for case 1), we don't want to consider sandboxed frames (which cannot access their parent frames) - a sandboxed frame should not inherit its privileges. But for case 2), we want to consider sandboxed frames, so that content scripts can run in these. Split ScriptContext::GetEffectiveDocumentURL() into ScriptContext::GetEffectiveDocumentURLForContext() and ScriptContext::GetEffectiveDocumentURLForInjection() to account for these differences; this fixes an issue where scripts wouldn't correctly inject in sandboxed frames. Modify existing tests for both GetEffectiveDocumentURL() and injecting scripts in sandboxed frames. This also paves some more of the way to injecting in data: URLs. Bug: 1108505, 55084 Change-Id: I97707b7bba520f8177f59a4568971df543f69785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314810 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792349}
-
Ian Clelland authored
Bug: 1062400 Change-Id: I787f4996c76946b53e67122672ef085036ee33c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323821Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#792348}
-
Avi Drissman authored
If another channel of Chromium is already default, don't ask to become default. This re-lands e2d335fb with a fix. Bug: 1109417 Change-Id: Ib0c699ebbbc15e0bb636f6d49ea6082c3208f423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323824Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792347}
-
Nnamdi Theodore Johnson-Kanu authored
References to assertNotReached() cause closure compilation to fail for code using JS modules. This CL removes these generated calls at the top of the files, and replace the calls serving as placeholders with empty implementations. Updates were generated using a script ./tools/json_schema_compiler/compiler.py \ chrome/common/extensions/api/quick_unlock_private.idl \ --root=. --generator=externs > \ third_party/closure_compiler/externs/quick_unlock_private.js python tools/json_schema_compiler/compiler.py \ chrome/common/extensions/api/quick_unlock_private.idl \ --root=. --generator=externs > \ third_party/closure_compiler/externs/quick_unlock_private.js Bug: 1045266 Change-Id: Ib4fa9a09a985e08eccc5834241f308b651efff6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314812Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#792346}
-
Dylan Cutler authored
last_access_time. Bug: None Change-Id: Ic3709bc975dac8d7ffa1bcba0451e92364433943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321348Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#792345}
-
Charlene Yan authored
Bug: 1110108 Change-Id: Ie23896b56983ec165180e4f02deddce7bdd9d735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321530 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792344}
-
Matt Mueller authored
Bug: 1108632 Change-Id: Ia1ab7aaabe38f5c9d15fcb781768fae29b59c716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321555 Commit-Queue: Matt Mueller <mattm@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792343}
-
Evan Stade authored
Bug: 1007823 Change-Id: Ie9c7bb8db921ff4723dbb913c7010da3f0b90110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304721Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#792342}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a3b0adc306c5..150be20d4334 2020-07-28 andreperezmaselco.developer@gmail.com spirv-fuzz: Add condition to make functions livesafe (#3587) 2020-07-27 rharrison@google.com Rolling 4 dependencies (#3601) 2020-07-27 andreperezmaselco.developer@gmail.com spirv-fuzz: Implement the OpTranspose linear algebra case (#3589) 2020-07-27 rdb@users.noreply.github.com Fix SyntaxWarning in Python 3.8 (#3388) 2020-07-27 bclayton@google.com CMake: Enable building with BUILD_SHARED_LIBS=1 (#3490) 2020-07-27 dneto@google.com Avoid operand type range checks (#3379) 2020-07-27 jaebaek@google.com Preserve debug info in scalar replacement pass (#3461) 2020-07-27 pierremoreau@users.noreply.github.com Update OpenCL capabilities validation (#3149) 2020-07-27 stevenperron@google.com build(deps): bump lodash from 4.17.15 to 4.17.19 in /tools/sva (#3596) 2020-07-27 antonikarp@google.com spirv-fuzz: adds TransformationReplaceLoadStoreWithCopyMemory (#3586) 2020-07-27 jaebaek@google.com Preserve OpenCL.DebugInfo.100 through private-to-local pass (#3571) 2020-07-27 stefanomil@google.com spirv-fuzz: Relax type checking for int contants (#3573) 2020-07-27 stefanomil@google.com spirv-fuzz: Generalise transformation access chain (#3546) 2020-07-27 stefanomil@google.com spirv-fuzz: Split blocks starting with OpPhi before trying to outline (#3581) 2020-07-27 afdx@google.com spirv-fuzz: Set message consumer in replayer when shrinking (#3591) 2020-07-24 vasniktel@gmail.com spirv-fuzz: Don't use default parameters (#3583) 2020-07-23 rharrison@google.com Change DEPS rolling script to point at external/ (#3584) 2020-07-23 vasniktel@gmail.com spirv-fuzz: Create a helper in fuzzerutil to reuse function type (#3572) 2020-07-23 vasniktel@gmail.com spirv-fuzz: Test usages of IdIsIrrelevant fact (#3578) 2020-07-23 antonikarp@google.com spirv-fuzz: adds TransformationReplaceCopyMemoryWithLoadStore (#3575) 2020-07-23 antonikarp@google.com spirv-fuzz: adds TransformationReplaceCopyObjectWithStoreLoad (#3567) 2020-07-22 stevenperron@google.com Start SPIRV-Tools v2020.5 2020-07-22 stevenperron@google.com Finalize SPIRV-Tools v2020.4 2020-07-22 vasniktel@gmail.com spirv-fuzz: Fix usages of irrelevant constants (#3566) 2020-07-22 stevenperron@google.com Update CHANGES 2020-07-22 alanbaker@google.com Support SPV_KHR_terminate_invocation (#3568) 2020-07-22 stevenperron@google.com Sink pointer instructions in merge return (#3569) 2020-07-21 greg@lunarg.com Preserve OpenCL.DebugInfo.100 through elim-dead-code-aggressive (#3542) 2020-07-21 vasniktel@gmail.com spirv-fuzz: TransformationReplaceParamsWithStruct (#3455) 2020-07-21 38144211+vkushwaha-nv@users.noreply.github.com Add changes for SPV_EXT_shader_atomic_float (#3562) 2020-07-21 vasniktel@gmail.com spirv-fuzz: Use irrelevant constants (#3565) 2020-07-21 stefanomil@google.com spirv-fuzz: Extend TransformationRecordSynonymousConstants to allow composite constants (#3537) Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers from ac638f181542 to 979924c8bc83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: I4409d7670e9ddcd4cec62cdaf945b69b10e4d4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792341}
-
Xiaohan Wang authored
This ID is not needed since there's a strict 1:1 mapping between the media player (Renderer) and CDM in Chromium. Bug: 999747 Change-Id: I5cbe7346a29d2ef47be3c307e508db037c71b102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314668Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#792340}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/75770d6f7f01..9cbd788e95fc 2020-07-28 janscheffler@chromium.org Migrate `front_end/js_main` to `devtools_entrypoint` 2020-07-28 alexrudenko@chromium.org Move inspector_overlay test files into debug/ 2020-07-28 aerotwist@chromium.org Migrate protocol_client to devtools_entrypoint 2020-07-28 janscheffler@chromium.org Migrate `front_end/ui` to `devtools_entrypoint` 2020-07-28 jobay@google.com Introduce custom query handlers for piercing shadow dom 2020-07-28 changhaohan@chromium.org Add persistent grid overlay and hook up with Grid adorner 2020-07-28 pfaffe@chromium.org Support location information with missing column information 2020-07-28 janscheffler@chromium.org Add _sources suffix to ensure sorting in .gni files 2020-07-28 jacktfranklin@chromium.org Include nested interfaces when extending types 2020-07-28 leese@chromium.org Support organizing variables into namespaces 2020-07-28 jacktfranklin@chromium.org Migrate text_editor and cm to devtools_entrypoint 2020-07-28 jacktfranklin@chromium.org Make cross-reference script show errors If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356,chromium:1056264,chromium:1066772,chromium:1101738,chromium:1109784 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I95d5aea4b84fc24a6e8dcac4348c3b6774bc7458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323247Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792339}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 142 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-01-24. TBR=chromium-metrics-reviews@google.com Change-Id: I97e400a6d8580a97400e53bf64f4bac778fcd7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323861Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#792338}
-
Ayu Ishii authored
This updates CookieStoreAPI to return EffectiveSameSite across all of its endpoints. If EffectiveSameSite is not available it will fall back to using SameSite. Bug: 1065010, 1092695 Change-Id: I26b0dd8e9ccbf3a57c3eef1a828d94fb4ce14568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295927 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#792337}
-
Kyle Horimoto authored
Searches for cellular queries lead users to the cellular details page. Before this CL, we assumed that all searches for items on the details page were for connected networks, but cellular is a special case, since it allows users to change settings on the page even while not connected. This broke an assumption in internet_section.cc which can trigger a crash. Note that this issue is not present on devices without cellular capabilities (i.e., the vas majority of devices). Bug: 1110200 Change-Id: If7de36f358d3b92ca22191a5b8433cd2cd35743f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323723 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792336}
-
Sonny Sasaka authored
The ID from /sys/class/power_supply/hid-{btaddr}-battery is already in the correct order so there is no need to reverse it. Tested with Apple Magic Mouse. Bug: b:161733238 Change-Id: Iad98f1ba016fee70f4fa9b2280f975dacf24bea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308855Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#792335}
-
Antonio Gomes authored
This CL complements https://crrev.com/c/2307152, where blink::mojom::RemoteMainFrame was introduced. The missing bit was the plumbing in RenderFrameProxy::OnAssociatedInterfaceRequest(), where the mojo interface is registered. BUG=1102440 R=haraken@chromium.org Change-Id: I47567ca0f865e3868bb32f726b1fc09c738900ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323136 Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#792334}
-
David Maunder authored
As part of migrating tab fields to CriticalPersistedTabData the observers need to be moved as well. CriticalPersistedTabDataObserver has been created to this end and and onRootIdChanged has been moved to CriticalPersistedTabData. setRootId is also moved out of TabImpl to CriticalPersistedTabData Bug: 1091802 Change-Id: I79d9863f870d533547608a3a64a82623acc84cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313300Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#792333}
-
Sophey Dong authored
Bug: 1079467 Change-Id: I91e227f2cfc8617548d006c42a0c136e31854b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308943Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#792332}
-
Ben Joyce authored
Enables on the fly code coverage and then appends those results to the end of the instrumented code coverage report. Bug: 1107004 Change-Id: I68b4d78fb6d04d0e9348601663526c21e7c73b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315930 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#792331}
-
Tommy Li authored
Currently they are expiring with M85. We aren't ready to get rid of them yet. Extending to M95. Bug: 1089190 Change-Id: Ifecbcb559144104da0a0c5db0587ee8b5d16dde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321564Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#792330}
-
Sonny Sasaka authored
This refactors the code to use make_unique when creating unique_ptrs. Bug: b:160905767 Change-Id: I9273dacbff86d5ba82c97be550b209515c73c02e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315484Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#792329}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d292e89bd75a..608ea4a3dcd9 2020-07-28 rmcilroy@chromium.org [Telemetry] Add android-chrome-64-bundle to browser types. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: eseckler@google.com Change-Id: I6e5513c536a69f103884f66fc5257710708077f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792328}
-
Andy Lu authored
completion should be called in every branch of the function, and it was not in this one, which is a bug. Separated out from CL: https://chromium-review.googlesource.com/c/chromium/src/+/2236243 so that in case of reverting, this change can stay. Change-Id: If1cf0522b492e8c240253e89432f16d21916da70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320133 Commit-Queue: Andy Lu <andyhylu@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#792327}
-
Sami Kyostila authored
This patch fixes raciness and thread safety issues in NestedMessagePumpAndroid by reimplementing it on top of the regular MessagePumpAndroid. This allows us to remove the complicated 100ms timeslicing logic between Java and C++ tasks and just share the underlying Looper directly. Bug: 872269 Change-Id: Id5f5e42f2dac6f065769d69743d78b1fb04bb916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207171Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#792326}
-
Caitlin Fischer authored
Also, remove code that logs the histograms and add an owner. Bug: 1110301, b/162309838 Change-Id: I2ac0f064cfe5195640cd87e279195b5d8307582d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323137Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#792325}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 21e6c4e1. With Chromium commits locally applied on WPT: 051a934d "Reland "Reland "Do not expose media devices before a successful getUserMedia()""" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I4b677024dfc032e99e550f5205d25c058f66fcf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323661Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792324}
-
Yann Dago authored
Bug: 1095226 Change-Id: I3c9cdb97eade7d967a434dd252487b1548021e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317568 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792323}
-
Zarah Tesfai authored
Purpose: Move payment files to components/ to be used for //weblayer. Change: * Move WebPaymentIntentHelperTypeConverter to /payments/intents * Move CanMakePaymentQuery to /payments * Edit dependencies and targets according to new paths Bug: 1098482 Change-Id: I31ec8ef883522237df49acece0f6108921016ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310922 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#792322}
-
Mustaq Ahmed authored
This is not used anywhere. Change-Id: I6e4adf739264a0a6bbd1f8c8a8910f3a07d680c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321068Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#792321}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I1a6b5ac999468514c9f269cbdbe22ca3000dcd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792320}
-
Vasiliy Telezhnikov authored
Before https://crrev.com/2302924 we would exit the process on context immediately, so it wasn't problem. Now MarkContextLost abandons GrContext, so we need to abort draw here. Bug: 1109601 Change-Id: I649dffb065fa28a689279e6c8f6619bd9ec29516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323132Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#792319}
-
Katie D authored
Check if the top center of a window is visible before moving SA focus to that window. It's still possible to end up at an occluded window when restoring SA focus from history, or by going to firstValidChild. We could add an eventhandler to the desktop or a repeated interval to each window node child to check for occlusion. This is left as a TODO. AX-Relnotes: N/A Bug: 1106080 Change-Id: Ib88d53a3b18b8c9f5da2403b61d1624e1258014c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318245 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#792318}
-
Olivier Robin authored
Note that this CL will make autofill follow the keyboard focus. But due to a bug in keyWindow system, this may not be the last webState that was focused on iOS13. See crbug.com/1109124 for details. Bug: 1106743 Change-Id: Ie9e8eccbca6ce0c139fcac423a1ef64adcb70612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316579Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792317}
-
Renato Silva authored
Enterprise Enrollment will be skipped and the normal Gaia login will be shown if enrollment was advertised, but isn't mandatory. Bug: 1084442 Change-Id: Ia26d75ebb85eec21942702d43b182b337b4ac858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279891 Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#792316}
-
dpapad authored
Bug: 1101598 Change-Id: I8a7286166fb204aaaab51fad66d9e1bf398f7047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321147 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#792315}
-
Mehran Mahmoudi authored
This adds a finch-controllable delay before removing the paint preview player on tab first paint, for startup experiment. It also increases the snackbar duration from 5 to 8 seconds. Bug: 1110360 Change-Id: I46d12eae990be2695af4ae7ca2ca27eb28f70902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323822Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792314}
-
ckitagawa authored
Additional clients are interested in using the paint preview capture pipeline for other usecases. Some of these do not require link capture. This CL makes link capture optional. It also fixes a small bug where capture size restriction only applied to the main frame. Bug: 1109775 Change-Id: I0b0921537f50ebc6d49a3f6c977ec4b909855d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320628Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#792313}
-