GitLab

Bug: 992597
Change-Id: Id18b03656b8cacac0d4a815d0602dfb4ec51a5ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761427Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#688621}

Allows to import from the core module in tools/perf without bringing
the whole of Telemetry as a dependency.

This will be particularly needed by the results_processor, to be able
to run it on a separate swarming task from where Telemetry ran.

Should be safe to land after all impacted scripts have been updated in:
https://chromium-review.googlesource.com/c/chromium/src/+/1760218

Bug: 981349
Change-Id: I75898455c3f261859ec2fe3d2cba2248c8b3ef17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762070
Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688620}

- Changes SerializedData return type to base::span<const uint8_t>. The
  old type, Vector<const uint8_t>, forces a copy. Changing to span will
  enable us to avoid copying cached code as it's passed from the browser
  via a mojo_base::BigBuffer. Eventually, we'll be able to move the
  BigBuffer to CachedMetadata.

Bug: chromium:992991
Change-Id: Ic4ac00282f3e0346649a1266e33cb57e1b40551a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758727Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688619}

This is an attempt to reduce heap usage in merges.

BUG: 982452
Change-Id: If17dad64ab8adde29384765720c210e7f5e72601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762083Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688618}

Bug: 927957
Change-Id: I5919885840a41ffec4e458382158aa40747bd64c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760420Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Felipe Cerqueira <cerqueira@google.com>
Cr-Commit-Position: refs/heads/master@{#688617}

This service is run in the GPU process and its interfaces are bound only
by the browser, brokering unfiltered requests from renderers. Logic is
simplified by removing all dependencies on Service Manager APIs, in
favor of the browser's brokering logic talking directly to
GpuProcessHost and maintaining a persistent connection to the service.

Bug: 977637
Change-Id: I9047889de659b8ff61df4bae40867d3b81d8127f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761689
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688616}

These events got moved to the "fonts" category.
They are currently dropped and not visible in slow-report traces.

R=oysteine@chromium.org

Bug: 867931
Change-Id: I8940165b5196f074cac9735057ff60b129015cef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758340Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688615}

This is a reland of https://crrev.com/c/1648886

It was reverted due to a crash in a non-cq bot, see https://crbug.com/976331.

Patchset 1 shows the original patch and the specific non-CQ bots that failed on them are red.

Patchset 3 has the fix, and shows that the bots are now green.

I believe the bug is related to oilpan memory management in the custom struct I created. So instead I used a simpler std::pair to hold the callback and AsyncTaskId.

TBR: pfeldman@chromium.org
Bug: 851531
Change-Id: I625dacd61ea663097605df1f10e26baa58ce07c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761289
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688614}

Existing print_job_unittest doesn't need print_preview and add
a trivial unittest for PrintViewManagerBasic to exercise the code.

Bug: 993255
Change-Id: I2897c4cf9e46fbfc893a5868a544c5757efd6295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757022Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Joel Klinghed <the_jk@opera.com>
Cr-Commit-Position: refs/heads/master@{#688613}

Avoid potential unnecessary copies by using emplace consistently.

No intended functional changes.

Bug: 995605
Change-Id: I4e937338a05e6f7322d2813f2f633f0037cd4b67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761649Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688612}

The `CreateNextWord*Position` functions were not updating their iterator
in certain edge cases, which caused an infinite loop.  (Notably, the
`CreatePreviousWord*Position` functions *are* updating their iterators
in the same scenarios.)

The new test included in this change would hang before the fix.

The following is a detailed description of the error scenario:
-- Start with a AXTextPosition (at index 0) at a high level in the tree.
-- Call one of the `CreateNextWord*Position` functions.
-- These functions start by getting a "leaf" text position, which drills
   down deeper in the tree.  Specifically, they drill down into a node
   that includes placeholder text (which appears as part of their
   hypertext, but not in the hypertext of the outer node).
-- The function then tries to advance to the next word, and finds a
   valid word stop.
-- The end of this loop compares the new position against the original.
-- operator==/CompareTo must adjust the positions to be relative to the
   same node, which it does using repeated calls to GetParentPosition().
-- GetParentPosition() determines that the text-offset in the deep node
   is not valid in the outer node, so it resets the index to zero.
   (This workaround was added in CL:1661548.)
-- As a result, CompareTo determines that the two nodes are equal.
-- Therefore, we loop in CreateNextWord*Position.
-- Because the iterator was not updated, we loop infinitely.

Bug: 994871
Change-Id: I6e5880bfa7073e2ca672d281fca223e90e5fe288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758590Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Ian Prest <iapres@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#688611}

This CL moves the permission checks that used to exist in the
ExtensionTabUtil::ScrubTabForExtension method into its own util method
so that the level of scrubbing of data that needs to happen can be
determined in the context from which it is requested. This will
ultimately help in allowing WebUI to get non-scrubbed data.

Bug: 994337
Change-Id: I6c7cd37b1cb0f64233759ccac7aa9b8097234482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755052
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688610}

It returns the matrix with transform origin applied. Useful where we
want to get whole matrix that this transform node will apply.

Also fix a bug in CullRect::ApplyTransforms() where we missed the
origin.

Change-Id: If671470a5c9ea0e8a46e128692862bb0779d005f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757081Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688609}

We were showing the nav widget in the right conditions, but we were
not hiding it aggressively enough.

Add tests to prevent future regressions.

BUG=992336

Change-Id: I4d19473f514b8979c940daa008e16a43e3de9773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761492Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688608}

This CL adds NetworkIsolationKey as an argument to H2-support-checking
methods in HttpServerProperties, and makes consumers pass in the correct
key.

Bug: 969890
Change-Id: I8ea06693a470eef3ca24ec8d269ce5ac131e312f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753807Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688607}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5c6b118c..f624b9be

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0032e6229b83cf1202e7c5a5063e2ac6c3995e91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757862Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688606}

Bug: 994291
Change-Id: I48fe790dbf6c686e83264b638b0b031eb801d626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762239Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688605}

Bug: 900706
Change-Id: Id3940f6d3321f22159a577e3634ea926f6870b04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755409
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688604}

Add three bots to CQ for any changes to sandbox/win:

 * win-asan
 * win10_chromium_x64_dbg_ng
 * win7-rel

This is because any sandbox changes can be particularly sensitive
to OS version/configuration.

BUG=750886

Change-Id: I4ff315f65e220591a0835069342b51ab2549d183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762384Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688603}

... with translations: origin and post_translation.

This reduces the size of TransformNode by 108 bytes.

Bug: 993937
Change-Id: I52b60dfba9a34b1062960cbd78a9bababd0e6a1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759891
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688602}

TBR=marinaciocea@chromium.org,robertma@chromium.org

Bug: 995817
Change-Id: I854a366775f515744bc9422cf5e58c16a99fa25a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762350Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688601}

Bug: 992491
Change-Id: Icf791568a56e5dafb9f280021aad4a0742520fe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733726
Commit-Queue: Anne Lim <annelim@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#688600}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: I0de7982a275451bcc781621c8fae884d9ddb66de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700942
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688599}

Using wpt-import in Chromium 3fb589c1.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
iclelland@chromium.org:
  external/wpt/feature-policy

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Ib5b023b71030a64d76e1403dc27ce60a8f8d73ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762408Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688598}

This is a reland of d9dbade3

Original change's description:
> [Traffic Annotations] Run extractor.py on waterfall
> 
> linux-annotator-rel and win-annotator-rel will now test traffic
> annotations with extractor.py, as well as the clang tool.
> 
> Also updates a traffic annotation in management_ui_handler.cc, since
> extractor.py doesn't understand #ifdefs. As a workaround, this
> CrOS-specific annotation is moved to a CrOS-only file.
> 
> TESTED=
>   Ran traffic_annotation_auditor_tests.py locally, excluding the
>   --no-filtering configs.
> 
> Bug: 966883
> Change-Id: I7848877f67635b50d8ce2a841019e49136a33b11
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692970
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#675994}

Bug: 966883
Change-Id: I5d3275315565b0592c86feedb564fa5cbf154e4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761146Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688597}

Update the description string shown for `File editing` on
chrome://settings/contents.

Bug: 992175
Change-Id: I88d6283d8b481989f2af8cd24e20fc560f1b9c23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760962Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Auto-Submit: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688596}

Make RenderingContext::IsOriginTopLeft() the source of truth for flip-y
state and update the associated pixel test to verify this.

This fixes incorrect rendering of low latency canvas2d on Windows since
CanvasResourceProviderSharedImage started being used.  This resource
provider doesn't support single buffering mode if overlays aren't being
used which is what caused the flip-y state to be inconsistent.

Also includes minor cleanup in CanvasResourceProvider to store important
state in the base class instead of duplicating in many subclasses.

Bug: 994866
Change-Id: Ia955bfa87380ecfb3772b017528434182cbd391a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759214
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688595}

It's unused. This CL is a refactor with no intended behavior change.

Bug: 994926
Change-Id: Ied6ff61da33b3f69b1cd49ffb310fe4e0668c192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761261
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688594}

Bug: 988461
Change-Id: I86be68ebf6ad07bf680f11c49864a4ccb056e19e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761276Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688593}

Screenshot (<1024px) : http://screen/ktdXzvCgc0c
Screenshot (<512px) : http://screen/kPDKQRi0dyo

Bug: 994545, 993915
Change-Id: Iecf2c2c7865e9d8aaf905fe43124193f03b2beda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757290
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688592}

Bug: 993962
Change-Id: Iaa4ada2faf2384a4bdb142756bece266d80fddd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761297
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688591}

This CL updates the expiry milestone for the GPU AppContainer flag to
M82. While this file is being modified remove the entry for the old
renderer AppContainer flag which has already been removed from the
codebase.

Change-Id: I75ddee725bc86a1ed0a6063b77a9c2e4c56bf4eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758342Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688590}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b88012e339bf..7a6df9bfe5fd


Created with:
  gclient setdep -r src-internal@7a6df9bfe5fd

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: I576796369c22bec219158b991358e2fa9f5e85a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762270Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688589}

Enable openxr input tests in webxr_vr_input_browser_test.cc by changing
tests using IN_PROC_MULTI_CLASS_BROWSER_TEST_F2 to
WEBXR_VR_ALL_RUNTIMES_BROWSER_TEST_F.

Bug: 992575
Change-Id: I1799b3c332424530b16e1f865b0785aa51755639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744675
Commit-Queue: Zheng Qin <zheqi@microsoft.com>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688588}

This test is still flaky. crrev.com/c/1760892 didn't disable it correctly.

TBR=eirage@chromium.org

Bug: 995285
Change-Id: I1459e5a753d9e2435393242a990c20741be77a91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761637Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688587}

This is for test only.

Bug: 993298
Change-Id: I1ad64dc60828040403be5bc0e8265d89c1ddf60c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757311
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688586}

both for implementors and users. The previous version used out parameters
combined with usual net style maybe-async methods, which were also cancelled
if the backend was destroyed. This has caused multiple complexities:
1) Managing lifetime of the place where the out parameter is written to is
   messy for the client.

2) The cancellation requirement on the backend is a bit tricky since it needs
   to post asynchronously, so there are multiple ways of getting it wrong and
   either overruning the lifetime of target pointer or leaking a pointer that
   shouldn't leak, and I think I did pretty much all of them?

3) (This was pointed out by comments in CacheStorage code): if the callback to
   is  bound to a weak pointer, then it was very easy for just-opened entries
   to leak if the destination became null.  This was a problem before CL internally in
   SimpleCache, and despite having these helpful comments on some ops, CacheStorage
   had it wrong in others. GeneratedCodeCache (which I reviewed, *cough*, *cough*),
   had that leak. I think the HTTP and shader caches might have been the only places
   to get it exactly right...

So instead, return / pass to callbacks a move-only EntryResult type which owns the
entry until it's released from it.  This type still has a net error code, so
the pending pattern still largely follows, but there are no longer any out pointers,
and if a callback is cancelled the entry gets closed.

Bug: 586174
Change-Id: I9b747766dff0b3cad031a1e04658ea7ad96643b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735974Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688585}

These were not being assigned to a var, so were immediately getting
destroyed. I did the same thing for one of my crash keys so thought I
would look around to see if anyone else made the same mistake.

Bug: 824649
Change-Id: Ib253e01f4eedeae8412a80fb91650639b06c84e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761014
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688584}

- This change disables non ipp/ipps protocols for autoconf printers,
  since selecting one for an autoconf printer could put the user in
  a broken state.
- Since we will disable the make/model dropdown in the edit dialog for
  autoconf printers, we want to prevent users from selecting a protocol
  that would require users to select their own PPD make/model.

Bug: 947183
Test: End to end manual, browsertest
Change-Id: I0d46626113f98a128e05cc7b6d95678e6e9301cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747148
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688583}

Just some spelling corrections.

Change-Id: I5d3105901de21b444014f599dafad74d29ea4571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761475Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688582}