GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/74096ec8f277..cd83dda45843


git log 74096ec8f277..cd83dda45843 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 hjd@google.com Unify on for (;;)


Created with:
  gclient setdep -r src/third_party/perfetto@cd83dda45843

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I7444b3208fa39e54a631954fe8bcd5a38f0bb917
Reviewed-on: https://chromium-review.googlesource.com/c/1336651Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608231}

This cl moves network icon cache purging to a new observer that is owned
by the unified system tray.

Currently there are five subclasses of
TrayNetworkStateObserver::Delegate. Every time we get a network list
update the global network icon cache is purged.
This means that for every update the cache is purged at least five
times.

With this cl TrayNetworkStateObserver::Delegate can still be used as a
simple way of subscribing to all network events without excessive icon
purging.

Bug: 902409
Change-Id: I078ac8dbdee473fc285ee8e91f735c99524c74a7
Reviewed-on: https://chromium-review.googlesource.com/c/1334835
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608230}

are changed but also when the selection is changed.

Bug: 898442
Change-Id: I927171f7ded54cad1626e367a33a900e90adc8f4
Reviewed-on: https://chromium-review.googlesource.com/c/1319211
Commit-Queue: Shu Chen <shuchen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608229}

Move input timestamps manager out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: I65e8baba6d20b726cf69fed3b90286d6ea7cd756
Reviewed-on: https://chromium-review.googlesource.com/c/1318789
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608228}

removed acceleration and rotation rate class from device motion data and put all the logic into device_acceleration and device_rotation_data class

Change-Id: If54ad00321f4fe14be4468ed3d01291af4d6c783
Reviewed-on: https://chromium-review.googlesource.com/c/1320589Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608227}

https://chromium.googlesource.com/angle/angle.git/+log/ccad5e333472..1934b786149d


git log ccad5e333472..1934b786149d --date=short --no-merges --format='%ad %ae %s'
2018-11-15 fjhenigman@chromium.org Refactor instancing tests.


Created with:
  gclient setdep -r src/third_party/angle@1934b786149d

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ibc369c9aa7e350c8a270e6cd369537a15d7b277a
Reviewed-on: https://chromium-review.googlesource.com/c/1336653Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608226}

Bug: b:119555990
Change-Id: I5c2e49fe96c4524db0fd07d2d826f9d5aaa0b48c
Reviewed-on: https://chromium-review.googlesource.com/c/1335880Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#608225}

Bug: 837381
Change-Id: I5421657d43646c768def7a5ccf235b9eb483e2e2
Reviewed-on: https://chromium-review.googlesource.com/c/1336548Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608224}

net::SerialWorker is a RefCountedThreadSafe object that also uses
WeakPtrFactory to create WeakPtrs of itself. To run whatever work it's
supposed to run, it PostTaskWithTraitsAndReply's to another sequence to
do the work there, and then gets called back when the work is complete.
The work callback holds a (refcounted) reference to the SerialWorker,
and the reply callback is bound to a WeakPtr to ensure the SerialWorker
will still be deleted if posting the reply fails. WeakPtr enforces that
all dereferences to it, as well as its invalidation, must happen on the
same sequence to avoid races. When the reply callback is being called,
it dereferences the SerialWorker WeakPtr on the original sequence,
which binds that WeakPtr to that sequence. It's possible for the
SerialWorker’s owner to release it after the WeakPtr has been checked,
but before the worker function has returned, in which case the worker
function will have the last reference to the SerialWorker. In that case,
when the worker function finally does return, it will delete the
SerialWorker, which will delete its WeakPtrFactory, which will
invalidate existing WeakPtrs. However, the WeakPtr was previously
dereferenced on the SerialWorker sequence, and now it’s being
invalidated on the worker sequence, which is invalid.

To fix this, this CL makes SerialWorker a RefCountedDeleteOnSequence to
ensure the deletion always happens in the right sequence.

Bug: 882610
Change-Id: If738d3724384ffd5ac210130415bce7262932feb
Reviewed-on: https://chromium-review.googlesource.com/c/1336066
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608223}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a878e1c2fc6..ccb751a21b7d


Created with:
  gclient setdep -r src-internal@ccb751a21b7d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8f29523afd0cb4f75f942e28a15d93fb5a245df3
Reviewed-on: https://chromium-review.googlesource.com/c/1336850Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608222}

They already start out empty by default.

Change-Id: Iccfab99f6591753b91c08fbdc1d5edc13b1fa1c5
Reviewed-on: https://chromium-review.googlesource.com/c/1335280Reviewed-by: David Jacobo <djacobo@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608221}

https://skia.googlesource.com/skia.git/+log/44764000b49c..7d2aae3165a2


git log 44764000b49c..7d2aae3165a2 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d5f1489286b8..3fc6893c8b24 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@7d2aae3165a2

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@chromium.org

Change-Id: Ifa5267e17f2bf8e0bab205dc9e4e76d1cbcd2b14
Reviewed-on: https://chromium-review.googlesource.com/c/1336649Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608220}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/88c15c341d97..ece712e727b4


git log 88c15c341d97..ece712e727b4 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 pprabhu@chromium.org chromeos_config: Temporarily drop hwtests from clapper-release


Created with:
  gclient setdep -r src/third_party/chromite@ece712e727b4

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I9b584177509c5cd7a92adfe6f3ae58d7e2b7ca79
Reviewed-on: https://chromium-review.googlesource.com/c/1336750Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608219}

Change-Id: I6d6704beaeec441a2848ce9c53e9faa6df79fdee
Reviewed-on: https://chromium-review.googlesource.com/c/1336919Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608218}

This reverts commit 41f8a81f.

Reason for revert: broke browser_tests on chrome_os, see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8900

Original change's description:
> chromeos: refactors MultiUserWindowManager into two classes
> 
> One lives in ash, the other in the browser. The one in ash is responsible
> for the actual window management and animations, the one in the browser for
> forwarding to the one in ash and caching state. I'm happy to rename these
> classes in the future.
> 
> BUG=756085,875111
> TEST=covered by test
> 
> Change-Id: I2367534e0566742f3897c69fb8ece7dfff1b1aff
> Reviewed-on: https://chromium-review.googlesource.com/c/1328567
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608022}

TBR=sky@chromium.org,afakhry@chromium.org

Change-Id: I23f7126a5ff8e897b7ad2ced79277392f771f2f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 756085, 875111
Reviewed-on: https://chromium-review.googlesource.com/c/1336792Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608217}

FilesApp OWNERS should be consulted, and also help review changes, to
the ChromeOS system modal select file dialog.

Bug: 895703
Change-Id: I4258de9c2b3bfc7e37e68b546c9e16a1395572dc
Reviewed-on: https://chromium-review.googlesource.com/c/1336952
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608216}

Not all code in the file needs to be visible to the outside. Also use
the appropriate naming style for functions.

Change-Id: I4f22df2932954b71ce65232a019cfcddd5fd408b
Reviewed-on: https://chromium-review.googlesource.com/c/1336521Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608215}

This CL:
1. Extracts logic for displaying lists of URLs (used by popup and
   redirect blocking UIs).

2. Removes a failure-case from url_formatter::FormatUrlForSecurityDisplay.
   This API should handle all cases, and other UI code does not fall back
   to using the raw URL string if FormatUrlForSecurityDisplay returns an
   empty string.

Bug: None
Change-Id: I6f610cb41b8fba85a0952bd1aae2419c23c66586
Reviewed-on: https://chromium-review.googlesource.com/c/1334414
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608214}

Creates the DemoResources class, removing the nitty-gritty details of
component loading from the global DemoSession instance.

This will make it simpler to update the offline-enrolled mode to use the
offline version of the Demo Mode Resources component. It will also allow
us to check for the existence of Demo Mode resources without starting a
a DemoSession, eg from OOBE.

DemoResources avoids using the term "offline resources" except in the
context of the preinstalled resources used in offline-enrolled Demo
Mode. General Demo Mode resources will just be called "Demo Resources"
or similar.

A follow-up change will update calls to
DemoSession::EnsureOfflineResourcesLoaded() to instead call a similar
function on DemoResources.

Bug: 904641
Change-Id: Ia931721511fac4efb9e796052bd760a87c952be9
Reviewed-on: https://chromium-review.googlesource.com/c/1333112
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608213}

This is a reland of b44653f9

Original change's description:
> viz: DCHECK that clients don't send empty frames
>
> The service rejects a CompostiorFrame if it has an empty render pass
> list, or an empty output rect.  Add a DCHECK to ensure that clients
> don't send these.
>
> Change-Id: I2a1a25fab8b2e01f5355eaf0378c98d730490863
> Reviewed-on: https://chromium-review.googlesource.com/c/1335268
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608087}

TBR=dcheng@chromium.org

Change-Id: Ia29587d7033a01bd4679bffb8a89508db01b0545
Reviewed-on: https://chromium-review.googlesource.com/c/1336373
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608212}

Move WaylandTouchDelegate out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: I8fc2cb3d52c76bdcc4d52c70e63beeb6cd403894
Reviewed-on: https://chromium-review.googlesource.com/c/1318737
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608211}

No change to logic.

This adds metrics to track the scheme passed to loadUrl(). This also
modifies our previous metric (tracking baseUrl() scheme) to distinguish
between file:///android_asset/ URLs (and android_res) from other
file:// URLs.

This treats loadData() as "data:" scheme. This intentionally excludes
loadDataWithBaseURL().

R=isherman@chromium.org, torne@chromium.org

Bug: 901581
Test: run_webview_instrumentation_test_apk \
Test: --gtest_filter=AwContentsTest#testLoadUrlRecordsScheme*
Change-Id: Ic09bf91a25ebeb7dd075337ae3e28e26e603c3ff
Reviewed-on: https://chromium-review.googlesource.com/c/1334843Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608210}

This CL adds logic for determining which URL to prefetch and records
UMA around that. Note that navigation predictor is still running in
dry-run mode, as in no prefetch is actually done.

Change-Id: I620a3c10146f47b3bd2d8b042b54af0a5879fc90
Bug: 903945
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1333247Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608209}

This preserves suppress Play Store show state in case Chrome was
restarted during the previous session and initial OptIn flow is
currently active.

TEST=Locally, simulating that case  + unit test
BUG=b:119069366

Change-Id: Ifc30bf538baf42d6b91a20d8263d90e7d8962db2
Reviewed-on: https://chromium-review.googlesource.com/c/1331829Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608208}

Bug: 900736
Change-Id: I1413bbfb052850dc6ad2e9ca7137c40d2cd978d2
Reviewed-on: https://chromium-review.googlesource.com/c/1324369
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608207}

The following elements are only used in ChromeOS, so they don't have
to be included in non-ChromeOS builds

 - iron-input
 - paper-input-container
 - paper-icon-item

Bug:843350,899982

Change-Id: I376e811a6b53fca71ea5a14df479c6f958632547
Reviewed-on: https://chromium-review.googlesource.com/c/1336189Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608206}

The logic to check if we should handle certain scrolls was moved to
shelf_layout_manager.cc in [1]. The logic remaining in
home_laucher_gesture_handler.cc is no longer needed.

[1] https://chromium-review.googlesource.com/c/1307233

Test: manual
Bug: 896790
Change-Id: Ic4b8a65ff8b4f6f3b5ed39147c09a68506bb1181
Reviewed-on: https://chromium-review.googlesource.com/c/1334648
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608205}

When an xml-stylesheet is declared before the <html> element, the
document's pending stylesheet count is incremented; but the count is
not decremented when the xml-stylesheet finishes loading.

This has no effect when UpdateStyleAndLayoutIgnorePendingStylesheets
is used; but when that mechanism is removed, it blocks rendering,
causing the test named below to fail.

BUG=521692
TEST=fast/dom/StyleSheet/detached-style-pi-2.xhtml

Change-Id: Ibadae4b66d5351cd58ed00ad654247f53fba6861
Reviewed-on: https://chromium-review.googlesource.com/c/1334946
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608204}

My previous CL (crrev.com/606662) made a few typos in this function.

Bug: 854346
Test: manually
Change-Id: If9f1c94a28e3f88cbff58ae5b1549ed09aa3c2e6
Reviewed-on: https://chromium-review.googlesource.com/c/1336469Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608203}

This CL:
https://chromium-review.googlesource.com/c/1331689
overzealously captures all key events instead of the
previous logic that only handled a subset of th expected
navigational keys.  This restricts dispatching to the
list view except for the previously expected keys.

In particular, you can't type space in the current state,
which is...unfortunate.

BUG=898522

Change-Id: I55c055ae6f942cda833f2e3c678a458f55406741
Reviewed-on: https://chromium-review.googlesource.com/c/1336494Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608202}

Bug: b/116166191
Test: Histogram unit_tests and Local build
Change-Id: I55fc6579bd3346c9ecc7bdf9b2b90758101290e3
Reviewed-on: https://chromium-review.googlesource.com/c/1335963Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608201}

The crash handler needs to know where the GuardedPageAllocator in the
crashing process is to determine if the crash is related to a GWP-ASan
allocation. Use a crash key to transmit this information.

Bug: 896019
Change-Id: I93428ec6d46ebefe2939ff74fab9cb9fd35782a2
Reviewed-on: https://chromium-review.googlesource.com/c/1330073Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608200}

That flag is now always enabled by default (https://reviews.llvm.org/D51251)
and the analyzer errors out when the flag is passed via command line.

Also adding myself as an owner for Clang Static Analyzer and Code Coverage
related files.

Bug: 901486, 759794
Change-Id: I54c9988c79f13287bb0580637d1a3ae4aa46bba7
Reviewed-on: https://chromium-review.googlesource.com/c/1330758Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608199}

Bug: 900373
Change-Id: Ibaaeda2fcff69b5bf45eb7de767731bf53177f56
Reviewed-on: https://chromium-review.googlesource.com/c/1336510Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608198}

Normally custom ErrorProne checks would catch this,
but they were inadvertently disabled.
In preparation for for re-enabling these custom ErrorProne checks
this CL fixes all the redundant field initializations that have
crept into the codebase.

Trivial mechanical change

TBR=yfriedman@chromium.org

Bug: 904524
Change-Id: I96a81a1cb3b8c67bc682728aa9035c4757ed319b
Reviewed-on: https://chromium-review.googlesource.com/c/1334188
Commit-Queue: Aiden Benner <abenner@google.com>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608197}

Trying to use --help with grit just ends in errors like:
  $ grit --help
  getopt.GetoptError: option --help not recognized

Add support for it with `grit --help`.  This doesn't update the
subtools for now as that'll take much more work/thought.

We also don't support the -h short option as it's already used for
other things, and we don't want to complicate/break it.

Bug: 747171
Change-Id: Ied24f810ed583d464dc2970c8e472784e22ec044
Reviewed-on: https://chromium-review.googlesource.com/c/1327421Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608196}

Checking in the strings early to get a jump on localization.

Bug: 902041
Change-Id: I697462486441a009b36f31955f61633946410ee2
Reviewed-on: https://chromium-review.googlesource.com/c/1336084
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608195}

vector_scalar_arithmetic_inside_loop fails on Android Nvidia (N9, STV
devices.) Suppress.

BUG=905370
TBR=kbr@chromium.org

Change-Id: I996bd3e01e680dc53267393cf345fc45988028c9
Reviewed-on: https://chromium-review.googlesource.com/c/1335989
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608194}

Do not activate quick switch when double tapping the tray, if the mru
window is not activate. This was causing an unexpected window activation
which was messing up the overview state, and also visually popping up
and activating an unexpected window.

Test: Checked that OnEndingAnimation does not get called between ToggleOverview calls
Bug: 905082
Change-Id: Iaa7d3d02482d33d27ade6684ece8b92e9c270204
Reviewed-on: https://chromium-review.googlesource.com/c/1336149
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608193}

And create a generic thumbnail_placeholder_on_white_bg color for use in
Zine as well.

BUG=900757

Change-Id: I8cee89a7bfc361288b4f5b0041efb6dc2d8785c7
Reviewed-on: https://chromium-review.googlesource.com/c/1336062Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608192}