- 06 Mar, 2020 10 commits
-
-
Raul Tambre authored
../../base/strings/string_util.cc(930,7): error: call to 'empty' is ambiguous if (empty(parts)) ^~~~~ ../../base/strings/string_util.cc(959,10): note: in instantiation of function template specialization 'base::JoinStringT<std::__1::vector<std::__1::basic_string<char>, std::__1::allocator<std::__1::basic_string<char> > >, std::__1::basic_string<char> >' requested here return JoinStringT(parts, separator); ^ C:\Google\chromium\src\out\release\..\..\buildtools\third_party\libc++\trunk\include\iterator(1899,16): note: candidate function [with _Cont = std::__1::vector<std::__1::basic_string<char>, std::__1::allocator<std::__1::basic_string<char> > >] constexpr auto empty(const _Cont& __c) ^ ../..\base/stl_util.h(102,16): note: candidate function [with Container = std::__1::vector<std::__1::basic_string<char>, std::__1::allocator<std::__1::basic_string<char> > >] constexpr auto empty(const Container& c) -> decltype(c.empty()) { ^ Bug: 752720 Change-Id: I4382b78e772743976cd0bd3682f81c64788c9bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089762 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747492}
-
chrome://app-management/dpapad authored
The chrome://app-management page has been removed and those files even though included in the ChromeOS build, were not actually used anywhere. Fixed: 1002782 Change-Id: I469ba0b975a396515c5f897859e1f56fc0c4d704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090458 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#747491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59ccb910d003..b26fbdde1b2d Created with: gclient setdep -r src-internal@b26fbdde1b2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1054351,chromium:1058522,chromium:996148 Tbr: jbudorick@google.com Change-Id: I99844707be7eb7d7f42422e2b761d73ae57da5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090230Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747490}
-
Doug Arnett authored
If auto translation is triggered for a site when you navigate to a link, there is code that intentionally stop the Translate info bar from being shown. Unfortunately, that code also stops the Translate info bar from being shown when the overflow menu Translate feature is selected. This change will make that check conditional on it not being a menu selection so it will show from menu action but not automatically on auto trans navigation. Bug: 1056400 Change-Id: I72d09264b170498b27af321e6b879ff249cf63bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082910Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#747489}
-
Natalie Chouinard authored
Move Contextual Search settings alongside Contextual Search code. Bug: 1047357 Change-Id: I0b8bd5e9f666df98efd4ac0b77e6ee118ec35fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086073 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#747488}
-
sczs authored
At the time there were various failures on iOS12. I can't repro locally now I'll re-enable and monitor since I'm sheriffing. Bug: 1049972 Change-Id: I0345fd704dcef24285d461ca07244baafb06c163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090608 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#747487}
-
rbpotter authored
Bug: 1026426 Change-Id: I3f46461373385d91008a5ae9d81498a122eca5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088357 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#747486}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4ca48851. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 3e43336a "Update performance.measureMemory to the latest proposal" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I162c685b6370fd47d71ad0e1411c03ec550c5e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089407Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747485}
-
Robert Ogden authored
Any origin in the chain that is ineligible for the feature stops the chain from being followed any further. Redirects do not count against the max number of prefetches. Bug: 1023485 Change-Id: If00c0620f7f34e3b6db7c8ef52a862c6e7440441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085706 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#747484}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/296d1dc00641..c8aaddeaf3ea $ git log 296d1dc00..c8aaddeaf --date=short --no-merges --format='%ad %ae %s' 2020-03-03 martin arm64: mc: NEON implementation of w_mask for 16 bpc 2020-03-04 janne-vlc CI: run a selection of jobs on a node with avx2 2020-03-04 gramner x86: Fix crash in AVX2 cdef_filter with <32-byte stack alignment 2020-03-03 martin arm64: mc: NEON implementation of blend for 16bpc 2020-03-04 martin arm: mc: Optimize blend_v 2020-03-03 martin arm64: mc: Treat the stride as a full 64 bit (potential signed) value in blend_8bpc_neon 2020-03-03 martin arm64: mc: Fix indentation 2020-03-03 martin arm64: mc: Use more intuitive lane specifications for loads/stores 2020-02-25 jb Update NEWS for 0.6.0 2020-03-03 janne-vlc CI/armv7: use `linux32 meson ...` to allow running on aarch64 2020-02-18 martin arm64: loopfilter: NEON implementation of loopfilter for 16 bpc 2020-02-18 martin arm: loopfilter: Prepare for 16 bpc 2020-02-25 martin arm: loopfilter: Fix a comment 2020-02-17 janne-vlc fuzzing: link the fuzzing binaries as C++ 2020-02-17 janne-vlc fuzzing: split the fuzzing targets to their own meson.build file 2020-02-20 gramner x86: Add mc w_mask 4:4:4 AVX-512 (Ice Lake) asm 2020-02-20 gramner x86: Add mc w_mask 4:2:2 AVX-512 (Ice Lake) asm 2020-02-20 gramner x86: Add mc w_mask 4:2:0 AVX-512 (Ice Lake) asm 2020-02-20 gramner x86: Add mc avg/w_avg/mask AVX-512 (Ice Lake) asm 2020-02-14 victorien x86: optimize cdef_filter_{4x{4,8},8x8}_avx2 2020-02-12 victorien x86: add a seperate fully edged case to cdef_filter_avx2 2020-02-19 gramner checkasm: Improve the cdef input randomization algorithm Created with: roll-dep src/third_party/dav1d/libdav1d Fixed: 1057531 TBR=tguilbert Change-Id: I2d240c53ace18092001fe80e930a12f5a93bb328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090615Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#747483}
-
- 05 Mar, 2020 30 commits
-
-
Nico Weber authored
Bug: 1053958 Change-Id: I87b12a7d8d032825c52bf195e1d7114a2ba0aae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088042 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#747482}
-
Avery Musbach authored
When you drag an ARC window from one overview grid and drop into another overview grid, it shall neither cause a crash nor cause overview to end. Test: manual Bug: 961170 Change-Id: Iac895e4f896cf652dc2d522f3f1b8a4c1765416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088507Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#747481}
-
Jarryd authored
Change the default behavior to enabled, update unit tests to match new default behavior, and remove fieldtrial testing config. Bug: 960305 Change-Id: I8f045648c73ab8787dddc2a75d576f23c13dac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090451 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#747480}
-
btolsch authored
TBR=rogerta@chromium.org Bug: 1059060 Change-Id: Ifc21f291edd39fbab294722d3be8d74e4a2f3a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090718Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#747479}
-
Carlos IL authored
Committed interstitials have been launched in non-webview platforms since M80, and will launch in webview in M81. Landing this ahead of the M81 webview launch since flipping the flag unblocks a CTS fix. Bug: 1047527 Change-Id: I0f196669a0d5e80c6d0c674a9eaab574605e04c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090611 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#747478}
-
Reilly Grant authored
In r745013 we introduced a case where createPermissionClickCallback() can be called with both a null intentOverride and androidPermissions. This change adds the missing null check. Bug: 1058746 Change-Id: I5971f20b18b193ba664ab8f24a0a03841da32b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090174Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#747477}
-
Toni Barzic authored
Adds support for learn-more-link attribute to settings toggle button - the attribute adds "Learn more" anchor element to the setting sublabel, and triggers an event when the link is clicked (used to record the user action for metrics). Uses the new attribute in manage_a11y_page for show shelf navigation buttons setting - "learn more" will link to a help page article, but the URL has not yet been finalized, so keeping it blank for now. Also, adds a user action for clicking the link to metrics. BUG=1050544, 1055688 Change-Id: I4126a6a85bf54c0039d2a14063f83f1e08db0d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069847Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#747476}
-
Mehran Mahmoudi authored
This CL: 1. Removes Android-specific code from paint_preview_base_service.(cc|h). 2. Replaces the PaintPreviewBaseService Java class with the NativePaintPreviewServiceProvider interface. This enables each implementer of paint_preview_base_service.cc to independently handle its JNI communications. Bug: 1058405 Change-Id: Id629aa95560cb4c0f202079c1437a16c67798d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090592Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747475}
-
Noel Gordon authored
The iconSet property of most volume types is empty, but we expect that third party volumes (ANDROID_FILES, DOCUMENT_PROVIDERS and File System Providers) should provide icons in their respective iconSets. CL:2032469 added a shouldProvideIcons() helper to volume manager so we can detect these volumes. ANDROID_FILES is done (CL:1945958) and noted File System Providers and DOCUMENT_PROVIDERS were still todo. In this change, use the shouldProvideIcons() helper to detect the File System Providers and DOCUMENT_PROVIDERS that provide no icons, and use a generic icon for these volumes instead. files-ng only: this to avoid drawing a dull gray box for these volumes in files-ng if they provide no icons. Bug: 992819 Change-Id: Ia2b4c6caf70d3b8250acc8d9706f476a486199ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089178Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747474}
-
Sean O'Brien authored
Add a key event handler to the create note action, looking for events with a special flag showing that they were generated by a stylus bluetooth button. This will allow users to open a new note by double clicking the tail stylus button Bug: b:139781900 Change-Id: Ie77e12b4b5256922f3653bacb425a15fdafcf8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079836 Commit-Queue: Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#747473}
-
Bettina authored
Bug: 1017499 Fixes: 1017499 Change-Id: I0b4f6da09b8cb5804fe85e7402f3e1ea83193497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088502Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#747472}
-
rbpotter authored
Instead of defining a function object and then adding functions to it, wrap everything in a cr.define, which can be removed later once these tests are fully migrated to use JS modules. Update all test classes to es6 classes. Bug: 1026426 Change-Id: I004fb0798b5a855bda2de9c3f996fe346937e1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088650Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#747471}
-
Morten Stenshorne authored
Marking the entire ancestry for invalidation while inside pre-paint probably isn't too healthy anyway, and when the pre paint machinery is updated to walk the NG physical fragment tree rather than the layout object tree, we're potentially going to visit the same layout object more than once, and not always in exact tree order. Bug: 1043787 Change-Id: Id99f46f4704cc279323a94a80762c4e0d2cd166b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089832Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#747470}
-
Mike Wittman authored
Cleans up the StackCopier interface/implementations by reusing the stack copier delegate for metadata recording. This allows us to remove the awkward dependency on ProfileBuilder within the StackCopier implementations (awkward since the StackCopiers otherwise don't know anything about building a profile). This requires one additional function on the delegate interface to allow the metadata provider to be eagerly destroyed. Bug: 1035855 Change-Id: I59bf1abbddfeb1a54442a826e309a1b29ffbe31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075881 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#747469}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0c6dfdbceb9e..7e47609cf293 git log 0c6dfdbceb9e..7e47609cf293 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 pmuetschard@google.com Adds a LAST_NON_NULL window function to the trace processor. Created with: gclient setdep -r src/third_party/perfetto@7e47609cf293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I04128556754d1670bd6635b503b300ff5391631f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090228Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747468}
-
Caleb Rouleau authored
Instead of correcting timing data when doing reporting, this change makes it so that timing data is corrected before it is written to the json files. That makes reports easier to write since we don't need to figure out if a platform is running reference builds or not. Also, it means that we don't incorrectly apply doubling to gtest perf tests, which never run reference builds. R=tdresser@chromium.org, wenbinzhang@google.com Bug: 1054000 Change-Id: I78de317099a1af0a77d4a6d5802a6ffa46a8840d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089436 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#747467}
-
Rachel Carpenter authored
This means it doesn't show in the launcher, and it records the correct metric. Bug: b/150738188 Change-Id: I8e14ca21a68bac95f0b7dae8b8719632289089ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086382Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#747466}
-
Xiyuan Xia authored
A display transform pass could be added during capturing when devices are not in their default orientation. Making the display transform pass to copy |has_transparent_background| flag from root renderer pass fixed the problem on Dru. Without the flag copied, Dru (ARM/Mali) somehow shows the display transform pass as a black frame and causes the flicker. Bug: 1041901 Change-Id: I9651073cf8f9ab75ae5aaf6bfcd20a25fd4349d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089957 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#747465}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f5b833c6d2ac..61f8ad8b69f9 git log f5b833c6d2ac..61f8ad8b69f9 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 jalyn@microsoft.com Add titles for all actions Created with: gclient setdep -r src/third_party/devtools-frontend/src@61f8ad8b69f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibff34cf56959a847252ce4d464c5470c21b698ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089776Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747464}
-
Vasiliy Telezhnikov authored
This CL re-enables OffscreenCanvas tests that depedends on surface embedding as VizForWebView is enabled in fieldtrial_testing_config.json for a while now. Tests pass on gpu-fyi-try-android-m-nexus-5x-64 bot. Bug: 805739 Change-Id: I2dbb32e684005fe9521d91289d2d5c992a261394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088339Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#747463}
-
Alan Cutter authored
The kWeb branch in AppServiceContextMenu::IsCommandIdChecked() is capable of handling web apps that run using BMO or Extensions as the backend. This CL removes the flag check and fallthrough behaviour. Bug: 897314 Change-Id: I530988629aa92e13d3cac9ccb8bcd500c1e7f7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087247 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#747462}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a40862f237fc..8ecb862ae74d git log a40862f237fc..8ecb862ae74d --date=short --first-parent --format='%ad %ae %s' 2020-03-05 tsepez@chromium.org Retain layout item in all CFXA_FF.*::Paste() method overrides. 2020-03-05 nigi@chromium.org Add FXSYS_IsLowerASCII(). 2020-03-05 nigi@chromium.org Add a caller for FXSYS_ToUpperASCII() to simplify code. 2020-03-04 tsepez@chromium.org Retain layout item in a few more places where text changes. 2020-03-04 nigi@chromium.org Add FXSYS_IsUpperASCII(). Created with: gclient setdep -r src/third_party/pdfium@8ecb862ae74d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1055869,chromium:1058653 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I221c2f725aa0dce901bf6c3c8f2fd91c0aea28a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090223Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747461}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/7e5e609bc7a1..c7e392d65eb9 $ git log 7e5e609bc..c7e392d65 --date=short --no-merges --format='%ad %ae %s' 2020-03-05 nharper Fix initialization of vectors in tls_connection.cc 2020-03-05 dschinazi Add missing QUIC_EXPORT_PRIVATE to fix QUIC merge 2020-03-04 bnc Add helper functions for PROTOCOL_QUIC_CRYPTO versions. 2020-03-03 wub gfe-relnote: (n/a) Pluming work for loss detection tuning using go/smartchoices. No behavior change, not protected. 2020-03-03 renjietang Move stream static checks from QuicSession to QuicStream. 2020-03-03 renjietang Let session methods that write data take argument of TransmissionType so that it's clear at which transmission type the data is written. 2020-03-03 fayang gfe-relnote: In QUIC, do not bother stream ID manager on pending stream closing if connection disconnects. Protected by existing gfe2_reloadable_flag_quic_enable_version_draft_25_3. 2020-03-03 wub gfe-relnote: (n/a) Add a histogram to record the writer status code from QuicConnection::FlushPackets. Stats only, not protected. 2020-03-02 wub gfe-relnote: (n/a) In QUIC BBRv2, avoid unnecessary PROBE_RTTs when coming out of quiescence. Protected by --gfe2_reloadable_flag_quic_bbr2_avoid_unnecessary_probe_rtt. 2020-03-02 fayang gfe-relnote: In QUIC, use standard deviation to calculate PTO timeout. Protected by gfe2_reloadable_flag_quic_use_standard_deviation_for_pto. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Iab4ea0a1ae1b3796e522be2359b9a7c536e21f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090234 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#747460}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5d15630c9a5beb7462431867baf0adebb42b6647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747459}
-
Alexander Timin authored
ThumbnailPageEventAdapter is unused at the moment and there is no active development in the directory. Remove it to reduce the number of users of WebContentsObservers and other content/public APIs and make changes to them (a little bit) easier. R=dfried@chromium.org Change-Id: Ibba50f017a1ebf3b90eacf4392ea72413a97a113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085311Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747458}
-
Sunny Sachanandani authored
Consider two windows (surfaces) one with DC layers enabled (A) and the other disabled (B) and these sequence of events: 1) MakeCurrent with B 2) SetDrawRectangle on B. |g_current_surface| is null since B doesn't have a |dcomp_surface_| and B's |draw_texture_| is |swap_chain_| back buffer. 3) MakeCurrent on A 4) SetDrawRectangle on A. |g_current_surface| is A's |dcomp_surface_|. 5) MakeCurrent on B before SwapBuffers on A so that |g_current_surface| is not null We will enter the `if (g_current_surface != dcomp_surface_.Get())` branch and then `if (draw_texture_)` branch which will cause this crash. The fix is to check that |dcomp_surface_| is not null before calling ResumeDraw(). Bug: 1055909 Change-Id: I2d14d0713a51474ca757125a99a525b14ee0a568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090028 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#747457}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3ccfc90f5032..99df04e8aa24 git log 3ccfc90f5032..99df04e8aa24 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 ehmaldonado@google.com git-cl: Check if author exists before adding to presubmit command line. Created with: gclient setdep -r src/third_party/depot_tools@99df04e8aa24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I2b065dd26545e6c4c61da18142dfe8c1d30c0645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090220Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747456}
-
dpapad authored
Bug: 720034 Change-Id: I6afea3c8fe453ca5519f7255a5b24850aafed2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089995Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#747455}
-
Stephanie Kim authored
Crostini tests were failing on E2 machines because there was no KVM available. This CL requires that browser tests are run on machines that have a KVM. Bug: 1058924 Change-Id: I9178dd5c8fb8e704e853c75c58cf5d0899c4c593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088408 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#747454}
-
Maggie Chen authored
The current watchdog V2 has the same timeout value as V1. All experiment code in V2 is removed. Bug: 949839 Change-Id: I5f85d2ee538833234e328bbe2b98c2891e305a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083755Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#747453}
-