- 14 Dec, 2020 40 commits
-
-
Leo Lai authored
we are migrating tpm status calls to TpmManagerClient. BUG=b:172748724 TEST=build ok. Change-Id: I296ad2fd2014a9de4b63b7844a047053e21ea12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588976Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#836595}
-
Oleg Davydov authored
And also rename it to AddExtensionToDownloader. ExtensionDownloader::AddExtension is the only place ExtensionDownloader is aware of the Extension object, and (besides tests) it is only used in ExtensionUpdater. Therefore, its logic may be moved to ExtensionUpdater, and this will benefit to: * Better separation of CRX fetching (which is ExtensionDownloader about) and runtime extensions system (where Extension objects live). * Future enforced update URL, where information from the Extension object has to be combined with profile-based data from ExtensionManagement. This CL makes following small changes: * Remove ExtensionDownloaderDelegate::GetUpdateURLData method, since it was only used in AddExtension, which is now part of ExtensionUpdater. * Add some more arguments to the ExtensionDownloader::AddPengindExtensionWithVersion method, to make it flexible enough. This is possible place for future refactoring: deal with plenty of parameters by, for example, introducing a helper struct. Bug: b:168097163 Change-Id: I53b3d2d43ff94befc2a350f5d2bf7132b00223b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586349 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836594}
-
Liviu Tinta authored
With Scroll Unification, in LayerTreeImpl::DidUpdateScrollOffset there are cases where a ScrollUpdate may be mutating a ScrollNode that: - has a MainThreadScrollingReason - the main thread needs to repaint it each time we scroll. - it isn't composited In this case, when ScrollNode is mutated we don't want to make a corresponding change in the associated TransformNode. Instead, we want to SetNeedsCommit so that the changed offset in the ScrollNode is committed to the main thread, then blink regenerates its side of the property trees and cc::Layers. In this test, we hit the first case. In order for the test to pass we need to wait for the main thread to sync. Bug: 1086625 Change-Id: Icdc3eb5cc786ebdecd516f3cb0fd58d47077d6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585765Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#836593}
-
Nico Weber authored
- don't pass --no-call-graph-profile-sort to lld/Mach-O, it doesn't understand it and doesn't have a call-graph-based sorting feature yet - implicitly disable fatal linker warnings for lld (else people will add the disabling to their args.gn and will then forget to remove it once it's no longer needed) - update docs -- mention that `llvm-ar` needs copying too -- mention that an `ld64.lld.darwinnew` symlink must be created -- mention that protoc not working is a (now) known issue No behavior change for normal mac builds. Bug: 1149587 Change-Id: I57d4c194338f97b7ca5325c022d606d8391eb955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587359 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836592}
-
Yi Gu authored
Bug: 1007686 Change-Id: Ia5b949884e1175ab32013002f12174c644f59446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587235Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836591}
-
Andrey Zaytsev authored
Screenshot: https://screenshot.googleplex.com/49sNLibjZ5ovU7j.png Android counterpart of this page: https://docs.google.com/presentation/d/1_6jDegg169xJ5qgaABZ_wV3-Csd_OL5bf9H1NeUqS9Y/edit#slide=id.ga23676aa2c_1_20 Bug: 1152351 Change-Id: Ib7c4b19713d4706248f55af81ee0e2fbe0a68a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558197 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#836590}
-
Nikita Podguzov authored
* Move DlpRulesManagerFactory to separate file. * Separate DlpRulesManager interface and implementation. * Add missed method to MockDlpRulesManager. * Remove DlpRulesManagerFactory::OverrideManagerForTesting() and replace it with direct dependency DataTransferDlpController from DlpRulesManager. * Move policy constants to separate file. TBR=achuith@chromium.org,gab@chromium.org Bug: 1153146 Change-Id: Ic498947d9bcb41908c9433117a065e19d7afcbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581930 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#836589}
-
Stephan Hartmann authored
Compile fails only when building without Ozone. Bug: None Change-Id: Ic8e7c5dcefb2cb6b675497fc9b3cca91ace492db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587160Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836588}
-
Daniel Vogelheim authored
The current implementation assumes that TT is shared between all users of a DOM instance, so that the main world & extensions will "see" the same TT instance. This isn't desirable, and also doesn't actually work, as the attached bug demonstrates. This patch creates & stores separate TT (namely, TTPolicyFactory) instances for each "world". Bug: 1149364, 984979 Change-Id: I12351e9d475907891b8f547b9f4568f3056bb527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584771 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#836587}
-
Gyuyoung Kim authored
This CL removes all uses of WebMemoryPressureLevel enum to make Blink public layer slim. Instead, this CL replaces all uses of WebMemoryPressureLevel with base::MemoryPressureListener::MemoryPressureLevel. Bug: 919392 Change-Id: I85d466887483557b34f88b40fba4ce7c6ec1649b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588681 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96b0fdfcfb65..6a32d1681184 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:688063 Tbr: sinhak@google.com Change-Id: I90faaaf432debc72a5c3bf5e86e967381effc15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589553Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836585}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6798d1b9dc14..818087f47f78 2020-12-14 sigurds@chromium.org Move more cache-related classes to ApplicationPanelCacheSection.ts 2020-12-14 szuend@chromium.org Handle Trust Token done event arriving before requestWillBeSent 2020-12-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-12-14 leese@chromium.org Revert "Fix: no space at the bottom of the image in ImageView" 2020-12-14 jacktfranklin@chromium.org Script to generate dark mode stylesheets 2020-12-14 sigurds@chromium.org Refactor ApplicationCacheManifestTreeElement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126824,chromium:1152736,chromium:11574664,chromium:1157484 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I62d717419a5e20a20910e5612bc4ff8ec10ffe72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836584}
-
Matt Menke authored
In order to make sure NIKs are set everywhere, and working correctly, I'm working towards getting all tests passing with partitioning enabled. This is a small step towards that. Bug: 1082280 Change-Id: I3549ede3f360c9bd3b906f52cb23f3abe775c7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585834Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#836583}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607914577-bca0912c8e5b677cc0f4c3a09eafddf2bb79f844.profdata to chrome-win64-master-1607925234-725e190e4680cc41f5e8777dffee5ef8a0b3f956.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I56d0090263400a17816ac2f8bf6e45910af35f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589394Reviewed-by:
-
Leo Lai authored
This reverts commit 78537960. Reason for revert: the test is crashing: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome Original change's description: > SystemTokenCertDBInitializer test cases of ownership taken signal. > > This is the missing test coverage in unittests. > > Technically speaking, certain browser tests, e.g., > WebviewClientCertsTokenLoadingLoginTest also exercise the logic, but > the code distance is very far and thus hard to debug. It makes sense for > the its own unittests to test it first. > > BUG=b:172748724 > TEST=unit_tests. > > Change-Id: Ib293bdeb1c572172e611ce9a55da15a8a0349a87 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581707 > Commit-Queue: Leo Lai <cylai@google.com> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836512} TBR=achuith@chromium.org,emaxx@chromium.org,cylai@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ic6c6749fbc017823bff63732e1dd45c472cd3007 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:172748724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589058Reviewed-by:
-
Ossama Mahmoud authored
Bug: 1153306 Change-Id: I425eba7b9d8b15c6538f4dc49ddd4db893779128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566993Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Cr-Commit-Position: refs/heads/master@{#836580}
-
Antonio Sartori authored
In the Blink Content Security Policy code, we switch from using the internal blink ContentSecurityPolicy::DirectiveType enum to the mojo enum network::mojom::blink::CSPDirectiveName for enumerating CSP directives. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: I91681d4a7bfebc06cb40e88f6f9ff9392dfaa0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562253 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#836579}
-
Michael Lippautz authored
Use kNoHeapPointers instead of kEmpty. Bug: 1056170 Change-Id: Ic45d8a216cda3a5ff30d3fe4bfdf32b08e806c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587732 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Ziran Sun authored
Specifically, the following logical properties are included: - border-start-start-radius - border-start-end-radius - border-end-start-radius - border-end-end-radius These properties correspond to the border-top-left-radius, border-bottom-left-radius, border-top-right-radius, and border-bottom-right-radius properties. The flow-relative Corner Rounding properties (border-*-radius) will allow to set top-left, bottom-left, top-right and bottom-right box corners with logical mappings rather than physical. Intent to Prototype and Ship: CSS flow-relative Corner Rounding properties https://groups.google.com/a/chromium.org/g/blink-dev/c/YmWSODSTPS4 Spec: https://drafts.csswg.org/css-logical/#border-radius-properties Test: http://wpt.fyi/css/css-logical/logical-box-border-radius.html Bug: 1155270 Change-Id: Ia4462092b08f2b2821218b1584fdb0985c98c5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570570Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Ziran Sun <zsun@igalia.com> Cr-Commit-Position: refs/heads/master@{#836577}
-
Olivier Robin authored
By quickly retrigger overscroll actions, you can be in a state where no action is selected but offset is big enough to trigger action. In this case, Overscroll action is stuck in this state. Bug: 1003766 Change-Id: I2071a120e475bfc0bb95f2bddd216bbcb960f916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578984 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836576}
-
Kush Sinha authored
This reverts commit 56a15a3f. Reason for revert: Fails unit tests on linux-chromeos-rel. See https://crbug.com/1158303 for details. Original change's description: > GuestOsSharePath mark paths no longer shared on VM shutdown > > Bug: 1144138 > Change-Id: I970293c61c9686ab32f574957c028bd3db754ccd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589049 > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Jason Lin <lxj@google.com> > Reviewed-by: Jason Lin <lxj@google.com> > Cr-Commit-Position: refs/heads/master@{#836531} TBR=joelhockey@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,lxj@google.com Change-Id: I4ba6d44fa5b448a4d6899a69dd5848a103a5614c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1144138, 1158303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588930Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#836575}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6a85f40d75b78a412d80613cf664036b584a58bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589226Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/282fb4092b6c..d0f99d5405b4 2020-12-14 xiaoxuan.liu@arm.com Vulkan: Fix build issue in vulkan display/headless backend. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Icee5f8f940c955039bf23498cd1ea5a836467649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589228Reviewed-by:
-
Wolfgang Beyer authored
Frontend CL: https://crrev.com/c/2581542 Disable tests CL: https://crrev.com/c/2580885 Bug: 1152082 Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k update tests Change-Id: I2deaf3b83905665db277600d9170e6ae89e09723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581839Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836572}
-
Yi Gu authored
Bug: 1152263 Change-Id: Iea5a9ae4af34b34267f4c4a04b85ea4c3c715b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585640 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#836571}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0991ca17bab3..8b35cefb4523 2020-12-14 jleconte@google.com Fix Uncaught Error: Invalid dimensions for plot, width = 0, height = 0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: If3124054038060f271f5c2337b599918e0dcc16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589229Reviewed-by:
-
Wolfgang Beyer authored
This CL adds a histogram to keep track of which kind of issues are created. Frontend CL: https://crrev.com/c/2567967 Change-Id: Ifc906076fad1c8f2925953366d4791edc7ca2a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574985Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836569}
-
Fredrik Söderqvist authored
This CL switches from using the SVGResources object graph to do cycle- checking, to using SVGResourceClient and SVGResource (sans the 's'). One of the major benefits is we no longer perform the cycle-check during layout tree attachment, but rather lazily during resource accesses after style resolution and layout tree construction. This should make this process a little more "lifecycle conscious", and makes access to some SVG resources less SVG-centric/awkward in some cases since we no longer need to go through the SVGResourcesCache/SVGResources objects. Accesses to resources now go through the associated SVGResource, that hangs off of computed style, and make use of the client object registered during style recalc. (This is to some degree similar to how StyleImages work.) Since this removes the need to track and maintain the SVGResources object for each client we can drop all the code that constructs and builds this database (which is a fairly significant drop in both LoC and code-size). SVGResourcesCache is thus dropped completely and SVGResources is turned into a static-only class with helpers (likely to be cleaned up latter). Bug: 1028063 Change-Id: I851e76384160a159a826979efab156036271aa5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577210 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#836568}
-
Alice Wang authored
This CL moves AccountPickerFeatureUtils to signin.ui target. Bug: 1157822 Change-Id: I6094021754e9197ad71b63f5299a6d685e92095a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584927 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#836567}
-
Mikel Astiz authored
This rewrites histograms.xml to avoid text duplication. Change-Id: I80ae3d3b7e6873c1d193ef4520d63fc3c6163982 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517594 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836566}
-
Moja Hsu authored
This CL adds focusMode(continuous/manual) and focusDistance MediaTrackCapabilities. Bug: b:151048287, 1068176 Test: Tested logitech camera on eve. Test WFC of kukui. Change-Id: I85fa31b8b4f147b8cc054eac3f94974595545c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371843 Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#836565}
-
Antonio Sartori authored
Some Web Platform Test was expecting that dedicated workers served with Content-Security-Policy: script-src 'none' would block importScripts and setTimeout because of that CSP. However, according to the spec, dedicated workers inherit their CSP from the creator document and disregard the CSPs they are served with. We rewrite those tests with two different cases. For dedicated workers, we expect the inherited CSPs to be applied. For shared workers, we expect the CSP delivered with the worker to be applied. Bug: 1021462,1149272 Change-Id: I64469b2c9017b1d41a65abd4305d2440250b64d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578837 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607903843-e9f03e03b6a80ac1b9393fa413e44243742fdb9c.profdata to chrome-win64-master-1607914577-bca0912c8e5b677cc0f4c3a09eafddf2bb79f844.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If2a6e9fe57b497a8f7f23690560cd722ee45b733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589217Reviewed-by:
-
Hiroki Nakagawa authored
Change-Id: I1e7c49eac75295452149f2e41b290736b8f7e298 Bug: 1144577 Tbr: blundell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586177 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#836562}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I4705fd76bbf6e27f0a4568941ac483aacaf1dbae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589120Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836561}
-
Nancy Wang authored
This CL adds FullRestoreSavehandler class and the SaveAppLaunchInfo interface to prepare for the restore data writing implementation. There will be separate CL to implement the restore data and the FullRestoreFileHandler class to run the actual writing with a background task runner. BUG=1146900 Change-Id: I2ff73b40d6441e0f581b7f4a5b035cf6156241c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580922 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#836560}
-
dpapad authored
Bug: 1132403 Change-Id: I4f2feb3468649214c4a3c999505d1601d6fd94b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586761Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#836559}
-
Antonio Sartori authored
When the renderer initiates a navigation, it currently sends the routing_id of the initiator RenderFrameHost to the browser. Among other things, this is used for inheriting the policy container of the initiator RenderFrameHost. Unfortunately, setting the initiator routing id is done in a best effort way. Indeed, the initiator routing id is set in the RenderFrameImpl by fetching the routing id of the initiator RenderFrame, which however might already be gone. In particular, this happens when a form submission is executed after the form has been deleted, which can happen since form submissions are scheduled asynchronously in Blink. Because of this reason, the information about the initiator for a form submission must be recorded when we schedule it, not when we issue it. Unfortunately, the code scheduling the form submission does not leave the third_party/blink layer, hence has no access to the routing id of the initiator RenderFrame. Because of this reason, we replace the initiator routing id with the initiator frame token in the BeginNavigation and OpenURL mojo messages. The frame token can be retrieved from within third_party/blink, making it possible to always ensure that a form submission has a valid initiator frame token. Notice that even if the initiator RenderFrameHost has been deleted already, we can still use the initiator frame token to retrieve its policy container. This is implemented in a follow up CL. Bug: 1059959,1130587 Change-Id: Ib98cd86a32328ca9a002b08106205c357f25bde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560578 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836558}
-
Frédéric Wang authored
In [1], security levels 0-1 were introduced for registerProtocolHandler. This CL adds a third level: Level 0: Strictly follow the HTML5 specification (*). Level 1: Allow registration from cross-origin. Level 2: Allow registration of ext+ scheme and chrome-extension:// handler. The ext+ scheme covers one of the use case mentioned in [2] : Extensions willing to register protocols for a "reserved" scheme, that is not overridable by pages. The HTML5 specification does not allow handler with chrome-extension:// scheme [3]. However, removing it was not possible without breaking existing extensions [4]. This CL changes that behavior to both match the spec and allow registration of handler with chrome-extension:// scheme in the context of extensions. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2287304 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=64100#c19 [3] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers [4] https://chromium-review.googlesource.com/c/chromium/src/+/1728369 Bug: 64100 Change-Id: I60e6abc19d5a134c67a9ab7a1ff83b7d11ea3622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560305Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL moves two confirm sync dialog tests to the junit target of c.b.signin.ui module. Bug: 1156585, 1156588 Change-Id: I3f54d90707a20ab22671d3f20e8ef1146c784cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584977Reviewed-by:
-
