- 01 Sep, 2020 40 commits
-
-
Azeem Arshad authored
Creating a basic README for chromeos/network directory. See https://bit.ly/chromium-readme-tracker. Fixed: 1102454 Change-Id: I09d92b50e664447d17d6537fca16e023cdb3c098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281556 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#803681}
-
Brian Sheedy authored
This is a reland of 252fed6f Changes from original CL: * Adds an additional crash signature for the renderer process Original change's description: > Add hung renderer minidump test > > Adds a test for exercising Telemetry's hung renderer detection/crashing > code. If Telemetry detects a hung renderer, it should crash the hung > renderer process and the GPU process so that we can get minidumps to > diagnose the root cause. > > Bug: 1119564 > Change-Id: Ibf72a57af6396f7e3ad32fcc16f35d5cd7d1b657 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378761 > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Auto-Submit: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803200} Bug: 1119564 Change-Id: Ieda25c053a170121b4878ceb23d66c03e0b2a189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386490Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#803680}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia4e0085b9fa7a51b1ecadff2255002dc277cc435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803679}
-
Matt Menke authored
This adds a couple safety DCHECKs when they're dereferenced, though isn't a huge win. It does help in cleaning up some string comparisons, though, which this CL also does. Bug: 1123179 Change-Id: I6023bebaf59c8d534c08dc386d7428b5f22ba731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387550 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#803678}
-
Yue Zhang authored
This CL adds contentDescription to the dialog_container_view in TabGridDialog. By adding this, we also fix the issue of the dialog auto-focusing on dialog toolbar back button when dialog opens. This bug is because that without a contentDescription, dialog container view will shift its focus automatically to its first "announce-able" child view which is the back button and announce that in a11y mode. After this CL, it will focus on the whole dialog and make the correct announcement instead. Bug: 1111962 Change-Id: I44e21dd5f8088e9903fa7306d56460ba2fc0feef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387198 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803677}
-
Azeem Arshad authored
The tether toggle is being removed from the mobile data subpage as part of the updated eSIM UI. See go/chromeos-lte. This CL hides the instant tethering toggle when UpdatedCellularUI flag is enabled. Additional subpage changes will be made in followup CLs. Bug: 1093185 Change-Id: I7f2f01ef18a4e32893ef2289d27ad003a8a20e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380323 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803676}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ib5de66a7b7005c132d37462bcab31587ea0d9393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382317Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803675}
-
Arthur Wang authored
The ChromeJUnit4ClassRunner calls InstrumentationProcessor.applyFeatures. R=harringtond@chromium.org Bug: 1060399 Change-Id: I747f6d926636d9ff7eae78fc8905bc5efd834324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388148 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#803674}
-
Lan Wei authored
In Chromedriver's ExecutePerformActions, we put the mouse events which have a button pressed in a list of input_cancel_list in the session, so we will release any pressed buttons at the end of each test. For mouse wheel events we also generate mouse events with type of "wheel", and it does not support any pressed button, so we should not push the mouse event in the input_cancel_list. Bug: 1040611 Change-Id: I3f651a26b9137dbd8e7754d62852be64f44d5e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387546Reviewed-by:
-
Alison Maher authored
When determining the column block size of a new proxy fragment that is added directly after a spanning fragment, we need to know the current column block offset. Bug: 1079031 Change-Id: Ibc03d753e927da3b02399d27e986132c4f4833e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365355 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803672}
-
Oleh Lamzin authored
Reorder methods in telemetry_extension_ui_browsertest.h/.cc based on following rules: 1. Most important methods first; 2. Methods in .cc are in the same order as they are in .h. Bug: b:158566609 Change-Id: If8b3e9a1518735bbfa2e83c8703647221760dc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387023 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#803671}
-
David Bokan authored
This is part of a series of steps to decouple input from compositing. In this CL, we remove LayerTreeHostImpl from being an implementation of the cc::InputHandler interface and moves that onto ThreadedInputHandler. As part of this move, the ThreadedInputHandler is now created outside of the compositor at the point where it was previously initialized, though the lifetime remains unchanged, bound to the LayerTreeHostImpl. This also changes the LayerTreeHostImpl to no longer require that an input handler be present. For tests, this means compositing unit tests no longer need to instantiate an input handler unless they're explicitly testing input. In the long term, input tests should not be part of compositor unit tests. Change-Id: I3896b3ce8646a3749a032b1ecf1fc5337c37d184 Bug: 915926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359398 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803670}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4953712980a2..2d5bbdc4d9de 2020-09-01 capn@google.com Assert multisample resolve has equal input and output formats 2020-09-01 jaebaek@google.com Handle OpenCL.DebugInfo.100 DebugOperation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic0012bf84aeece6154433d384a12e3b10c46bc3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386959Reviewed-by:
-
Anastasia Helfinstein authored
into the wrong input. AX-Relnotes: Fixes a Switch Access bug causing dictations to be entered Bug: 1123707 Change-Id: I7f7df36667a1af2ecb7d770f4db89fa3d7e91703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386379Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#803668}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2ac047515f09a14b7acb4ec36fd54d788d21a1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382814Reviewed-by:
-
Brandon Wylie authored
Bug: 1119656 Change-Id: Ibf8518900f9d4866ff900b8f7f8eccf089c14c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372813 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#803666}
-
danakj authored
None of these classes are interface mocks. Rename them to be more appropriate of what they are providing. R=avi@chromium.org Bug: 866140 Change-Id: I2ca0fd49b8b1a375d2be8c2e08bb99bab554fa42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388346 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#803665}
-
Robert Liao authored
PermissionCombobox used ModelChanged() incorrectly to propagate a change to the SizeToLargestLabel property. The real fix updates Combobox to correctly invalidate the preferred size on such a change and updates the method name in PermissionCombobox. Fixed: 1116750 Change-Id: I5bc8f3efe292e94cbfc1c94a2a5149b8b1514da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388889 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#803664}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2fccd171a4d970bc1cf29ec4314e63c8656fd3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382596Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803663}
-
Yue Zhang authored
Bug: 1116644 Change-Id: I2607ded4d277328067b79f5127664c7a457ba09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383092Reviewed-by:
-
Adam Ettenberger authored
This reverts commit 3cf58053. Reason for revert: There are 3 new performance regressions related to this change : [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1123547 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1123235 [3] https://bugs.chromium.org/p/chromium/issues/detail?id=1123254 Very likely caused AccessibilityIpcErrorBrowserTest.ResetBrowserAccessibilityManager consistently fail on android x86 builders since: * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2007 * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1102 It has been verified that this test * passed with earlier revision: https://chromium-swarm.appspot.com/task?id=4e5ebf09d330cd10 * failed with this revision: https://chromium-swarm.appspot.com/task?id=4e5eb98aba040310 Original change's description: > Reland "Fix Role::kButton name invalidation when descendant text is modified" > > This is a reland of 8f92c37d > > Revert CL : > https://chromium-review.googlesource.com/c/chromium/src/+/2346996 > > Reason for revert: causing build failure: > https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/15547? > > Original change's description: > > Fix Role::kButton name invalidation when descendant text is modified > > > > This CL addresses a bug where Role::kButton, and possibly other roles > > that derive their name from descendant contents, were not firing > > Text Changed when a descendant Node.TEXT_NODE modifies its text |data|. > > > > ax_object_cache_impl.cc : > > - When firing a text changed event, also fire a text changed event for > > the first ancestor that derives its name from descendant contents. > > This ensures the nodes are invalidated, send appropriate text changed > > events, and the changes are serialized to the browser process AXTree. > > > > browser_accessibility_manager_win.cc : > > - FireUiaTextContainerEvent made it possible to fire text events more > > than once for a given text provider so it has been removed. > > - Instead, populate a set |text_changed_events_| which contains the > > text providers via |GetUiaTextPatternProvider| and fire the UIA text > > events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents > > - |text_selection_changed_events_| could also potentially end up with > > the same double-event problem, so it uses GetUiaTextPatternProvider > > now as well. > > - Removing usage of std::unordered_set based on the guidance in > > base/containers/README.md. In general these sets shouldn't grow large > > enough to benefit from being unordered. > > > > AX-Relnotes: Fix bug where after updating the content of complex button might not notify ATs, causing the wrong accessible name to be announced. > > Bug: 1105262 > > Change-Id: I02dc7798686b09f780c90af52aeb2e36fe8fe048 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296564 > > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#796464} > > Bug: 1105262 > Change-Id: Idfafd2e7f886d4d27b735d143ceaa0f33607f7c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346933 > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802730} TBR=wez@chromium.org,nektar@chromium.org,aleventhal@chromium.org,kbabbitt@microsoft.com,kschmi@microsoft.com,Adam.Ettenberger@microsoft.com,yangsharon@chromium.org Bug: 1105262 Change-Id: I01dfe88c964c907331c4497f7e789e2ad59e14f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388361Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803661}
-
Adrienne Walker authored
To avoid changing the meanings of long-standing metrics, this patch adds two new metrics: * appcache.UpdateJob.ExistingResourceOnlyCorrupt * appcache.UpdateJob.ExistingResourceOnlyNotCorrupt These only are emitted for corrupt or non-corrupt resources, vs the previous metrics which also emitted a "0-bucket" for the opposite. This will allow us to use these metrics more clearly in Finch. This also changes the meaning of the currently unused appcache.UpdateJob.ExistingResourceCorruptionRecovery to behave in this same way. Bug: 1033703,989611 Change-Id: Iac9575de286db19102d9586866606e31d9c0bae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376571 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#803660}
-
Eugene Zemtsov authored
Bug: 1122955 Change-Id: I0d31e92fedfa8cbaf52445b1d727bb19401369c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381255Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#803659}
-
Robin Lewis authored
Bug: 1123858 Change-Id: Ide486d795a4b0c244e082e04ab3e9da02b0ff157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387621Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#803658}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I30ef2ad1444a2d21e59da4a590c8da1df4952668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382071Reviewed-by:
-
behdad authored
Aside from the compositorLatency.type which reports for every frame, two aggregate subcategories are added to track when there is any or no interaction active. Bug: 1122140 Change-Id: Ia44a8324eb09d86bdc67c6794446a86d94c99fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380423 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#803656}
-
Darwin Huang authored
This is a follow-up to the following CL: https://crrev.com/c/2252950. Remove TODOs to remove calls stripping Non-Breaking Spaces. Change-Id: I9f56378be2091dadb2e5b732d8573e4b8c254eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295795Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803655}
-
Henrique Ferreiro authored
IsNull and SetToNull aren't needed as the STL string type doesn't use nullable_is_same_type. Change-Id: I0770b42e275e3026749c5409015c4b79941ea56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386744Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#803654}
-
Yue Zhang authored
Bug: 1119632 Change-Id: I8814e259146b50144ec422b89732f15a6f677129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381053 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/816506e1c600..000948ecdba8 2020-09-01 treehugger-gerrit@google.com Merge "trace_processor: Dedup proto files and definitions" 2020-09-01 lalitm@google.com Merge "tp: use unique port by default" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia2b484d1c2e81b040b6126f8da7c6db3ba837e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388803Reviewed-by:
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: Ic523b315c8fcffd8f47d8ef517d4f365b2e6b3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386801 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
-
Carlos IL authored
This reverts commit bdc3ad55. Reason for revert: Bidi handling caused bugs for non-bidi URLs, for the time being this will be reverted while those are fixed, and a CL disabling elision experiments for bidi URLs will be merged to 86. Original change's description: > Fix elision for bidirectional URLs > > URLs where the TLD is separate from the host, which can happen for URLs > of the form http://LTR.RTL/RTL, were displayed with a blank spot when > elision was enabled. This CL changes this so the in between section, > which is not elided in this case, is also not colored transparent. > > Bug: 1117631 > Change-Id: I9bba2d2c0d494a4021b8c8edaacc87084e040964 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368458 > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Commit-Queue: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801559} TBR=tommycli@chromium.org,estark@chromium.org,carlosil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1117631 Change-Id: Idc2ac1d682b1ec5ca1c5d8efc60dad70e0f203d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387483Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#803650}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/928a02b1527d..f48dfd985712 2020-09-01 mtklein@google.com Revert "debug LSAN failures" 2020-09-01 herb@google.com fix unsigned compare against zero 2020-09-01 reed@google.com plumb cubic params into gpu backend 2020-09-01 bsalomon@google.com Separate our use of sampler object from GL support. 2020-09-01 herb@google.com maintain the page index in AtlasLocator If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I615b479f340c3d771b3e278053e44ca4ef9c8762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388860Reviewed-by:
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: Ie366422199576e352185d9f8877a8944dbdcad8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387645 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2bca0089149c..2597a1b22c0a 2020-09-01 ssilkin@webrtc.org Set initial decoder resolution from field trial. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1c8ccd65f534bf4266e784ada9f96c85bb0f89ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388802Reviewed-by:
-
Adrian Taylor authored
Previously, a couple of bugs went uncredited and didn't attract CVEs because this label wasn't added. This may help a little. Change-Id: I7208168a8cd8bae523bdfe00118ae70d3c901836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387416Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#803646}
-
Xianzhu Wang authored
Thumbnail capturing is a hidden capturer which should not have side-effect. It should not prefer the capture size. This CL is self-contained and tests by itself with the DCHECK in WebContentsImpl::IncrementCapturerCount(). I've verified that all callers now meet the requirement. Also verified programatically that the thumbnail capturing won't cause side effect of page rendering. Bug: 1112607 Change-Id: I9f9618e75568cec02d48ddb4b73c43b6233b7fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380884Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803645}
-
Shengfa Lin authored
Re-organize (ChromeDriver) http server into its own class so that http handler can be a friend of http server. Then we can handle the http server methods by posting on cmd thread to call http handler methods. The reason to post on cmd thread is that we can ensure thread safety when manipulating session map. Also, pass cmd task runner and pointer to session map to InitSessionParams so that session_commands can manipulate the session map upon ExecuteInitSession. Will make follow up CL to add condition check before manipulating the session map. Follow up CL will also need to parse user WebSocketUrl parameter. There is also pending discussion about the behavior WebSocket connection if the session terminates in the CL code review comments. Bug: chromedriver:3588 Change-Id: Ibbd8b12842cf2e5b93d67bf68e1b869bb93f20c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382299 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: I46bfbe9c0f3776be67c45c4d3541fcaaf3381ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386727 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
-
Kevin Yeo authored
Bug: chromium:1124018 Change-Id: Ib9e9f3a5bcb93d9dc094e1daee7217c3e01d8922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388603 Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@chromium.org> Cr-Commit-Position: refs/heads/master@{#803642}
-
