- 20 Feb, 2020 40 commits
-
-
Rayan Kanso authored
Check for the installed apps, then return an empty list if in incognito mode, to prevent the ability to use this API for detecting incognito mode. Bug: 1045506 Change-Id: I83c4611947990af470d64ac723fc6695893e2a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066778 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#743132}
-
Natalie Chouinard authored
Lint is no longer incorrectly generating errors for valid v27 usages of these navbar APIs, so we can now remove these suppressions. Bug: 856861 Change-Id: If211e8446ad2eb13634b7134b778e2e5b5a0b2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065848 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#743131}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c2ca38da431c..df5f7f9e4e1a git log c2ca38da431c..df5f7f9e4e1a --date=short --first-parent --format='%ad %ae %s' 2020-02-20 treehugger-gerrit@google.com Merge "test: log gtest onto logcat" 2020-02-20 taylori@google.com Merge "perfetto-ui: Correct resolution upon loading" 2020-02-20 treehugger-gerrit@google.com Merge "Add some benchmarks for data sources and track events" Created with: gclient setdep -r src/third_party/perfetto@df5f7f9e4e1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id2faa2c572cbde8f12fcb9d2c7861629161cdaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066797Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743130}
-
Xiaohan Wang authored
See discussion thread at https://groups.google.com/a/chromium.org/g/cxx/c/h4bdRqbduNY/m/O8Blk8SoEQAJ The recommendation style is as follows: class Foo : public IComIsFun { IFACEMETHODIMP IsFun(BOOL* fun) override; }; HRESULT Foo::IsFun(BOOL* fun) { *fun = false; return S_OK; } Change-Id: I3209682f14489d9c1b31cf5f563a50cccf42a05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065857Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743129}
-
Olivier Robin authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/8c3afe370288..559a3893cb58 $ git log 8c3afe370..559a3893c --date=short --no-merges --format='%ad %ae %s' 2020-02-19 featherless Revert "Temporarily use the `develop` .gitattributes." 2020-02-19 featherless Update snapshot tests. 2020-02-19 featherless Remove checked in files. 2020-02-19 featherless Temporarily use the `develop` .gitattributes. 2020-02-19 featherless Bump the version correctly. 2020-02-19 featherless Bump the release. 2020-02-19 featherless Update changelog. 2020-02-19 featherless Revert "Revert "merge release-candidate"" 2020-02-19 featherless Revert "Revert all commits to stable since v104.0.1." 2020-02-19 featherless Revert all commits to stable since v104.0.1. 2020-02-19 featherless Revert "merge release-candidate" 2020-02-18 yarneo update changelog 2020-02-17 yarneo Bumped version number to 105.0.0. 2020-02-17 yarneo Hand-modified CHANGELOG.md API diff. 2020-02-17 yarneo Automatic changelog preparation for release. 2020-02-16 56741989+copybara-service[bot] [Dialogs] Add snapshot tests for additional dialog configurations. (#9646) 2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor title-icon, title-icon-view frames calculations to accommodate adjustable insets (#9657) 2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor action frame calculations to accommodate adjustable insets (5 seconds ago) (#9656) 2020-02-15 galiak [Dialogs] Refactor content frame calculations to accommodate adjustable insets (#9710) 2020-02-15 galiak [Dialogs] Refactor title frame calculations to accommodate adjustable insets (#9709) 2020-02-14 galiak [Dialogs] Update adjustable insets values (#9695) 2020-02-14 galiak [Dialogs] Update adjustable insets comments (#9694) 2020-02-14 andrewoverton Remove unneeded subspec (#9748) 2020-02-14 galiak [Dialogs] Fix custom title icon view layout - top inset (#9721) 2020-02-14 bryanoltman Fix invalid podspec (#9745) 2020-02-14 randallli [Material][Availability] Migrates cards to MDCAvailability. (#9728) 2020-02-14 randallli [Material][Availability] Migrates Tabs to MDCAvailability. (#9716) 2020-02-14 randallli [Material][Availability] Migrates Chips to MDCAvailability. (#9713) 2020-02-14 randallli [Material][Availability] Migrates Bottom Navigation to MDCAvailability. (#9717) 2020-02-14 andrewoverton [Dialogs] Migrate dialogs to availability (#9743) 2020-02-14 randallli Add @jakerockland to CODEOWNERS: NavigationDrawer (#9715) 2020-02-14 bryanoltman [Material][Availability] Migrates Flexible Header to MDCAvailability. (#9744) 2020-02-14 andrewoverton [Material][Availability] Migrates Schemes to MDCAvailability (#9736) 2020-02-14 bryanoltman [Material][Availability] Migrates Ink to MDCAvailability. (#9741) 2020-02-14 bryanoltman [Material][Availability] Migrates Snackbar to MDCAvailability. (#9739) 2020-02-14 andrewoverton [private] Make private/color use availability (#9738) 2020-02-14 bryanoltman [Material][Availability] Migrates activity indicator to MDCAvailability. (#9735) 2020-02-14 bryanoltman [Material][Availability] Migrates Action sheet to MDCAvailability. (#9733) 2020-02-14 andrewoverton Move static const assignment to MDCTextControl.m (#9701) 2020-02-14 randallli [Material][Availability] Migrates Slider to MDCAvailability. (#9704) 2020-02-13 andrewoverton [Material][Availability] Migrates Text Controls to MDCAvailability (#9720) 2020-02-13 andrewoverton Remove test spec (#9718) 2020-02-13 andrewoverton [TextControls] Changes from text-area-feature-branch with additional podspec and BUILD file changes (#9711) 2020-02-13 randallli Delete Dialogs OWNERS file (#9697) 2020-02-13 randallli Delete NavigationDrawer OWNERS file (#9696) 2020-02-13 galiak [Dialogs] Adding accessory view vertical inset to private header (#9692) 2020-02-12 56741989+copybara-service[bot] [Component] MDCButton. (#9667) 2020-02-11 56741989+copybara-service[bot] [Dialogs] Adding an adjustable insets feature flag. Flag default is NO. Clients must enable flag if they want to customize the inset. This flag has no effect yet in this CL. Adjustable layout logic will be introduced in followup CLs. (#9648) 2020-02-11 bryanoltman [TextFields] Delete deprecated MDCTextFieldTypographyThemer (#9689) 2020-02-11 bryanoltman [Buttons] Delete deprecated MDCOutlinedButtonThemer (#9688) 2020-02-19 yarneo snapshots 2020-02-19 yarneo updated changelog 2020-02-18 bryanoltman [Dialogs] Add reference images for MDCAlertControllerConfigurationsTests (#9757) 2020-02-18 yarneo update changelog 2020-02-17 yarneo Bumped version number to 105.0.0. 2020-02-17 yarneo Hand-modified CHANGELOG.md API diff. 2020-02-17 yarneo Automatic changelog preparation for release. 2020-02-16 56741989+copybara-service[bot] [Dialogs] Add snapshot tests for additional dialog configurations. (#9646) 2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor title-icon, title-icon-view frames calculations to accommodate adjustable insets (#9657) 2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor action frame calculations to accommodate adjustable insets (5 seconds ago) (#9656) 2020-02-15 galiak [Dialogs] Refactor content frame calculations to accommodate adjustable insets (#9710) 2020-02-15 galiak [Dialogs] Refactor title frame calculations to accommodate adjustable insets (#9709) 2020-02-14 galiak [Dialogs] Update adjustable insets values (#9695) 2020-02-14 galiak [Dialogs] Update adjustable insets comments (#9694) 2020-02-14 andrewoverton Remove unneeded subspec (#9748) 2020-02-14 galiak [Dialogs] Fix custom title icon view layout - top inset (#9721) 2020-02-14 bryanoltman Fix invalid podspec (#9745) 2020-02-14 randallli [Material][Availability] Migrates cards to MDCAvailability. (#9728) 2020-02-14 randallli [Material][Availability] Migrates Action sheet to MDCAvailability. (#9732) 2020-02-14 randallli [Material][Availability] Migrates Tabs to MDCAvailability. (#9716) 2020-02-14 randallli [Material][Availability] Migrates Chips to MDCAvailability. (#9713) 2020-02-14 randallli [Material][Availability] Migrates Bottom Navigation to MDCAvailability. (#9717) 2020-02-14 andrewoverton [Dialogs] Migrate dialogs to availability (#9743) 2020-02-14 randallli Add @jakerockland to CODEOWNERS: NavigationDrawer (#9715) 2020-02-14 bryanoltman [Material][Availability] Migrates Flexible Header to MDCAvailability. (#9744) 2020-02-14 andrewoverton [Material][Availability] Migrates Schemes to MDCAvailability (#9736) 2020-02-14 bryanoltman [Material][Availability] Migrates Ink to MDCAvailability. (#9741) 2020-02-14 bryanoltman [Material][Availability] Migrates Snackbar to MDCAvailability. (#9739) 2020-02-14 andrewoverton [private] Make private/color use availability (#9738) 2020-02-14 bryanoltman [Material][Availability] Migrates activity indicator to MDCAvailability. (#9735) 2020-02-14 bryanoltman [Material][Availability] Migrates Action sheet to MDCAvailability. (#9733) 2020-02-14 andrewoverton Move static const assignment to MDCTextControl.m (#9701) 2020-02-14 randallli [Material][Availability] Migrates Slider to MDCAvailability. (#9704) 2020-02-13 andrewoverton [Material][Availability] Migrates Text Controls to MDCAvailability (#9720) 2020-02-13 andrewoverton Remove test spec (#9718) 2020-02-13 andrewoverton [TextControls] Changes from text-area-feature-branch with additional podspec and BUILD file changes (#9711) 2020-02-13 randallli Delete Dialogs OWNERS file (#9697) 2020-02-13 randallli Delete NavigationDrawer OWNERS file (#9696) 2020-02-13 randallli [buttons] Fix tvOS target bug. (#9705) 2020-02-13 galiak [Dialogs] Adding accessory view vertical inset to private header (#9692) 2020-02-12 56741989+copybara-service[bot] [Component] MDCButton. (#9667) 2020-02-12 56741989+copybara-service[bot] [FlexibleHeader] Added property for minimumHeaderViewHeight (#9649) 2020-02-12 yarneo fix snapshot tests for CI (#9698) 2020-02-12 bryanoltman [TextFields] Update snapshot goldens (#9691) 2020-02-11 56741989+copybara-service[bot] [Dialogs] Adding an adjustable insets feature flag. Flag default is NO. Clients must enable flag if they want to customize the inset. This flag has no effect yet in this CL. Adjustable layout logic will be introduced in followup CLs. (#9648) 2020-02-11 bryanoltman [TextFields] Delete deprecated MDCTextFieldTypographyThemer (#9689) 2020-02-11 bryanoltman [Buttons] Delete deprecated MDCOutlinedButtonThemer (#9688) Created with: roll-dep src/ios/third_party/material_components_ios/src Change-Id: Ia980199891d4d55704b8d616505b74adacf417d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066757 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743128}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9d4e31d6cda5..0cd68ab14a08 git log 9d4e31d6cda5..0cd68ab14a08 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 robertphillips@google.com Add private GrContext::compile API 2020-02-20 robertphillips@google.com Add new gpu sink for DDLs Created with: gclient setdep -r src/third_party/skia@0cd68ab14a08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I21ab9161176530b9bd02e30bbf4fa8a3fed1e2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065907Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743127}
-
Tim van der Lippe authored
They were using typedefs that should have used the actual symbol. Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2060290 TBR=aerotwist@chromium.org Bug: 1006759 Change-Id: I3f1433de7e472d7877729132278b581540665cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064942Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#743126}
-
Jeroen Dhollander authored
Previously "0" was always passed as the user-id to LibAssistant. This now causes issues when trying to introduce marble, as marble actually relies on the user-id being a real Gaia-id. Another change I've made here is introduce a |ScopedAshSessionObserver| class which is used inside the Assistant |Service|. This simplifies the house-keeping inside the |Service| class. Note: This requires crrev.com/i/2556323 to land first (and be uprevved into Chromium). Bug: b/143984405 Change-Id: I28b6801a598de1b7f76c19af272d3fc18efa47e9 Tests: New chromeos_unittests that are covered by the filter "*Assistant*" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055428 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#743125}
-
Nohemi Fernandez authored
This patch adds three button styles for the confirmation button depending on the user sign-in state: 'More', 'Confirmation', and 'Add Account'. See go/chrome-ios-signin-migration for more information. Bug: 971989 Change-Id: I4b98eea8bb260267c6ee0d9621059a7c1138649f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062991Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#743124}
-
Yann Dago authored
Bug: 958893 Change-Id: Ife077c62be1c98073cab9a216b4870fcf768c4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042301 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#743123}
-
behdad authored
filter_terrain_svg has been flaky on Win10 FYI x86 Release (NVIDIA). TBR=sadrul@chromium.org Bug: chromium:1053614 Change-Id: I71392b8b9e9e212d5f5cb5c54cbab9278fed6a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066449Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#743122}
-
Robbie Gibson authored
According to design, on iPad the spacing between buttons (not text fields) and an adajcent edge should be greater. Fixed: 1053988 Change-Id: Id061603e32e184864cba61ee11c6e6a946b41e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066541Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#743121}
-
Ken Buchanan authored
The flag itself was already removed in r735677, this removes the metadata from the json file. Bug: 1046131 Change-Id: Id54ebfcd472e06f1bbfb870fa60e62bb97555ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064815Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#743120}
-
Joshua Bell authored
The HostZoomLevelContext class was refcounted, but only ever owned by a StoragePartitionImpl so remove the refcounting. It also had a custom deleter doing basically the same work as DeleteOnUIThread so use that instead. De-virtualize the destructor, too. Change-Id: I75bf780953e6420e00d488af1560262ca4ed7188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028934 Auto-Submit: Joshua Bell <jsbell@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#743119}
-
James Cook authored
* Wire PeopleHandler::TurnOffSync to the IdentityManager. * Clean up PeopleHandler unit tests. Re-enable some tests on Chrome OS, delete unused helper methods, make signin step more explicit. * Add initial implementation of RevokeSyncConsent to IdentityManager. For now this is only supported on Chrome OS because Chrome OS is the only platform that needs to exercise it. Bug: 1050677 Test: Enable SplitSettingsSync, enable sync in browser first-run flow, go to Settings, turn sync off, chrome://sync-internals shows browser sync feature enabled is false Test: added unit_tests and components_unittests Change-Id: I5b2afa49ffa71aac155f93b9abb504c14c4f6b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982186Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#743118}
-
Aga Wronska authored
Child user will see the notification with the details of time limit change in the following cases: * App did not have the limit and new limit was set. * App had time limit set and it was removed. * The value of time limit changed. There are no notifications displayed for web apps, as they share the limit with Chrome and notification will be shown for Chrome. Bug: 1052011 Test: AppTimeControllerTest Change-Id: I662773969b4668c73bc3d6a9d572f8a11d147ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065411Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#743117}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b0e9cd6645e1..2156c444568a git log b0e9cd6645e1..2156c444568a --date=short --first-parent --format='%ad %ae %s' 2020-02-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f155ccfd202d..6112b121e104 (8 commits) Created with: gclient setdep -r src/third_party/angle@2156c444568a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I7ed398a158660559225f7443f328b468b6adbb82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065906Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743116}
-
Maria Kazinova authored
On some websites multiple redirects occur straight after login but on iOS they are not treated as redirects, but rather as form submissions, so the infobar should not expire not only on redirects, but on form submission navigation as well. Bug: 720090, 720154 Change-Id: I766ee66749d0f4942206cc44a6d5d1e50a2a672b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066617Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#743115}
-
Matt Menke authored
NetworkIsolationKey and site-for-cookies are related, in such a way as that we shouldn't be sending same-site-cookies for requests when the NIK doesn't indicate the top-frame origin (and frame origin, if present) are for that site. We want to add DCHECKs that this is always the case. This CL fixes a couple NetworkContext unit tests where the two values don't agree. Bug: 1052148 Change-Id: Ibd7118310ac01b19f60001a1296f3e76af091c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055426Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#743114}
-
Manu Cornet authored
Change-Id: Iaadce70c24f55fe5bb68ffdd6963c7812f25e271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065273Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#743113}
-
Nina Satragno authored
Fixed: 1054402 Change-Id: I4e07f98bf365f0adbbf51680d913af91b0e81859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066448 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#743112}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1282babe6621..2e161c4dd654 git log 1282babe6621..2e161c4dd654 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 mbonadei@webrtc.org Revert "Remove ResourceAdaptationModule::OnMaybeEncodeFrame" 2020-02-20 phoglund@webrtc.org Fix required property for iOS tests. 2020-02-20 jakobi@webrtc.org Update target rates if stable target has changed. 2020-02-20 sprang@webrtc.org Lazy conversion to i420 buffer in SimulcastEncoderAdapter 2020-02-20 danilchap@webrtc.org Delete legacy DataSize and DataRate factories 2020-02-20 danilchap@webrtc.org Parse DependencyDescriptor rtp header extension 2020-02-20 phoglund@webrtc.org Whitespace change to kick bots. 2020-02-20 elrello@microsoft.com Rollback transport created by data channel 2020-02-19 philipp.hancke@googlemail.com loosen ice-ufrag/ice-pwd ice-char restrictions 2020-02-19 titovartem@webrtc.org Add YUV to IVF video converter util 2020-02-19 mbonadei@webrtc.org Remove wildcard ownership for build files. 2020-02-19 danilchap@webrtc.org Refactor parsing generic descriptor extension into own function 2020-02-19 mbonadei@webrtc.org Remove inactive OWNERS. 2020-02-19 titovartem@google.com Remove unused compile-dep from sdk/android:base_java target 2020-02-19 phoglund@webrtc.org Fix dead link. 2020-02-19 mbonadei@webrtc.org Make error message more actionable. 2020-02-18 deadbeef@webrtc.org Make CNAME optional. 2020-02-18 deadbeef@webrtc.org Add constants for allowed network_priority values 2020-02-18 jamiewalch@chromium.org Add missing interface methods. Created with: gclient setdep -r src/third_party/webrtc@2e161c4dd654 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032987,chromium:1044521,chromium:1052352,chromium:1053756,chromium:1053891 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibf46e5e39407babffe40e4cf83b35a9e7134aaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065905Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743111}
-
Randy Rossi authored
The screen reader's focus rings have outsets around the bounding box from the semantics tree info. However, when the bounding box is for a full screen item (like the background image, for example) the focus ring becomes invisible because it renders outside the screen area. This CL clips the points to the screen's dimensions. Bug: 1052121 Test: Local build display assistant with screen reader enabled Change-Id: Icf4ad68f59c23e503bc3baf9ec7763e175095853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055668Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743110}
-
Nico Weber authored
While here, also remove some references to GYP. Bug: 1031169 Change-Id: Ibb00ea755454be02b366f344d9bae8b693dbd581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066060 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743109}
-
David Bokan authored
The current algorithm first finds a |prefix|, then checks if the immediate following text is the |search_text|. If it is it'll advance |search_start| to the end of the |search_text| so it can confirm it's followed by the |suffix| text. However, this means that if the |suffix| text doesn't match, the next iteration of the algorithm will start searching for the |prefix| at the end of the |search_text|. This is a problem if the |search_text| == |prefix| because we've now skipped the |search_text| part of the range for prefix matching. E.g. With prefix=foo search_text=foo suffix=bar we'll fail to match: foo foo foo bar Because the first iteration of the loop will use the first "foo" as the prefix, and the next iteration will use the third "foo" as the prefix; we skip the second. Bug: 1054243 Change-Id: I62b8a32f89c987e5bed8ea439ae1b7d53d12436d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065979Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743108}
-
Justin Cohen authored
This reverts commit 7a9ca38d. Reason for revert: It appears all the browserlist observers are busted after closing the last incognito tab. Original change's description: > [iOS] Create WebStateList observation registrar. > > This CL creates AllWebStateListObservationRegistrar, which can be used > in any case when an object needs to observe all web state lists for a > given BrowserState. > > This is a generalized version of the snapshot cache tab model observer, > which this replaces. > > For cases where only regular or OTR browsers' WebStateLists should be > observed, AllWebStateListObservationRegistrar has an optional param that > can be set at creation time. > > To avoid circular dependencies, one target in web_state_list/ had to > be split from the main target (hence the scattershot BUILD.gn updates). > > Change-Id: Ic3977b709d5b089ebf31afd0fa868067833f2249 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997306 > Commit-Queue: Mark Cogan <marq@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742172} TBR=rohitrao@chromium.org,marq@chromium.org,justincohen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If97541ae3196c04da57c8a49896e8c55d5646949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063918Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#743107}
-
yilkal authored
Enable whitelist policy wrapper to graciously handle empty or incorrect values. Bug: 1051201 Change-Id: I1e94af89e60106b7eedbd0e65c2b1138055ba5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065983Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#743106}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71d0f777fcf6..e1cd8b3dcc1d Created with: gclient setdep -r src-internal@e1cd8b3dcc1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040143 Tbr: jbudorick@google.com Change-Id: I331dde0bcc0b63c9888e06acb1346421beb0c2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065904Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743105}
-
Wolfgang Beyer authored
Update the expected test output, which is caused by changes in the DevTools CL linked below. Reenable the respective test. https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056480 Bug: chromium:1035309 Change-Id: I5910d4f83741b9fb1c2c5235ce888e5d304ec8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059976Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743104}
-
Torne (Richard Coles) authored
We were only catching Exception which meant that other Throwables (often OutOfMemoryError) were still crashing in the JNI bindings instead of generating "nice" Java stacks. Bug: 718929 Change-Id: I6c941002d632696c736aed9ad3304223d813c94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060671 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#743103}
-
Hui Yingst authored
Under chrome/browser/resources/pdf directory, move existing enums into constants.js. constants.js will be used to hold all future enums which are added into this directory. Change-Id: Ic3ed8e0d0cfa13e157c45ea640ec52dd5a67b90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056568Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743102}
-
Charlie Hu authored
This reverts commit be7ed6c8. The fail/timeouts in cfi tests are caused by an implicit DocumentPolicyFeature enum to int cast in feature_policy_helper.cc.tmpl. The problem is fixed by including document_policy_feature.mojom-blink.h in feature_policy_helper.cc. Original change's description: > Revert "Add DocumentPolicyFeature enum" > > This reverts commit 9594a5d4. > > Reason for revert: suspect causing faillures on LinuxCFI bot. > > Sample build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16433 > > Manually bisected and this CL seems to cause the tests' timeout. > > Original change's description: > > Add DocumentPolicyFeature enum > > > > This CL separates DocumentPolicyFeature enum from FeaturePolicyFeature > > enum, which makes DocumentPolicy and FeaturePolicy independent to each > > other. Previous test on document policy and feature policy coexist > > is removed. Follow-up CL will replace all usage of migrated features, > > i.e. font display and unoptimized-lossless-images so that current wpt > > tests on document policy still pass. > > > > Bug: 993790 > > Change-Id: I730b95efd013c25d97c2d24dd777e12b7b38bbb7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028666 > > Cr-Commit-Position: refs/heads/master@{#741609} > > TBR=dgozman@chromium.org,dcheng@chromium.org,iclelland@chromium.org,chenleihu@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 993790 > Change-Id: Ifaacbc1461dfd4048329ed11763ecfff197b22e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060188 > Cr-Commit-Position: refs/heads/master@{#741884} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993790 Change-Id: I1a282d6546819936617ecebbab96ecc73cf498fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061394Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#743101}
-
Peter E Conn authored
Bug: 1040143 Change-Id: Ife79cfe1f0c5963bf4c6c7bee0c810e936b0a9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062208 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#743100}
-
Steve Kobes authored
Move the LayoutInstability test case and CLS-specific stuff into a separate file, add comments to document MetricIntegrationTest APIs, and create UKM/UMA tester objects automatically. Bug: 1045064 Change-Id: I905975afc97fa7ebd3b3d5382b7c77429628c07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064780Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#743099}
-
Marc Treib authored
Before this CL it was a vector, but after recent cleanups, it only ever had a single entry. Bug: 1029481 Change-Id: I0e7964d4233f08e102b1c0a0413aaff7dd6514ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065004 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#743098}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/69ac3898ce66..f0a082ec3466 git log 69ac3898ce66..f0a082ec3466 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-20 tvanderlippe@chromium.org Update TypeScript to 3.8.1RC Created with: gclient setdep -r src/third_party/devtools-frontend/src@f0a082ec3466 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idd5d708cae7996fc4148905651571b54081b22ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743097}
-
Nazerke authored
This CL modernizes the HistoryClearBrowsingDataCoordinator - to use |browser| in the initializer instead of |browserState| - to remove the public property for dispatcher - to use self.browser to get browserstate and dispatcher values. Bug: 1029346, 1048407 Change-Id: I9422cc3dac91b0b27f16378f4c65dbe9c2d42563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064392Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#743096}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e4a608b99a32..c2ca38da431c git log e4a608b99a32..c2ca38da431c --date=short --first-parent --format='%ad %ae %s' 2020-02-20 fmayer@google.com Merge "Do not insert session into active_configs_ if setup fails." Created with: gclient setdep -r src/third_party/perfetto@c2ca38da431c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifb7848755231e396023ce02b0b3979658f0c9523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743095}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b86395aa..6afd7913 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d9998d03bda2bbd8d35247a19117177a66099aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066578Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743094}
-
Aaron Leventhal authored
The aria-description property is now in the master branch of the draft ARIA spec. Bug: 1006767 Change-Id: Ic23904c8d8de32aa0f7ff3c4c03ec8a9a26c6b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999301Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#743093}
-