- 01 Nov, 2017 40 commits
-
-
Raphael Kubo da Costa authored
We are currently hitting an "argument list too long" error in git-cl upload that is blocking imports. At least temporarily, stop mentioning the owners for the directories being changed, and trim the "note to sheriffs" so that the CL message gets shorter. Bug: 780055 Change-Id: Icf65268c5f8429c1b18d327d320a5731b1bd0784 Reviewed-on: https://chromium-review.googlesource.com/749062 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#513109}
-
Miguel Casas-Sanchez authored
This CL updates code in a few locations in vaapi_decode_accelerator.cc: - inlines the ctor and emtpy destructor of Vaapi{H264,VP8,VP9}Picture because, since they're in a .cc file anyway, separating declaration and definition is unnecessary. - makes some members const in VaapiDecodeSurface. - makes ctors explicit and uses scoped_refptr (and not const&), see [1] and the discussion in [2]: "If the function (at least sometimes) takes a ref on a refcounted object, declare the param as scoped_refptr<T>. The caller can decide whether it wishes to transfer ownership (by calling std::move(t) when passing t) or retain its ref (by simply passing t directly)." "A great deal of Chromium code predates the above rules. In particular, some functions take ownership of params passed as T*, or take const scoped_refptr<T>& instead of T*, [...]. Try to clean up such code when you find it" [1] https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#object-ownership-and-calling-conventions [2] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/TlL1D-Djta0 TEST= **No new code intended**. Compiled simplechrome and loaded on Soraka, then played videos making sure (via chrome://media-internals) that GpuVideoDecoder was used. Bug: 717265 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6006fb23325d23841c8613fa41d65f8707a5446c Reviewed-on: https://chromium-review.googlesource.com/746369Reviewed-by:Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#513108}
-
Mounir Lamouri authored
There was a hard coded limitation to 3 actions because the pre-N notifications do not look great with more than 3 actions but it is breaking consistency for websites using the Media Session API. This is also renaming `isRunningN()` to `isRunningAtLeastN()`. Bug: 775471 Change-Id: I2e9289ff0daa987acf0b656a239069676b03d722 Reviewed-on: https://chromium-review.googlesource.com/747221Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#513107}
-
Hajime Hoshi authored
This CL also replaces caller side of Suspend(IfNeeded)/Resume to use Pause(IfNeeded)/Unpause. This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663 Bug: 780378 Change-Id: Ie228c1e2e498ff5c65a877e4cf24dc92c9714039 Reviewed-on: https://chromium-review.googlesource.com/748722Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#513106}
-
Ryan Hamilton authored
BUG=777728 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6a80db88aafdf20c7abd3847404b818565681310 Reviewed-on: https://chromium-review.googlesource.com/748425Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#513105}
-
Donna Wu authored
The report_id in U2fHidDevice is always 0. This CL removed it from U2fPacket payload and updated related unit tests. BUG=728223 Change-Id: I460e0a867c111c71e5cf0939ca504b0ffb802bd6 Reviewed-on: https://chromium-review.googlesource.com/741167 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#513104}
-
Edward Jung authored
+ Remove the gradient from behind the fix button nav as this is poorly rendered on low bit depth screens. + Reduce the margin needed for the details button. + Reduced the margin for the dino game. This allows all the text to fit without scrolling. Bug: 755714 Change-Id: Ia90afd5ab621fd0c0c9781cb13f7a9e003c053a0 Reviewed-on: https://chromium-review.googlesource.com/741741 Commit-Queue: Edward Jung <edwardjung@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#513103}
-
Robert Hogan authored
Bug: 690087 Change-Id: I9628c03accaf66fffae40d96bb1de2174e5fd3e2 Reviewed-on: https://chromium-review.googlesource.com/732110 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#513102}
-
Anatoly Pilikov authored
Bug: 771907 Change-Id: Ib15de7a0792d370f75d17275670abb8685b68585 Reviewed-on: https://chromium-review.googlesource.com/738138Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#513101}
-
Yoichi Osato authored
This patch excludes text granularity adjustment part from ComputeVisibleSelection() to a function which returns SelectionTemplate<Strategy> for code health. We will have ComputeVisibleSelection(passed_selection) { const SelectionTemplate<Strategy>& xxx_adjusted_selection = AdjustSelectionXXX(passed_selection); const SelectionTemplate<Strategy>& yyy_adjusted_selection = AdjustSelectionYYY(xxx_selection); const SelectionTemplate<Strategy>& zzz_adjusted_selection = AdjustSelectionZZZ(yyy_selection); return zzz_adjusted_selection. } Bug: 775701 Change-Id: I34fefb47fe7b82916a41f0f876030561fc21f1d4 Reviewed-on: https://chromium-review.googlesource.com/748842 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#513100}
-
Hajime Hoshi authored
This is the first step to replace all SuspendableObject with PausableObject. This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663 Bug: 780378 Change-Id: I76781b850f8a1c71f4a01178d3fd7432534adc06 Reviewed-on: https://chromium-review.googlesource.com/749022Reviewed-by:
-
Makoto Shimazu authored
TBR=lazyboy@chromium.org Bug: 780398 Change-Id: Iab2f2612095ebf947bb0f86d0e3067119c53d1c9 Reviewed-on: https://chromium-review.googlesource.com/748743Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513098}
-
wutao authored
Create a flag to implement keyboard shortcut viewer. This flag will be removed once the feature is launched. Bug: 778874, 768932 Test: test new flag with command line, and chrome://flags. Change-Id: I7ea41f990059a52c4a3f008fff9f8b9ba30da938 Reviewed-on: https://chromium-review.googlesource.com/740943 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#513097}
-
Yoichi Osato authored
We clear old selected but not selected LayoutObject's SelectionState to kNone using LayoutObject::SetSelectionStateIfNeeded(). However the function calls virtual LayoutObject::SetSelectionState(), which change containing blocks' SelectionState. This causes inconsistency that marked not kNone LayoutObject can accidentally marked kNone. This patch changes it to call non virtual LayoutObject::SetSelectionState() and assign kNone SelectionState to only target old selected LayoutObjects. Bug: 739062 Change-Id: I9ca736de43a2a982b1e29a1607325a1b77e3c35f Reviewed-on: https://chromium-review.googlesource.com/748841 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Greg Thompson authored
Tests in the interative_ui_tests fixture are known to timeout if there's an always-on-top window on the desktop. This change introduces a few improvements to the existing data collection strategy to help diagnose the provenance of these always-on-top windows. - Checks for always-on-top windows are moved out of the test child processes and up to the parent test proc. This is a more reliable place to log any info, as such log messages are more likely to make it into the main swarming log output. This is a result of the way GetTestOutputSnippet pulls what it thinks is the only relevant test output -- it drops messages emitted outside of the test body. - Scans for always-on-top windows now take place before running any test in the shard and after any test that times out. - A screen snapshot is saved if any always-on-top window is found, even in the case of dialogs that will be closed. - An attempt is made to find and emit the command lines for all processes in the process hierarchy of the proc owning an always-on-top window. - All details are emitted in a single log message. For example: There is an always on top window on the desktop after this test timed out. This may have been caused by this test or a previous test and may cause flakes; window class name: ConsoleWindowClass; subprocess command line: "".\interactive_ui_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=AutofillInteractiveTest.AutofillViaClick --single_process --snapshot-output-dir="e:\b\s\w\iomhwbd8" --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6396_16240\results6396_26680\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iomhwbd8\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6396_16240\d6396_27306""; owning process lineage: (process_id: 2000, command_line: "C:\Windows\system32\cmd.exe /c ""C:\Users\chrome-bot\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup\run_swarm_bot.bat" ""), (process_id: 1496, command_line: "C:\Windows\Explorer.EXE"); screen snapshot saved to file: "e:\b\s\w\iomhwbd8\ss_20171030114011_636.png"; BUG=764415 R=sky@chromium.org Change-Id: I1aed3a41542680b197c7856e1f5d9ec9af6e3774 Reviewed-on: https://chromium-review.googlesource.com/737641Reviewed-by:
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/c1f14fbea92b..e88ec8eed5a4 $ git log c1f14fbea..e88ec8eed --date=short --no-merges --format='%ad %ae %s' 2017-10-31 jmadill Vulkan: Refactor GarbageObject. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9640a7405b0f235657dbf178862712f5c5c2dd60 Reviewed-on: https://chromium-review.googlesource.com/748903Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513094}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3987906..51e24003 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I75b68b1278937a3d796bb263225cee9c0c13261d Reviewed-on: https://chromium-review.googlesource.com/748803Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#513093}
-
Makoto Shimazu authored
TBR=kochi@chromium.org Bug: 780386 Change-Id: If4286a902cde9c33ef04aebc648b9f5ad822601d Reviewed-on: https://chromium-review.googlesource.com/748462Reviewed-by:
-
Greg Thompson authored
This allows consumers of TestLauncher and content::LaunchTests to take action on child process timeout before the process is terminated. BUG=764415 R=phajdan.jr@chromium.org,sky@chromium.org Change-Id: Iccb359273c464f1e660a079af92edfc7feed817f Reviewed-on: https://chromium-review.googlesource.com/746701 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Hayato Ito authored
Format js files by "clang-format -i <file>". TBR=kochi@chromium.org Change-Id: I28f5a0885688928dcb8b40e8f0abcedfdc6a30c5 Reviewed-on: https://chromium-review.googlesource.com/748921Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#513090}
-
Greg Thompson authored
Originally, LaunchChildGTestProcess took a single callback that was run on the caller's thread when all processing was done for the child process. Eventually, a second callback was added to give consumers a chance to act immediately on process launch. This here change switches from two callbacks to an observer interface in preparation for a third observation point. BUG=764415 R=sky@chromium.org,phajdan.jr@chromium.org Change-Id: I38a8a99a78007d4598e650b85d9936beb1ef6a1e Reviewed-on: https://chromium-review.googlesource.com/746682 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Scott Graham authored
Reverts the QEMU binary which caused a substantial perf regression on arm64 emu. TBR: wez@chromium.org Bug: 780096, 707030 Change-Id: Ib48849dcfb261205a6211c9eec0a9e2b997970cd Reviewed-on: https://chromium-review.googlesource.com/748682 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#513088}
-
Aleks Totic authored
This patch computes static position in inline layout, and propagates OOFDescendants up the fragment tree. kojii: I've added NGInlineLayoutAlgorithm::CurrentDirection method. Rename suggestions welcome. Interesting bits: 1) LayoutBlock::LayoutPositionedObject LayoutBlock::LayoutPositionedObject had to be modified because it would relayout already positioned OOF. The way it decided relayout was needed was by positioning the element, and then comparing its position to position it already had. NG and Legacy would disagree here by a fraction of a pixel, and this would trigger relayout. My fix skips this check if LayoutNGBlockFlow is a containing block. 2) Failing tests: there are 23 new failures, and 159 passes. I've examined the failures. Will need help from inline team on 2a, 2b and 2c. 2a) DCHECK inline_size < 0 animations/interpolation/letter-spacing-interpolation.html animations/interpolation/word-spacing-interpolation.html fast/inline/empty-inline-create-linebox.html fast/text/text-large-negative-letter-spacing-with-opacity.html fast/text/text-letter-spacing.html fast/text/international/rtl-negative-letter-spacing.html css2.1/t0803-c5502-imrgn-r-03-b-a.html css2.1/t0804-c5507-ipadn-r-03-b-a.html 2b) bad static position. Block is being positioned by inline-layout-algorithm, instead of block-layout-algorithm. Should start a new line external/wpt/css/CSS2/normal-flow/block-non-replaced-width-001.xht external/wpt/css/CSS2/normal-flow/inline-block-replaced-height-004.xht external/wpt/css/CSS2/normal-flow/inline-block-replaced-height-005.xht external/wpt/css/CSS2/normal-flow/inline-block-replaced-height-007.xht external/wpt/css/CSS2/normal-flow/inline-replaced-height-004.xht external/wpt/css/CSS2/normal-flow/inline-replaced-height-005.xht external/wpt/css/CSS2/normal-flow/inline-replaced-height-007.xht fast/css/sticky/sticky-vertically-overconstrained.html 2c) <span> has many <br>. NG includes <br> in line height, Legacy does not. FF does not at all fast/replaced/absolute-position-percentage-height.html 2d) passes on reload. Content might not be laid out when document.onload() fires Fully correct (like FF), unlike Legacy which fails 2 tests. fast/box-sizing/replaced.html 2e) some relayout multicol weirdness fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html ietestcenter/css3/multicolumn/column-containing-block-001.htm ietestcenter/css3/multicolumn/column-width-applies-to-008.htm ietestcenter/css3/multicolumn/column-width-applies-to-014.htm 2f) unusual test: svg, shadow roots, i am not sure what is going on svg/foreign-object-under-shadow-root-under-hidden.html Bug: 740993 Change-Id: I0eab6ec0ee87bdb10c9a69df0e18f19bcaafef68 Reviewed-on: https://chromium-review.googlesource.com/738870 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#513087}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/a44b013a328d..611d48c1ed39 $ git log a44b013a3..611d48c1e --date=short --no-merges --format='%ad %ae %s' 2017-11-01 angle-deps-roller Roll skia/third_party/externals/angle2/ c1f14fbea..e88ec8eed (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I29495753e4c20247d53bf90da3c27d0e35769a6f Reviewed-on: https://chromium-review.googlesource.com/748641Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513086}
-
Tarun Bansal authored
QUIC usage and warmup URL fetching. Also, enable fetching of the warmup URL even if usage of QUIC proxies is disabled. Bug: 780117 Change-Id: I06706aed704701ca6f85553913b8cc94eb4a7afe Reviewed-on: https://chromium-review.googlesource.com/747131Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#513085}
-
Makoto Shimazu authored
This is following-on to crrev.com/c/746601 and crrev.com/c/747627. The original patch to disable the tests is missing to add MAYBE_ prefixes for each test. TBR=lazyboy@chromium.org Bug: 779973 Change-Id: Ib6a86f61972436034c84694ce87ebab763db7f89 Reviewed-on: https://chromium-review.googlesource.com/748402Reviewed-by:
-
Eddy Mead authored
Change-Id: I43488771e326310c2fd1775b8fac96ad6995b41a Reviewed-on: https://chromium-review.googlesource.com/748502Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#513083}
-
Yutaka Hirano authored
Bug: 603396, 703483 Change-Id: I8b9c2ae5251670130e6c22be971fd610121be15e Reviewed-on: https://chromium-review.googlesource.com/748221Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#513082}
-
Makoto Shimazu authored
This test seems flaky when disabling browser-side-navigation according to the flakiness dashboard. TEST=interactive_ui_tests --gtest_filter=PopupBlockerBrowserTest.Regress427477 --disable-browser-side-navigation TBR=avi@chromium.org Bug: 780371 Change-Id: I2cd1027ebe8ce2d46919e8a492cda078417be935 Reviewed-on: https://chromium-review.googlesource.com/748503 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Lei Zhang authored
Most std::vector iteration can just be range-based For loops. TBR=zea@chromium.org Change-Id: Ibe18f8a088a27f41dbe0e38c40787bbcef28a7e2 Reviewed-on: https://chromium-review.googlesource.com/741545Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Stanislav Chiknavaryan <stanisc@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
ScriptElementBase::InitiatorName() is "script" for both of HTMLScriptElement and SVGScriptElement. This CL replaces InitiatorName() with hard-coded "script" to reduce dependencies to ScriptElementBase. Bug: 777626 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I39bf17f0e95e169acf2cf4956c84d35b0511b618 Reviewed-on: https://chromium-review.googlesource.com/740873 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#513079}
-
Hajime Hoshi authored
This is one step of all replacings at https://chromium-review.googlesource.com/c/chromium/src/+/743663 Bug: 777775 Change-Id: Ib388098d7a6f3d1baa3b144734f470b0263f74f7 Reviewed-on: https://chromium-review.googlesource.com/748741Reviewed-by:
-
Yoichi Osato authored
This patch converts editing/selection/mouse/drag_focus_node.html with assert_selection to promote the use of w3c testharness and improve code health. Bug: 679977, 775701 Bug: Change-Id: Icde9911081d459ce53ac9155bedf98702b78b66c Reviewed-on: https://chromium-review.googlesource.com/746481 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Brett Wilson authored
Enables the --experimental-tab-controlelr flag to use the new code path. Just enough is implemented to allow the tab strip to show and not crash. Changed the NotifyTypes enum in the TabStripModelImpl to use the latest style. Bug: 778461 Change-Id: I6e124044b0318c2d6b250ad86f796d570067e81a Reviewed-on: https://chromium-review.googlesource.com/747628Reviewed-by:
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5d790d53ea6e..70dea4270ec1 $ git log 5d790d53e..70dea4270 --date=short --no-merges --format='%ad %ae %s' 2017-10-31 hinoka Reland 2 "bot_update recipe: Upload source manifest" Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I210c7a84e2ed7cc91e42f37c2db52f62f0ddbef0 Reviewed-on: https://chromium-review.googlesource.com/748362Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513075}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1facfc82..f3987906 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie288a71e84e2380e42ab78add27b2d376ba8e08a Reviewed-on: https://chromium-review.googlesource.com/748066Reviewed-by:
-
Makoto Shimazu authored
ExtensionWebRequestApiTest.WebRequestUnloadImmediately in renderer_side_navigation_browser_tests is flaky on Linux/Mac. This disables it. TEST=browser_tests --disable-browser-side-navigation --gtest_filter=ExtensionWebRequestApiTest.WebRequestUnloadImmediately TBR=battre@chromium.org Bug: 780369 Change-Id: I61c32c1d35de888298d8344d0d367044ece64d39 Reviewed-on: https://chromium-review.googlesource.com/748661 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Peter Boström authored
"Close Firefox..." no longer mentions Chromium or Google Chrome so it can be used as a generic string. This fixes the current mismatch between Chromium/Google Chrome as only the former was updated for the new dialog string. Bug: chromium:754034 Change-Id: I4cfcf53057be681142ea8684a40b6b3eee33e436 Reviewed-on: https://chromium-review.googlesource.com/745310Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#513072}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/b8ee9dd35e60..c1f14fbea92b $ git log b8ee9dd35..c1f14fbea --date=short --no-merges --format='%ad %ae %s' 2017-10-28 oetuaho Remove empty switch statements from translated shaders Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2c824333a3d8549480054ab8d307ea579dc9f45c Reviewed-on: https://chromium-review.googlesource.com/748423Reviewed-by:
-
Michael Martis authored
This comprises: - Attaching an iOS language detection client (similar to the existing Content-based client) to each web state - Updating the language detection controller (which does the actual CLD) to notify the language detection client rather than translate code, and to use core datatypes (rather than iOS-specific ones) - Updating the translate driver to receive language info via a callback from the language detection client - Updating unit and integration tests to account for these changes Bug: 755856 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7544863835d0d507a3e1453973f55c7fc918ba83 Reviewed-on: https://chromium-review.googlesource.com/740421 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by:Renjie Liu <renjieliu@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513070}
-
