GitLab

Use a ButtonHandler for the play/pause and close buttons so
they can be picked up by voiceover.

BUG=848509

Change-Id: I6fb063c03156d48b814fd3d370703724753a0b29
Reviewed-on: https://chromium-review.googlesource.com/1153623
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578821}

"Use Selection for Find" = Cmd+E
"Jump to Selection" = Cmd+J

Bug: 868405
Change-Id: I83a6e7fdecb21b5d9e0aabd2ecb8fc4483d7a273
Reviewed-on: https://chromium-review.googlesource.com/1153142Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578820}

The TouchInputBrowserTests were flaking across OSes.
This was due to how it was waiting for frames. It was waiting for a
visual properties synchronization to have been started. However, while
this leads to a frame being generated, it does not block until that
frame is produced.

This change updates the frame syncing.
Now it will use RenderFrameSubmisisonObserver to wait for a frame from the URL load to be generated.
For non-Android it will then set a size, which triggers a visual properties sync. Then it will wait for a frame to be generated.
On Android, this size is set in the initial page load, so there is no synchronizing here.
Furthermore for Viz Hit Testing, a wait for hit test data is added.

TEST=TouchInputBrowserTest

Bug: 346363, 514456,855532
Change-Id: Ifa9179af9234d98c5be5575876c061763edb9f4e
Reviewed-on: https://chromium-review.googlesource.com/1147322Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578819}

Creating an OWNERS file in the third_party/blink/renderer/modules/navigatorcontentutils
and adding myself as owner.

Gyuyoung has mainly fixed wrong behaviors, synced with the updated specification, and
improved test cases. He has landed about 20 CLs and reviewed some CLs for this
feature.

Bug: None
Change-Id: I3cd91b3206489b88c85deee52424d24c683bd7ba
Reviewed-on: https://chromium-review.googlesource.com/1152332Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#578818}

These builders do not use the chromium recipe.

Bug: 868525
Change-Id: Iac4a05d46397e70a25e47ca3a27a27300b32cff9
Reviewed-on: https://chromium-review.googlesource.com/1153297Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578817}

Add <h4> to page and window titles for easier navigation.

Bug: 839042
Change-Id: Ic20f90cd9379fd8c6df8122691b5819c97248338
Reviewed-on: https://chromium-review.googlesource.com/1153576
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578816}

Bug: 756094
Change-Id: Ic492595a0b79202157d6b7ad9c588c518f417f92
Reviewed-on: https://chromium-review.googlesource.com/1116183
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578815}

Most errors found by flake8 are fixed. The exceptions are:
- E111: indentation is not a multiple of four
- E121: continuation line under-indented for hanging indent
- E501: line too long (> 79 characters)

Bug: None
Change-Id: I6d85b3b170d5e0682e30c564e9dbaf185bb55168
Reviewed-on: https://chromium-review.googlesource.com/1152125Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578814}

No functional change. Group methods together by the class they override
from.

Change-Id: I9f6850bae872239915d9e698b9e2020c6efcef8c
Reviewed-on: https://chromium-review.googlesource.com/1153613Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578813}

This differs from the initial phase's testing config as the default
behavior is now to show only the lock icon for non-EV HTTPS sites, so
we set the new testing config to "both-to-lock" to set it to the lock
icon for all HTTPS.

Bug: 803138
Change-Id: Ia3a7a4e1b07098e0cfa73d95fa2866fdad8b7343
Reviewed-on: https://chromium-review.googlesource.com/1153565Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578812}

Below commit removed the test by mistake. So this CL adds it again.

Surface synchronization: Make sure viewport size is updated with DSF/LocalSurfaceId
e65f318c

Bug: 839687
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iae469948a3a88fb09fa9828e3e2e4d3cd1557681
Reviewed-on: https://chromium-review.googlesource.com/1152709Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#578811}

This follows post-commit feedback on
https://chromium-review.googlesource.com/1088918

Bug: 751996
Change-Id: I230c4ff13122d7977ee6f2901cd08a25f67466a5
Reviewed-on: https://chromium-review.googlesource.com/1148395Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578810}

Introduces the SequencedTaskSource interface to //base. This should ultimately
be coalesced with a similar interface used by SequenceManager but this CL was
complex enough in isolation that it was easier to introduce only the basic API
for now.

MessageLoop will as a follow-up expose an API that will allow it to be created
with a custom SequencedTaskSource. This will enable
ScopedTaskEnvironment::MOCK_TIME on custom MessageLoops (i.e. ForUI/ForIO) and
soon after on all threads (not just main thread), since TaskScheduler's delayed
tasks are managed on a MessageLoopForIO. Finally this will allow MOCK_TIME on
TestBrowserThreadBundle (which uses a MessageLoopForUI); nicely rounding out the
MOCK_TIME APIs.

In this CL the following semantics have changed in MessageLoop :
 * MessageLoop::unbound_task_runner_ ->
    - MessageLoop::underlying_task_runner_
    - MessageLoop::task_runner_ still initially set to it
    - but now const to clarify lifetime (and not set to null in
      ~MessageLoop() as this was pointless)
    - Implements SequencedTaskSource
    - Now has a Shutdown() phase so that PostTask() that happen-after
      ~MessageLoop() returns false
      (MessageLoop::Controller::DisconnectFromParent() still required,
      see comment in ~MessageLoop())
 * IncomingTaskQueue (to be renamed to PendingTaskQueue in follow-up) :
    - no longer has a TriageQueue (MessageLoop communicates directly with
      SequencedTaskSource)
    - no longer ref-counted, strictly a member of MessageLoop
    - MessageLoop uses it as storage for tasks it must delay/defer
    - IncomingTaskQueue no longer has a Shutdown() phase, becomes
      dead storage on shutdown and dies with MessageLoop
    - Racy PostTask() on shutdown are now strictly handled between
      MessageLoop and its Controller
 * SequencedTaskSource :
    - the interface MessageLoop feeds from, initially only
      implemented by MessageLoopTaskRunner but will be made customizable
      as a follow-up
 * MessageLoop::SetTaskRunner()
    - still a thing to keep existing use cases alive but will ultimately
      die in favor of providing an external SequencedTaskSource (and
      killing all MessageLoop task_runner dances performed today :))


Note: most new logic in message_loop_task_runner.cc was moved as-is from
incoming_task_queue.cc

Bug: 708584, 860252
Change-Id: I23f40d293d2df6fe41374fad127745f2ff72fbe0
Reviewed-on: https://chromium-review.googlesource.com/1088762
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578809}

This reverts commit 41e3c570.

Reason for revert: https://crbug.com/868536 - DCHECK being hit because OSCrypt isn't set up.

Original change's description:
> NetworkContext: Always create the CookieStore and ChannelIDStore
> 
> This CL makes NetworkContexts create CookieStores and ChannelIDStores in
> the hybrid URLRequestContext creation path, where the embedder starts
> configuring a URLRequestContextBuilder, and the NetworkContext finishes
> configuring it.
> 
> The reduces redundant code, lets us test the new path in production
> before we ship the network service, and will allow Isolated App
> URLRequestContexts to need less code when they're updated to use the
> hybrid configuration path (Which I plan to do in a followup CL).
> 
> The NetworkContext constructor that takes an already-initialized
> URLRequestContext is not modified in this CL.
> 
> Bug: 789644
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Ibf40ae6497e7be06b0a666bc664ea943e145cae9
> Reviewed-on: https://chromium-review.googlesource.com/1152083
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578740}

TBR=mmenke@chromium.org,morlovich@chromium.org,cduvall@chromium.org

Change-Id: Ia9f914fac8b0fa624210363dd55333a0dfa20531
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789644
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1153232Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578808}

With the default behavior of Chrome being to not show a tab background, we want
to change themes to default to that as well, unless the theme author actually
supplies an image/color for this explicitly.  To do this, we need to support
different tab text colors for the cases where the frame colors can vary.  This
adds the framework for that support.

Right now, the default is to use the same text colors in inactive windows as
active ones.

This also gives themes that want normal and incognito windows to differ greatly
(as the built-in theme's does) the ability to implement that and still have
readable tab titles.

Bug: 866672
Change-Id: I032a72bc799d0675c517db10283513a30db23328
Reviewed-on: https://chromium-review.googlesource.com/1152418
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578807}

For boolean flags in ChromePreferenceManager, removed their setters and
getters, and let caller call writeBoolean/readBoolean directly with the
predefined keys.

Bug: 864257
Change-Id: I80c6511ff2b8ca3139a4a50a26989aa5e4495703
Reviewed-on: https://chromium-review.googlesource.com/1141358
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578806}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3fff4ff38701..3e03eba0a7e2


git log 3fff4ff38701..3e03eba0a7e2 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 tbrindus@chromium.org cros_generate_update_payload: Convert to chromite
2018-07-27 dgarrett@google.com chromeos_config: Checkin luci-scheduler.cfg.
2018-07-27 chirantan@chromium.org cros_setup_toolchains: Add llvm-libunwind as an extra package
2018-07-27 vadimsh@chromium.org cipd: Bump cipd client version to the one that understands SHA256 hashes.


Created with:
  gclient setdep -r src/third_party/chromite@3e03eba0a7e2

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I23aa03b0168fe1dd0959748474fe74c7f5aa8632
Reviewed-on: https://chromium-review.googlesource.com/1153509Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578805}

Add the following tests to the Fuchsia filter for content_unittests:

- BluetoothBlocklistTest.InvalidUUID
- RenderWidgetHostViewAuraTest.SyntheticFlingCancelAtTouchpadScrollBegin
- WebBluetoothDeviceIdTest.DefaultConstructor

Bug: 776424, 867502
Change-Id: I7e588b3946e640cb77b46cace1ef8ab79385f5b8
Reviewed-on: https://chromium-review.googlesource.com/1150803
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578804}

Bug: 868463
Change-Id: I6183b008ba749dcde3b317fbccc0636053e8a667
Reviewed-on: https://chromium-review.googlesource.com/1153578Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#578803}

Survey base/task_scheduler for remaining unprefixed "BACKGROUND" strings
referring to task priority (i.e. not referring to
"background thread priority").

Best-effort survey of the codebase for "BACKGROUND priority" left behind
in comments.

Update docs and remove TaskPriority::BACKGROUND for good

TBR=robliao@chromium.org

Bug: 863341
Change-Id: I055ac623767c1d77895d78dbf544a2d781a6637d
Reviewed-on: https://chromium-review.googlesource.com/1153461
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578802}

The class names should end with "Test", and the test* methods should
use relevant names.

Bug: None
Change-Id: I53ad14e3e19674f96218fcb9eb2d7646dedb1754
Reviewed-on: https://chromium-review.googlesource.com/1152116Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578801}

This change removes queuing the DidCommitAndDrawCompositorFrame message
when Chrome commits a paint update. Queuing the message causes an
additional blink update, resulting in a serious performance regression.

The original intent of queuing the DidCommitAndDrawCompositorFrame
message is to notify the WebContents when Chrome performs a paint, which
in turn helps Chrome's experimental capture sites automation test framework.
Since this performance regression is particularly large, and the absence
of this event only impacts the test framework, we decide to remove
queuing the message for now.

Bug: 866981
Change-Id: I20e6fa6dbe1fd30f1529d6dda20e6208ae719bd1
Reviewed-on: https://chromium-review.googlesource.com/1153594Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578800}

Adding the navigation category to get better trace for omnibox debugging.

R=oysteine@chromium.org

Bug: 868419
Change-Id: I08842d4f8de7845f63a8add5ef2f10ab460b1ce5
Reviewed-on: https://chromium-review.googlesource.com/1153457Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578799}

Relanding go/chromium-cl/1145892 with the fix.

This reverts commit 3f6d2857.

Bug: b/111694183
Test: Numerous runs of cast_media_unittest
Change-Id: I46dd922bd99e8a957d90446cfcebd56f405fdc0f
Reviewed-on: https://chromium-review.googlesource.com/1153504Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578798}

This reverts commit 1ba5d611.

Reason for revert: Broke chromeos builders.

Original change's description:
> build: Enable ThinLTO in official Android builds.
>
> With this change we start building Chromium with ThinLTO when targeting
> Android. In 64-bit Monochrome builds, the 32-bit binary is also built
> with ThinLTO. This change is expected to reduce code size significantly
> (in local measurements it reduced the size of MonochromePublic.apk by 2.3MB)
> and is a prerequisite for enabling control flow integrity in official
> builds.
>
> Note that although this change enables ThinLTO, it does not enable
> the cross-TU optimizations normally associated with LTO. Enabling
> cross-TU optimizations is a separate project.
>
> On my local machine (a Lenovo P920) libmonochrome.so link times increase
> as follows:
>
>          before  after (first link)  after (incremental links)
> 32-bit    18s          140s                     50s
> 64-bit    13s          107s                     41s
>
> All known blockers have now been fixed. This CL is likely to uncover
> unknown blockers.
>
> Bug: 469376
> Change-Id: I8981e17abd50bc5ca00440e0d74dda878c911749
> Reviewed-on: https://chromium-review.googlesource.com/1150870
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578195}

TBR=thakis@chromium.org,dpranke@chromium.org,pcc@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 469376, 868426
Change-Id: I3938b0bbc5fdc0d689de21b52de2dd859852139b
Reviewed-on: https://chromium-review.googlesource.com/1153396
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578797}

InProcessCommandBuffer doesn't currently handle dropping to 565
low-bit-depth on low-end Android. This CL adds this logic.

To safely handle low bit depth and virtualized contexts, we need
to know whether our target bit depth is compatible with the default
offscreen context. This change passes the surface format of this
context through CommandBufferTaskExecutor to allow this to be queried
from InProcessCommandBuffer.

Finally, as error-handling for the creation of the offscreen surface
is currently a bit scattered, this CL simplifies things by creating
this surface during init and passing it in to GpuChannelManager, so
any callers can just assume success.

BUG=868476

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8ffaa05e2ebbf6e910e76a8ef75095edf1cd3fe5
Reviewed-on: https://chromium-review.googlesource.com/1150966Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578796}

https://android.googlesource.com/platform/external/perfetto.git/+log/ae0c5273bfa1..7e4b89eab724


git log ae0c5273bfa1..7e4b89eab724 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 michaschwab@google.com Number of Grid Lines depends on window width
2018-07-27 hjd@google.com perfetto-ui: Add TrackControllerRegistry


Created with:
  gclient setdep -r src/third_party/perfetto@7e4b89eab724

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I17ba02694a0a55eeb6010825f92c1168c089b6df
Reviewed-on: https://chromium-review.googlesource.com/1153511
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578795}

In order to use geometry mapper, we need to ensure that the prepaint
step of the lifecycle has run. However, if the target frame is
throttled this is not the case. We don't want to force run it, because
it causes compositing to run which has memory implications. Instead
fall back to slow path in intersection geometry.

Bug: 868230
R=chrishtr@chromium.org, pdr@chromium.org

Change-Id: Icaef44dd3e399b12df77eb550eb5ae0fa43291b6
Reviewed-on: https://chromium-review.googlesource.com/1150876
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578794}

In the two (soon to be three) places where we call
BluetoothPairingDialog::ShowDialog, we first call
device::BluetoothDevice::CanonicalizeAddress(address).

We should do this in the ShowDialog call instead to simplify the
calling code.

Bug: 756094
Change-Id: Ie4b6ee4935bd9a632e231f5c07b4830fc590a832
Reviewed-on: https://chromium-review.googlesource.com/1153573Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578793}

This CL inserts the appropriate strings to be displayed in the unified
setup flow, and adjusts some styling to match the mocks.

Still to be done:
(1) Adding animations on both the "start setup" and "setup succeeded"
    pages; these animations have not yet been provided in the required
    SVG or PNG formats.
(2) Inserting the correct icons on the "start setup" page; currently,
    the Google "G" icon is displayed multiple times. These icons have
    not yet been provided by UX.
(3) Adjusting the forward/backward button styles. Multiple sets of
    mocks exist, each with different styles and different button text.
(4) Making the pages "pixel-perfect"; this CL causes the page to match
    the mocks roughly, but there are a few edge cases. I didn't make all
    CSS perfect yet due to some inconsistencies with the mocks, and I
    want to make sure that the mocks are truly finalized before
    perfoming the rest of the UI polish work.

Bug: 824568
Change-Id: I840afcb30f07d9d899ff17e156faa0268a5f556e
Reviewed-on: https://chromium-review.googlesource.com/1152030Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578792}

Moved the incognito toggle button to the bottom toolbar and removed
the new tab button and incognito toggle button from the top toolbar.

Bug: 847639

Change-Id: I1a8c081251f2058f74ec7ad9b76865758fe136e4
Reviewed-on: https://chromium-review.googlesource.com/1152541
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578791}

These will eventually be used for three purposes:
(1) To allow generating different background tab images from a common tint for
    the inactive and incognito cases, thus allowing background tabs that blend
    into the frame for custom themes.
(2) To allow autogenerating the background tab colors from the background tab
    images, thus letting us autocalculate better tab text/separator/etc. colors.
(3) To allow theme authors to customize/override this behavior more precisely.

Reasons (1) and (2) dictated the design here; reason (3) is basically a free
bonus.  I thought about not making these resources overrideable by theme
authors, but there was some technical reason that turned out to not be easily
feasible, and there seems little reason to prevent it.

This also allows us to read THEME_TAB_BACKGROUND_INCOGNITO on Mac (Views).

This shouldn't result in a visual change on its own.

Bug: 862664
Change-Id: Icc57f78fd526d68b83c692fbac669a7371bb38ff
Reviewed-on: https://chromium-review.googlesource.com/1147869
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578790}

https://chromium.googlesource.com/catapult.git/+log/d8072e683a00..b9813d2fdd13


git log d8072e683a00..b9813d2fdd13 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 changwan@google.com Attempt to fix flakiness in webview_startup perf tests


Created with:
  gclient setdep -r src/third_party/catapult@b9813d2fdd13

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:814330
TBR=sullivan@chromium.org

Change-Id: I13248cdb34caeee208cd90f7c8e03f7c40e81cc6
Reviewed-on: https://chromium-review.googlesource.com/1153288Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578789}

Homepage tile should not be added to Most Visited tiles if the homepage
url is google.com.

Bug: 862786
Change-Id: Icb42ce4fb5f0c26bece80b7a7dd82bfd8526bcb2
Reviewed-on: https://chromium-review.googlesource.com/1152298Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578788}

IP config only exists for connected networks.
Proxy config only exists for networks with a proxy configured.

Storing these as a DictionaryValue takes 32 bytes, whereas storing these
as a unique_ptr<> only takes 8 bytes. It also makes the symantics of
whether or not the property as set a bit more clear.

Bug: 651157
Change-Id: I4ab04ada996406bcace85c9038ac35f32b77054d
Reviewed-on: https://chromium-review.googlesource.com/1152148
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578787}

In this patch, we introduce a feature behind the flag: TouchpadAsyncPinchEvents
to improve touchpad pinch zoom performance.

We record the ACK of in a synthetic wheel event the first in pinch sequence.
Then send the rest of the synthetic wheel events of the pinch sequence as
non-blocking if the first event’s ACK is not consumed.

We also add phase information to synthetic wheel event based on pinch event
phase.

Bug: 565980
Change-Id: Ic5d642d75f4102ee12b86fded0d6418fbe8b76e3
Reviewed-on: https://chromium-review.googlesource.com/1140909Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578786}

Adds a couple of extra waitForTabPageLoaded to
VrBrowserNavigationTest#testIncognitoMaintainsSeparateHistoryStack as
a workaround for Incognito tabs reporting page load too quickly, which
was causing flakiness.

This can be removed once the root cause is fixed.

TBR=asimjour@chromium.org

Bug: 868506
Change-Id: Ie91a8213e641d9f51dc353d5215e8ac0695db059
Reviewed-on: https://chromium-review.googlesource.com/1153614Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578785}

This prints an error if:
- A line begins with '//' or '/*'
- A non-comment contains a whitespace
And prints a warning if:
- A filter file contains both inclusions and exclusions

Bug: 868000
Change-Id: I2a04504d3a17f4f7536b529a0e2e626eb6e61f66
Reviewed-on: https://chromium-review.googlesource.com/1153427
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578784}

WillSendRequest for main resource happens during BeginNavigation, so we can just
skip it during commit time.

The logic of saving metrics from DidReceiveResponse has been copied to CommitNavigation.
We could get rid of DidReceiveResponse entirely if we were always going through
CommitNavigation path, but we sometimes don't (see kWebNavigationPolicyCurrentTab
returned from RFI::DecidePolicyForNavigation).

Bug: 855189
Change-Id: Ib78bda6e22e4a301adf7c66215568ca6f02fa01d
Reviewed-on: https://chromium-review.googlesource.com/1145900
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578783}

Create observer interface so that WebAuthN UI components (i.e.
ChromeAuthenticaterRequestDelegate and AuthenticatorRequestDialog) can
get notified of device discovery.

Bug: 866601
Change-Id: I0af544f4c3754bd0b76b6a354833ed12858a0967
Reviewed-on: https://chromium-review.googlesource.com/1147307
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578782}