- 21 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bb9ade82457a..536c641b7736 git log bb9ade82457a..536c641b7736 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 mythria@chromium.org Update V8 runtime_stats to use different pattern for optimize background Created with: gclient setdep -r src/third_party/catapult@536c641b7736 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: None Change-Id: Ic46c6cb5d9e8c687c141b10d7a6ce5567a4afbe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717619}
-
Eric Seckler authored
This reverts commit 7a502f46. Reason for revert: patch that caused the failures was reverted Original change's description: > Disable failing tests on android-go_webview-perf > > Disabling the following tests on android-go_webview-perf: > * system_health.common_mobile/browse:media:youtube:2019 > * system_health.common_mobile/browse:news:nytimes:2019 > * system_health.common_mobile/browse:news:cnn:2018 > > TBR=crouleau@chromium.org > NOTRY=true > > Bug: 1026822 > Change-Id: I2581e3c21158edff2563de628bfa41de7349271d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927216 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717272} TBR=crouleau@chromium.org,johnchen@chromium.org Change-Id: I0cf407e4ec8f3a44afa229c9fae82c064d9bb9a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928322Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#717618}
-
Jit Yao Yap authored
A new login_screen_extension_ui namespace is added to replace the LoginScreenExtensionUi prefix (i.e. LoginScreenExtensionUiFooBar is converted to login_screen_extension_ui::FooBar). This namespace will cover code specific to UI presented by login screen extensions on the signin screen. Bug: 988379 Change-Id: I3896b175e195da44703e11c5a824b79c2ab2c6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919928 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#717617}
-
Henrik Lundin authored
The underlying metric is added in https://webrtc-review.googlesource.com/c/src/+/160045. Bug: webrtc:10549 Change-Id: I8d4c9e14e4b73ede8021f286bc64c21c32cad120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925066 Commit-Queue: Henrik Lundin <hlundin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#717616}
-
Mathias Carlen authored
Before this patch we used the device/platform locale to set/get things in autofill profiles. That locale is dropped in the autofill code and not used at all. This patch removes the locale logic from two actions. The consequence now is that the mock in tests does not set the full name and that is used in the completeness comparison. The fix used here is to always construct the FullName from the first,middle,last triplet when needed. R=arbesser@google.com, marianfe@google.com Bug: 806868 Change-Id: I0835da87a07c409af8832cd052f6654372b8dcf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926487 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#717615}
-
Anatoliy Potapchuk authored
Since we are moving away from good old base::Value in favour of the new one which is not able to do the expansion, we should be reading the data layer by layer, rather that simply concatenating them by a period ".". Bug: 1006230 Change-Id: Ica7298eb44f186adff00b2e565a8c85646806321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926767 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#717614}
-
Raphael Kubo da Costa authored
* Reorder arguments in ScriptIterator's constructor that takes a v8::Isolate. In general, functions that take a v8::Isolate* have it as the first argument. Make ScriptIterator's constructor follow suit for consistency. * Replace the ScriptIterator(nullptr_t) constructor with a default one. Taking a nullptr (as well as not making the constructor explicit) never made much sense in the first place. Change-Id: I19873f5e6c1996279c76029aa3303fe50a890023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928778Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#717613}
-
Sylvain Defresne authored
All private frameworks needs to be codesigned, so ensure they are signed (this is useful when using binary framework pre-compiled). Bug: 1012115 Change-Id: I9953c391bc3c203ce7b34055690a3cccd23d2acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926485 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#717612}
-
Dominique Fauteux-Chapleau authored
Adds round trip time for the user download access point, for each result value and bytes/sec for successful results. Bug: 1020267 Change-Id: I2eab7272afb71d3abf4a37e71da10bbdabcf5911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917464 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#717611}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: If2317def8d94c339c3a3bb8d8c6518347a718da8 Bug: 988343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928817 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Kent Tamura authored
* Rename IDLDate to IDLDateOrNull to reflect the reality * Rename ToCoreDate to ToCoreNullableDate * Change |double| argument of InputType::SetValueAsDate() to base::Optional<base::Time> * Change |double| argument of |BaseTemporalInputType:: SerializeWithMilliseconds| to base::Optional<base::Time> * Rename SerializeWithMilliseconds to SerializeWithDate This CL has no behavior changes. Change-Id: I2d8476821317a4577ddcf26a2c88eb9809425ed9 Bug: 988343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928512 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#717609}
-
Tim van der Lippe authored
The Runtime exists in the Root namespace now. In an upcoming change in the DevTools frontend [1], the Runtime.js is loaded as a proper ES module, instead of injected into the build artifacts by the build system. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1926503 Bug: 1006759 Change-Id: Ifdd4c7329163637bb461d5466ba3efdc38ebc532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928705Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#717608}
-
Yi Su authored
Search engine setting should have the same trailing inset for separators as other settings. Bug: 937015 Change-Id: Ie9f75ebcb06c9fe927901490d4cb3ec607eab013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928776Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#717607}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fdbc1acec72f..bf492e4910bb git log fdbc1acec72f..bf492e4910bb --date=short --no-merges --format='%ad %ae %s' 2019-11-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 2377845dd216..f2c9ce1e08ed (4 commits) 2019-11-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 40cd2166a446..39b3005ba560 (26 commits) 2019-11-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 720c5deb0244..53902309eda9 (9 commits) Created with: gclient setdep -r src/third_party/angle@bf492e4910bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Ie398ebdeb8500f5859570c045a30db14bdebcdc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928019Reviewed-by:
-
Maksim Sisov authored
Previously, we've assumed that the tooltip manager never shows tooltips if a mouse pointer is hovered over a popup window. This lead to wrongly placed tooltips whenever one was shown right below a popup window (like the one shown when a user clicks on a bookmarks' folder), and as long as the tooltip manager always places tooltips in screen coordinates and the WaylandWindow used that popup window as a parent window, the tooltip has had an offset equal to the position of that popup window in regards to a toplevel window. Basically, it looked like that: toplevel window __________ | _____ | | |popup| | | ----- | | __ | | |tp|| | -- | ---------- Where tp is the tooltip and is a child of a popup surface, but positioned relatively to the toplevel window. The origin of each window looked like this: toplevel - 0,0 popup - 10, 10 (relative to the toplevel) tp - 15, 15 (relative to the toplevel) Instead, the tp must be positioned relatively to the popup window: toplevel window __________ | _____ | | |popup| | | |tp| | | | ---------- And the origin became the following: toplevel - 0,0 popup - 10, 10 (relative to the toplevel) tp - 5, 5 (relative to the toplevel) Also fixed the way how the tooltips are hidden and stopped caching the parent as long as the tooltips may be potentially reused and shown for different parents. Test: WaylandWindowTest.TooltipSimpleParent, WaylandWindowTest.TooltipNestedParent Bug: 1026600 Change-Id: I4a89e70f2e99010b6c76a3f12176d8ff51671bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926318 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#717605}
-
Greg Thompson authored
- Make ShutdownType an enum class. - Introduce browser_shutdown::HasShutdownStarted as a convenience. - Switch from UMA macros to functions for one-shot metrics. (cherry picked from commit 11936b31) BUG=958865 Change-Id: I2c6c018f1b2b298f19cdde819477ab084f2d1c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924192Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#717604}
-
Roman Aleksandrov authored
Add all needed functionality for the new Packaged License screen. Bug: 1024809 Change-Id: Ic7f4a3a8b5d64d414bf317d52e6acd4bc1f79426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904198Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Tim Schumann authored
EnableDisableSingleClientTest are parametrized tests that were missing their instantiation which caused them not to be run. This was an oversight in https://chromium-review.googlesource.com/c/chromium/src/+/1895797 Change-Id: Ib2d44a11dbc3f2fe28818ced27877cd8c4116bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928696Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#717602}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/94b4a0baf8bc..7fa83680ccbb git log 94b4a0baf8bc..7fa83680ccbb --date=short --no-merges --format='%ad %ae %s' 2019-11-21 hablich@chromium.org [Infra] Whitespace change for testing Created with: gclient setdep -r src/third_party/devtools-frontend/src@7fa83680ccbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1021467 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I97d63b54eeac175acf88a2e72619cca2df7afdf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928971Reviewed-by:
-
Clemens Arbesser authored
This CL fixes a bug in the bottom sheet where size change notifications while in SCROLLING state where ignored. See the linked bug for more information. Bug: b/144838045 Change-Id: I825ed22c2078873fcf7295f86e99d4b14b01cc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926479Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#717600}
-
chrome://policyVladislav Kuzkokov authored
Bug: 1018466 Change-Id: I8e1478be2ed448105354fa6dcb15cbfa241be512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926949Reviewed-by:
-
Jonathan Ross authored
This reverts commit 24689a76. Reason for revert: Suspect this breaks SnapshotBrowserTest.SingleWindowTest going to do a trybot run Failing build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20FYI%20SkiaRenderer%20Vulkan%20%28Intel%20HD%20630%29/3704?blamelist=1#blamelist-tab Original change's description: > Use Skia API for Vulkan readback > > This CL switches to using new Skia API for GPU accelerated readback > with the Vulkan backend. Subsequent CL will also switch over GL > backend from (GLRendererCopier). > > Notable changes: > a) Using asynch GPU readback instead of synch CPU readback. > > b) Modified the test infrastructure to use Skia API to force a flush > of GPU pipeline (so that it works on Vulkan). This guarantees that > asynch readback completes. > > c) Instrumented LayerTreePixelTest with a flush. This path did not have > a flush on it previously. This was necessary to make cc_unittests > pass with TSAN builds (which change timing). > > Bug: 1022495 > Change-Id: I35a8d4b9ceab96455d179b91c68528228fbb4962 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917622 > Commit-Queue: Jonathan Backer <backer@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717143} TBR=penghuang@chromium.org,backer@chromium.org,kylechar@chromium.org Change-Id: I53efac647f62a7bf237af5019fe70df2afcbe923 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927224Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#717598}
-
Francois Beaufort authored
This CL adds UKM counters to NDEFReader.scan and NDEFWriter.push. Bug: 520391 Change-Id: I33e8f8ad90b20871eb24622531c93ce387d873f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910089 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#717597}
-
Morten Stenshorne authored
When block-fragmenting, we always need to know the block-start offset before laying out anything. To calculate the block-offset of a float, we need to know its inline-size, to figure out if it can fit beside earlier floats or not. To calculate its inline-size, we have to lay it out. This means that we may need to guess its block-offset and lay it out. After layout we know the inline-size of the float, and then we can calculate its exact position. If our initial guess was wrong, we need to lay out again at the correct position. A different block-offset may lead to different fragmentation inside the float. Bug: 829028 Change-Id: Ibef71d124704116d788cd755467a26d4c26ada4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926315Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#717596}
-
Andrew Bennetts authored
Bug: 998357 Change-Id: I72329cc53c7526d6bb62dc1fd6346c0178bc8785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914590Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Andrew Bennetts <abennetts@google.com> Cr-Commit-Position: refs/heads/master@{#717595}
-
Maksim Sisov authored
To avoid adding more platform specific interfaces, it is better to extract the APIs into platform extensions. The platforms are then free to implement the interfaces and set a property for that specific extension on the platform window they implement. This allows more flexibility and makes ui/views less platform dependent. This change extracts workspace related APIs into a separate extension. Bug: 1016556 Change-Id: Ieed247f908d258f2b6edb93aa263f0433767e74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917765 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#717594}
-
Monica Basta authored
The GAIAInfoUpdateService uses the |ProfileDownloader| to download the primary account or the unconsented primary account info. Also, the |AccountTrackerService| downloads and tracks these info as well. Instead of downloading the same info twice, we stop using |ProfileDownloader| in |GAIAInfoUpdateService| and retrieve the info from the |AccountTrackerService|. Change-Id: I24b101d4baaaa19197cbbe81a6ad7d13e2450715 Bug: 1025691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835363Reviewed-by:
-
Steven Bingler authored
This CL, and description, is based extensively on https://crrev.com/c/1592454. This CL adds a field, source_scheme_, to CanonicalCookie to store whether the scheme of the cookie's source origin was secure (i.e. https or wss). If this information is not provided the field is marked as unset. This also updates Blink::CanonicalCookie to add an analogous field. This also updates the SQLitePersistentCookieStore to v12 to add a column for this new field. Existing cookies in the database are marked as unset. This also updates the cookie serialization scheme on Android. Bug: 1021284 Change-Id: I877262307571fad7668208995fec741097b3d057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898301Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#717592}
-
Swapnil authored
For upload attempts made after kLogThrottleCount, earlier the check was that it should be within a small delta time of kLogThrottleWindowDuration. The small delta time could break the test, hence it is sufficient to check that the delay is greater than 0. Bug: 1022591 Change-Id: I8b7a9cf363120e7149488e81ba380172776c420c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906370Reviewed-by:
-
Greg Thompson authored
Once upon a time, Chrome used breakpad for handling crashes. When restarting the browser after disabling crash reporting, it was once important to clear the CHROME_BREAKPAD_PIPE_NAME environment variable to be sure that the new process didn't connect to the old crash handler. Chrome has since been migrated from breakpad to crashpad. As a result, neither this env var nor the exported function in chrome.exe exists. BUG=546288,958865,1025634 R=bcwhite@chromium.org, mark@chromium.org Change-Id: Ied7311016c208563613027603af2b03f349bd405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924469 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 1023677 Change-Id: I597790855c76f80d94e1cfc89495cee97e92488d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926671 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#717589}
-
Alex Ilin authored
There are no users of the deprecated shared memory left, so its code can safely removed. To use shared memory in Chrome, please refer to base::WritableSharedMemoryRegion and base::ReadOnlySharedMemoryRegion classes. This CL removes all remaining #includes of "base/memory/shared_memory.h" and "base/memory/shared_memory_handle.h". They are replaced by new shared memory includes when needed. It also appears that "base/files/file_util.h" and "base/posix/eintr_wrapper.h" were transitively included in many places through the removed files. This CL includes them explicitly in all those files. TBR: wfh@chromium.org Bug: 795291 Change-Id: I97ecac4b529c0ad6498b6e5ccf01515f750448ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919152 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
David Benjamin authored
Alas we haven't yet managed to enforce this. Next year hopefully. Bug: 1025840 Change-Id: I773612f3ed185a3edbd6110421777beabf4f2d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922969 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=hbos@chromium.org Bug: 1023677 Change-Id: I5fbe780a4db60b341fe697b9b33a0a453459927f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925461 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#717586}
-
Henrique Ferreiro authored
Migrate users of blink::OutOfProcessFont to gfx::FallbackFontData. This allows to remove blink::OutOfProcessFont from the Blink public API. Additionally, also replace blink::PlatformFallbackFont, which was a duplicate of OutOfProcessFont in terms of members. Bug: 1020993 Change-Id: If12901d186a50f04e795171022c63a3b5fceb3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917535 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
This CL introduces a new class that encapsulate the save/update logic. 1- This makes the password form manager smaller and more maintainable. 2- The save/update logic is now better testable. 3- This will allow introducing the multi-store password save manager which will be needed for Butter for Passwords without touching the PasswordFormManager class. TBR=vasilii@chromium.org Change-Id: Ib2c3d134ba5e94975610d263da6bece3bb5c3302 Bug: 1012203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865158Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#717584}
-
tby authored
This crash looks to be caused by accessing a null base::Value, and there's only one unchecked access in the EnforceLoggingPolicy. This CL adds a null check there too. Logic change: The code block checks whether an arc app is syncable and, if so, whitelists it for logging. Otherwise it whitelists a generic 'some app' for logging. This change means that, if we can't establish whether an arc app is syncable, we assume it is *not*, and add the generic app. As far as I understand, this complies with logging policy. Bug: 1026967 Change-Id: I2b33e81d847a82fdceea97e75acf8bd9a7acee3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928457Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#717583}
-
Yuki Shiino authored
It's invalid that DOMString / USVString have default value of IDL null. Removed such use cases. https://crrev.com/c/1920018 will prevent writing this sort of mistakes in future. Bug: 1024695 Change-Id: I9d21bfda685ba54bce3d0e32aa0a2fd111b621d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926094 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=toyoshim@chromium.org Bug: 1023677 Change-Id: If25fcb12308719437e56883f20cff1c83d435b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924962 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#717581}
-
Colin Blundell authored
This CL paves the way for reusing //chrome's SSLBlockingPage(Base) in WebLayer by componentizing them. We do not componentize ssl_blocking_page_unittest.cc at this time as it fundamentally relies on //chrome-level mechanisms. We are going to investigate whether the test really is conceptually //chrome-level (in which case we'll rename it to something like chrome_ssl_blocking_page_unittest.cc) or whether the mechanisms that it relies on for validating its tests can be converted to mechanisms available in //components. We also do not put the moved files in the security_interstitials namespace at this time to avoid churn with further moves that will occur. TBR=mkwst@chromium.org Bug: 1025059 Change-Id: I4c594c3b4d53f804847919bb5c3be86444767730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924252 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#717580}
-
