- 28 Nov, 2018 40 commits
-
-
mrefaat authored
Tab no longer use the VoiceSearchTabHelper, so ordering is not needed any more Bug: 778416 Change-Id: I37a84f76de97be5af8956eb829808f86ac839468 Reviewed-on: https://chromium-review.googlesource.com/c/1353937Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#611943}
-
Michael Spang authored
This was replaced by ScenicGpuHost but not removed. Bug: 861853 Test: compile Change-Id: I6c982b87a6f9d64abb975ebfd4ac2d024333d503 Reviewed-on: https://chromium-review.googlesource.com/c/1354480Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611942}
-
edchin authored
This is a reland of d3708f20 The previous CL did not return the device to the original rotation. Original change's description: > [ios] Create UI test for page info (site info) > > This CL creates an UI integration test that tests that the > page info view gets automatically dismissed on device rotation. > > Change-Id: I02611cc2fab5a214b74af01d15cd8d12e19eff6e > Reviewed-on: https://chromium-review.googlesource.com/c/1338561 > Commit-Queue: edchin <edchin@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608844} Change-Id: I5c4a8286275b1ab3d411d4e355557d499607437a Reviewed-on: https://chromium-review.googlesource.com/c/1343517 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611941}
-
Douglas Stockwell authored
The motivation to do this is to be able to convert in annotation mode when the plugin is not active. Fortunately it turns out that there is enough information to do this without communicating with the plugin -- the dimensions of each page are available and the translation from points to pixels is straightforward. This new implementation also deals with the case where the document has been rotated. Bug: 902646 Change-Id: Id2814f96f6020c44cee07f725f5170494f1b512b Reviewed-on: https://chromium-review.googlesource.com/c/1347646Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#611940}
-
Tom Anderson authored
When using native GTK frame buttons, we only want the padding returned by NavButtonProvider::GetTopAreaSpacing() to apply to the side(s) that actually have frame buttons on them, otherwise the padding on a tab that is adjacent to the frame edge will depend on which GTK theme is used, rather than being constant across all themes. BUG=None R=pkasting Change-Id: Ibf5bb40c0d51d6387ca2b21abc54b1adad8f69b0 Reviewed-on: https://chromium-review.googlesource.com/c/1287261 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#611939}
-
Becca Hughes authored
Add docs for using MediaController. BUG=893296 Change-Id: I5e836749d94b0274d7bc10ee31c03469d1d01cb4 Reviewed-on: https://chromium-review.googlesource.com/c/1354481 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#611938}
-
Kyle Horimoto authored
Originally landed as: https://chromium-review.googlesource.com/c/1352855 Reverted as: https://chromium-review.googlesource.com/c/chromium/src/+/1354327 First patch set includes original CL, and subsequent patches contain updates to fix the failing test. Original CL descrition: When a SecureChannel disconnects due to authentication failures, BleConnectionManagerImpl invokes the relevant failure callback, which then causes ConnectionAttemptBase to cancel the connection attempt. When the attempt is cancelled, the SecureChannel object is deleted via BleConnectionManagerImpl::ProcessPotentialLingeringChannel(), but BleConnectionManagerImpl::HandleSecureChannelDisconnection() assumed that the object was still valid and tried to to remove itself as an observer, causing a segfault. The fix is to check whether the object has been deleted before attempting to call RemoveObserver(). Bug: 905904, 909883 Change-Id: I770bff8f05865aeac8b7513d7193d0b7a40d056e Reviewed-on: https://chromium-review.googlesource.com/c/1354333Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#611937}
-
Xiaohui Chen authored
* Pass in profile instead of mojom connector, this will guarantee the profile and connector always matches Bug: 908919 Test: locally build and run Change-Id: Iae0a73524456c108c75e1a21400d28a99afe6cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1352769 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611936}
-
Mike Wittman authored
This interface is unused within CallStackProfileBuilder. The equivalent functionality will be supported eventually within the class but will occur via the metadata mechanism. Bug: 851163 Change-Id: I3bd8430de70c973c3e4a293118403312b977f8d1 Reviewed-on: https://chromium-review.googlesource.com/c/1351533Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611935}
-
James Cook authored
Flaky DCHECKs in the ash process, likely threading issues. Bug: 909736 Change-Id: I080d1a30b415e10a33bb957711c0f4a68328c7ba Reviewed-on: https://chromium-review.googlesource.com/c/1354345Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#611934}
-
manuk authored
Bug: 891303 Change-Id: I07686b8d72934ad32574aa8d2b901e110c41457c Reviewed-on: https://chromium-review.googlesource.com/c/1352506Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#611933}
-
chrome://proximity-authKyle Horimoto authored
These scripts were erroneously omitted from the page, resulting in a DCHECK() failure. Change-Id: I9b1ccb554d096767d949ede14914aae13d00fbdc Reviewed-on: https://chromium-review.googlesource.com/c/1354133Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#611932}
-
Stuart Langley authored
Bug: 884020 Change-Id: I072b6902757149f93bbf40443e45b56670b04858 Reviewed-on: https://chromium-review.googlesource.com/c/1350410Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#611931}
-
Vincent Boisselle authored
This will allow using Autofill API rather than the legacy server to query and upload form data for crowdsourcing. Using the Autofill API is gated by the feature flag "AutofillUseApi". Changes should be no op if using the legacy server. Summary of the changes: > Added a function to parse the API response. > Added logic to make request data (query and upload) for API. > Added an API key attribute to AutofillDownloadManager. > Added unittests for new code branches of the API. Tests: > Updated unittests. > Did a small integration test between a local API and a chrome browser built at this CL with the API feature enabled. Tested both query and upload. Change-Id: I5933949c25d9ad9566e910002bdcd09c39983af5 Reviewed-on: https://chromium-review.googlesource.com/c/1343068 Commit-Queue: Vincent Boisselle <vincb@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#611930}
-
Clark DuVall authored
This should fix the Android Mojo bot failing. The asserts in this test were changed in http://crrev.com/c/1338660. TBR=timvolodine@chromium.org Bug: 893580 Change-Id: I9ce72b7726e553758f80b379c0c652df72b5909d Reviewed-on: https://chromium-review.googlesource.com/c/1354441Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#611929}
-
Kyle Horimoto authored
This DCHECK() asserted that a SecureChannel status change could only be AUTHENTICATED => DISCONNECTING, AUTHENTICATED => DISCONNECTED, or DISCONNECTING => DISCONNECTED. However, AUTHENTICATING => AUTHENTICATED is also a valid status change, so I added that to part of the DCHECK(). This issue was discovered when attempting to enable DCHECK()s by default in accordance with the recent e-mail announcements. Change-Id: Ia5126b70e25245f49d04939ae2e1e0bc0ea9315a Reviewed-on: https://chromium-review.googlesource.com/c/1352996Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#611928}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbdf45b8cca9..172196a4380a Created with: gclient setdep -r src-internal@172196a4380a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I86427541b8dabb2fcf848525527e7e21d983f432 Reviewed-on: https://chromium-review.googlesource.com/c/1354163Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611927}
-
Parastoo Geranmayeh authored
To show that this case is not currently supported. Bug: 909730 Change-Id: Iaca51858fa9987ef95cd9c4341386472dc55cb57 Reviewed-on: https://chromium-review.googlesource.com/c/1352507Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#611926}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 58af8aa9. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ifebbee7d79380894ac0fb87246f81a3bae510972 Reviewed-on: https://chromium-review.googlesource.com/c/1352940 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611925}
-
Esmael El-Moslimany authored
Bug: 908003 Change-Id: Iada2d816073d4f38cd0438838548d10f94d5b7db Reviewed-on: https://chromium-review.googlesource.com/c/1352944 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#611924}
-
Ted Meyer authored
Sometimes video containers report audio packet timestamps as -1, which was triggering the packet drop code from background track seeking. Bug: 902634 Change-Id: I2b74fde01f9f2e06aeaf5fa4c2a3a1a4af8ead5d Reviewed-on: https://chromium-review.googlesource.com/c/1352579 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#611923}
-
James Darpinian authored
conformance2/textures/misc/tex-mipmap-levels.html fails on some configurations, presumably due to driver bugs. TBR: kbr@chromium.org Bug: 909879 Change-Id: Icba22da20242c9dea3e9bf19f5842e75e88e7c2f Reviewed-on: https://chromium-review.googlesource.com/c/1353954Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#611922}
-
Mounir Lamouri authored
This is allowing the test to run and mark it properly as a leak test problem. Bug: 733494 Change-Id: I9c4b9276745510482e58ea89dce9c65c596bcba5 Reviewed-on: https://chromium-review.googlesource.com/c/1352619Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#611921}
-
Matt Menke authored
It needs to hold onto a reference to itself until the end of the method, instead of just until its HasOneRef() check has completed. Bug: 907524 Change-Id: I75fab97b07fe55f30a6a7c6def390f5d0bc28c4f Reviewed-on: https://chromium-review.googlesource.com/c/1352684 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611920}
-
Eric Roman authored
Bug: 901896 Change-Id: I932d2a34b63c803f1455b9d908539072ce350cd8 Reviewed-on: https://chromium-review.googlesource.com/c/1351820 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#611919}
-
Jao-ke Chin-Lee authored
Bug: 790309,790294,790286 Change-Id: I9e6a5ff635b6edda8bbe4fb87826f8cf7a5dcd5f Reviewed-on: https://chromium-review.googlesource.com/c/1354137Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#611918}
-
Mounir Lamouri authored
This is adding an DecodingInfo class that carries key system access information back and create a MediaKeySystemAccess. This implementation in //media/blink is a stub that is meant to only pass WPT tests at the moment. Bug: 907909 Change-Id: I3bac0087ca3051defb8b47d10fffdb6052814ae9 Reviewed-on: https://chromium-review.googlesource.com/c/1348733 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#611917}
-
David Quiroz Marin authored
Some of the canvas UMA histograms use the square root of total pixels in an image or canvas in this CL uses CheckedNumeric to avoid overflow. Bug: 905314 Change-Id: I10a85c5c372406449a64f1e32153d58d560e901c Reviewed-on: https://chromium-review.googlesource.com/c/1351519 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611916}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/ui/dialogs. This CL was uploaded by git cl split. R=kkhorimoto@chromium.org Bug: 589840 Change-Id: I26574d0bf7c02e2939076155ac614986be676136 Reviewed-on: https://chromium-review.googlesource.com/c/1351962 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#611915}
-
mrefaat authored
This was created for voicesearch bar which is removed with the new UI. Bug: 898697, 778416 Change-Id: Ice43ef892a886bf616f8bc2712c0a6b2d48b29f8 Reviewed-on: https://chromium-review.googlesource.com/c/1353936Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#611914}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4274496685fe..cdbaaa244432 git log 4274496685fe..cdbaaa244432 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 yueherngl@google.com octopus: fix version string generated by firmware builder 2018-11-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@cdbaaa244432 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I246e468d9c0216d141c2934febe0640905e0fd9a Reviewed-on: https://chromium-review.googlesource.com/c/1354304Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611913}
-
Ben Kelly authored
Currently there are a number of histograms that are recorded for each "operation" that is scheduled. All operations are aggregated into a single bucket. This makes it hard to tell if one operation type is having a problem. Also, some operation types are much more frequent than others which further skews the metrics. This CL breaks out these operation histograms by the type of the operation. The aggregated histograms are still preserved for detecting infrastructure level changes and comparing to historical data. This CL also migrates the OperationDuration and QueueDuration to the LONG_TIMES histogram type. We have top level metrics that greatly exceed the default 10 seconds and we expect some of the specific operations will need to measure very long values on some platforms. TBR=jkarlin cannot be easily further reduced. Bug 909894 has been filed as a follow-on to reduce the code bloat further. Binary-Size: Increase is due to a large number of new UMA histograms which Bug: 908851 Change-Id: Iee607ae8f9f15384058af4977fffcffe027e0dbc Reviewed-on: https://chromium-review.googlesource.com/c/1352479 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:Victor Costan <pwnall@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#611912}
-
Giovanni Ortuño Urquidi authored
AdapterPoweredChanged gets called right after AdapterPresentChanged when an adapter is added or removed. This causes us to call Observer::OnBluetoothStateChanged() a second time without the state actually changing. To avoid this, we cache the state whenever AdapterPresentChanged and AdapterPoweredChanged get called and only notify if the new state is different than the cached state. Bug: 908879 Change-Id: I7ca48b20678b5336346955fd2254bc68f2a09b75 Reviewed-on: https://chromium-review.googlesource.com/c/1352123 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#611911}
-
Zhenyao Mo authored
These changes are generated simply by running build_gles2_cmd_buffer.py Get this out of the way so CLs can focus on real changes. BUG= TEST=bots TBR=piman@chromium.org Change-Id: I4922a493881d8bd8abfc006f680c049fe3689d8a Reviewed-on: https://chromium-review.googlesource.com/c/1354134Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611910}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/596d6fe00db7..ac71e34d4ad1 git log 596d6fe00db7..ac71e34d4ad1 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 brandon1.jones@intel.com Change Copy Operation Interfaces to Match WebGPU IDL 2018-11-28 enga@chromium.org Factor SerialQueue into SerialQueue and SerialMap 2018-11-28 cwallez@chromium.org WireCmd: require opt-in to treat ID 0 as nullptr instead of error. 2018-11-28 cwallez@chromium.org Roll SPIRV-Tools and temporarily use Vulkan SPIRV validation Created with: gclient setdep -r src/third_party/dawn@ac71e34d4ad1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:905273,chromium:906418,chromium:908678 TBR=cwallez@chromium.org Change-Id: I4979c5123a026fa468c660f45dce4fcf4f1903ae Reviewed-on: https://chromium-review.googlesource.com/c/1354240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611909}
-
Garrett Beaty authored
Bug: 889992 Change-Id: I3cc9b095ecd19acda49e1d1d34b5b064668d7e26 Reviewed-on: https://chromium-review.googlesource.com/c/1343367Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#611908}
-
Yusuke Sato authored
The #include is needed for std::max. BUG=None TEST=git cl lint Change-Id: Ib0a0de3191b180c7f0c9774505feecad7e248a7f Reviewed-on: https://chromium-review.googlesource.com/c/1354401Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#611907}
-
Rebekah Potter authored
This reverts commit 42c0440f. Reason for revert: This causes https://crbug.com/908775, and the Blink changes that were the reason for the change have been rolled back for now. Original change's description: > Settings WebUI: Add tabindex -1 in scrolling container to prevent tabstop. > > This is necessary because of recent Blink changes at r608013. > > Bug: 905999 > Change-Id: I111e3631e4d832afb48a4161552fc27a1bbb9630 > Reviewed-on: https://chromium-review.googlesource.com/c/1343197 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609546} TBR=dpapad@chromium.org,rbpotter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 905999, 908775 Change-Id: Ie14d8cbea36dcb91d03e8e7ab7b2fdd5010fcc10 Reviewed-on: https://chromium-review.googlesource.com/c/1354235Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#611906}
-
Kyle Milka authored
If a custom background is set clear the theme attribution url. Bug: 908798 Change-Id: I2c612fa2fffaff04925a1f8d04d6b5962b0ccc4c Reviewed-on: https://chromium-review.googlesource.com/c/1354007Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#611905}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/029a56af584c..eee0f6ad0df5 git log 029a56af584c..eee0f6ad0df5 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 pcc@google.com Add crosshatch and blueline to the special root device list. Created with: gclient setdep -r src/third_party/catapult@eee0f6ad0df5 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie201d2cf5cb443d4e011ed107f93dbc96d67750b Reviewed-on: https://chromium-review.googlesource.com/c/1351263Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611904}
-