- 26 Aug, 2019 40 commits
-
-
Mohit Hotwani authored
1) Use url_loader instead of URLRequest. 2) Use network_connection_tracker instead of network change notifier. Bug: internal b/139539332 Change-Id: Ia84e3d62d22fd97d440ecf7e148ce8e663a9568d Merge-With: eureka-internal/255804 Merge-With: eureka-internal/305059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762598 Commit-Queue: Mohit Hotwani <hmohit@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Junbo Ke <juke@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#690453}
-
Clifford Cheng authored
Waits between tests are not the most ideal location. They should be placed to wait for the session to be created and receivers to show. Change-Id: I4ff4c102fbce13c63466a4f53d0b8745815f0092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769997Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#690452}
-
Matthias Körber authored
The |LeakDetectionDelegate| uses a helper class to asynchronously determine the |CredentialLeakType| for choosing which dialog to show. Change-Id: If8790ff4fda2fe74bc527816daa2efbc6b5b24ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768428Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#690451}
-
Sasha McIntosh authored
This should be a no-op refactor for existing UMAs to make them more extensible for future additions, in particular for adding similar UMAsfor jpeg decoding. Histograms to support: ...DurationUs.<DecodedImageType>.<RasterTaskType> ...DurationUs.<RasterTaskType> ...DurationUs.OutOfRaster.<RasterTaskType> Bug: 995934 Change-Id: I303dc6758a7a1da37a5c9d819fa7811a02f80843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768866 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#690450}
-
Robbie Gibson authored
Bug: 996914 Change-Id: I7ed8b5f1c23f4a3d997bc7a9c0d5a4f21aa9b67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768483Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#690449}
-
Tomasz Wiszkowski authored
This change fixes issue with third-party autofill applications, such as password managers, where these apps would receive edited URL, making it difficult to find associated data, and in turn, fail to work correctly. Bug: 996402 Change-Id: Ie4b11ddcbc7818df31f7be2ac6b6bafdfd99f6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764415 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#690448}
-
Eric Roman authored
Bug: 997372 Change-Id: Ia8f870bd9afe93c156a24271f2751c70d4972f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769726 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#690447}
-
Daniel Clark authored
Change the ControlType of <figcaption> from Group to Text per https://w3c.github.io/html-aam/#el-figcaption <figcaption> Also update the AriaRole exposed to UIA from 'group' to 'description'; the spec doesn't comment on this but it is consistent with the current behavior for other inline wrappers like <mark>. Bug: 997714 Change-Id: I26c9a55bbdc02bed0707e926be332f7ebb53b27f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769049 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690446}
-
Jazz Xu authored
Bug: 997324 Change-Id: I250edb4d588b78a5bc7dc29763ee22f68204ee77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769228Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690445}
-
siyua authored
Removing these icon cases since this autofill_ui_util class does not care about other icons at all. Besides this class is only temporary and will be removed after status chip is done. Bug: None Change-Id: I5872c16651c980d4e8a2d332cdb5d806508008fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769803Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#690444}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/678bea7e..2334bc12 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I75cebc375af0500041e470e1fa30b25c1e1a1adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771617Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690443}
-
Darwin Huang authored
static initialization is thread-safe, since C++11, and base::LazyInstance is deprecated[1]. Therefore, remove use of base::LazyInstance. This also provides the opportunity to remove a preprocessor macro. This CL also fixes TestURLExchangeFormatsViaCOM, which was using an incorrect FORMATETC argument. [1]: https://cs.chromium.org/chromium/src/base/lazy_instance.h?rcl=82bf98cd15cedc12558f475feb6770f0c9d903ea&l=5 Bug: 800760 Change-Id: Ib902ca5f7660c609f74c2681a9bf96cb828be52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764890 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690442}
-
Brian Sheedy authored
Whitelists angle_perftests for automatic conversion from chartjson to histograms before uploading to the perf dashboard. The tests were updated to be compatible with histogram conversion in https://chromium-review.googlesource.com/c/angle/angle/+/1762360. Bug: 924618, 923564 Change-Id: Idf14f7fee3f8492c2ef9457a858cea1f43a0f5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769229Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#690441}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1078fdda6aea..83d2edf28b9d git log 1078fdda6aea..83d2edf28b9d --date=short --no-merges --format='%ad %ae %s' 2019-08-26 bpastene@chromium.org devil: Update flash_device.py with A/B device partitions. Created with: gclient setdep -r src/third_party/catapult@83d2edf28b9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:997254 Change-Id: Ie4d4f4908ddcb45502cca261a7b590cac53f2b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771585Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690440}
-
Joel Hockey authored
Create a default implementation of AppBrowserController::HasTitlebarToolbar which removes the toolbar for System Apps (except Terminal), but shows it for all other apps. Added controls for app origin text, and content settings to remove these for System Apps. Bug: 846546 Change-Id: I9a4083cd78c81736533a2dd275aba70d32a6c233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763268Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#690439}
-
Chris Harrelson authored
It has been on stable for quite a while now. Change-Id: Ibe06fc8ad4e36d7ce070cfb40c7ad01ae72adc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766783Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#690438}
-
Etienne Pierre-doray authored
This is a reland of 63fbbb92 Reason for reland: - Fixed with ScopedAllowBaseSyncPrimitivesOutsideBlockingScope. Original change's description: > [ThreadPool]: Implement Job Delegate's ShouldYield and concurrency increase. > > This CL partially implement job's delegate, as well as concurrency > usage assertion: > - ShouldYield must be called in worker task. > - max concurrency is expected to decrease unless > NotifyConcurrencyIncrease() is called. > > To implement ShouldYield, PooledTaskRunnerDelegate is used > to communicate with ThreadPool and a racy priority is added to > task source. > > Bug: 839091 > Change-Id: I3504f00ec48ab600f79b64e44151bc9dded408a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713146 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690127} Bug: 839091 Change-Id: I6f36f27426351e4efbcbaf7e9356840c004e6630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769502 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#690437}
-
John Budorick authored
This is a speculative fix for pickle failing to find the ascii codec when jinja2 goes to import it. See crbug.com/912292#c2 for prior theory. Bug: 997598 Change-Id: Ie52b72fbe7cbefeb58ea6dc0aaafa73e1d125bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771554Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#690436}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f269f8e76a47..4857c934a09c Created with: gclient setdep -r src-internal@4857c934a09c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: If6aaf9554389bd6474bffee9e31d9c33de8dbff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771037Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690435}
-
Xianzhu Wang authored
They are true more commonly in real world and tests. This doesn't affect production code because they are always initialized by cc::PropertyTreeBuilder or blink::PropertyTreeManager. Their cc::Layer corresponding values (to be removed as BlinkGenPropertyTree has launched) are already true by default. This affects only tests that create the nodes directly, e.g. those using the functions defined in property_tree_test_utils.h. Bug: 994361 Change-Id: I6be1ef0355c11cd7c3c124d020c487aac2958456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770038 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#690434}
-
Weiliang Chen authored
When using a BufferQueue, the OutputSurface is treated as an Overlay, and is made into an OverlayCandidate. That overlay candidate is then pushed in as the front of the candidate list. This CL changes it into its own type instead of checking for a bool on OverlayCandidate. This is CL 1/? of overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: I7e61732de09bddeb63d6f2ba69991d82d297bea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739980 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#690433}
-
Ivan Šandrk authored
Since we're in the process of changing the approach slightly, roll back and then re-enable once we update the approach. TBR=rsorokin@chromium.org Bug: 891222 Change-Id: Ib26cf93cb7780e795294709e3589ac06d57ae0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771781 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#690432}
-
Marijn Kruisselbrink authored
These tests are flaky on ASAN builds, see bug for details. Tbr: rdevlin.cronin@chromium.org Bug: 997634 Change-Id: I07ecffd1050c51e3957109b3f0ee491f7a78bd97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769582Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#690431}
-
Khushal Sagar authored
R=fserb@chromium.org Bug: 900706, 995142 Change-Id: I7221db94e63f11d67c45cbafcc019b3995f8fe8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765659 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#690430}
-
Peter Wen authored
Built locally @265454220 and uploaded to CIPD. Updated ModuleInstaller to use the new SplitCompat API. Add new play core activity to expected manifest file. Changes from original CL: Includes fix from play core for NPE. Reland of original CL: https://crrev.com/c/1764804 Tbr: Reland with no chrome changes Bug: 996212 Change-Id: I9de3a3c54beea64fc526a9b380eef2bd608a26c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771737Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690429}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/25cc723823e3..f19c328b5ba5 git log 25cc723823e3..f19c328b5ba5 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 enga@chromium.org Fix NextPowerOfTwo for 64-bit MSVC Created with: gclient setdep -r src/third_party/dawn@f19c328b5ba5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I6714455e05826d59ab16ada891983f1ebfe4c3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769581Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690428}
-
Marijn Kruisselbrink authored
This test has been very flaky on ASAN build lately, so disabling. See bug for details. Tbr: msw@chromium.org Bug: 997634 Change-Id: Ie04c0795470860891feabdda9d3dbce3c2a40a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769585Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#690427}
-
Maksim Sisov authored
The fuzzer has been broken after some major refactorings done. We have not noticed it as long as there is not buildbot for that. This CL fixes it. Bug: 578890, 873132 Change-Id: Iea7c4b8f8415d8fdbf091595c09ccfd1e69c6d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768697Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#690426}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f2f111d77fa8..87b106a0944e git log f2f111d77fa8..87b106a0944e --date=short --no-merges --format='%ad %ae %s' 2019-08-26 jmadill@chromium.org Fix trace logging in Debug. 2019-08-26 ianelliott@google.com Vulkan: Enable ES1_VULKAN testing in end2end tests. Created with: gclient setdep -r src/third_party/angle@87b106a0944e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I52e3915464aca243567d299877bb248fa33dc18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770694Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690425}
-
Doug Arnett authored
TBR=tbansal@chromium.org Bug: 997697 Change-Id: I25b1b67ba8950c8c615b5458895f6eb3eb806233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771392Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#690424}
-
John Chen authored
Creating an error Status object is expensive, as it generates a stack trace. Avoid creating such object until it is needed. Bug: 997414 Change-Id: I694981761135a987f3bd767617eaf0206ce62af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769580Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690423}
-
Andrew Luo authored
Change-Id: I49e7cab2a169292d3650aea164da068ce69871d0 Bug: 997309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763263 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#690422}
-
Clark DuVall authored
Bug: 996603 Change-Id: I335cc43743de4f4c4ba66fa14a096182fbbf4bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771385Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690421}
-
James Cook authored
The SplitSettings project has moved OS-specific settings, including Bluetooth, into a separate WebUI surface. Directly open the Bluetooth settings subpage from the bluetooth chooser "adapter off" link, rather than opening browser settings and trying to do a search. Bug: 994896 Test: Turn adapter off, open https://permission.site, click bluetooth, click "Turn on bluetooth" link Change-Id: I602d979c88f3d89c82702e92ad3bb81230f03698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771841Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#690420}
-
sczs authored
Bug: 979201 Change-Id: I9d5ed63fc694dc10d564d3e4255187470b619943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762573Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#690419}
-
John Chen authored
Update run_py_tests.py to attempt to locate Chrome binary automatically, to make RemoteBrowserTest compatible with CQ. Bug: chromedriver:2277 Change-Id: Iee82313ac5d38315f1017961c487dc202025196b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769722Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690418}
-
Kyle Milka authored
The button labels on the richer picker were slightly too big and became misaligned when minimum font size was set to huge on Windows. Bug: 996160 Change-Id: Ibda385b544637e3d1d893bbed85c885c92178750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769579Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#690417}
-
Andrei Chulkov authored
Casting pointers to numeric types other than intptr_t is a potential security issue. Replaced with casts to intptr_t. Change-Id: I4905401dcc93b89efad8437b0b6f17412cfe2925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765710Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Andrei Chulkov <achulkov@google.com> Cr-Commit-Position: refs/heads/master@{#690416}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7064c6b3b409..e21a095bc454 git log 7064c6b3b409..e21a095bc454 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 saklein@chromium.org BundleAutotestFiles: Refactor to chroot and sysroot arguments. Created with: gclient setdep -r src/third_party/chromite@e21a095bc454 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I60c35d055fb5a7ec14cd02535672559c280fe0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771583Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690415}
-
Nico Weber authored
Including directories full of generated files causes incorrect incremental builds. There's already a data_deps on the action, so just setting `outputs` correctly makes that do the right thing, without needing the explicit directory. To make sure this does the right thing, I ran gn gen out/gn --runtime-deps-list-file=<(echo -e \ //chrome/test:performance_test_suite\\n\ //chrome/test:ct_telemetry_perf_tests_without_chrome) (...which is what tools/mb/mb.py gen -m chromium.perf -b linux-builder-perf \ --swarming-targets-file \ <(echo -e performance_test_suite\\nct_telemetry_perf_tests_without_chrome) \ out/gn runs behind the scenes.) I the compared these files before and after this patch: out/gn/obj/chrome/test/performance_test_suite.stamp.runtime_deps out/gn/obj/chrome/test/ct_telemetry_perf_tests_without_chrome.stamp.runtime_deps $ diff -u performance_test_suite.stamp.runtime_deps out/gn/obj/chrome/test/performance_test_suite.stamp.runtime_deps -gen/components/subresource_filter/tools/ +gen/components/subresource_filter/tools/default_local_state.json $ diff -u ct_telemetry_perf_tests_without_chrome.stamp.runtime_deps out/gn/obj/chrome/test/ct_telemetry_perf_tests_without_chrome.stamp.runtime_deps -gen/components/subresource_filter/tools/ +gen/components/subresource_filter/tools/default_local_state.json I then grabbed an existing isolate off a recent https://ci.chromium.org/p/chrome/builders/ci/linux-perf build from a performance_test_suite run: tools/swarming_client/isolateserver.py download -I https://chrome-isolated.appspot.com \ --namespace default-gzip -s d60732b5f6374dc56d1b01c2e54c82fc411c83e5 --target foo And inspected all the files in the tools directory: $ ls foo/out/Release/gen/components/subresource_filter/tools/ GeneratedRulesetData default_local_state.json (gen/components/subresource_filter/tools/GeneratedRulesetData was already in the .runtime_deps files.) Bug: 912946,884035 Change-Id: Ife400071aa25589c66abfe693108a483ad14870d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769204 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690414}
-