- 24 Nov, 2020 40 commits
-
-
Reid Kleckner authored
The closing paren and opening square bracket apparently must be joined for these links to be recognized as markdown links. R=hans@chromium.org Change-Id: I7a3e42c6c6e0ade18a1305e0ae6ed8e48e50bb9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555540 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#830516}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/260eb0f662b4..b35dd76cd5f6 2020-11-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I3526605f02c4399d5daf47e0b21e6e8d8f01d376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557457Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830515}
-
Austin Tankiang authored
This test was failing as it was timing out when waiting for the file handler extension's background page to close. Override the page's idle time to ensure it closes before the test times out. Bug: 1150689 Change-Id: Iff3970c65149f322ebfe014d773abc646a8cc503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557280 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#830514}
-
Yuki Yamada authored
I've disabled some tests for all the platforms, but they had problems only with specific platforms. This is a follow-up for these CLs: https://crrev.com/c/2556621 https://crrev.com/c/2557065 https://crrev.com/c/2557279 TBR=dpapad@chromium.org,bugsnash@chromium.org,rohitrao@chromium.org No-Try: true Bug: 1152287, 1152318, 1152289 Change-Id: If24633596f23ae8f53447b02b2232dd44eed9761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557284Reviewed-by:
Yuki Yamada <yukiy@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#830513}
-
Sean Harrison authored
Add description text to the customized behaviors section for content settings in chrome://settings/content. Bug: 1113642 Change-Id: Idb8dd03d152f8c2bdccc27dffca1bdc8e233aca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555037Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#830512}
-
Shik Chen authored
This CL fixes the following error by remove the 'for' attribute: Avoid 'for' attribute on <label>. Place the input within the <label>, or use aria-labelledby for <select>. The <input> are already associate with <label> correctly as a direct child. ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label Bug: b/172879638, b/172340545 Test: Pass presubmit checks and manually check with Chromevox Change-Id: Idcf38a2de244b9a3052a0831be28b72c522ca0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554272 Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#830511}
-
Taeho Nam authored
Change-Id: I1a73ce66491885f38bb481c9c7f2b565def536ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551892Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#830510}
-
Yuzu Saijo authored
This CL mechanically replaces a parameter of SetDefersLoading, bool, with enum. Bug: 1137682 Change-Id: I5af8193acf926867f56980686d0a58c4d238f1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537457Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Rainhard Findling authored
* Show the number of compromised and weak passwords that were found by the password check in the password check child of safety check (SC). Translation Screenshots: IDS_SETTINGS_SAFETY_CHECK_PASSWORDS_SAFE: https://storage.cloud.google.com/chromium-translation-screenshots/9337b5cfa3bcef4342156a73d83cf37043f783e9 IDS_SETTINGS_SAFETY_CHECK_COMPROMISED_PASSWORDS: https://storage.cloud.google.com/chromium-translation-screenshots/48000c9b3b776cd72ef4b37861123533cef88cb7 IDS_SETTINGS_SAFETY_CHECK_WEAK_PASSWORDS: https://storage.cloud.google.com/chromium-translation-screenshots/8d987688c08641fee35f117eddeaa63f9769a515 IDS_SETTINGS_SAFETY_CHECK_STRING_TUPLE_WITH_COMMA: https://storage.cloud.google.com/chromium-translation-screenshots/6139bb64c11e0f921e8d5951367952b62ecb3fcc Bug: 1015841 Change-Id: Id40473d34164dfaafdea2e0db6f0f256a1b73522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547582Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#830508}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60b0ce5c4a44..8fb8d59ba581 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukiy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1149681 Tbr: yukiy@google.com Change-Id: Iedfce050b40a48db7721b9f13d4215ef86ee1ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557147Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830507}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606175959-25d181192b782b01bd229877ae9d4ba54da15043.profdata to chrome-mac-master-1606196878-31a6a989939947bbb9b6b52f3528a70f37f5b2e2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ida2dea1c67437937f7e0eef4f7e6821d81d3eea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556501Reviewed-by:
-
Colin Blundell authored
This CL does the initial bringup of ad tagging and blocking functionality in WebLayer. To do so, we do the following: - Bring up an implementation of SubresourceFilterClient and attach it to WebContents instances - Instantiate subresource filter navigation throttles on navigation - Instantiates and configures SubresourceFilterAgent instances in the renderer The organization and code added is modeled after that in //chrome. We have left TODOs for significant pieces of functionality to be added in followups (e.g., showing of the infobar on Android). One thing to note is that ad tagging/blocking only triggers on Android in WebLayer, as it requires having a safe browsing database instance and WebLayer does not have one on platforms other than Android. This CL also adds browsertests of this initial functionality: - that the subresource filter activation state is computed on page loads - that ads are blocked on activated pages if they are flagged by the ruleset This CL is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2526087, which was reverted as one of the added tests exhibited flake on Windows: occasionally the result of a check of whether a resource was loaded reflected the state of a prior navigation to the test URL. That flake has two likely sources: (1) The test is not waiting for the right event to be signalled (i.e., the document is not fully loaded) (2) The repeated navigations to the same URL are resulting in some sort of optimization (e.g., in //content) that is interfering with the expected flow of the test (1) seems unlikely, as //weblayer's NavigateAndWaitForCompletion() waits until WebContentsObserver notifications have been received that both the navigation to the given URL has completed *and* that loading has stopped. This CL provides a speculative fix for (2) by adding intervening navigations to a different URL. If the flake still exhibits itself, we will have gained more insight for further debugging it. Bug: 1116095 Change-Id: I4e5fd3f9debfaccc219f865c896010429f1f299e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554539Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#830505}
-
Morten Stenshorne authored
CL:2421371 does something similar for floats. Bug: 1079031, 829028 Change-Id: Ifee794cb4fb6751a511f075b32fbe0b9c50d18c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554568Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#830504}
-
Yuki Yamada authored
All/MediaAppIntegrationTest.HandleRawFiles/_WebAppInfoInstall randomly failing on builder "linux-chromeos-chrome" TBR=bugsnash@chromium.org No-Try: true Bug: 1152318 Change-Id: I2ca7b0f4b50a83be8a0fe5a504ab94cf024c0f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557065Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606175959-14a3411953113a2fe64aa457a295c32153a3500e.profdata to chrome-linux-master-1606196878-64b7b1e8929e5613baadbfb35b6857cd242016c0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1205440d0ecc5eb6f147bd87957bf8a1b9928b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557341Reviewed-by:
-
Mason Freed authored
The conversation [1] about the recent changes to setInnerHTML have led to the conclusion [2] that perhaps we shouldn't add a new XSS sink method at all. That would "fix" the declarative Shadow DOM problem, but would create a new sink that all security libraries would need to know about and handle. Seems like not a good trade. In the meantime, a polyfill can stand in for setInnerHTML: Element.prototype.setInnerHTML = function(content) { const fragment = (new DOMParser()).parseFromString(`<pre>${content}</pre>`, 'text/html', {includeShadowRoots: true}); this.replaceChildren(...fragment.body.firstChild.childNodes); }; [1] https://github.com/whatwg/dom/issues/912 [2] https://github.com/whatwg/dom/issues/912#issuecomment-732476002 Bug: 1042130 Change-Id: Ibaf15a3edf86be9a720225dea2ba2741f2882b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555589 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#830501}
-
Yutaka Hirano authored
Bug: 1152249 Change-Id: Id21f5ec3531f3b3b03f163fe3d1f8d848ca3b8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556887 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I794e7484ccea4d900c1fd6ee77aa2281271f9ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554982 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#830499}
-
Jinsuk Kim authored
A single factory instance for TabDelegate objects is enough for a ChromeActivity. This CL prevents multiple instantiations of the factory. This fixes a bug that logs MobileNTPOpenedInNewTab more often than expected due to numerous UMA reporter objects. Bug: 1014382 Change-Id: I7c28f6cd500bc58a835c16d7e5dbb6f9e90d82b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554274 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#830498}
-
Alice Wang authored
This CL migrates usage of signin.SigninPreferencesManager to the same class in signin.services target and remove the old class signin.SigninPreferencesManager. Bug: 1150862 Change-Id: I97f08bf0723ed8baf3d4757f1f01754c3eeb31c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553550Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830497}
-
Risan authored
In the Android CLs, we allow this to happen and we prohibited the creation of the Android directories. So apps can access the MyFiles through Storage frameworks, but no default directories to be created. BUG=b:162793388 BUG=b:169537013 TEST=Manual test in Photos app, CtsAppSecurityHostTestCases, CtsProviderTestCases, part of CtsMediaTestCases Change-Id: I98ab33d6d68adfb1638bcdf07557817df257c6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536424Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830496}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ieab892a421c52a3dcc4e00bfd6a34b24eddeb963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546664Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830495}
-
Yoshifumi Inoue authored
This patch extends expiry of WebCore.Editing.Commands* histogram and updates owner of WebCore.Editing.* histograms This is reland of the CL[1] with changing owner to yosin@ and kojii@ from editing-dev@ which is not valid for owner. [1] http://crrev.com/c/2550325 Bug: 1149518 TBR: schenney@chromium.org Change-Id: I46cc7e1db43c294a3dd7c0bc266266073535ec2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556891Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830494}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I3b8b1179ee7a7cc44a8649514a13134ae2065ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546388Reviewed-by:
-
Julie Jeongeun Kim authored
This CL returns nullopt if GetIndexInParent() is called on the WebView as it's not the child list in its parent if it has the WebContent. It fixes DCHECK error on GetIndexInParent(). AX-Relnotes: n/a. Bug: 1147007 Change-Id: I3def3ac9a4abb2abac8d2ae7702e8979a7c90e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552310 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830492}
-
Darren Shen authored
Add a new API for the IME to tell Chrome about autocorrects. Call the new autocorrect UI when there's an autocorrect. Bug: b/172969200 Change-Id: Iac1be66ff6c3eb6cfaff75ba96a388aa27d7a6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531080 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#830491}
-
Ankit Kumar 🌪️ authored
Add AccessibilityCharInfo in pdf/ to replace usage of PP_PrivateAccessibilityCharInfo. PP_PrivateAccessibilityCharInfo is a Pepper struct. The new struct ensures that PP_PrivateAccessibilityCharInfo is scoped to parts specific to Pepper implementation. Bug: 1144444 Change-Id: I55ab25fd01a8b49976f936688a35de0ada1192a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554255 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#830490}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0f225f57e701f19705e46e5594528b5f1a82a56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555419 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830489}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/65fb101861ab..3df719619f0a 2020-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 546a7c98c897 to 03badec5d73a (3 revisions) 2020-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ebf890fcf9f3 to 1b413197a6d7 (13 revisions) 2020-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6d612051c083 to 43bb60e1fa11 (6 revisions) 2020-11-24 csmartdalton@google.com Return the contour's final point from SkPath::RangeIter in kClose If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: adlai@google.com Change-Id: I81c0dfa7358cacbc5f71ab5f4a0a088c5810118a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556920Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 816bad6a. Reason for revert: This seems to cause https://crbug.com/1152235 Original change's description: > [DEPS] update luci-go > > Bug: 1143567 > Change-Id: I37f738d40c7a424440bf892405a0cca1ca2742cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551867 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Ye Kuang <yekuang@google.com> > Auto-Submit: Ye Kuang <yekuang@google.com> > Cr-Commit-Position: refs/heads/master@{#829620} TBR=tikuta@chromium.org,jwata@google.com,yekuang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1143567, 1152235 Change-Id: Ib256257e24fd72b07ce3ebaa79ab9e6fac0ab3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557118Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#830487}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c2a74cbb8ee1..1b413197a6d7 2020-11-24 jmadill@chromium.org generate_entry_points.py clean-ups. 2020-11-24 jmadill@chromium.org EGL: Add const to several methods. 2020-11-24 jmadill@chromium.org Use hard-coded year in generate_entry_points. 2020-11-24 jmadill@chromium.org EGL: Remove egl::Error from validation code. 2020-11-24 jmadill@chromium.org EGL: Expose device query as a client extension. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: Ief9d82711b30118e3a885c26eb4329d3a8b7bdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556385Reviewed-by:
-
Muhammad Hasan Khan authored
ProvisioningResult is used in UMA stats so we're not removing it but replacing most of its use with a new ArcProvisioningResult object that can represent all kinds of problems that can happen during provisioning. BUG=b:166322619 TEST=CQ TEST=unit_tests --gtest_filter='*ArcProvisioningResultTest*' Change-Id: Iec7192e05a84e1f4ae4d8e556a675d67fff1cd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548841 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830485}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1a111c2..3e3f152 Bug: 1136231, 1149176, 1152259 Tbr: jdarpinian@chromium.org Tbr: shrekshao@google.com Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I3ee0d2b7d598a836635d35fa812c4917f40d38b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552371 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#830484}
-
James Vecore authored
Nearby reuses the same notification id for all notifications so prior to this change, after the first share notification, new shares would not pop-up the accept/reject notification and it would get lost in the tray. This is a simple fix to just close the notification before an incoming share notification is displayed and also makes it high priority. Additionally we do the same for the success and failure notifications to ensure they pop-up. A more involved fix could separate out the stages of sharing into separate notifications or create a new id per share. Fixed: 1150648 Change-Id: I4523297fdd038a3904bd1358e0e671bb8b3a481e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556214Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#830483}
-
Jan Wilken Dörrie authored
This reverts commit 5d1496e0. Reason for revert: https://bugs.llvm.org/show_bug.cgi?id=48048 got fixed. Original change's description: > Revert "[base] Use NO_UNIQUE_ADDRESS in flat_tree" > > This reverts commit f55e9981. > > Reason for revert: https://crbug.com/1144431 > > Bug: 1144431 > > Original change's description: > > [base] Use NO_UNIQUE_ADDRESS in flat_tree > > > > This change makes use of NO_UNIQUE_ADDRESS in flat_tree, allowing the > > removal of an internal class which just existed to make use of the empty > > base optimization. > > > > Bug: 682254 > > Change-Id: Iabf91d4acee95c7ba4e929d23528d95b0ced1612 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509757 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822948} > > TBR=dcheng@chromium.org,jdoerrie@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 682254 > Change-Id: If3b15e15241e8f8b5d99b80caadbb25153648f37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514147 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823192} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144431 Bug: 682254 Change-Id: I70549a9fa09c05c1528a3df6f317fe2ac042b814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553429Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830482}
-
Yuki Yamada authored
Randomly crashes on Win 7 Tests x64 (1) https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/b8862779006945233296 TBR=rohitrao@chromium.org No-Try: true Bug: 1152289 Change-Id: I8007bb02997d230a66a78fda17b18c3c466f327b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557279 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Fix the bug found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic33ba5a34435089eceda578014cd62b84350eef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555123 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#830480}
-
Minggang Wang authored
As part of the OnionSoup project, this patch moves request_peer.h to third_party/blink/public/platform/, which is needed when moving its sub class content::SyncLoadContext into blink and removing ResourceDispatcher finally. Change-Id: I874307b49a68ed2ea931db1e48faf02539551d7a Bug: 1110032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548648Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#830479}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I86256d662153a26856323316978fa370a0cdc7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550004 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#830478}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ic46914d41965026956ec9adea34137fda5fdca16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550002 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
-
