- 16 Dec, 2020 40 commits
-
-
Antonio Sartori authored
Executing a javascript: URL does not commit a new document, and executing a javascript: URL in a srcdoc iframe does not change the fact that this is a srcdoc iframe. (cf https://crrev.com/c/2464930). On the other side, the algorithm for computing the referrer of a srcdoc iframe defers to the parent: https://w3c.github.io/webappsec-referrer-policy/#strip-url Bug: 1043895 Change-Id: I144aa288204f9e92d1b41b0f3c64bc0d6274f10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582045Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#837504}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ae8efc5c4e6a..67a17949745b 2020-12-16 patrick.brosset@microsoft.com Bring back expander icons for the Flex and Grid sections in Layout pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158671 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I47020ba14b0fded35382cde1757cdc4fcd56172d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837503}
-
Gauthier Ambard authored
This CL fixes the audio test when the new error page workflow is enabled. It was failing because the LoadHtml method is triggering the WebState callbacks twice, letting the delegate_ receiving empty data for the first callback. Bug: 1152364 Change-Id: I6e6a4d196e0381d7388981a4ecb5f086543396a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593092 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837502}
-
Nohemi Fernandez authored
As a follow-up to crrev.com/c/2562778, moves all sign-in utilities to the new signin namespace. Bug: 1157531 Change-Id: Ic695832a7cd5778e69039b2d3fd1395de3cde50c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593259Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#837501}
-
Hwanseung Lee authored
this histogram expired since M85 branch out. so remove this historam. Bug: 1088836 Change-Id: I1b05d0773d1f8d83200ff815eb667c72c057727a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588676Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#837500}
-
Benoit Lize authored
Bug: 998048 Change-Id: I266cdb8ff0c37f0f4e4c57673674890772f9df09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593118Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#837499}
-
Alice Wang authored
This CL refactors the ViewBinders in account_picker MVC in two ways: 1/ Make all view binders implements the ViewBinder interface instead of using static class; 2/ Merge IncognitoRowViewBinder and AddAccountRowViewBinder into one reusable class. Bug: 1158373 Change-Id: I6a1f5442c52e4eb8e2115cd34c140822a494bdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589934 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#837498}
-
rajendrant authored
This CL implements OAuth login flow detection - login start and successful completion. Subsequent CLs will record these login types to UKM and also add more login detection heuristics. Design doc: https://docs.google.com/document/d/1EUf4reGzB2peV60Vx2iop5rchHLEIAnE6GviwTESvt8/edit#heading=h.x3b01qdtugx8 Bug: 1149853 Change-Id: Idfe0428e4cde4c0721c72c60bfe0f38cf38c6185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575121 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#837497}
-
Shik Chen authored
The naming is following the Google color palette. Bug: b/172879638 Test: Manually Change-Id: I99b0f350bebd60270e33b4d300cf37b23276178f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592573 Auto-Submit: Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#837496}
-
Hirokazu Honda authored
crrev.com/c/2576298 rejects non-8-bit streams in VaapiVideoDecodeAccelerator. This adds the test case to its unittest for the change. The new test case confirms that VaapiVideoDecodeAccelerator rejects a vp9 profile 2 stream. Bug: b:174798524 Test: media_unittests Change-Id: Iab4a561a1df37c7df52b97cb1693fee0cdf21dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576235 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#837495}
-
Hiroki Nakagawa authored
To deflake browser tests, this CL makes NavigationWithLocation() helper ignore the result of ExecJs(). The helper is used for activating prerendered pages. Depending on timing, activation could destroy the current WebContents before ExecJs() gets a result from the frame that executed scripts. This results in execution failure even when it actually succeeded. This part will drastically be modified by the MPArch, so this CL takes the approach just to ignore it instead of fixing the timing issue. When ExecJs() actually fails, the remaining test steps should fail, so it should be safe to ignore it. Bug: 1156141 Change-Id: Ia9c72ccd161b29f9fde4481cbc3e4fae4167fb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593796Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#837494}
-
Luciano Pacheco authored
JS modules for - //u/f/f/b/j/mount_metrics.js - //u/f/f/b/j/mount_metrics_unittest.m.js Change metrics_base to refer to its own namespace `metricsBase` instead of `metrics`. Bug: 1133186 Change-Id: Id4929916ce3571faa9d63aed741860a1b22e052c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592576 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837493}
-
Victor Hugo Vianna Silva authored
- Make sure the non-obsolete/expired ones have at least 2 owners. - Move components/invalidations/ histograms from */others/histograms.xml to a new */invalidation/histograms.xml. - Remove code recording expired/obsolete histograms. Fixed: 1158383 Change-Id: Ie3c7ab0334b0458057e63429927c09c88e1cef4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589975Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#837492}
-
Victor Hugo Vianna Silva authored
Sync.{CookieJarEmptyOnMismatch,CookieJarMatchOnNavigation} have been expired since M77. This CL marks them as obsolete and removes the associated plumbing to record them, which is considerable. Bug: 1158449 Change-Id: I03a9c48c17ba71508f96fb122b522ba03300d773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589836Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/98b56e604256..328f72ae21cb 2020-12-16 jmadill@chromium.org Update VVL directories in Android build. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Icfecc90a301694ad1edd3fdf750f3adc5dc337dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593600Reviewed-by:
-
Nick Diego Yamane authored
Do not dcheck for mouse button state when processing the drop event as it causes crashes in lacros when the tab drag session is triggered by touch events. Upcoming CLs will add actual support for touch-based tab drag sessions. R=msisov@igalia.com Bug: 1158557 Change-Id: Ic68a076934dbe669fb713d4a4f9ce9a02d008e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594021Reviewed-by:
Maksim Sisov (slow) <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#837489}
-
Alan Cutter authored
This CL updates the YouTube default web app to install as opening in a window. This only affects new users on Chrome OS. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=481158&signed_aid=oxtHhds0ncHcPrMr76xdvA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=481159&signed_aid=B2AAZpgZRJqHpeXt61yyrw==&inline=1 Bug: 1159306 Change-Id: I59b3f83c801596520c37995d849a156e4c0fd89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592076 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#837488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d224369988e1..c29aca88aeb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1159112 Tbr: aboxhall@google.com Change-Id: If19650b99c8b850e89a79218149b2be954342444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594194Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837487}
-
Alice Wang authored
This CL refactors account_picker MVC with LayoutViewBuilder. Bug: 1158373 Change-Id: I7f9ea3959eb7922a40f3bc2a05673332a1a1d025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588913Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608076760-b9ea13a2a007bc956431b47b7a25fe6a939d9e2a.profdata to chrome-mac-master-1608097529-4473bb129a43d499a6f4ca2ef772a18f6300cda1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I05495bad6f0a11e6e9d37d62bde91d84ff8805e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594197Reviewed-by:
-
Mike West authored
We never landed metrics to measure the impact of the proposal in https://github.com/w3c/webappsec-referrer-policy/pull/124. This patch remedies that oversight. Bug: 1158426 Change-Id: Iccde2a755d7003a401a80e6c085a5ad97ac87389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589875Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#837484}
-
Nancy Wang authored
Add the class RestoreHandler to call FullRestoreFileHandler to read the full restore data file, and load the RestoreData. RestoreHandler is used at the system startup phase to load the restore data for restoration. There will be a separate CL to add tests. Bug:1146900 Change-Id: If43082936394997f5b8e90125b43baa6577e9f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592275 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#837483}
-
Shik Chen authored
This reverts commit 135a698d. Reason for revert: http://b/175756864 Original change's description: > camera: Support focus distance control > > This CL adds focusMode(continuous/manual) and focusDistance > MediaTrackCapabilities. > > Bug: b:151048287, 1068176 > Test: Tested logitech camera on eve. Test WFC of kukui. > Change-Id: I85fa31b8b4f147b8cc054eac3f94974595545c05 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371843 > Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> > Reviewed-by: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836565} TBR=shik@chromium.org,mojahsu@chromium.org,wtlee@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:151048287 Bug: 1068176 Change-Id: Id5a76aa173401b9f7f1391c8de2e65709cef38ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594618Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#837482}
-
Jan Wilken Dörrie authored
This reverts commit f41cb9eb. Reason for revert: Likely culprit of https://crbug.com/1159333. Original change's description: > Re-enable Mac Document/Window idlharness WPT > > This reverts commit 0e528de2. The test > should be passing now that web platform tests has fully synced its IDL > with the HTML spec, and the -expected.txt files have been regenerated > with the latest Chrome implementation. > > Original change's description: > > Sheriff: Fix Mac WPT > > > > TBR: domenic > > Bug: 1158672, 1157917 > > Change-Id: Ie10cad8aa48f989a8fd76eda0ed3e605b09fafb0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592228 > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#836992} > > Bug: 1158672 > Bug: 1157917 > Change-Id: If3e717b05de26d26595c649979f52e5d3343ae62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593887 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Commit-Queue: Domenic Denicola <domenic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837250} TBR=domenic@chromium.org,smcgruer@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id76f561ca0c38c735fa9861be9c43a3329e01f2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1158672 Bug: 1157917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594907Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#837481}
-
Antonio Sartori authored
In the Blink Content Security Policy code, for parsing the 'plugin-types' directive, we switch from using the internal blink type blink::MediaListDirective to using a Vector<String> as in the mojo type network::mojom::blink::ContentSecurityPolicy. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: I26e2625f825c23f0e8ea557f5acfe3c94313ce9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563547 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#837480}
-
Maggie Cai authored
This CL extends the intent-picker-pwa-persistence flag to M92 given it is not lanched yet. BUG=853604 Change-Id: If996223ce26e2865d4b33528af2bc02fa6492c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594828Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608076760-d4793f464fd5473cef2d681bda9559291286bad5.profdata to chrome-linux-master-1608097529-96e83b64d2e55c9fef1094979ebe73b794f619fe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic15c17a9590b78b1309e530aad05db6d78e47016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594195Reviewed-by:
-
Alice Wang authored
This CL moves SignOutDialogRenderTest to signin.ui module. Bug: 1157415 Change-Id: I67fc8bc55c1779a6f27f8cdc6efb807c34e40814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593090Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837477}
-
Alice Wang authored
This CL adjusts the access level for confirm sync data classes as the modularization for this part is done. Bug: 1155123 Change-Id: Idf8ab39b655799f75c68486ec3a06b67ea2acb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593097Reviewed-by:
-
Jason Lin authored
Bug: b/167491603 Change-Id: Ie4da3308869873ba57699daa4cc32659d188615e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592577 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#837475}
-
Tal Pressman authored
Before this CL, DomWindow was marked as const, but returned a mutable LocalDOMWindow*. This CL creates two overloads of DomWindow(): - const LocalDOMWindow* DomWindow() const; - LocalDOMWindow* DomWindow; See: https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#use-correctly Change-Id: I786fc68ebe92a81ee1822ac06841aed1445889f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592274Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#837474}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f649421. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-contain NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I18c22142b0b981a5211d7dbe740a68e73ca653b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592143Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837473}
-
Alice Wang authored
This CL moves the SigninHelper init and getter part to a new class SigninHelper. This helps to isolate the dependency on SyncController in a relatively simple class SigninHelperProvider, so that we can modularize SigninHelper class in short term. In long term, we only need to expose SigninHelperProvider and SigninHelper interface to public, the real implementation of SigninHelper will be package private. Bug: 1158801 Change-Id: I1648ca59778f8c5410843cd1824325bd1fea1f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593115Reviewed-by:
-
Christopher Cameron authored
Change CanvasResourceParams to use - SkColorType instead of CanvasPixelFormat - SkAlphaType instead of OpacityMode This will allow us to cull CanvasPixelFormat down to just the types that users can specify. Bug: 1157747 Change-Id: I70b23024d6fda00d031e013610347eebae896d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589354 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#837471}
-
dpapad authored
Specifically: - Serve mocha.js from chrome://test - Load mocha.js and mocha_adapter.js within test_loader.html This allows JS module based tests to simply load mocha.js and mocha_adapter.js with a <script> tag instead of relying on the old |extraLibraries| injection mechanism. Tests that don't already use test_loader.html will be addressed in a follow-up CL. Bug: 1158471 Change-Id: If1c2db28dab3a6de4af04eebb89dd72d9e04a60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586026Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837470}
-
Mason Freed authored
Some styles (e.g. webkitUserModify) should not propagate from a ShadowRoot to the children. Note [1] that it is possible all such properties are deprecated. But they still have decent [2] usage. See [3] for what happens if this check is removed. [1] https://crbug.com/687462 [2] https://chromestatus.com/metrics/css/timeline/popularity/338 [3] https://ci.chromium.org/p/chromium/builders/try/linux-rel/570174? Fixed: 1158424 Change-Id: I994691cb63d96d60d8a47d8698ad86a43f8ea10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593285 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#837469}
-
Sven Zheng authored
This test is flaky only on Lacros. Disable it first. Bug: 1154365 Change-Id: Ie0b5db5f1c6ba2652e359769108262163750c7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593216Reviewed-by:
-
Alexander Cooper authored
Now that OpenXR support is widespread, we can simplify our codepaths by relying solely on the OpenXR runtime. This change removes the last non-OpenXR runtime. Fixed: 1121632 Change-Id: I108af56cdf0e6c2f41af64e09f80b27b9e9f4183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587691 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837467}
-
Mirko Bonadei authored
Bug: webrtc:9987 Change-Id: Iae028ac321bffb9c7b0980dd4323fe5d81d5b66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593088Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#837466}
-
Nancy Wang authored
This is the preparing for the full restore file reading function. Add the construct function for RestoreData to convert the JSON format to the RestoreData. Add the unit tests to verify the convert function: RestoreData -> base::Value -> RestoreData. BUG=1146900 Change-Id: I54133e83e9b7abce62c5812cc5e87941e770f958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591987Reviewed-by:
-
