- 15 Oct, 2020 40 commits
-
-
Chan Li authored
This experiment has been enabled at 100% on fyi builders and it's confirmed working. Bug: 1108016 Change-Id: Ie421701de49116dab4169a6e210d069e01bbba37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476536Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#817729}
-
Rafael Cintron authored
Future fence work for Windows will require ID3D11DeviceContext1-4, ID3D11Device1-5 and ID3D11Fence mocks. This CL adds support for them to d3d11_mocks.h, d3d11_mocks.cc and test_utils.h Bug: 1131616 Change-Id: Ic8492b5962a914146305fb58974c7fac1956e15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476537Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#817728}
-
Devlin Cronin authored
The chrome.test API predates promises, but should still work well with them. This is useful, because promises can greatly increase the readability of certain tests. Add some basic test coverage of common promise-based patterns in API tests. Bug: None Change-Id: I04b279f132e017e5eb81323dc96d9607513b54f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391602 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#817727}
-
Ghazale Hosseinabadi authored
This CL refactors ExtensionContextMenuApiTest. ExtensionContextMenuApiTest's functions and member variables related to visibility testing are moved to ExtensionContextMenuVisibilityApiTest. Furthermore, ExtensionApiTest.ContextMenus is divided to four tests and is moved to ExtensionContextMenuVisibilityApiTest. Bug: 1093066 Change-Id: I6142790b01b583eb6664712d1fb1ab7df08452de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468346Reviewed-by:
-
Jazz Xu authored
This CL fixed the issue where the audio controls' focus ring is seem chopped. Demo video linked in the bug. Rebaseline some of the test since the shrinking height of buttons in audio controls will result in some tiny pixel changes. Bug: 921955 Change-Id: I197cb7c0f29b2bbd5383203f8d7dd8d0b7ee4f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468783Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817725}
-
David Dorwin authored
Update base_unittests.cmx to inject archivist-for-embedding.cmx instead of archivist.cmx, which has been removed in Fuchsia. Bug: 1139075 Change-Id: Id5d30e5c9be7b14e9c5c7f4633ceb5ef4a032ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477423 Auto-Submit: David Dorwin <ddorwin@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#817724}
-
Wei Li authored
To safely change Button class' default focus behavior, we need to explicitly set all subclasses' focus behavior. To show these changes are preserving the existing behavior, this CL adds DCHECKs to show the current behavior. We will delete all the DCHECKs once Button's default behavior is being flipped. Bug: 1001103 Change-Id: Ic76bc2ffaa3dfb90b7cd93b59c0a6051e9f5d9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473562Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#817723}
-
François Degros authored
No functional change. BUG=chromium:912236 TEST=Manual Change-Id: Ie7a79682726701f2aad255183e0b2d674cf3e26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462991Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#817722}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //extensions. R=mcnee@chromium.org, rdevlin.cronin@chromium.org Bug: 1113033 Change-Id: Ia776ef0322aa315624d11ef7698b6cf049fe2cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473437 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#817721}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ec64d037bd04..f1f1e7dd3608 2020-10-15 reed@google.com Hide shrinkToFit -- not needed now that we have pathbuilder 2020-10-15 tdenniston@google.com Add subset of W3C test suite to SVG corpus 2020-10-15 jlavrova@google.com Placeholder at the end of the text right before \n. 2020-10-15 robertphillips@google.com Revert "[svg] Relocate out of experimental" 2020-10-15 johnstiles@google.com Increase stack trace depth from 64 to 128. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I28bdefc79a9f42de2c7e8962f3ca88dd82160549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477278Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817720}
-
Elly Fong-Jones authored
This test has is flaky when run on devices that have a real wifi or cellular connection, because in that situation, the call to SimulateNetworkChange() can cause an arbitrary number of real calls to GetCurrentSignalStrengthWithThrottling(). This change de-flakes the test in that situation by: 1) Delaying constructing the HistogramTester, to avoid counting those calls, and 2) Advancing the fake time the test uses at the start of the test, so that the NetworkQualityEstimator under test is never in its timeout period when the test starts This change also re-enables the test on Android, since this should de-flake the test there too. Bug: 1133439,1130720 Change-Id: I4164ce4bb105082fe58382c3f7c72b5b9462a8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476812Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817719}
-
Steven Bennetts authored
Bug: 1137487 Change-Id: Ie8609cbce95ec1a485a1d3adb10c7a67a1385044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466600 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#817718}
-
Sky Malice authored
Update special handing in ForTest PRESUBMIT checking to make sure common Android annotation @VisibleForTesting is not flagged. This annotation typically means something in production code has a more permissive visibility setting (such as protected or public) so that a test can access it. The ForTest PRESUBMIT check is not applicable to this annotation. For more information about @VisibleForTesting annotation see https://developer.android.com/reference/androidx/annotation/VisibleForTesting Bug: 1138976 Change-Id: Ic345bfe8e5c283a8826e17c3209f6768a281151d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476515 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
who/bttk <bttk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#817717}
-
Moe Ahmadi authored
The order in which MV tiles appear cannot be changed and thus the MV tiles should not draggable. Fixed: 1139032 Change-Id: I0d2c1a157f09fa60fa269a2eace7d7db25d2ab19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477282 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#817716}
-
Ken Rockot authored
Update the credential-management WPTs to use JS modules, including for Mojo JS bindings. This also refactors the supporting modules to isolate individual tests from any browser-specific details. Bug: 1004256 Change-Id: If5428dbd4f371fdc92c62da2a2378e8221c5c658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472201Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#817715}
-
Matt Falkenhagen authored
A site reported breakage that only happened when the page was loaded in the background. While it's unclear how, we don't need to optimize hidden page loads anyway, and since they are already throttled it may not work well with the feature. It's unclear whether we should also do this for SchedulingLifecycleState::kThrottled. Bug: 1138805 Change-Id: I133d802843672e39673026075e25ed25929f0a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474836Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#817714}
-
Cammie Smith Barnes authored
This makes the histogram obsolete and removes the lines that record and test it. Bug: 1135300 Change-Id: I12c61700e32d44875a0fa96ec41bf62eff9aeb2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472523Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#817713}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aedca41e..6a394b3f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iac4860b8ea11f8899b657ec6867c5823fcca14d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476579Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817712}
-
Jazz Xu authored
Bug: 1138519 Change-Id: I985ff3044f154f8f07a84ce76435d63a9ce844a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472477Reviewed-by:
-
Maggie Chen authored
This records whether the GPU supports hardware overlays or not. Bug:1117185 Change-Id: I96b183fc918e7d7240beb959a12580c05f8199ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463339Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#817710}
-
Wei Li authored
This prepares to have Combobox's model be used as a metadata and builder property. Bug: 938501 Change-Id: I5721408ab0059c2b6b54863b897005ef77e27bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476514Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#817709}
-
Jonathan Backer authored
Skia may change a bunch of GL state (including active texture unit) when we create a backend texture. We can't easily restore that state, so do a full (often virtual) context switch instead. This will avoid damaging another client's state. Bug: 1095679 Change-Id: I511115f8add6c290fc6a63355cfc4b22a7b1b0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476899 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817708}
-
Tess Eisenberger authored
This patch corrects an invariant violation in which Chrome was swapping the min and max y coordinates when reporting bounding boxes to Fuchsia's a11y-manager. Bug: fuchsia:59709 Change-Id: I65122ef06d2089243d1d0688707ca8caf335b2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473361Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2948c1aca72c..957c117e514f 2020-10-15 bsheedy@chromium.org [typ] Support ignoring tags If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1011107,chromium:1111876 Tbr: wenbinzhang@google.com Change-Id: Iadc9fc6419ba5c75d232e1c997a4cad40bd90b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477230 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
John Lee authored
This CL forces the dropEffect on a drag event's dataTransfer object to have a value of 'move' when a tab is moved into another window. The front-end will then use this value to determine if a tab that was dragged out should be reshown or kept hidden. This CL does not fix the case for dragging a tab into a new window by itself. Bug: 1081905 Change-Id: I08b5007640656a0017566f664fcc1c19062d3864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462353Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#817705}
-
Liquan (Max) Gu authored
Changes: * Rename PaymentRequestFactory into ChromePaymentRequestFactory. This change is made because going forwards, we will add WebLayerPaymentRequestFactory to create the PaymentRequest instance of WebLayer dialect. * Rename ComponentPaymentRequestImpl into PaymentRequestService. This change is made because ComponentPaymentRequestImpl is not implementing the PaymentRequest interface, and that we decide to use no prefix for the parts shareable between WebLayer and Chrome. * Rename PaymentRequestImpl into ChromePaymentRequestService. This change is made because it's no longer an implementation of the PaymentRequest interface, and that prefixing "Chrome" would distinguish it from the future WebLayerPaymentRequestService. * Rename PaymentUIsManager into PaymentUiService. This change is made for consistency with the naming convention of the above classes. Bug: 1137006 Change-Id: I13625a8f1553ee1eab612d70706295233e782c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467359 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817704}
-
Matt Jones authored
This patch also removes some plumbing that is no longer used as a result of removing this update. Change-Id: I624c0217054ee1954053d715b297a968dddcf43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476898Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817703}
-
Zentaro Kavanagh authored
- New code should import the .m.js version which does not try to initialize loadTimeData during import which causes an order dependency on imports. - Also ran git cl format --js to format/sort the imports Bug: None Test: browser_tests --gtest_filter=ScanningApp* Change-Id: Ie365b9563bca357b9467f556a5c12d28788b9716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477515 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817702}
-
Kenichi Ishibashi authored
This CL rewrites the test to remove use of ServiceWorkerRegistry and other in-memory representations so that the test can be moved to the Storage Service. This rewrites involved the following changes: * Change some helper functions to use ServiceWorkerStorage instead of ServiceWorkerRegistry. As a result, the type of return values of these functions are changed. * Update UserData operations in ServiceWorkerStorage to check arguments. These changes are required to pass existing tests. * Change the order of (expected, actual) pairs to (actual, expected) as new code uses the style. * Remove ServiceWorkerRegistry::DisableDeleteAndStartOverForTesting(). This is no longer needed. Bug: 1016064 Change-Id: Id26c790aced1a84ee49311563eec1b7c2422d848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473783Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#817701}
-
Nina Satragno authored
This patch implements gzip compression and decompression for WebAuthn's large blobs extension. Compression needs to happen 1) when receiving a large blob through the WebAuthn API, 2) when setting a large blob through the virtual authenticator (exposed through webdriver and devtools) and 3) when directly setting a large blob in unit tests. To satisfy the rule of two for cases 1) and 2), this patch introduces a Gzipper interface to the data decoder service, which runs in a sandboxed utility process. Case 3) is simply handled by compressing in tests. This feature is guarded behind the WebAuthenticationLargeBlobExtension feature flag. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I52c9031f1927a1bd4819d4d075fd59036fd3187a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464011 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#817700}
-
Adrienne Walker authored
There are plenty of bits of code that aren't tested in Chrome, and we don't need to specifically call these out. The bug to remove these has been open for six years, and so the time has come to just remove these macros. Bug: 380416 Change-Id: I9d8e4641d074763649fa600ef9c7411e64b961de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477238 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#817699}
-
Prakhar authored
Bug: 1139007 Change-Id: Icc9c097410148a6b55f0dad5b08cee9a10c088aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476875 Commit-Queue: Prakhar Asthana <pasthana@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#817698}
-
Jazz Xu authored
This CL changes the anchor of GMC dialog from bottom right to media tray button. We are anchoring it to rect rather than the media tray view since the dialog won't close if the media tray became hidden (e.g. when user clicks the unpin button in the dialog). Bug: 1137542 Change-Id: Ic71f4f1b46bb2e0a6e6b66c5806127631fa47a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464787Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817697}
-
Michael Checo authored
- There is now only one stop for the entire row. bug: 1031368 test: manual inspection Change-Id: I541f0c3d7fd8303e5ac9428f497f651332d402e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462384Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#817696}
-
Sergey Poromov authored
Before capturing video in Capture Mode, it should be checked whether the captured area is allowed according to the currently set Data Leak Prevention rules. Also, when video is being captured and confidential content appears in the area, the capture should be stopped via a callback. Bug: 1133324 Change-Id: I28ddd46b4c10760d3631d5b934ea06facec31df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438411 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#817695}
-
Xianzhu Wang authored
This is another preparation for unified PaintController. This ensures that the pre-composited layer list is always updated for not only the GraphicsLayers, but also the painted results. As we will always collect the layer list during paint, we no longer need the "SetForeignLayerListNeedsUpdate" flag. This also fixes the crash issues caused by the previous preparation CL crrev.com/814547. The crashes were because of stale PaintChunkSubset (referencing stale PaintArtifact) in the pre-composited layer list. Bug: 1132717, 1137591 Change-Id: I5401f909e104a143511de376d90cae6805c7baff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474094Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817694}
-
Kyle Horimoto authored
This CL completes the startup/shutdown refactor for the Nearby utility process. It adds an asynchronous ShutDown() function which is used in place of simply resetting the Mojo connection, which does not allow the process to shut down cleanly. Additionally, this CL adds a test for NearbyProcessManagerImpl which was omitted from https://chromium-review.googlesource.com/c/chromium/src/+/2459112. Fixed: 1130069 Change-Id: Ia5b0b28f185c07511ba0754a5ebf97b9b35ee737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460230 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#817693}
-
Torne (Richard Coles) authored
Enable this experiment flag by default in preparation for enabling it on stable via Finch. Extend the expiry of the related metric so that it keeps collecting data until after the default-enabling has reached stable. Bug: 1038002 Change-Id: Ieae23184ab430565df775c1aad4112dc63ae1561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477155Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#817692}
-
Jinsuk Kim authored
Extends the experiments to M92 so the flag options will be visible. Also extended Search.ContextualSearch.SelectionExpanded while I'm at it. Change-Id: If2466711bd67d1c692d0e1f3cec1fe2461f009e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472680Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#817691}
-
Claude van der Merwe authored
Mark Wifi Sync V2 translation strings in the multidevice suite as translateable and upload screenshots. Bug: 1117619 Change-Id: I44b6fdada47c6325dbd291bdb1fab82292bcbe84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468921Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#817690}
-
