Commits · d6e67531862df7ff3880fa80d8ac36cc9dd90ac9 · eriksson monteiro / tangled

25 May, 2020 40 commits

[COEP] Reorganize test expectations · d6e67531

Yutaka Hirano authored May 25, 2020

 - no-secure-context.html failures are platform independent. Unify the
   entries and associate it to an appropriate crbug issue.
 - javascript.https.html is no longer failing.
 - coep-frame-javascript.https.html is no longer failing.
 - require-corp.https.html is (sadly) flaky on both Debug and Release.
   Unify the entries.

Bug: 1086066, 1015187, 1013523, 626703, 1086065
Change-Id: I016579257bf3175a08755ee34bd8c911eeeb1d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212120
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771496}

d6e67531

Utilize selection_test() in editing/execCommand/format-block-with-trailing-br.html · 7a9db9c8

Yoshifumi Inoue authored May 25, 2020

This patch changes "format-block-with-trailing-br.html" to utilize
|selection_test()| for ease of maintenance and help to implementing EditingNG.

Bug: 707656, 679977
Change-Id: I386ca10eb56a820cf9b7e2ee140016ab17043733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214458
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771495}

7a9db9c8

WebApp: Make sure that ManifestUpdateManager works in the provider ready scope. · aee1785a

Alexey Baskakov authored May 25, 2020

Make sure that ManifestUpdateManager doesn't cause FinalizeUpdate while
web apps system is not ready.

Note: we should do
tasks_.clear();
in Shutdown to destroy all ManifestUpdateTasks.
That's how we unsubscribe tasks from WebAppUiManagerImpl:

void ManifestUpdateTask::UpdateAfterWindowsClose() {
...
  ui_manager_.NotifyOnAllAppWindowsClosed(
      app_id_,
      base::BindOnce(&ManifestUpdateTask::OnAllAppWindowsClosed,
      AsWeakPtr()));
}

In next CL: Plumb WebAppUiManagerImpl Startup/Shutdown.

Bug: 1084939
Change-Id: I25112df44af57606e38bcc6c12f12f67bd94c8b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212197
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771494}

aee1785a

Utilize selection_test() in editing/editing/style/5279521.html · 1b87679b

Yoshifumi Inoue authored May 25, 2020

This patch changes "5065910.html" to utilize |selection_test()| and renames to
"justify_block_starts_with_image.html" for ease of maintenance and help to
implementing EditingNG.

Bug: 707656, 679977
Change-Id: Ic22aa13b2da5c6dbcc0657d742c79bd4ffe37a27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213646
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771493}

1b87679b

file_manager: fix linting errors · 0709f3d4

Julian Watson authored May 25, 2020

Bug: 778674
Test: autoninja -C out/Release ui/file_manager:closure_compile
Test: autoninja -C out/Release browser_tests && out/Release/browser_tests --gtest_filter=*/FilesApp*
Change-Id: I1a9e532afc0122a78328eae857e0dbf34971fcbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212015
Commit-Queue: Julian Watson <juwa@google.com>
Auto-Submit: Julian Watson <juwa@google.com>
Reviewed-by: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771492}

0709f3d4

Migrate LocalFrame to use GC mojo wrappers. · bc5da8c9

Minoru Chikamune authored May 25, 2020

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: Ibf4e509a959108ddee42bef7233a0436ee7376cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192574
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771491}

bc5da8c9

Mechanically replace Shadow DOM v0 with v1 in web_tests [CL 1 of 3] · ed7f2284

Mason Freed authored May 25, 2020

This CL is the result of the following mechanical replacements, within
the third_party/blink/web_tests folder, on only .html and .js files:

'.createShadowRoot()'               -> '.attachShadow({mode: 'open'})'
'document.createElement('content')' -> 'document.createElement('span')'

Several web_tests did not pass after the above replacements were made.
Those tests were reverted - the changes in this CL are only the tests
that pass in the same way that they did prior to the replacements.
The only exceptions, which were re-baselined here, had *only* a
console warning message like this, which is now missing:

CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated
and will be removed in M80, around February 2020. Please use...

In addition, most of the same test expectations files were completely
removed from the virtual/web-components-v0-disabled folder, since these
tests no longer depend on WCv0 features, and no longer fail. One
exception is this one:
  fast/dom/shadow/disconnected-distribution-cycle-expected.txt
which still uses getDestinationInsertionPoints() and so breaks
differently now.

Bug: 937746
Change-Id: I03c0f834c82bac79e48eb0ddd419c9351b61b455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208386
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771490}

ed7f2284

Stop storing NGInlineItemResult in NGLogicalLineItem · d09348a6

Koji Ishii authored May 25, 2020

Because |NGLogicalLineItem| can live longer than
|NGInlineItemResult|, the pointer may become stale.
Instead, this patch changes |NGLogicalLineItem| to copy
necessary data from |NGInlineItemResult|.

This is to prepare for vectorizing |NGFragmentItem|, by
allowing to defer creating |NGFragmentItem| to after
|NGInlineItemResult| is destroyed.

This patch has no behavior changes.

Bug: 982194
Change-Id: Idfad9fe4d4421ddd76b2348e6c17e50e327911a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212187Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771489}

d09348a6

Start using ServiceWorkerStorageControl · a514e0e9

Kenichi Ishibashi authored May 25, 2020

This CL starts using ServiceWorkerStorageControl in
ServiceWorkerRegistry. For now, an instance of
ServiceWorkerStorageControl is owned by ServiceWorkerRegistry as a
drop-in replacement of ServiceWorkerStorage. Eventually the instance
will live in the Storage Service once all ServiceWorkerStorage method
calls are migrated into mojo methods.

This CL only replaces UpdateLastUpdateCheckTime() call. Subsequent
CLs will replace more ServiceWorkerStorage method calls.

According to android-binary-size trybot, this increases the binary
sizes by ~37kb. Most of the increase (~29kb) comes from mojo generated
code and there isn't much we can do to reduce them. Introducing this
mojo interface is necessary for migrating ServiceWorkerStroage to
the storage service. See the design doc [1] for the motivation and
plans.

[1] https://docs.google.com/document/d/1hO0WEuoEOgEBlf5nDE3fDjuQY2bV_d5hLtk25iBo0LM/edit?usp=sharing

Bug: 1055677
Binary-Size: Size increase is unavoidable (see above)
Change-Id: Ic843e25f3556249b67252f52e9e16428ec488dfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214582
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771488}

a514e0e9

BackForwardCache: Add first-paint timer after bfcache restore to WebPerformance · badb83e8

Hajime Hoshi authored May 25, 2020

This CL adds methods to WebPerformance to record the latest timing when
the page is restored from the back-forward cache and the latest timing
of first-paint event after restoring.

This CL is a preparation to record first-paint event for back-forward
cache at PageLoadMetricsObserver.

Bug: 1014174
Change-Id: Ie0bd0e1cbfc070867a75b2574f05ad0797934875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210181
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771487}

badb83e8

Utilize selection_test() in editing/editing/style/font-family-with-space.html · e1dd4ebc

Yoshifumi Inoue authored May 25, 2020

This patch changes font-family-with-space.html" to utilize |selection_test()|
for ease of maintenance and help to implementing EditingNG.

Bug: 707656, 679977
Change-Id: I1dc4ec92ce7aeb3b095f9854a2a1699bb3fa9dba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212196
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771486}

e1dd4ebc

Revert "WebApp: Call RegistryOpenedCallback asynchronously." · e394070d

Yutaka Hirano authored May 25, 2020

This reverts commit 945fcd73.

Reason for revert: Speculative revert for AppControllerPlatformAppBrowserTest.ActivationFocusesBrowserWindow failure. https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/50628


Original change's description:
> WebApp: Call RegistryOpenedCallback asynchronously.
> 
> We should break down this synchronous call chain:
> 
> web_app::WebAppSyncBridge::CommitUpdate()
> web_app::ScopedRegistryUpdate::~ScopedRegistryUpdate()
> web_app::WebAppInstallFinalizer::UninstallWebApp()
> web_app::WebAppInstallFinalizer::UninstallWebAppOrRemoveSource()
> web_app::WebAppInstallFinalizer::UninstallExternalWebApp()
> web_app::InstallFinalizer::UninstallExternalWebAppByUrl()
> web_app::PendingAppManagerImpl::UninstallApps()
> web_app::PendingAppManager::SynchronizeInstalledApps()
> web_app::ExternalWebAppManager::OnScanForExternalWebApps()
> web_app::ExternalWebAppManager::ScanForExternalWebApps()
> web_app::ExternalWebAppManager::Start()
> web_app::WebAppProvider::OnRegistryControllerReady()
> web_app::WebAppSyncBridge::OnDatabaseOpened()
> web_app::WebAppDatabase::OnAllMetadataRead()
> syncer::ModelTypeStoreImpl::ReadAllMetadataDone()
> 
> WebAppSyncBridge::OnDatabaseOpened() must not cause immediate
> WebAppSyncBridge::CommitUpdate() on same `this`.
> 
> Bug: 1084939
> Change-Id: Ib32c52780a647a0985418c0f92985f041869f104
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212236
> Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
> Commit-Queue: Alexey Baskakov <loyso@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771473}

TBR=ericwilligers@chromium.org,loyso@chromium.org

Change-Id: I80600ec60e1f669ca0823caf77ce36a3985d9dbe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1084939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213648Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771485}

e394070d

Roll Catapult from 5598ba3c0e6f to 34a30f39c0d1 (1 revision) · 39e04e09

chromium-autoroll authored May 25, 2020

https://chromium.googlesource.com/catapult.git/+log/5598ba3c0e6f..34a30f39c0d1

2020-05-25 fancl@chromium.org auto-triage: Fix point range AlertGroup

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1086055
Tbr: wenbinzhang@google.com
Change-Id: If2105e1612a772b74c5f1b4709aa5d1747cd302d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214683Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771484}

39e04e09

Set extension_flags for oes_draw_buffers_indexed func · e81fe436

shrekshao authored May 25, 2020

TBR=kbr@chromium.org

Bug: 1058744, 1085704, 1085846
Change-Id: Ia268bfe248a8fa7caa832e9e696a8039c7605b37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214611Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#771483}

e81fe436

Roll Skia from b5391d98b8d8 to 340fee5c8499 (1 revision) · 994cac50

chromium-autoroll authored May 25, 2020

https://skia.googlesource.com/skia.git/+log/b5391d98b8d8..340fee5c8499

2020-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 65ee6497d620 to 31c9c6949e02 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC westont@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: westont@google.com
Change-Id: Ifb853887942a5bc6c3ba3e50aada75309eff3ab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214684Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771482}

994cac50

Utilize selection_test() in editing/editing/style/5084241.html · 91198fa7

Yoshifumi Inoue authored May 25, 2020

This patch changes "5065910.html" to utilize |selection_test()| and renames to
"typing_style_color_before_delete.html" for ease of maintenance and help to
implementing EditingNG.

Bug: 707656, 679977
Change-Id: Ic7ede76eaa15a7381eaeaeaf087b3b703788d5bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214762
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771481}

91198fa7

Utilize selection_test() in editing/editing/style/block-style-00{1,2}.html · 89bb78e3

Yoshifumi Inoue authored May 25, 2020

This patch changes "block-style-00{1,2}.html" to utilize |selection_test()| and
integrates into "block-style-001.html" for ease of maintenance and help to
implementing EditingNG.

Bug: 707656, 679977
Change-Id: Ic2ae843b078ab9d85d6a7cb47337458fe3b031eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214584
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771480}

89bb78e3

Update OffTheRecord profile test in SearchPermissionsService. · a1e66183

Ramin Halavati authored May 25, 2020

Profile API is being updated (issue 1033903) and the usage of
GetOffTheRecordProfile and HasOffTheRecordProfile without argument is
getting deprecated.

The use of the function in SearchPermissionsServiceTest is updated and
a new test is added for non-primary off-the-record profiles.

Bug: 1060940
Change-Id: I39d1451c386d93fb47cbf2576d3b4280e634cb34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213563
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771479}

a1e66183

Roll Chrome Win32 PGO profile from... · 4ac39264

chromium-autoroll authored May 25, 2020

Roll Chrome Win32 PGO profile from chrome-win32-master-1590362592-27d6169705690c1f85a434239769339f2909dab4.profdata to chrome-win32-master-1590378757-fbe5ba418cc3b4a3b6daa4da92a12bf985342290.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I5cfb578711a914a50ef8fa68ef46d0a5f7ce42a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214688Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771478}

4ac39264

Reduce sizeof(NGPhysicalContainerFragment) by 8 bytes on 64-bit systems · 0cb42b4b

Xianzhu Wang authored May 25, 2020

Adjust the order of field to fill gaps after inherited fields.

Change-Id: Iafb34294d0643ffc4f761921a8382b595897463d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214462
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771477}

0cb42b4b

Roll Chrome Mac PGO profile from... · 62f238c8

chromium-autoroll authored May 25, 2020

Roll Chrome Mac PGO profile from chrome-mac-master-1590362592-b410bf229b3e4363919a6ee2322f1e85184470ca.profdata to chrome-mac-master-1590378757-0e86ea9817fe6c644c14c0cd7e1701a48ebcda53.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I07879cf3c4faa1fd573ef6432a857687fa3bc63b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214685Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771476}

62f238c8

Utilize selection_test() in editing/editing/style/4916887.html · 0b52638e

Yoshifumi Inoue authored May 25, 2020

This patch changes "4916887.html" to utilize |selection_test()| and renames to
"color_of_indented_text.html" for ease of maintenance and help to implementing
EditingNG.

Bug: 707656, 679977
Change-Id: I97c3a41130d62af6b4255fd161d9f21aaeccb5a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212239
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771475}

0b52638e

Roll Skia from 0e6d4f1bcfd1 to b5391d98b8d8 (1 revision) · 6d469c06

chromium-autoroll authored May 25, 2020

https://skia.googlesource.com/skia.git/+log/0e6d4f1bcfd1..b5391d98b8d8

2020-05-25 csmartdalton@google.com Reland "Reland "Add a tessellation mode that uses indirect draws""

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: westont@google.com
Change-Id: I526850c2a739f159ef2d0c695cbb2cf9fae86271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214681Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771474}

6d469c06

WebApp: Call RegistryOpenedCallback asynchronously. · 945fcd73

Alexey Baskakov authored May 25, 2020

We should break down this synchronous call chain:

web_app::WebAppSyncBridge::CommitUpdate()
web_app::ScopedRegistryUpdate::~ScopedRegistryUpdate()
web_app::WebAppInstallFinalizer::UninstallWebApp()
web_app::WebAppInstallFinalizer::UninstallWebAppOrRemoveSource()
web_app::WebAppInstallFinalizer::UninstallExternalWebApp()
web_app::InstallFinalizer::UninstallExternalWebAppByUrl()
web_app::PendingAppManagerImpl::UninstallApps()
web_app::PendingAppManager::SynchronizeInstalledApps()
web_app::ExternalWebAppManager::OnScanForExternalWebApps()
web_app::ExternalWebAppManager::ScanForExternalWebApps()
web_app::ExternalWebAppManager::Start()
web_app::WebAppProvider::OnRegistryControllerReady()
web_app::WebAppSyncBridge::OnDatabaseOpened()
web_app::WebAppDatabase::OnAllMetadataRead()
syncer::ModelTypeStoreImpl::ReadAllMetadataDone()

WebAppSyncBridge::OnDatabaseOpened() must not cause immediate
WebAppSyncBridge::CommitUpdate() on same `this`.

Bug: 1084939
Change-Id: Ib32c52780a647a0985418c0f92985f041869f104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212236Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771473}

945fcd73

Call HTMLSelectElement::SetActiveSelection*() only in the listbox mode · 059d75ea

Kent Tamura authored May 25, 2020

active_selection_*_ data members are referred only in listbox mode.
We don't need to update them in the menulist mode.

Bug: 1052232
Change-Id: Ib688c6e9977f42cd1cefdd83388fdc286345b842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212108
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771472}

059d75ea

Revert "Add tests for QuickAnswersView" · dd4da576

Yutaka Hirano authored May 25, 2020

This reverts commit fb330032.

Reason for revert: Failing on bots: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/b8879653217445589120

Original change's description:
> Add tests for QuickAnswersView
> 
> Add a test-fixture and basic tests for QuickAnswersView. Current tests
> verify the view's positioning with respect to its anchor and more tests
> will be added in follow-up CLs.
> 
> Bug: b:157182213
> Test: Built and ran ash:ash_unittests on local build.
> Change-Id: I44634313ff6538e48ef7375641e1971bfc989ab1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210977
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Abhijeet Singh <siabhijeet@google.com>
> Cr-Commit-Position: refs/heads/master@{#771207}

TBR=xiyuan@chromium.org,siabhijeet@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:157182213, 1085632
Change-Id: Iedb2530ed4d8c6b56ba8b5f3fe42fcc4d0052c5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212238Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771471}

dd4da576

ServiceWorker: Rename "running_hosted_version" to "version" · cd1e538a

Hiroki Nakagawa authored May 25, 2020

This CL renames ServiceWorkerHost's running_hosted_version to version
because it's obvious that the version kept by ServiceWorkerHost is the
running hosted version.

Bug: 931087
Change-Id: Icfa6ae852418c7e089b254b19a745756fd6d3c74
Tbr: kinuko@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206935
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771470}

cd1e538a

Files app: Alters the throttled change event algorithm · 10bf4a61

Bo Majewski authored May 25, 2020

Rather than counting time since last time we scheduled a throttled
change event, we count time since last time we posted one. This allows
us to post an event with 0 delay first, before starting to throttle
them.

Bug: 936790
Change-Id: Id9a40890d8d7fdb53e57f657c979f2ac5f4f7f19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210089Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Bo Majewski <majewski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771469}

10bf4a61

Roll src-internal from 2c63db0f9a76 to 7ca48df80a7b (1 revision) · c24feb4e

chromium-internal-autoroll authored May 25, 2020

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c63db0f9a76..7ca48df80a7b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC yhirano@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: yhirano@google.com
Change-Id: I2761e57aacdfe89c7024132321c6188aa5e10b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214580Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771468}

c24feb4e

Mark snap-to-target-on-layout-change.html as flaky on more platforms · dbfff880

Yutaka Hirano authored May 25, 2020

Tbr: yigu@chromium.org
No-Try: True
Change-Id: I95fdbddabf525f5455574622e138874b5245044e
Bug: 1060164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213644Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771467}

dbfff880

Try to make as much const in DocumentLoader as possible. · 849e290e

Fergal Daly authored May 25, 2020

Move a lot of stuff from constructor to initializers and mark
fields as const where possible.

Also
- add comment referencing https://crbug.com/855189
- delete GetClientHintsPreferences which is unused.

There's more that can be done but this is all of the stuff that was
easy.

Change-Id: I97bc5b9cc67fada0bb57426271fd38c376adcac9
Bug: 855189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203040
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771466}

849e290e

Import wpt@be4a903bca0a01b794bebf486f707c9f8e9e9ff6 · 3aa27d53

Chromium WPT Sync authored May 25, 2020

Using wpt-import in Chromium ff64aa2b.
With Chromium commits locally applied on WPT:
f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html"
45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent"
fc4093a6 "Move mouse-pointer-preventdefault.html to wpt"
3304d0fe "Revert "Move mouse-pointer-preventdefault.html to wpt""


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I700238d8da3501763e14cda400d973e536be2b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212388Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771465}

3aa27d53

[actionbar] Make search box collapse smoother · 86a9a04a

Alex Danilo authored May 25, 2020

Adds a transition for the background-color property on the search box
wrapper so that it fades out while the search text entry field is
collapsing to stop the sudden change of color when the text field starts
to collapse.

Bug: 1075941
Change-Id: I25d38c2db817b2585b8c86c046e5d88e041ec30a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210297Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771464}

86a9a04a

ServiceWorker: Rename ServiceWorkerProviderHost to ServiceWorkerHost · 593b6f5f

Hiroki Nakagawa authored May 25, 2020

ServiceWorkerProviderHost is equivalent to RenderFrameHostImpl,
DedicatedWorkerHost, and SharedWorkerHost. For name consistency, this CL
renames ServiceWorkerProviderHost to ServiceWorkerHost.

Design doc:
https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing

Bug: 931087
Change-Id: I583838006e8c10540acbe0a2681d11b8d9aad1ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203781Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771463}

593b6f5f

Updating trunk VERSION from 4155.0 to 4156.0 · f27f13b3

chrome-release-bot authored May 25, 2020

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I1c87ca2f4b9de688f18e382c187c13911950a3cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214622Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771462}

f27f13b3

Migrate WebFrameWidgetBase to use GC mojo wrappers. · 216045c2

Minoru Chikamune authored May 25, 2020

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: Ie6278431712a48c834491a56afc352a7ff63fa5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189714Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771461}

216045c2

Remove COEP expecations in stale virtual test suites · 0138d20e

Yutaka Hirano authored May 25, 2020

virtual/cross-origin-isolation was removed at
https://crrev.com/c/1975477.

virtual/stable/external/wpt/html/cross-origin-embedder-policy was
removed at https://crrev.com/c/2096403.

Bug: 1086065
Change-Id: I89655a99ff9de4be8357e8640fad95602b941d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212018
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771460}

0138d20e

Revert "WebUI NTP: redirect sign-in to chrome://newtab (reland)" · 3ac643d7

Yutaka Hirano authored May 25, 2020

This reverts commit 8ba04bb7.

Reason for revert: DiceBrowserTest.EnableSyncAfterToken is failing.

Original change's description:
> WebUI NTP: redirect sign-in to chrome://newtab (reland)
> 
> This is a reland of 142274a8 with a fix
> for DiceBrowserTest.EnableSyncAfterToken. Original change's info:
> > Bug: 1015293
> > Change-Id: Ic76e7911403a925fa46a5b5fc58eca95fa292269
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209392
> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> > Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#771116}
> 
> TBR=thestig@chromium.org
> 
> Bug: 1015293, 1085540
> Change-Id: I05450e311b9458b6927763cbf6b4c75c0621b56e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212818
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771246}

TBR=droger@chromium.org,thestig@chromium.org,tiborg@chromium.org,aee@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1015293, 1085540
Change-Id: Ic2d3ed8d4c34373fa200563b922a4b4af0b08abe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213643Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771459}

3ac643d7

Add more types to personal info suggester. · f733c15b

Jing Wang authored May 25, 2020

This is requested by our UX Claire. Add first name and last name, and
add one more way to trigger phone number.

Updated the unit test.

Test: tested with Chrome on Linux
Bug: 1042084
Change-Id: Ib9cd1185f8538f2655fc30a2a092de8aa27c4b7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210083Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jing Wang <jiwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771458}

f733c15b

ime: Delete chrome.input.ime for Windows and Linux. · fb2a2b5f

Darren Shen authored May 25, 2020

This CL deletes "win" and "linux" specific functions in chrome.input.ime,
which resulted in a chain reaction of deletions, including InputImeApi,
InputMethodEngine and UI code.

This CL is intentionally kept as small as possible. There will be
additional cleanups in the future.

Proposal doc: http://doc/1eIsYPs2JhzQ8qmM-96amsashfFmAAC9xoYRmY2CIjtM

Change-Id: I689badba5157f76b5a92d6a9b705a198760e7f00
Bug: 1083803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198861
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771457}

fb2a2b5f