GitLab

Step 1 of renames preceding the fix for family based fallback font selection.

BUG=382411
R=eae,behdad

Review URL: https://codereview.chromium.org/326763002

git-svn-id: svn://svn.chromium.org/blink/trunk@175858 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are two fixes here:
1) Previously frame scrollbars never had a chance to handle an event if an element or event handler swallowed the event. So, for example, if a mousedown event listener was added to the window and the handler called preventDefault(), then the frame scrollbar would never receive mouse clicks. This change always gives frame scrollbars an opportunity to handle the event. This would also affect elements (such as plugins) that lie underneath overlay scrollbars and swallowed events.

2) Previously if an overlay scrollbar was above a plugin, clicking on the scrollbar could trigger mouse capture on the plugin, which would interfere with the scrollbar receiving events. This change prevents mouse capture on a plugin from starting if the event was initiated above a scrollbar.

BUG=369898,358248

Review URL: https://codereview.chromium.org/296003011

git-svn-id: svn://svn.chromium.org/blink/trunk@175857 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes Position::isCandidate() and Position::isCandidate() not to
return true for SVG elements except for rendered text, since we don't implement
SVG editor yet.

Note: Rendered text in SVG documents are represented by |Text| class and their
renderer is |RenderSVGInlineText| derived from |RenderText| class.

BUG=380043
TEST=LayoutTests/editing/execCommand/format-block-with-uneditable-crash-2.html

Review URL: https://codereview.chromium.org/314923003

git-svn-id: svn://svn.chromium.org/blink/trunk@175855 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently ServiceWorkers are non-null, however when we implement the .waiting property, the browser will "set" a null ServiceWorker to clear the property. Make Blink ready to unwrap one of those.

BUG=379012

Review URL: https://codereview.chromium.org/323523002

git-svn-id: svn://svn.chromium.org/blink/trunk@175853 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL splits ScrollView::updateScrollbars() into 3 independent helper
functions, namely:

computeScrollbarExistence() computes whether scrollbars are needed given
the current ScrollView state.

adjustScrollbarExistence() creates/removes scrollbars and invoke appropriate
callbacks to update layout (if applicable).

updateScrollbarGeometry() positions the scrollbars and pushes the scroll
extents.

Also we no longer do update scrollbar passes in recursion. Instead we do
it in a loop and early exits if updateScrollbars() is re-entered.

No tests as there should be no behavior difference.

Review URL: https://codereview.chromium.org/314583008

git-svn-id: svn://svn.chromium.org/blink/trunk@175852 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're going to change element factories at least twice.
 1. Replace adoptRefWillBeRefCountedGarbageCollected with adoptRefWillBeNoop
 2-1. Replace PassRefPtrWillBeRawPtr<T> with T* and remove adoptRefWillBeNoop if
   we switch to Oilpan successfully.
 2-2. Replace PassRefPtrWillBeRawPtr<T> with PassRefPtr<T>, and
   adoptRefWillBeNoop with adoptRef if we decide not to switch to Oilpan.

This CL makes these changes easier.

Also, this CL split existing DEFINE_NODE_FACTORY into DECLARE_NODE_FACTORY and
DEFINE_NODE_FACTORY to avoid inline definition in headers.
http://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-inlining-code-in-headers

BUG=357163

Review URL: https://codereview.chromium.org/327633004

git-svn-id: svn://svn.chromium.org/blink/trunk@175851 bbb929c8-8fbe-4397-9dbb-9b2b20218538

First (simple) step in factoring out redundant GYP actions into templates.
Also moves the 'write_file_only_if_changed' flag to scripts, as that's where
it's used, which allows more simplification.

R=haraken

Review URL: https://codereview.chromium.org/316173008

git-svn-id: svn://svn.chromium.org/blink/trunk@175848 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175832

BUG=381138
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/322693003

git-svn-id: svn://svn.chromium.org/blink/trunk@175847 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is by no means a good implementation of Fetch, however it is sufficient
to let us start proceeding with the cache API (and add).

R=falken@chromium.org,jkarlin@chromium.org
TBR=jochen@chromium.org
BUG=381179

Review URL: https://codereview.chromium.org/311343003

git-svn-id: svn://svn.chromium.org/blink/trunk@175846 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175827

BUG=372837
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/328553003

git-svn-id: svn://svn.chromium.org/blink/trunk@175845 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reduce the size of Node by 8 bytes on 64bit with gcc and clang compilers
(from 72 bytes to 64 bytes) by altering the order of its parent classes. The
TreeShared<Node> parent class now comes last because it contains only 1 member
(in release) which is an int and the first member of Node is a uint32_t. This
way no padding is added by gcc/clang and these two members will use the same
word in memory.

MSVC likely won't get any benefit from this because it makes sure each class
in the hierarchy is memory-aligned (see "Compiler being used" section in [1]).
There should be no size impact for MSVC.

[1] http://www.cprogramming.com/tutorial/size_of_class_object.html

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/326793002

git-svn-id: svn://svn.chromium.org/blink/trunk@175844 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix RenderObject::repaintRectangle in situations when the render object is not a layer and is squashed.

Previously it was recording a repaint rect in the coordinate space of the enclosing *squashed* layer,
not the coordinate space of the *squashing layer* that the squashed layer paints into.
BUG=382129

Review URL: https://codereview.chromium.org/328533003

git-svn-id: svn://svn.chromium.org/blink/trunk@175843 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This replaces calls to RenderLayer::hasDirectReasonsForCompositing in
RenderObject::adjustStyleDifference with calls to
RenderLayer::styleDeterminedCompositingReasons.

This also removes hasDirectReasonsForCompositing altogether, as it
no longer has any callers.

Review URL: https://codereview.chromium.org/327593002

git-svn-id: svn://svn.chromium.org/blink/trunk@175842 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=368814
TBR=jww

Review URL: https://codereview.chromium.org/320403003

git-svn-id: svn://svn.chromium.org/blink/trunk@175841 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove impossible conditions from SelectorChecker::checkOne(). The code is in
an if "(selector.m_match == CSSSelector::PseudoClass)" check scope so it is
impossible for "selector.m_match == CSSSelector::Tag" to ever be true in
the two conditions that are removed.

This is based the following WebKit revision by benjamin@webkit.org:
http://trac.webkit.org/changeset/156380

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/328443003

git-svn-id: svn://svn.chromium.org/blink/trunk@175839 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow on patch / fix after r175488, where I started
forcing a "crash" if we detected output from the sanitizer after a
test. We were not setting the process name or pid, which caused
problems later when writing out the crash logs.

TBR=ojan@chromium.org
BUG=336971

Review URL: https://codereview.chromium.org/325993002

git-svn-id: svn://svn.chromium.org/blink/trunk@175838 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- This CL adds an ASSERT to ScriptValue to verify that ScriptValue::v8Value() is used in the same world that created the ScriptValue.

- To insert the check, we need to get a current world in ScriptValue::v8Value(). For that goal, this CL makes sure that we're in some context when calling ScriptValue::v8Value().

BUG=341032

Review URL: https://codereview.chromium.org/314953005

git-svn-id: svn://svn.chromium.org/blink/trunk@175837 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175820

BUG=378959
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/324803005

git-svn-id: svn://svn.chromium.org/blink/trunk@175836 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some modifications necessary to account for differences in version of the spec and implementation.

BUG=377941,245025

Review URL: https://codereview.chromium.org/298023002

git-svn-id: svn://svn.chromium.org/blink/trunk@175833 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In an attempt to optimize pushing and popping LayoutState,
the entire optimization ended up being turned off. Fix the
use of LayoutState for RenderView-relative renderers.

BUG=381138

Review URL: https://codereview.chromium.org/326753002

git-svn-id: svn://svn.chromium.org/blink/trunk@175832 bbb929c8-8fbe-4397-9dbb-9b2b20218538

if the tracing category blink.invalidation is on.
BUG=

Review URL: https://codereview.chromium.org/320553004

git-svn-id: svn://svn.chromium.org/blink/trunk@175831 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Moves some logic from the JS code in to the code that generates
builders.jsonp for steps with test in the name that don't actually
run tests. Also expands this list a bit.

Also, creates a new list for test steps that do run tests, but
don't upload to the dashboard. In a future patch, I'll expand this
list and give it a nice UI in the flakiness dashboard that points
people to a way to get the test step to upload results.

Review URL: https://codereview.chromium.org/309783002

git-svn-id: svn://svn.chromium.org/blink/trunk@175829 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It didn't really make sense to be part of auto-rebaseline except
for the special noneedsrebaseline entries, which I've decided are
not really useful anyways. More importantly, move it up means
that we actually log everything to the server, including the outer
git pull call and it means that we log asynchronously to the
auto-rebaseline command, which should make it a lot faster.

Also, make the git cl upload logging log stderr as well.

BUG=382248

Review URL: https://codereview.chromium.org/327443002

git-svn-id: svn://svn.chromium.org/blink/trunk@175828 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=abarth
BUG=372837

Review URL: https://codereview.chromium.org/311273008

git-svn-id: svn://svn.chromium.org/blink/trunk@175827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, StringHasher contained methods for calculating the hash of a pure C
character array without having to pass in the length of the array. This was only
used for AtomicStrings constructed via a string literal. The impl of the specific
hashing function currently used in WTF already checks for null terminated character
array and when the final StringImpl* for the AtomicString is constructed we
do so again.

This patch just computes the length up front and passes that information along
to the hashing function.  Eventually this length is used to construct the
StringImpl without computing again.

BUG=none

Review URL: https://codereview.chromium.org/328453003

git-svn-id: svn://svn.chromium.org/blink/trunk@175826 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=abarth
BUG=382129

Review URL: https://codereview.chromium.org/323853007

git-svn-id: svn://svn.chromium.org/blink/trunk@175825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're adding the GN bots to the CQ, so they should be here as well.
Also, update the list to point at the correct set of android compile-only bots.

R=jamesr@chromium.org
BUG=380464

Review URL: https://codereview.chromium.org/319873002

git-svn-id: svn://svn.chromium.org/blink/trunk@175824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Everything in the code assumes that the interval size will always fit in
an int. However, to make sure there are no negatives, the
RasterShapeInterval constructor takes an unsigned. This clamps that
value to make sure we can't overflow an int later.

Review URL: https://codereview.chromium.org/313393004

git-svn-id: svn://svn.chromium.org/blink/trunk@175823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When acceleratedCompositingForFixedPositionEnabled is not set
FrameView::scrollContentsFastPath() performs invalidate for every sticky or
fixed layer. Page http://people.mozilla.org/~jorendorff/es6-draft.html#sec-terms-and-definitions-symbol-type 
causes Region::unite a lot. Vector buffer reallocations are hot in profiler.
This patch pre-allocates vector buffers in Region::Shape::shapeOperation() and
moves Vector allocation out of inner loop. This significantly reduces number of
vector buffer reallocs.

BUG=335306

Review URL: https://codereview.chromium.org/183663030

git-svn-id: svn://svn.chromium.org/blink/trunk@175822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

-Pass -f instead of setting EDITOR.
-Put a message at the top of FlakyTests saying it's autogenerated.
-Add a test that goes through the upload codepath.
-Have ExecutiveMock log calls to run_and_throw_if_fail.

Review URL: https://codereview.chromium.org/312103005

git-svn-id: svn://svn.chromium.org/blink/trunk@175821 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because font is inherited we had bugs due to the text autosizing
multiplier and the font getting out of sync. This patch changes
the text autosizing multiplier to inherit like the font properties.

TEST=display-type-change.html which failed before this patch.
BUG=378959

Review URL: https://codereview.chromium.org/319283002

git-svn-id: svn://svn.chromium.org/blink/trunk@175820 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently Clank could only delete (with the backspace key) nodes that are
visible to the android IME, and since a replaced element, e.g. <img>, is not
visible to the IME, thus it could not be easily deleted using the backspace key.
Another side effect is that if two text nodes are separated by an image element
alone, then they appear as a single composition to the IME.

To fix these issues, this CL exposes a replaced element as a single object
replacement char 0xFFFC to InputMethodController. For more details please refer
to the atatched bug.

BUG=311448

Review URL: https://codereview.chromium.org/297003003

git-svn-id: svn://svn.chromium.org/blink/trunk@175819 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=382589

Review URL: https://codereview.chromium.org/313393005

git-svn-id: svn://svn.chromium.org/blink/trunk@175818 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test checks that the composited layer tree is updated immediately
after the inner iframe becomes composited due to an accelerated
overflow scrolling layer.

I have confirmed that this test fails without Ojan's change to give
all RenderParts render layers (this CL marks composited iframes as self
painting immediately rather than after a style update allowing the
GraphicsLayerUpdater to stitch in the subframe's graphics layer tree
right away) -- https://codereview.chromium.org/302083002

R=ojan@chromium.org
BUG=379097

Review URL: https://codereview.chromium.org/324733002

git-svn-id: svn://svn.chromium.org/blink/trunk@175817 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're not actively working on CSSStickyPosition. It's not ready for web
developers to experiment with yet.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/320323002

git-svn-id: svn://svn.chromium.org/blink/trunk@175816 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Return early from preload request for main resource
to avoid spinning up ResourceLoader unnecessarily.

Review URL: https://codereview.chromium.org/314423004

git-svn-id: svn://svn.chromium.org/blink/trunk@175815 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/319383002

git-svn-id: svn://svn.chromium.org/blink/trunk@175814 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Automatically generated using:
webkit-patch update-flaky-tests

R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/319383004

git-svn-id: svn://svn.chromium.org/blink/trunk@175813 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Nothing calls this any more after
https://codereview.chromium.org/323633002/

BUG=none

Review URL: https://codereview.chromium.org/322553006

git-svn-id: svn://svn.chromium.org/blink/trunk@175812 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We were just looping over port names before, which will default
us to only use release builds. Also, that's wrong anyways because
there's no guarantee that a port actually runs on a builder yet.
Instead, loop over the builders. We assume throughout the codebase
that these builders upload results to the flakiness dashboard,
so it's correct to use the builders list here.

Review URL: https://codereview.chromium.org/326483002

git-svn-id: svn://svn.chromium.org/blink/trunk@175811 bbb929c8-8fbe-4397-9dbb-9b2b20218538