- 19 Dec, 2019 40 commits
-
-
Nicolás Peña Moreno authored
This CL does the following fixes to crossiframe.html test: * Remove slow-image and onload, which are obsolete assumptions. Instead, rely solely on PerformanceObserver. * Use awaits where needed to make the test logic more sequential. * Use coordinates and test_driver.Actions() to target the iframe. Using the test_driver.click directly won't work for elements in iframes. * Updates the test to check reasonable values for the frame and iframe entries and check that they don't receive each other's entries. This CL also: * Removes unneeded variables from the clickAndBlockMain(). * Removes manual test, which is no longer needed. Bug: 831729 Change-Id: Iff50035a216b21f67cd71796023af4f934573086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972249 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#726422}
-
Aya ElAttar authored
Moved the browsertests of media stream policies out of policy_browsertest.cc & added TODO comment to refactor base::RunLoop::QuitCurrentWhenIdleDeprecated() Bug: 1002483 Change-Id: Ia007dfd0a6b30ed4be0e1eb708899b3f47e1376d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930831Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#726421}
-
Andrew Grieve authored
Change-Id: I7fe91b126afdf7b6db18476579002c1ea03774c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976192 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726420}
-
Marc Treib authored
This CL adds suffixes Sync, Drive, and Policy to the existing histogram FCMInvalidations.FCMMessageStatus. Having all the different senders in a single histogram made analysis tricky. Since the sender_id constants aren't accessible at the place where the histogram is recorded, they're duplicated. This should be okay since existing sender_ids are not expected to change, and new ones are added infrequently. While I'm here, also add myself as an owner of other FCMInvalidations histograms, since the original owner is OOO. Bug: 1023813 Change-Id: I41d24f4d61c22641eb0e599176fcfff45f2740c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972841 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726419}
-
Pete Williamson authored
This histogram is useful for dashboarding system health. Change-Id: I67bfb8a085b683478d27ebfe61f1d8cc734a7e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970739Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#726418}
-
Olivier Li authored
Also switch from SingleThreadedTaskEnvironment to TaskEnvironment to prepare for activation of HistoryServiceUsesTaskScheduler activation. The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be prepared to stay functional when that happens. Bug: 546640 Change-Id: I6c9c414794dc86c96721bdd23ccb31765e6a31c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976290 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Gabriel Charette authored
See bug for details. Bug: 1035604 Change-Id: I071fce979094d291171a7fba4b90da2bf70ce711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974585Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#726416}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cf788596f480..5217ad51c521 git log cf788596f480..5217ad51c521 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 enga@chromium.org fuzzing: When fuzzing, always ASSERT, and abort() instead of SIGTRAP Created with: gclient setdep -r src/third_party/dawn@5217ad51c521 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I47d945c7ec45d165bef18adac3aafbd09d32208c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726415}
-
Mugdha Lakhani authored
This change adds an observer class to BrowserFragmentImpl, so we can observer when the first fragment using WebLayer is attached, and when the last such fragment is detached. For this duration, logic has been added to listen to changes using NetworkChangeNotifier. Manually tested using chrome://inspect and navigator.online(). Not able to test a javatest because the instrumentation test and the activity under test use different class loaders, causing two instances of the NetworkChangeNotifier singleton. It's thus hard to force/mock network connectivity state to observe changes to navigator.online() as a result. Bug: 1018848 Change-Id: I4a4c990ee6e98d5b35f91a68c15baa97def7cd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971926 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#726414}
-
Evan Stade authored
Bug: 1034609 Change-Id: Ie32dc7e7a92f8286a5ab3357cfc9a1cb51f2d4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972169Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#726413}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4fd7fccd6db5..6d3c7f5526ec git log 4fd7fccd6db5..6d3c7f5526ec --date=short --first-parent --format='%ad %ae %s' 2019-12-19 swiftshader.regress@gmail.com Regres: Update test lists @ 4fd7fccd Created with: gclient setdep -r src/third_party/swiftshader@6d3c7f5526ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1e505489b251c3e228c5af166c637414b2953cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976098Reviewed-by:
-
yilkal authored
This CL does the following: 1. Adds the kite icon to the page. 2. Simplifies the design to have only 2 different modes. 2.1 Mode 1. For view ports with width > 420px and 2.2 Mode 2. For view ports with width < 420 px (mobile devices or iframes) The changes simplify the error page making it easy to modify without breaking it. Bug: 850328 Change-Id: I9138670ffce0e705456eb5cce7d7ff048ef693d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959849Reviewed-by:Marc Treib <treib@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#726411}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/121ebd03..5b70d915 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ied21a258e5f5ed536a3c74fc5a10a4b726db8371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976251Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726410}
-
Elly Fong-Jones authored
During the refactors in r723559 and prior two bugs crept in: 1) HasOmniboxKeyword() became inverted so that it returned true if there was *no* omnibox keyword (oops) 2) ShouldAnchorToOmnibox() came to mean "has omnibox keyword" rather than "has omnibox keyword *and* shouldn't anchor to browser/page action", which is what the old code had (oops again) This change fixes both of those errors. Bug: 1033856 Change-Id: I3c7a1a24d223b1893b4945a0aff6c79bc49c3ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966360 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#726409}
-
Aya ElAttar authored
Moved the browsertests of component updater policy and all the related stuff out of policy_browsertest.cc & added TODO comment to refactor base::RunLoop::QuitCurrentWhenIdleDeprecated() Bug: 1002483 Change-Id: Id92bc69cf4aea1ed015fb191bffed6cdafa12121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926138Reviewed-by:
-
Xianzhu Wang authored
Increase difference between the test and the ref. Change-Id: I956a4ef3ee304c0ab25b62cebe1185d6c5e3a941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975383 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726407}
-
Etienne Bergeron authored
This CL is rewriting the ElideText unittests. The goal of this rewrite is to allow adding more unittests. * ELIDE_HEAD * ELIDE_EMAIL * ELIDE_MIDDLE * Eliding with styles It is now using a templated tests to ease debugging. A change to the way glyph_width_for_test_ work was needed. Zero width codepoints will stay zero width, even if a glyph width is provided. This is required to ensures RLM and LRM (directional marker) stay with width zero. Otherwise a DCHECK is failing since the text can be larger with eliding (2 glyphs instead of 1 glyph). Bug: 1025561 Change-Id: I19f18fb99f52edbbb59d170f7b47bef3a3f3de5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975056 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#726406}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iba1bec6352c6659c0feceb7e20a29f5c03224de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976100Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8519d85b8ea..baf7a8617f37 Created with: gclient setdep -r src-internal@baf7a8617f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981 Tbr: jbudorick@google.com Change-Id: I2be6e9dc422c7fda35813d3a0d23ec36ae58865b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976099Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726404}
-
Nina Satragno authored
As per the spec [1], the attestation certificate must have the C, O, OU, and CN attributes set. [1] https://w3c.github.io/webauthn/#sctn-packed-attestation-cert-requirements Fixed: 1035092 Change-Id: Iff61fe93136e45a0e20d42a0a08ddf5c34f0bc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974703Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#726403}
-
Xiyuan Xia authored
- Add --trace-dir=PATH to chromeos/test_runner.py When present, test_runner script passes the switch with device local path (e.g. /tmp) to gtest to generate trace file on device and collects the trace files back to PATH on host afterwards. - Update run_gtest_benchmark.py to map the trace file path in the test result json collected by test_runner script so that processor scripts could find and computer metrics from the trace file. Example usage: For developers: tools/perf/run_gtest_benchmark.py out_${SDK_BOARD}/Release/bin/run_interactive_ui_tests --device=$DUT --gtest_filter=All/OverviewAnimationsTest.EnterExit/7 --output-dir=/tmp/perf_output --output-format=histograms --dbus-stub --stop-ui For perf bots: testing/scripts/run_performance_tests.py --isolated-script-test-output=/tmp/perf_output/output.json --non-telemetry=true --use-gtest-benchmark-script --gtest-benchmark-name=interactive_ui_tests tools/perf/run_gtest_benchmark.py out_${SDK_BOARD}/Release/bin/run_interactive_ui_tests --device=$DUT --output-format=histograms --dbus-stub --stop-ui Bug: 945711 Change-Id: Ia6911921b8354d7763be96c30a8877c9d598f103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974587 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:Ben Pastene <bpastene@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#726402}
-
Yue Zhang authored
Some of the tests disabled by https://crrev.com/c/1951894 are due to unexpected device orientation change possibly caused by previously runned tests changing orientation but never resetting back. Now that we have reset orientation in http://crrev.com/c/1972942, re-enable these tests to see if the problem is resolved. Bug: 1033970, 1030561, 1030562 Change-Id: I41c7bfba8d3a8962423d571196190475e821bc20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976014 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77742c350371..d04ddcd6c518 git log 77742c350371..d04ddcd6c518 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 robertphillips@google.com Update GL and Vulkan backends to support compressed backend formats 2019-12-19 brianosman@google.com Runtime SkSL: API sketch for child shaders/effects Created with: gclient setdep -r src/third_party/skia@d04ddcd6c518 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I892b0ff95859422f011c84f6d1cb5143d600f7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976097Reviewed-by:
-
Dave Tapuska authored
In order for WebInputEvent to have virtuals and make the class less struct like we need to formally move it into common. This change was largely done via sed. BUG=836826 TBR=thakis@chromium.org, lazyboy@chromium.org Change-Id: I9db295f66f723cb0ea5dd69868d28de508bf056e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973197 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#726399}
-
Rune Lillesveen authored
We should do the necessary invalidation from RemovedFromFlatTree() in the same method for light tree children, and marking nodes for style recalc from child insertions and slot assignment as necessary. Change-Id: Ibed7c1dc5243cf6524dd9fa8c2e214d9d8e1f04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975915Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#726398}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c58ff87e3200..8b42807c6f1e git log c58ff87e3200..8b42807c6f1e --date=short --first-parent --format='%ad %ae %s' 2019-12-19 andrewlamb@chromium.org replication_lib: Add trailing newline to JSON payloads. 2019-12-19 vapier@chromium.org cros_build_lib.run: clean up combine_stdout_stderr->stderr migration 2019-12-19 bpastene@chromium.org auth: Add support for fetching git creds via git-credential-luci. 2019-12-18 saklein@chromium.org commandline: Add servo device support 2019-12-18 tbegin@google.com packages: add uprev_ebuild_from_pin uprev handler 2019-12-18 mmortensen@google.com Update query_build_logs to fix verbose, include more fields. 2019-12-18 andrewlamb@chromium.org Remove sanity suite from Canary. 2019-12-18 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-18 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-18 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-18 saklein@chromium.org Goma: Fix log dir handling. 2019-12-18 mmortensen@google.com Update query_build_logs to show improved usage on errors. 2019-12-18 mnissler@chromium.org Provide virtio-rng device to guests. Created with: gclient setdep -r src/third_party/chromite@8b42807c6f1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I8cb350435a2fd30c88a0e4a9fc3950d34b76cbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976095Reviewed-by:
-
Scott Violet authored
It's the default and we started removing code that means we can no longer disable it. BUG=993813 TEST=none Change-Id: I9f65953bd5a696ad9281644285caa3f9ccba8c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975303 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Stephen Nusko authored
blink_perf.canvas/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d_RAF.html?RAF everywhere and others on android, mac, and win. NOTRY=true TBR=crouleau@chromium.org BUG=1035865,978500 CC=aaronhk@chromium.org,fserb@chromium.org Change-Id: I747fb7924f9632edd3bf5f6582e99f028e4fb65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975923Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#726395}
-
Robbie Gibson authored
A utility function for setting BOOL preference values was added recently, so this test no longer needs the test-specific AppInterface code setting these. Bug: 987646 Change-Id: Ic5b96b2b20667e218407663cf2d7e042371653ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972308 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726394}
-
James Hawkins authored
The registration in route.js does not include the 'apps/' prefix. R=dpapad@chromium.org Bug: 1029093 Test: none Change-Id: I4fed6fd3f98f647884604b81e518f7e483bf8fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974704Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#726393}
-
henrika authored
Extends existing logs related to media streams and media stream tracks and aligns the style with recent work in this area. Bug: 1017219 Change-Id: I88ed50cd4c0d9dd5e2f6104e8176a8ef99d6d46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960278Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#726392}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/860e0e564df9..79994d4369cf git log 860e0e564df9..79994d4369cf --date=short --first-parent --format='%ad %ae %s' 2019-12-19 lalitm@google.com trace_processor: rename timestamp -> ts 2019-12-19 lalitm@google.com Merge "build: add example api target" 2019-12-19 lalitm@google.com Merge "trace_processor: revamp Android CPU metric" 2019-12-19 lalitm@google.com Merge "perfetto: remove redundant genrule in ipc target" Created with: gclient setdep -r src/third_party/perfetto@79994d4369cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I73286c4886054ef539ef6cb36fc5a47d82877f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976096Reviewed-by:
-
Finnur Thorarinsson authored
The small blue Play button was used when in full screen mode, but with this CL it changes to a centered large Play button. Bug: 895776, 656015 Change-Id: I502d77d0cc3d88a57e4b251b152651b1a4b6311f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970475 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726390}
-
Alex Ilin authored
This CL fixes monochrome build error that was introduced by unfortunate rebase in https://crrev.com/c/1974000/1..4 TBR: torne@chromium.org,cjgrant@chromium.org,estevenson@chromium.org Bug: 1035793, 1027573 Binary-Size: putting some missing assets back, no regression Change-Id: Ibeceacc9b876759c8ad179850ec89daea0dde613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975723Reviewed-by:
-
ewannpv authored
- Adds new security indicator icons that are more visually balanced with the origin label. - Adds new share icon that is more consistent in weight to the other toolbar icons, and who’s scale is feels more appropriate inside the Omnibox. - Adds new toolbar icons that distinguish from Safari and are more GM2 compliant. Before: https://drive.google.com/a/google.com/file/d/1eAM4B9XFHt6iZx6c9Swks_7Qj9lL4FIF/view?usp=sharing After: https://drive.google.com/a/google.com/file/d/1Zxbv1RYuBuzjDrxSKS_QJ7ZOVQUHarNo/view?usp=sharing Bug: 1035850 Change-Id: I70cac1b64833fd9921bbc9db868862aedd797391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974090Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#726388}
-
Simon Zünd authored
This CL re-enables tests that are affected by V8's top-level await implementation. Manual wrapping of code in an async arrow function was removed from the frontend, so the 'unit' test for that wrapping code is also removed as part of this CL. Since we also correctly handle the completion value of async scripts, the top-level-await web test was rebaselined. All other tests can simply be re-enabled. Bug: chromium:1021921 Change-Id: I902f36fa5b662f7df549dc233eee94212aaeadb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962259Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#726387}
-
Demetrios Papadopoulos authored
Also moving wallpaper_browser_proxy.html/js to c/b/r/chromeos/ Bug: 1026455 Change-Id: I89e8fbcfff964fede0361e65346acce63ea8f1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975291 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#726386}
-
Emanuel Ziegler authored
This CL replaces calls to deprecatedByteLengthAsUnsigned by calls to byteLengthAsSizeT. Since the value is only used for comparison, the implicit upcast to size_t will be rejecting too large sizes. This are only the trivial fixes, the complex fixes are covered in bug chromium:1030717. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=mkwst@chromium.org Bug: chromium:1008840 Change-Id: Ic6e4a07b55b1c0f37a31c8ab1de41c183032de60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964591Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#726385}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2d6ebb24. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" 044ad8ad "[OT-PW] Make it work with OOP-R" 9899425d "[css-layout-api] IntrinsicSizes Implementation" 7d838af7 "[scroll-to-text-fragment] Apply :target CSS pseudo-class to match." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia35e4c583199a2f1e32b85d6d105f66ff48c5c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975834Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726384}
-
Ben Kelly authored
Previously there were many different places where CacheManager() was being called like this: if (CacheManager()) CacheManager()->DoSomething(); This is problematic for two reasons. First, CacheManager() can begin returning nullptr at any time if shutdown is initiated on a separate thread. Second, CacheManager() will return a new object every time its called from a separate sequence which is wasteful in this pattern. This CL corrects these call sites to only invoke CacheManager() once and to use the returned reference instead. Bug: 1033251 Change-Id: I61c24fd9bbf20c8ad7791fdc5bb1698ea8a4c5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973998Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#726383}
-
