- 24 Mar, 2015 40 commits
-
-
calamity authored
This CL fixes the test by using FocusManager::GetNextFocusableView instead of actually setting focus, which was causing flake because other concurrent browser tests could change the focused view. BUG=463456 Review URL: https://codereview.chromium.org/984813002 Cr-Commit-Position: refs/heads/master@{#321949}
-
mgiuca authored
Tests are flaky, especially on WinXP bots. BUG=470013 TBR=tommi@chromium.org Review URL: https://codereview.chromium.org/1033593002 Cr-Commit-Position: refs/heads/master@{#321948}
-
kcarattini authored
BUG=438525 Review URL: https://codereview.chromium.org/1027683002 Cr-Commit-Position: refs/heads/master@{#321947}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#321946}
-
rnephew authored
A new way to enable collection of power data that is not dependant on the divice was implemented in https://codereview.chromium.org/993733002/ This CL is to change telemetry to use this when getting dumpsys data. This method of disabling charging does not work with monsoon since it does not actualy disable charging, but just starts the dumpsys collection. BUG= Review URL: https://codereview.chromium.org/1010213008 Cr-Commit-Position: refs/heads/master@{#321945}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/201fd41..de093d2 TBR=dglazkov@chromium.org,alph@chromium.org Review URL: https://codereview.chromium.org/1029223004 Cr-Commit-Position: refs/heads/master@{#321944}
-
hashimoto authored
Add a new method base::File::FlushData to use fdatasync. BUG=469071 Review URL: https://codereview.chromium.org/1023103002 Cr-Commit-Position: refs/heads/master@{#321943}
-
mtomasz authored
Instead of allowing all component apps, this CL whitelists only those apps which need access to this API. TEST=All current tests pass. BUG=323422 Review URL: https://codereview.chromium.org/1030533002 Cr-Commit-Position: refs/heads/master@{#321942}
-
bajones authored
BUG=295792 Review URL: https://codereview.chromium.org/1025303006 Cr-Commit-Position: refs/heads/master@{#321941}
-
shuchen authored
BUG=367631 TEST=None Review URL: https://codereview.chromium.org/1031573002 Cr-Commit-Position: refs/heads/master@{#321940}
-
benwells authored
The latest angle roll fixed the problem, so the suppression can be removed. TBR=glider@chromium.org BUG=468638 Review URL: https://codereview.chromium.org/1015243003 Cr-Commit-Position: refs/heads/master@{#321939}
-
mtomasz authored
The new logic was trying to mount all volumes in R/W mode, which was failing for read-only volumes. TEST=Tested manually with read only volumes. BUG=None Review URL: https://codereview.chromium.org/1024553005 Cr-Commit-Position: refs/heads/master@{#321938}
-
jackhou authored
This is effectively a revert of https://codereview.chromium.org/50073003 This was originally added to cover a crash in GTK, which is no longer used. These days, other app window tests will also wait for the app window to finish loading. The hidden-window plus normal-window case has been added to platform_apps/window_api. BUG=469249 Review URL: https://codereview.chromium.org/1024373002 Cr-Commit-Position: refs/heads/master@{#321937}
-
mgiuca authored
Revert of Add ClientConfig proto, and JSON generation/parsing. (patchset #6 id:100001 of https://codereview.chromium.org/1017853003/) Reason for revert: Seems that some of the tests introduced in this CL are failing on builders: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/11450/steps/components_unittests/logs/stdio Value of: config_parser::TimeToISO8601(test.time) Actual: "2009-04-22T19:24:48.000Z" Expected: test.expected Which is: "1601-01-01T00:00:00.000Z" [ FAILED ] ClientConfigParserTest.TimeToISO8601 (0 ms) Value of: config_parser::TimestampToTime(ts) Actual: 1964-11-24 17:31:43.000 UTC Expected: test.expected_time Which is: 2038-01-19 03:14:07.999 UTC [ FAILED ] ClientConfigParserTest.TimestampToTime (0 ms) No idea why they are failing there, or why they passed on the trybots. Original issue's description: > Add ClientConfig proto, and JSON generation/parsing. > > - Add the ClientConfig proto definition corresponding to the response > coming from the service. > - Create a means of generating a pseudo response from the built in > params and request options. > - Create a class to parse the JSON response. > - Add necessary helper classes for the ProxyScheme and time values > coming from the service. > > BUG=466753 > > Committed: https://crrev.com/97652ebe50c4be712aa976776bee9694cbce1178 > Cr-Commit-Position: refs/heads/master@{#321931} TBR=bengr@chromium.org,sclittle@chromium.org,jeremyim@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466753 Review URL: https://codereview.chromium.org/1020863009 Cr-Commit-Position: refs/heads/master@{#321936}
-
agoode authored
Review URL: https://codereview.chromium.org/1025863002 Cr-Commit-Position: refs/heads/master@{#321935}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b944946..201fd41 TBR=dglazkov@chromium.org,alph@chromium.org Review URL: https://codereview.chromium.org/1028343002 Cr-Commit-Position: refs/heads/master@{#321934}
-
hirono authored
PiexLoader is enabled only for official build. BUG=396702 TEST=None R=isherman@chromium.org Review URL: https://codereview.chromium.org/1026733003 Cr-Commit-Position: refs/heads/master@{#321933}
-
jdduke authored
In WebView, flings that target the root scrolling layer are ignored by the compositor. In this case, we failed to clean up the scroll state in InputHandlerProxy, leading it to believe that a scroll was still active after the fling had been ignored. Handle this case, resetting the scroll activity bit when a fling is ignored. BUG=469369 Review URL: https://codereview.chromium.org/1028533004 Cr-Commit-Position: refs/heads/master@{#321932}
-
jeremyim authored
- Add the ClientConfig proto definition corresponding to the response coming from the service. - Create a means of generating a pseudo response from the built in params and request options. - Create a class to parse the JSON response. - Add necessary helper classes for the ProxyScheme and time values coming from the service. BUG=466753 Review URL: https://codereview.chromium.org/1017853003 Cr-Commit-Position: refs/heads/master@{#321931}
-
noel authored
Degenerate TRC have runs of 0's / 1's from the left / right edge of the TRC curve (a curve we want to invert), but the inverse curve is not well-defined in those regions. Return 0 or 1 for the inverse in those regions. Also ensure the binary search parameters are bounded to a valid search range. BUG=458024 Review URL: https://codereview.chromium.org/1016213002 Cr-Commit-Position: refs/heads/master@{#321930}
-
shreeram.k authored
BUG=463671 Review URL: https://codereview.chromium.org/1029043002 Cr-Commit-Position: refs/heads/master@{#321929}
-
wittman authored
Provides a metrics provider that uploads statistical stack profiling state via UMA. This CL builds on top of the statistical profiler implementation in https://crrev.com/1016563004, which is under review. BUG=464929 Review URL: https://codereview.chromium.org/981143006 Cr-Commit-Position: refs/heads/master@{#321928}
-
jbudorick authored
BUG=431823 Review URL: https://codereview.chromium.org/1000793002 Cr-Commit-Position: refs/heads/master@{#321927}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b6342c4..b944946 TBR=dglazkov@chromium.org,alph@chromium.org Review URL: https://codereview.chromium.org/1026203002 Cr-Commit-Position: refs/heads/master@{#321926}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/7971def..374a4c3 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hcm@google.com Review URL: https://codereview.chromium.org/1033573002 Cr-Commit-Position: refs/heads/master@{#321925}
-
kcarattini authored
This is the first part of a multi-cl feature. I'll add the api functions in a followup cl to avoid having huge cls. BUG=438525 Review URL: https://codereview.chromium.org/1020473003 Cr-Commit-Position: refs/heads/master@{#321924}
-
boliu authored
This is a long lived command line switch that chromecast uses. Convert it to a RendererPreference instead. BUG=469343 Review URL: https://codereview.chromium.org/1025933002 Cr-Commit-Position: refs/heads/master@{#321923}
-
agoode authored
Review URL: https://codereview.chromium.org/1027643003 Cr-Commit-Position: refs/heads/master@{#321922}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/f5744a3..b6342c4 TBR=dglazkov@chromium.org,alph@chromium.org Review URL: https://codereview.chromium.org/1027243004 Cr-Commit-Position: refs/heads/master@{#321921}
-
horo authored
1/2 chromium: this cl 2/2 blink: https://codereview.chromium.org/1023293004/ Screen shot: https://code.google.com/p/chromium/issues/detail?id=466871#c9 BUG=466871 Review URL: https://codereview.chromium.org/1029553002 Cr-Commit-Position: refs/heads/master@{#321920}
-
eroman authored
BUG=None Review URL: https://codereview.chromium.org/1028873002 Cr-Commit-Position: refs/heads/master@{#321919}
-
sunnyps authored
EstimatedParentDrawTime was not being subtracted from MISSED BeginFrames as it is for all other BeginFrames. Review URL: https://codereview.chromium.org/1025373002 Cr-Commit-Position: refs/heads/master@{#321918}
-
Mark Mentovai authored
preference on Mac OS X. Metrics (UMA) never requires a restart for a toggle to take effect. For crash reporting, Breakpad required a restart, but Crashpad does not. A toggled preference takes effect immediately. Chrome on Mac OS X is now using the crash reporting client from Crashpad, not Breakpad. Since it is incorrect to state that a Chrome restart is required for a change in this preference to take effect, remove the text and the link that performs the restart. BUG=466964 R=estade@chromium.org Review URL: https://codereview.chromium.org/1032573002 Cr-Commit-Position: refs/heads/master@{#321917}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/92d04da..7971def CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hcm@google.com Review URL: https://codereview.chromium.org/1020853008 Cr-Commit-Position: refs/heads/master@{#321916}
-
dkrahn authored
BUG=None TEST=pretty_print.py / validate_format.py Review URL: https://codereview.chromium.org/1019893007 Cr-Commit-Position: refs/heads/master@{#321915}
-
pvalenzuela authored
This CL adds additional logging to the FakeServer verification methods of FakeServerVerifier. BUG=NONE Review URL: https://codereview.chromium.org/1008983002 Cr-Commit-Position: refs/heads/master@{#321914}
-
erg authored
This first patch allocates resource ids for the image structures in blink. It then temporarily renames current usage of all these symbols from IDR_* to IDR2_* so that we don't conflict on names once we land part 2. BUG=467176 Review URL: https://codereview.chromium.org/1030743002 Cr-Commit-Position: refs/heads/master@{#321913}
-
jamiewalch authored
This also moves the in-DOM equivalent under crd/ since it's no longer cross-application. BUG=b/19484255 Review URL: https://codereview.chromium.org/1023943004 Cr-Commit-Position: refs/heads/master@{#321912}
-
reillyg authored
To prevent an application from continuing to listen for TCP connections or incoming UDP packets when the user is not aware that it is still running this patch observes the state of its associated AppWindows and opens and closes ports as necessary. The socket itself is left open so that state is not lost. BUG=435404 Review URL: https://codereview.chromium.org/1022663003 Cr-Commit-Position: refs/heads/master@{#321911}
-
aelias authored
This entry didn't match because the parens were interpreted as regexp grouping instead of literal characters. I didn't notice the problem before given that K+ Adreno 3xx devices are also covered by the OpenGL ES 3.0 policy. This should actually expand the Ganesh whitelist to all pre-K Adreno 3xx devices as originally intended by r307526. BUG=467581,424970 Review URL: https://codereview.chromium.org/1025803003 Cr-Commit-Position: refs/heads/master@{#321910}
-