- 21 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b86a1770ee64..58a3210823a3 git log b86a1770ee64..58a3210823a3 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 crodbro@webrtc.org Add config to reduce weight on small samples in BitrateEstimator. 2019-11-21 jonaso@webrtc.org Add new GOOG_PING and GOOG_MESSAGE_INTEGRITY_32 2019-11-21 handellm@webrtc.org Revert "VideoFrame: Store a reference to an encoded frame" 2019-11-21 danilchap@webrtc.org Add RtpDepacketizerAv1::AssembleFrame function 2019-11-21 danilchap@webrtc.org Delete DEPRECATED_SingleThreadedTaskQueueForTesting 2019-11-21 yvesg@webrtc.org [UBSan] Add suppressions for vp8, opus, absl. 2019-11-21 sprang@webrtc.org Adds injectable trials from peerconnection down to transport controller. 2019-11-21 budnyjj@gmail.com Force alignment of generated JVM called functions. 2019-11-21 danilchap@webrtc.org Revert lock for logging to CriticalSection 2019-11-21 handellm@webrtc.org MediaStreamInterface: introduce encoded sinks. Created with: gclient setdep -r src/third_party/webrtc@58a3210823a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1013590,chromium:None,chromium:1013590 Change-Id: Iddcc86741f641aebf8798cc6a5b34e57e84a4697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928063Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717738}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2dad99092c8c..8053c972b431 git log 2dad99092c8c..8053c972b431 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 robertphillips@google.com Add onPrePrepare to GrFillRRectOp 2019-11-21 herb@google.com Simplify makeOps API 2019-11-21 mtklein@google.com one more stray Valgrind false positive 2019-11-21 halcanary@google.com [minor] mark scripts as executable 2019-11-21 halcanary@google.com Replace third_party/gif with new DEPS entry. 2019-11-21 mtklein@google.com expand float peepholes Created with: gclient setdep -r src/third_party/skia@8053c972b431 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: None Change-Id: I1bb7a160c9ecc94634dc25cafc5eb02d1e342354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928064Reviewed-by:
-
rajendrant authored
Also obsoletes the old services data use metric. Change-Id: I4bf6fb6a83c532f54f7b44a591f2b641540cd3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927491 Auto-Submit: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#717736}
-
Samuel Huang authored
Now that GRIT update_resource_ids is available, we can easily shuffle resource_ids GRD items. This CL moves 6 existing items to the /chrome WebUI section. Also update comments related to sections. Bug: 927131 Change-Id: Id4646f234f3f43093bb7c62ea9818db1f7c117a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925820 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#717735}
-
Jacob DeWitt authored
Change-Id: I787688b8ec3893572c6f5195c85bd0e4f46be9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929393 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#717734}
-
Michael Spang authored
We don't want direct dependencies on internals of the evdev component, so move features defined there to a common file. Using these files from //chrome/browser would break dependency checking through "gn check", except that checks for that tree are disabled (bug 949535). Bug: 1026406 Change-Id: I0fbf9d2c0f466b4d9dbdd903540fdc4972f397ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927209 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#717733}
-
Michael Spang authored
This test fails after 0ff1d4ac ("ozone: xkbcommon: Pre-compute masks when setting keymap") but was not running on any bots. Fix it by initializing the modifier masks in the test (thanks kpschoedel@ for debugging and finding this fix). Bug: 1026406 Change-Id: I0639e8537d48a7cfb846dea76284dea8f4ff7eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928249 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Łukasz Anforowicz authored
This reverts commit f0f00c0c. Reason for revert: Caused https://crbug.com/1027094 Original change's description: > |request_initiator_site_lock| enforcement - attempt #1. > > This CL starts treating |request_initiator| that doesn't match > |request_initiator_site_lock| as a bad IPC message and ignoring such > malformed resource requests. > > NetworkService.URLLoader.RequestInitiatorOriginLockCompatibility UMA is > non-zero in recent Canary releases. We expect that this CL will get > reverted after gathering sufficient number of DumpWithoutCrashing > reports to understand why the lock doesn't match the initiator in some > real world scenarios. > > Bug: 920634 > Change-Id: I509ebade1d64e5c5243150df8c3f5184273cf8ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661114 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717031} TBR=toyoshim@chromium.org,yhirano@chromium.org,hiroshige@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 920634, 1027094 Change-Id: I3ea5d8f2f770a3e329de6b1902c2e24bbea1745a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928560 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#717731}
-
Demetrios Papadopoulos authored
Bug: 807458 Change-Id: I22eafec23c447becaba75d19c4e710861c050bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928238 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#717730}
-
Navid Zolghadr authored
Comment out a DCHECK in prediction metric calculator as it seems to be failing in some tests. Further investigation is needed for this. Bug: 1017661 Change-Id: I6802b37297052c195be4d508da9575a0a045ae11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928323Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#717729}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/409b261f38af..95c6fd36ead5 $ git log 409b261f3..95c6fd36e --date=short --no-merges --format='%ad %ae %s' 2019-11-20 bnc Internal QUICHE change 2019-11-19 renjietang Remove QuicPacketCreator::AddSavedFrame() and make QuicPacketCreator::AddFrame() public. 2019-11-19 ianswett Remove unused set_endianness from QuicDataReader. 2019-11-19 quiche-dev Move quic::QuicEndian to quiche::QuicheEndian 2019-11-19 quiche-dev gfe-relnote: Update QuicConnection's SendMessage to allow specifying if the message being sent is retransmittable. 2019-11-18 bnc Fix use-after-free in QpackProgressiveDecoder and QpackInstructionDecoder. 2019-11-18 rch Add more QUIC_SLOW_TEST annotations to bbr2_simulator_test.cc since they're causing timeouts in Chrome bots. 2019-11-18 renjietang Add comments for some disabled simple_session_notifier_test. 2019-11-18 fayang gfe-relnote: In QUIC sent packet manager, replace handshake_confirmed_ and forward_secure_packet_acked_ with handshake_state_. No functional change expected. Not protected. 2019-11-18 dschinazi Remove use of illegal ":version" HTTP pseudo-header in tests 2019-11-15 renjietang gfe-relnote: Combine quic_no_stream_data_after_reset and quic_no_decrease_in_final_offset into a single flag gfe2_reloadable_flag_quic_close_connection_and_discard_data_on_wrong_offset to impose flag dependency. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I1cbffb5b1eb70a947af5d015baafd9c83e0a7b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925752Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#717728}
-
Armando Miraglia authored
According to http://crbug.com/1025874#c4, these metrics are still required for further issues debugging. Hence, I am extending the life time by 6 months. Fixed: 1025874 Change-Id: I6b388c6e310af1cd3297b4a4b01b41f11e3352f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926476Reviewed-by:
-
Jamie Madill authored
Uses a more general suppression for many Vulkan WebGL tests that seem to be flaky or failing: [ win nvidia vulkan passthrough ] conformance/ogles/GL/* [ Failure ] Bug: 1017162 Tbr: kbr@chromium.org Change-Id: I69eecdbdd911474b7f94b1a474ea39354fa72c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924916Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#717726}
-
Reilly Grant authored
They are not yet a Chromium committer so they can't Code-Review+1 reviews. Until then they shouldn't be in an OWNERS file. Change-Id: I3689ec2d4b64eecfb4f761a333ad565363fefed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928565 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#717725}
-
Lily Chen authored
This reverts commit faa17358. Reason for revert: We decided not to move forward with this feature. Original change's description: > Add draft UI strings for Legacy Cookie Access content settings > > This CL contains drafts of the UI strings to be used for Legacy Cookie > Access content settings in chrome://settings/content. > > The rest of the UI will be built later; this is just to get the strings > in before string freeze for M80. > > Bug: 1025007 > Change-Id: I9d03c2863dafab2f26796865321d83208f290ea4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918340 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Lily Chen <chlily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715586} TBR=dpapad@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1025007 Change-Id: I366c07b7ec1e26952fe39a3fe9bed28c8d39c1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929255Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#717724}
-
Demetrios Papadopoulos authored
Bug: 1022215 Change-Id: I288b359fba39100b732204d213e567fc8d221851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925369 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#717723}
-
Ted Choc authored
The metric isn't used frequently, but when needed it can help see trends in incoming traffic metrics. BUG=975882 Change-Id: Ic3e1e2a3b3ad273a4d8d128f82068142f7315950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713231Reviewed-by:
-
Vladimir Levin authored
This patch renames the signal to rendersubtreeactivation, to stop erroneously implying that it always happens before activation. on-render-subtree-activation can fire before and after the activation, depending on the way an element is activated. R=chrishtr@chromium.org, rakina@chromium.org Bug: https://github.com/WICG/display-locking/issues/98 Change-Id: Id3ba4e5ac93eb9b551c2419fb2e5d8c762d2f761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927023 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#717721}
-
Andrew Luo authored
Bug: 1021665 Change-Id: Ic2b72062f36eb219d10ae67f5c96c650fbd95c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918342Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#717720}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1023677 Change-Id: I2ccb853be1685d5e52e20a1cc855f4abf5347345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925738 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#717719}
-
Robert Ogden authored
Otherwise it is impossible to roll out using the server-side experimentations that are currently at play. Bug: 1021749 Change-Id: Ic6bf7e48c1aba52c16ef9ed1a048af963ea187a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922600Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#717718}
-
Dominique Fauteux-Chapleau authored
Remove the old std::string signature so future code uses the DMToken function instead. Also rename RetrieveBrowserDMToken to RetrieveDMToken to keep function name consistent with the rest of BrowserDMTokenStorage. Bug: 1020296 Change-Id: Ie3eb3cc44d9c0ca9503971a843bd9ff10ec6dfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924547Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#717717}
-
Sadrul Habib Chowdhury authored
The only override of OutputSurfaceClient::DidFinishLatencyInfo() in Display is a no-op (since crrev.com/567297). So remove this. BUG=none Change-Id: I53031545844ace0552ca88b30b78bc4d9d12ecb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928561 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#717716}
-
Jasper Chapman-Black authored
Change-Id: Ia8f2b58fe4ff351aff62e2ad5db953f369da66eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928569 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
-
Danyao Wang authored
The functionality behind this flag is replaced by the new StrictHasEnrolledAutofillInstrument feature. Bug: 1025228 Change-Id: I6d179e32fca657147401b8173f49d931e9abf703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924779 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#717714}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1023677 Change-Id: Ie508e6499be964b52ee1567967f4fc7a5ca4a1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926809 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Jonathan Ross authored
On Pixel 2 this test has begun consistently failing. Suppressing it while the root cause is analyzed. TBR=ynovikov@chromium.org TEST= webgl2_conformance_tests deqp/functional/gles3/negativetextureapi.html Bug: 1027125 Change-Id: Ie727ed406c10b42cfab5fb8f999068de32c19810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928145Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=kbabbitt@microsoft.com Bug: 1023677 Change-Id: I432d207b93c1146c24c36d08062b1ffa033caad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926803 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#717711}
-
Ayu Ishii authored
This change allows developers to use the SMS Receiver API with the Abort Controller to cancel once the API is called. This will help developers with flows for retrying and sending a new code and they want to abort the previous call they made to the API. If the InfoBar is up during abort, it will leave the InfoBar open while returning an AbortError to the website. If another request is made while the InfoBar for 1st request is still open (after abort), upon clicking 'Verify' the SMS retrieved for the 1st request will return to the 2nd request. Bug: 976401 Change-Id: I132800f2954fdc370172dcd03789d3f08bcc4040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866914Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#717710}
-
Peter Wen authored
The android_clang_arm subdirectory is used during the build for 64-bit builds. These generated resources need a similar alias to be accessible in chrome pages like chrome://offline-internals. This is a temporary fix to add the missing alias. A long-term fix should resolve @out_dir@ to include android_clang_arm or something similar. Bug: 1020284 Change-Id: Ibf5f422dc38d77ea984ad576f9e36ddf5fe868d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928556 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#717709}
-
Elly Fong-Jones authored
This change makes cbui (actually all of //chrome) unaware of DCV. Most of these changes are straightforward but there are a few wrinkles: * IntentPickerBubbleView does an explicit Layout immediately after its widget is created, which should be needless; * PasswordPendingView does an explicit Layout when changing its content, which should be needless because it calls DialogModelChanged immediately beforehand; * EnterpriseStartupDialogView sets button text directly rather than using set_button_label() but does not notify the dialog model about this, which probably causes visual glitches; * UserManagerView was reaching inside DialogClientView to unregister its default Esc key accelerator (!). As of this change, instead UserManagerView registers the same accelerator and discards it first; All of these now have TODOs to clean them up in subsequent CLs, since each of them might cause regressions when I fix them. Bug: 1011446 Change-Id: If5256329af1f9f649ec0e010dbe573479199e5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924960 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#717708}
-
Dominic Farolino authored
Now that BrowserAccessibilityManager implements WebContentsObserver (crrev.com/c/1672135), DidStopLoading is automatically called as a result of `navigator()->GetDelegate()->DidStopLoading();`. Bug: 981271 Change-Id: I081f0d9a2c54c9a99742c2aa4eb680c11c1b3bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924719Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#717707}
-
Devlin Cronin authored
Remove, expire, and obsolete-ify Extensions.LoadAllTime, since it is replaced by Extensions.LoadAllTime2. Mark Extensions.LoadAllTime2 as never expiring, since it is monitoring core extensions system performance. Bug: 1025837 Change-Id: Iedf225716607b2f827027ca501b2c327b609c48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927217Reviewed-by:
-
Sharon Yang authored
Remove the use of a do while loop in AccessibilityBridgeTests so tests don't have the opportunity to run indefinitely. Also remove special handling of the case where this is no root node as this is now supported by the Semantics Manager. Testing: CQ Bug: 973095 Change-Id: I014506bf77fa11b7f33e115b601b9bfaa781b8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924714Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#717705}
-
Francois Doray authored
BatteryMetrics did not connect to a remote BatteryMonitor due to a shutdown crash (https://crbug.com/794105). This shutdown issue was fixed by using SequenceLocalStorageSlot to tear down the BatteryStatusService on thread thread termination (https://crrev.com/665919). This CL can therefore safely change the code to connect to a remote BatteryMonitor on Windows. The immediate impact is that Power.BatteryPercentDrop will be properly recorded on Windows. In upcoming CLs, we plan to record more battery metrics on all platforms. Bug: 794105, 1026678 Change-Id: Iebd3f32beda2ae487c5b23263ec95e350390b237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925130Reviewed-by:
-
Ionel Popescu authored
When the date/time doesn't have "date-time-edit" in its shadow subtree, the is_ampm_first, has_ampm, has_second, has_millisecond fields are going to be uninitialized. This CL ensures that the fields are always initialized. Bug: 1026906 Change-Id: Ibfa8dd9993cf291402407e3592de82387c3d68b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927574Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#717703}
-
Jasper Chapman-Black authored
This is the first step in adding canned queries to Caspian. Refactored TreeBuilder to replace group_by_component with a more arbitrary Symbol -> parent path transformation. Leaving generated file classification to a future CL. Change-Id: Ia142df715ba911d9629ad89aa5fa0d714394410a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924604Reviewed-by:
-
Ovidio Henriquez authored
This change converts all of the base::Bind and base::Callback to their Once counterparts for bluetooth_socket_mac.{h,mm}. This change also affects any files that interact with this class. Bug: 1007780 Change-Id: If3c6b2e24ecd3cac18a9a726fa7b5e78d00b05e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904529Reviewed-by:Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#717701}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6c7a793d. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I60d98d0fc65e51f4ffa1800fa205f9feb62041c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929152Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717700}
-
Archana Malhotra authored
Bug: 1026675 Change-Id: Ic72d4c618e6287429ec01978d2d2d0e414f73f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925184Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Archana Malhotra <armalhotra@google.com> Cr-Commit-Position: refs/heads/master@{#717699}
-
