- 12 May, 2018 40 commits
-
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I4b682f120ac9aef13f63a1cb172e27fa676a4c34 Reviewed-on: https://chromium-review.googlesource.com/1056061Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558141}
-
Daniele Castagna authored
AddFramebuffer2 can fail for buffers coming via exo. We should not use an invalid fb when pageflipping in those cases otherwise the GPU process will crash. Bug: 779356 Test: wayland_simple_client with crrev.com/c/1056018 Change-Id: I179ce2ddbe1fb5080f9d00989ccf96ddf3f94d68 Reviewed-on: https://chromium-review.googlesource.com/1056017Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#558140}
-
Nicolas Pena authored
This CL does the following: * Use TimeTicks instead of double in WebURLLoaderClient::DidFinishLoading and propagate. * Remove unused double from ThreadableLoaderClient::DidFinishLoading and from WebAssociatedURLLoaderClient::DidFinishLoading. Change-Id: If1eed191efe6c39d376f6d7c1a636bc9dcb79251 Reviewed-on: https://chromium-review.googlesource.com/1048137Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#558139}
-
Alexey Kozyatinskiy authored
With V8 side CL [1] we will start using proper break location instead of stack check location almost all the time, e.g. for async step-into and for a lot of DOM breakpoints. [1] https://chromium-review.googlesource.com/c/v8/v8/+/1054155 R=dgozman@chromium.org Bug: v8:7753 Change-Id: I550d4d43494df7abe8c5fcd0fbb1d08ca88364f6 Reviewed-on: https://chromium-review.googlesource.com/1055791Reviewed-by:
-
Lei Zhang authored
Currently, it only synthesizes a key char event, which is insufficient for the PDF plugin to produce the proper response. With the additional key up event, the PDF plugin will react correctly to keep the selected text state synchronized between the plugin and the renderer. BUG=841196 Change-Id: I331562d2f39facc9affdeac98d85306c09d56130 Reviewed-on: https://chromium-review.googlesource.com/1053164Reviewed-by:
-
Alexandros Frantzis authored
Add a parameter for an unowned GpuFence to the NativePixmap::ScheduleOverlayPlane() method. The parameter is unused at the moment, but will be used in upcoming commits to wire the overlay plane GpuFences in Ozone-DRM. Bug: 828393 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4697764c88a307b307af0ca5c1305e2d83cceec4 Reviewed-on: https://chromium-review.googlesource.com/1021737 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558136}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cfd0d899. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17392 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I0da577389513a1182cb6ec57555845e300c60d94 Reviewed-on: https://chromium-review.googlesource.com/1056016 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#558135}
-
Erik Luo authored
This CL dismantles the side effect constructor blacklist, so Blink constructors (default, named, custom) all throw when evaluating with throwOnSideEffect. [Affects=Everything] is no longer a valid extended attribute. Constructors can still be invoked without side effects in one case: creating a DOM wrapper for the V8 object. Any whitelisted attribute/operation that returns an HTMLDivElement, for example, can call the constructor with ConstructorMode::kWrapExistingObject the first time it returns. Bug: 829571 Change-Id: I3ed2166da80d38a7835dc57a1ccaec23e22734e9 Reviewed-on: https://chromium-review.googlesource.com/1043655Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Stefan Zager authored
The viewport intersection shouldn't be updated for a force layout or other non-BeginMainFrame lifecycle update. BUG=842368 R=kenrb@chromium.org Change-Id: Ifd656b495e60e8b1413df8126c7b6ff95933abaf Reviewed-on: https://chromium-review.googlesource.com/1056491Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#558133}
-
Reid Kleckner authored
This reverts commit 646faed8. Reason for revert: These tests fail in official build configurations: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/84233 Original change's description: > Check that Channel ID is in use before providing Channel IDs to extensions > > Change-Id: Iabe9977651ec3e38f43d2495e790af508a43e0e5 > Reviewed-on: https://chromium-review.googlesource.com/1055676 > Commit-Queue: Nick Harper <nharper@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558096} TBR=rdevlin.cronin@chromium.org,nharper@chromium.org Change-Id: I4f0f2b194a709dd8b1a6cd690de60e24dacb7653 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1056567Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#558132}
-
erikchen authored
Change-Id: Icbfecced7e68f62c7f9eca0623ddf35a9a241c24 Reviewed-on: https://chromium-review.googlesource.com/1053960Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558131}
-
Antonio Gomes authored
Manual test: <out>/chrome --extensions-install-verification="enforce_strict" TEST=covered by existing tests. BUG=773295 Change-Id: I116d5c826935c6b5c6c9d062cf55422b7b1915f6 Reviewed-on: https://chromium-review.googlesource.com/1052867 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558130}
-
spqchan authored
Bug: 838303 Change-Id: Iba9ae89b36f711aec3e00b61fafd4c2e2672cc0d Reviewed-on: https://chromium-review.googlesource.com/1056403 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#558129}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/50c42dd35113..193c9144b170 $ git log 50c42dd35..193c9144b --date=short --no-merges --format='%ad %ae %s' 2018-05-09 jwerner fwgdb: Remove unified_depthcharge, make reboot flow more permissive Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8ddedcaf94e27807e0e58e87bfba9770679883ea Reviewed-on: https://chromium-review.googlesource.com/1056477Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558128}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1d2e7600b0b4..b424d15a6070 $ git log 1d2e7600b..b424d15a6 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 sammiequon Disable cache_temperature tests on chromeos. 2018-05-11 sullivan Update bug assigns to autorollers to assign to sheriff. 2018-05-11 simonhatch Dashboard - Remove some old logging from graph_data. 2018-05-11 dtu [pinpoint] Don't CC reviewers on bug comments. 2018-05-10 simonhatch Dashboard - Add some logging around /add_histograms. 2018-05-11 simonhatch Pinpoint - Update results2 generator for job format. Created with: roll-dep src/third_party/catapult BUG=chromium:830667,chromium:842248 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I6cfe1c7f4f7b7be60b505b4cae00b27cef8a66fc Reviewed-on: https://chromium-review.googlesource.com/1056471Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558127}
-
https://pdfium.googlesource.com/pdfium.git/+log/47a4f418a86b..82cb80962bc6 $ git log 47a4f418a..82cb80962 --date=short --no-merges --format='%ad %ae %s' 2018-05-12 hnakashima Prepare image comparison in safetynet_compare.py to work in nightly run. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I68419bab49c625e7fc1f68b0465aae961052d91b Reviewed-on: https://chromium-review.googlesource.com/1056493Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558126}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/348b95b14ab7..50c42dd35113 $ git log 348b95b14..50c42dd35 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 khmel arc: Fix ACL for archive with SDK tools 2018-05-09 yunlian enable thinlto on elm and veryon_jaq release builders. Created with: roll-dep src/third_party/chromite BUG=chromium:827217 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id75b97be2c132d6fcdfa128b050efc5d1d55fc35 Reviewed-on: https://chromium-review.googlesource.com/1056474Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3202ac4d24de..96b0b46f2334 $ git log 3202ac4d2..96b0b46f2 --date=short --no-merges --format='%ad %ae %s' 2018-05-12 angle-skia-autoroll Roll third_party/externals/angle2/ a69099212..18e323ab2 (3 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I6cf28500f14c483bdf28699ac6d50f1dae0c5181 Reviewed-on: https://chromium-review.googlesource.com/1056473Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558124}
-
Noel Gordon authored
Code is using std::move, defined in <utility>. Maybe clang-tidy has a feature for this, but anyho. Tbr: slangley Bug: 841659 Change-Id: I01d81203a77e96bc0115980eda43a442944abb31 Reviewed-on: https://chromium-review.googlesource.com/1056508Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558123}
-
Alexei Filippov authored
Profiler functions used to lock the mutex first and then update the entered_ TLS variable. That caused the following sequence leading to a deadlock: 1. In DoRecordAlloc it locks the mutex and then calls entered_.Set(true) 2. If this happens to be the very first access to TLS, it causes internal TLS vector to be allocated. 3. It then reenters DoRecordAlloc, the entered_.Get() is still false since #1 is not yet finished. 4. Thus it proceed to locking the mutex again. The fix is basically swapping the order of mutex locking and entered_.Set(true). BUG=842396 Change-Id: I926c05755321c082215ca84bfc312348c89ecdca Reviewed-on: https://chromium-review.googlesource.com/1056412 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=sammiequon@google.com Change-Id: Ie84183c812ac70c3f3c64de3340c11d37c25e04a Reviewed-on: https://chromium-review.googlesource.com/1056116 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#558121}
-
Jose Dapena Paz authored
AXNode accessors to AXNodeData have been added and declared constexpr. But the methods in AXNodeData are not constexpr (and they cannot be such). GCC complains about that. So remove the constexpr declarations accordingly. Change-Id: Ifaaaa44921e85076031f0d73a9260e074efbef07 Reviewed-on: https://chromium-review.googlesource.com/1053778 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#558120}
-
Chris Nardi authored
In https://drafts.csswg.org/css-values-4/#resolution, 'x' is defined as a synonym for dppx. Add support for parsing 'x' as dots per px. Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/FsD97U77tss Bug: 630597, 807653 Change-Id: I70c440c89e42cd005a9c58fd89745a5603e0dee6 Reviewed-on: https://chromium-review.googlesource.com/892467 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#558119}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ie205999387e07ec7632a0c3a0f1bb6f31ebc9095 Reviewed-on: https://chromium-review.googlesource.com/1056492 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558118}
-
https://pdfium.googlesource.com/pdfium.git/+log/626a093f5fde..47a4f418a86b $ git log 626a093f5..47a4f418a --date=short --no-merges --format='%ad %ae %s' 2018-05-12 hnakashima Remove unused CFWL_FormProxy. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I31a2625cc0b33758c1d51b5cfa2e2633dd830cb3 Reviewed-on: https://chromium-review.googlesource.com/1056470Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Tbr: fukino Bug: 836254 Change-Id: Ife1c1ccc84b3d25f469da93d69bd334145b8f4b8 Reviewed-on: https://chromium-review.googlesource.com/1055370 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Tbr: fukino Bug: 836254 Change-Id: I7b6553cf460ee330e50b8dc8a4fa666369affeab Reviewed-on: https://chromium-review.googlesource.com/1055036Reviewed-by:
-
sczs authored
- Deletes BookmarkContextBar files and usage from BookmarkHomeVC. - Uses BookmarkHomeVC navigationController UIToolbar instead. - Creates accessibilityIdentifiers for toolbar buttons. - Changes the BookmarkTableCell margins since these were giving the effect of shrinking row height. Screenshots Old: https://drive.google.com/open?id=1v3GQRiiPiIzJNZ7Lxd-pgpaaqP15b0PR New: https://drive.google.com/open?id=1z5mOT3p1NBj62EaMKfR2P5WSD2irQmyX Bug: 839435 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I155365b6f9520010153ce97187ef1f6a2a8514f7 Reviewed-on: https://chromium-review.googlesource.com/1054123 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#558114}
-
David Jacobo authored
Automatically close tabs after the user is authenticated and redirected to an ARC app. ArcWebContentsData can be removed via ArcExternalProtocolDialog as well as in AppsNavigationThrottle, with this we try to reduce the scope of the flag as much as possible while still allowing the user to bypass the UI and automatically close tabs left behind in the process. Bug: 838294 Test: Build, unit_tests still works Change-Id: Ifb812a3fab2fe7f49f07b4fbaee754ac96ea158f Reviewed-on: https://chromium-review.googlesource.com/1026870 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#558113}
-
Han Leon authored
Some code pathes aquire a service worker object info but do not send it immediately, the service worker object info holds a SWObjectAssociatedRequest whose corresponding SWObjectAssociatedPtr is held by a SWHandle, but during the period the SWHandle may call StateChanged() on this SWObjectAssociatedPtr, because the SWObjectAssociatedRequest has not been sent over Mojo yet, this will lead to a crash. This CL fixes such scenarios by enabling those code pathes to create/handle the (SWObjectAssociatedPtrInfo,SWObjectAssociatedRequest) pair on their own terms whenever they need to send the object info over Mojo, they will send SWObjectAssociatedRequest over Mojo first and then pass SWObjectAssociatedPtrInfo back to SWHandle to make calls safely there. Details: SWHandle::CreateIncompleteObjectInfo() does not bind the SWObjectAssociatedPtr and just returns an object info without a valid SWObjectAssociatedRequest. Callers will create (SWObjectAssociatedPtrInfo,SWObjectAssociatedRequest) by themselves later at any time when they want to send the object info over Mojo, after the SWObjectAssociatedRequest was sent they can call SWHandle::AddRemoteObjectPtr() to pass the SWObjectAssociatedPtrInfo back to SWHandle. BUG=838397 Change-Id: If2ed45cef1fe2a25bb9760a66a1ecc4c432ad8d3 Reviewed-on: https://chromium-review.googlesource.com/1036498 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558112}
-
https://chromium.googlesource.com/angle/angle.git/+log/422f2ce24c5b..18e323ab2cff $ git log 422f2ce24..18e323ab2 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 jmadill D3D11: Fix out-of-range access with robust access. Created with: roll-dep src/third_party/angle BUG=chromium:842028 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Id5f71c374ee3cd238fc2b2965cc3751184b33279 Reviewed-on: https://chromium-review.googlesource.com/1056489Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558111}
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Re-land. Was reverted on crrev.com/558004. Actual problem was an ASAN flake [1] and every subsequent run of this test was green on the ASAN bots before the revert landed (see image crbug.com/836254#c43). [1] ASAN flake crbug.com/837950 Tbr: slangley, fukino Bug: 836254 Change-Id: I1f1e60ad80130c5f2d7d92131fe21257f4ffa001 Reviewed-on: https://chromium-review.googlesource.com/1056507Reviewed-by:
-
Johannes Henkel authored
This change will make it easier to finish https://chromium-review.googlesource.com/c/chromium/src/+/1035091: - The "other" blocked reason, that is, an unspecified blocked reason, is now the default which we'll assume for the 0 value. - There's a 1:1 correspondence with the enum in browser_protocol.pdl, so we no longer need to conflate kNone and kOther. - The base::nullopt value for base::Optional<...> is more appropriate because in the inspector's protocol it will correspond to the absence of a string value (e.g. in a JSON message), as opposed to the string "none" or "other" (both misleading). Would like to land this first since it's easier to review / test it this way, as opposed to mixing it into a larger PR. Bug: 838291 Change-Id: I66da523495b38a297d22289ae7c32367a66bd6bb Reviewed-on: https://chromium-review.googlesource.com/1056030 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
David Tseng authored
When lines in the midst of editing operations are invalid, output the current line rather than attempting to make intra line diffs. type 'abc' within a textarea. Press enter. Verify we do not trigger intra line state machine changes and output 'abc deleted'. Rather, ensure we trigger output of the entire new line 'new line'. Test: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5b1252687e1463ca29f237bc4c86a87f0f5bb781 Reviewed-on: https://chromium-review.googlesource.com/1054698 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
dpapad authored
The negative margin was used because the buttons did not have a border or background, and wanted to align the end of the button's text with the other items on adjacent lines. Bug: 832173 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7d1368c839e5732dd88cbc3bb453846ecb289509 Reviewed-on: https://chromium-review.googlesource.com/1055817 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558107}
-
David Jacobo authored
ArcWebContentsData is used to mark tabs that were generated via ChromeShellDelegate by ARC request. This flag was introduced so we could offer a smoother authentication process, more specifically so the user doesn't have to deal with the intent picker UI nor leave tabs opened in the browser in the process. However since this flag allows the user to exit Chrome's context we need to remove the flag when no longer needed, in case the tab itself survives the authentication process. (e.g. maybe the user didn't complete the login process, or reused this tab to start a new query via the omnibox) In this CL we propose a way to get rid of such flag as soon as the user: - crosses the same origin boundary (this boils down to changing either the domain, port or scheme). - press the forward/back button. - types a url directly in the omnibox. TBR=sky@chromium.org Bug: 838288 Test: Build Change-Id: I7ba30d7874d5384d8ce4e3a9317d827198c23acd Reviewed-on: https://chromium-review.googlesource.com/1034027 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#558106}
-
Lei Zhang authored
Change-Id: Id883d962d14233db330a28d972c500fc8a502c06 Reviewed-on: https://chromium-review.googlesource.com/1056317Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#558105}
-
Jeremy Roman authored
Bug: 841751 Change-Id: I965b442ef21d0f199574d8d4ff04fc03af7158b9 Reviewed-on: https://chromium-review.googlesource.com/1054248Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558104}
-
xlai authored
Over code changes, the comment has been shifted to wrong places. Bug: 651456 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5b9cbe92d55a68bdd9547a000398d53fc58c3958 Reviewed-on: https://chromium-review.googlesource.com/1055892Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#558103}
-
Xiaohan Wang authored
Change-Id: Idda24d4e408e257fe1da332e7869b0b708f80a7f Reviewed-on: https://chromium-review.googlesource.com/1056209 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
