GitLab

We can just use org.chromium.base.onResourcesLoaded to get the same
behavior.

Bug: 1105096
Change-Id: I7303f1ba1e6ea741f0b42bb0aa56a4afb0ee663a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393005
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804415}

@CallSuper was added to FragmentActivity.onRequestPermissionsResult in
r.android.com/1233518, which is present in the AndroidX fragment library
v1.2. This change will prevent a compilation error when upgrading to
that version of the library.

Bug: 1123216
Change-Id: Icef9c868cc5cf2de38b6c40cacdc91f48e1edfbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386277
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804414}

TBR=govind@chromium.org

Change-Id: I9bd3478a68b1dfe7794bd96390e6dc45ad5fe7c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390805Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804413}

This CL adds a lookalike navigation browser test for signed exchanges.
The current lookalikes code blocks signed exchanges in both of the
following cases:
- The target URL of the SGX package is a lookalike
- The URL that serves the SGX is a lookalike

For the first case, the test navigates to a signed exchange URL that
serves a SGX for google-com.example.org and checks that the URL is
blocked by the target embedding heuristic. The second case serves the
SGX from google-com.example.org and checks that it's blocked.

There is an argument to be made for the latter case to not be blocked
since the URL that serves the SGX is never seen by the user during
normal browsing such as clicking links. However, there is still a chance
that such a URL is shared from outside Chrome (e.g. coming in an email).
We still want to block those cases.

Additionally, detecting that a navigation will end up as a SGX isn't
trivial as the SGX package needs to be fully validated before its
contents can be displayed. It might be too late to block the original
navigation by the time the SGX is validated. This needs to be confirmed
and might be changed in follow up CLs.

Bug: 1110151
Change-Id: I2b2e4841eb142b3f2d1c1cedf82138f578e770a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386429
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804412}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6d46b6f1..53c397b6

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I52af013cac907fd8b32d8721eaea4ea58e7efaeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392579Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804411}

This makes it easier to audit dependencies.

Change-Id: I1ea9db294f947f261b050dc61399ff93ef89dc69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391655
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804410}

Since the Bluetooth serial interface is designed to work
on Mac OS only as of now, change the Bluetooth SPP flag so
it can only be enabled on Mac OS.

Bug: 1043300
Change-Id: I35531d8388eefe1228ee970d1e6f8e56ac8a1a7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391922Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Vicky Min <vickymin@google.com>
Cr-Commit-Position: refs/heads/master@{#804409}

Most method calls are translated 1:1 by forwarding the call to the equivalent
MenuButton or View method. A notable exception is handling of the tab switcher
animation, which currently requires a view in order to perform canvas
translation before drawing the button in its animated state. In this case,
we provide a direct accessor for the view.

Reland note: the NPE was due to the MenuButtonCoordinator not being set until
right after inflation finishes, which is when ToolbarTablet was trying to use
it.

Bug: 1086676
Change-Id: I60819a54bc4ad6d84fcb5b932d04798ba6561bce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391643Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804408}

Bug: 1124366
Change-Id: I79ba5caecabbdd825283d21f37b029bdc55d734f
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390898
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#804407}

This reverts commit 72c29544.

Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2388561

Reason for revert:
This was landed after we reverted its dependent CL, causing assert
failure:
https://luci-logdog.appspot.com/logs/chromium/android/swarming/logcats/4e6e16a4bd138411/+/logcat_logcat_6189963507448870930_20200903T185337-UTC_0cbc662c032fd958

Bug: 1107039
No-Try: true
Change-Id: I8485665142c4ea446406cd9261756b1dd51f49de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393061Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804406}

Updates implementation to drop messages sent to/from a portal that is
cross origin with its host, and updates WPTs to reflect this change.

Bug: 1108793
Change-Id: Ie0056c7a01a4d65cccdbfb0a0044b3d6afc87497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382064
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804405}

Previously the font will be enlarged on big screen. Fix it by adding
media queries on css.

Bug: 1117417
Change-Id: I6003b48fcfab3f9547b8f16527278afb9f3dc377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391173Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804404}

Doc:
https://docs.google.com/document/d/14P-oS-WRgEO0ooGXyMOgM9eGygLlDMJ2NQPcwFYFf7U

This reverts commit d4c213d3.

Change-Id: I34b02dc82c396e9ae022402d446da2f7454339a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378267Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804403}

BUG=1122499, 1106937

Change-Id: I543caf8ae059cf7140cb7f88c90c8847c6c1a59c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379550
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804402}

Changed the value of None in |VirtualKeyboardVisibilityRequest| to be
more consistent with the naming in ui/base/ime/mojom files.
This was a CL feedback (crrev.com/c/2386461).

Bug: 856269
Change-Id: If78c97b002506d731a8b5367a44133fee6b9b46c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392919Reviewed-by: Anupam Snigdha <snianu@microsoft.com>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#804401}

This change removes nearly all instances of CanResize, replacing them
with uses of SetCanResize(). The single remaining instance is in
NativeAppWindowViews, which will deserve its own CL to clean up.

This change also removes WebDialogDelegate::CanResizeDialog(), replacing
it with a member variable on WebDialogDelegate.

Bug: 1075649
Change-Id: Iecdd17273c0a809e430b105c22dc98c5eed96326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380132Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804400}

This change:
1. Increases the text size and line height for tutorial content.
2. Styles the practice area.
3. Practice area UX enhancements (scroll items into view and
prevent clicked links from exiting the tutorial).

Bug: 1124065
Change-Id: I11aeeb75f3c4559fbb0c92aecd5d6b3a6191b0e8
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391592
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Auto-Submit: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804399}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9c616f80fb6..7592f9326fc9

2020-09-03 ddoman@chromium.org [resultdb] move cipd pin of infra/tools/rdb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1124498
Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com
Change-Id: I6dd323815cf415927d636a333ad2df0ea36c1bb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392731Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804398}

This records RTC event logs for the duration of each session. This data
is kept in a memory buffer, and limited in size to avoid the buffer
growing indefinitely.

Followup CLs will add the ability to send the recorded log to the
client.

Bug: 1122798
Change-Id: If32a1ea65d93a53ee5cf6e74cd7dbea151fb1214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380961
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804397}

Since webview_power_usage.sql now calculates power usage distribution by
core type, this change updates the corresponding tbmv3 metric
to output these values.

Bug: b/159154263
Change-Id: I1e1d3cbfe5843bdb61191d2356f40ef019532931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378810Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804396}

Updates the requirements for changing the layout axis to display on
a vertical axis when the user turns on "Larger Accessibility Sizes".

Bug: 1110243
Change-Id: Ib4eb3c915298a8cae3606e41c0ea63a2ff1ae062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390913Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804395}

https://chromium.googlesource.com/angle/angle.git/+log/999c85ee8215..b6b9cffaf3bc

2020-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 3b3f93c206dc to 5e85f689b911 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cwallez@google.com
Change-Id: Id5d1caf70b3edcac1e94f4ad1f190a48a7b6d72d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392729Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804394}

Roll Chrome Mac PGO profile from chrome-mac-master-1599112620-f359a51daebae2f754df062494b1fdebe13ff3bd.profdata to chrome-mac-master-1599155892-629b4d0dfe6acef6eef58d4607669a58bfb33fb6.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I85b0d9d806d533f9cc2a704d9995b14011ef0051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393037Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804393}

https://skia.googlesource.com/skia.git/+log/f8823b572600..00b2fdbc3c6f

2020-09-03 herb@google.com move blur and path attributes to key
2020-09-03 robertphillips@google.com Revert "Create cpu-side blurred RRect mask when recording DDLs"
2020-09-03 robertphillips@google.com Create cpu-side blurred RRect mask when recording DDLs
2020-09-03 johnstiles@google.com Add is<T> to IRNode types.
2020-09-03 johnstiles@google.com Use erase-remove idiom for dead-declaration removal.
2020-09-03 kjlubick@google.com [infra] remove SkottieWASM CPU job
2020-09-03 kjlubick@google.com [canvaskit] Add drawRect4f as example 'fast path' API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1108408
Tbr: michaelludwig@google.com
Change-Id: I0efe05c9cdb3401e5e1fb7eb3ad8a2e413e01ed7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392728Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804392}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e32d90fa6b3..c81f39950ebf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC btolsch@google.com,nicolaso@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1093353,chromium:1099917
Tbr: btolsch@google.com,nicolaso@google.com
Change-Id: I7193727c0adf01659ac7dd9ca79197bd1b5e682b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392727Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804391}

Bug: 1049826
Change-Id: I35a51c669e413c4b1cdf0b756239b3b3e0066ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391422Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804390}

This addresses the linked bug where the search provider logo would
sometimes disappear on the Android NTP under certain conditions
(device rotated while the logo is scrolled off-screen). A lot more
context on the bug is in this thread (googlers only, sorry):
https://groups.google.com/a/google.com/g/clank-dev/c/IWxWjz6qc90

One of the posts in that thread suggested changing the width of the logo
in the XML, and since doing so I have not been able to repro the bug, so
I believe this should fix the blocking issue.

Bug: 1122928
Change-Id: Id4503fa5a1131a83a43b7dbb083e7253f7e8138d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392751Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804389}

This CL add an new API to CustomViewBinder#getPixelHeight which allow
each custom view can return their height individually. The height is
based on the layout file related to the custom view.

This CL also add padding before and after the divider line, and render
test for it.

Bug:1114611

Change-Id: I5e104dd5cdcdcf4acf20beeab6a682b4d4bba152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387542
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#804388}

When auditing dependencies, a fundamental information is in which build
target the outbound or inbound dependency is.

Change-Id: I55513f18b76e6bad01d7a2f68aad5e56b256d49c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391651
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804387}

SkiaOutputDeviceGL can sometimes look in the wrong place for a texture.
It is using a deprecated system (MailboxManager) to find a texture based
on a mailbox (which is just an opaque id), because existing Windows
video overlay code still used the old GL texture system so the mapping
is stored there.

This CL adds code to look in the new shared images system to lookup a
texture from a mailbox and it will be required when upcoming changes in
"Zero-Copy Camera Capture Optimizations on Windows" [1] lands to ensure
that Skia rendering also works with these new changes. The upcoming code
uses the new system, so the mapping is stored there.

Note that, the changes in this CL will not have any effect until the
work in [1] lands in Chrome.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1120900

Bug: 1120900
Change-Id: I09b5f0b06ff7539a9448a5b28bbfef89b3666331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391236Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804386}

This should not change deep scanning behaviour with Connectors.

Bug: 1103390
Change-Id: If7562ef39a94680397b6dc48ee9cf7c41cf86988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388202
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804385}

The extension installation process reports times at various stages
in the process. Till now, we are just checking if an entry for the
time is getting recorded in the histogram. This CL additionally
verifies that the time recorded in the histogram is as expected.

Bug: b:162855564
Change-Id: I5c2d7e5c9b93df98c9e899d13e779adafc84563d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391145
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Reviewed-by: Swapnil Gupta <swapnilgupta@google.com>
Cr-Commit-Position: refs/heads/master@{#804384}

Currently the execvp fails for a launch process it does not give
much diagnosis. This change reports the errno reason why the execvp
failed. This has been useful in finding simple naming errors.

Change-Id: Ifcc33c87931535019d8509234818c9d995fa4b9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383292
Commit-Queue: Peter McNeeley <petermcneeley@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804383}

This is a mechanical conversion from the original HTML page to markdown
doc with few typo fixes, link fix and reformatting.

See http://go/clank/engineering/android-webview/java-bridge for the
original doc.

Fix: 948816
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I503c964bc6445ce26b8d9aea3cfd03bf77667c73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391771
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804382}

Pseudo element was renamed. Use the same crbug issue and reintroduce the
expectation line in the same place it was removed from.

Bug: 1086855
Change-Id: Ib9a258d8f2a494bdfc791d406a1f3eed5073e505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390915
Auto-Submit: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804381}

Bug: 1120109
Change-Id: Icbe6f8f000d4ff1db68445ffdabf931a6ce19aa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368136Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804380}

This CL changes NOTREACHED() to LOG(FATAL) in context lost handling on
RenderThread. WebView currently will intentionally crash in
HardwareRendererViz::OnViz::DisplayOutputSurfaceLost, but it happens on
viz thread later and has no useful information.

Bug: 1112841
Change-Id: I2548c06c32897d586e9d51d143d1dbd2f3fdfc6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392411Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804379}

Prior to https://crrev.com/802829, PDFExtensionClipboardTest used
polling to detect clipboard changes. As such, test cases took the
following steps and there was no alternative:

A1) Fire asynchronous input event.
A2) Poll the clipboard repeatedly for changes.

This has an inherently race risk, as (A1) can potentially finish before
(A2) starts. With the straight-forward ClipboardMonitor replacement in
https://crrev.com/802829, the test cases do less work by not polling,
but the race risk remains:

B1) Fire asynchronous input event.
B2) Start monitoring for clipboard changes.
B3) Wait until the clipboard changes.

Since the tests are no longer polling, it is now possible to improve
reliability by reordering the steps:

C1) Start monitoring for clipboard changes.
C2) Fire asynchronous input event.
C3) Wait until the clipboard changes.

To do this, change CheckClipboard() and CheckSelectionClipboard() to
take an additional base::OnceClosure for the input event action. Then
run the closure at the appropriate time.

Also update remaining comments that still mention polling.

Bug: 1121446
Change-Id: I2a29ef1ef3b08cf7567318d098f5b527ec9f53bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391582
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804378}

On the official WPT test runner, we can't test reporting at all.
See https://crbug.com/1121605

The "Report-To" header isn't parsed at all, due to an SSL certificate
error.
We are already using "--ignore-certificate-errors", but apparently this
isn't enough, we also need: "--ignore-certificate-errors-spki-list=XXXX"

Where XXX can be generated with:
```
openssl x509 -noout -pubkey -in ./tools/certs/web-platform.test.pem |
openssl pkey -pubin -outform der |
openssl dgst -sha256 -binary |
base64
```

This is adapted from the internal chrome test runner:
third_party/blink/tools/blinkpy/web_tests/port/base.py
(Search for WPT_FINGERPRINT)

Along the way, I found this issue:
https://github.com/web-platform-tests/wpt/issues/24180
which I think might also be fixed by this patch.

BUG=1121605

Change-Id: Ia6e98a5050c8d2513d605a45cd349a52314282cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390748
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804377}

This test is flaky on Win7 x86 32-bit bots.

TBR=nicolaso@chromium.org

Bug: 1124845
Change-Id: I26fc5b231a6aed0af4e5bd3c9e3eb7bfbdf0ba56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392936Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804376}