- 14 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/95e8d00d85d0..8ab5356c195c git log 95e8d00d85d0..8ab5356c195c --date=short --first-parent --format='%ad %ae %s' 2020-04-14 simonmacm@google.com Merge "Add some aggregate values about screen to the battery metrics." Created with: gclient setdep -r src/third_party/perfetto@8ab5356c195c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0991bfca125ea2f4da0fe8926395534f5c037c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758970}
-
Avi Drissman authored
This was partially removed in r256400; finish the job. Bug: 111652, 350118 Change-Id: I1080786d704b52662aa4d25d24d0ac44d51d09c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149404 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#758969}
-
John Lee authored
This CL continues the work to use cr-row on all pages. This CL attempts to also make pages look a bit more consistent by replacing one-off styles with existing classes, and removes extraneous use of settings-box. Bug: 973674 Change-Id: I1a4fa82b5a8dbfaf06a4fad79fb279ab5b9b2b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148280Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#758968}
-
Matt Menke authored
We should probably not have these requests follow cross-origin redirects anyways, but in the off case they do redirect to the original site, they should not be sending SameSite cookies to it. Fixed: 1070232 Bug: 1060631 Change-Id: Id1e5b700c779f7b20aeba9bd372178aeb83c755f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147924 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#758967}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e52e2dbcdf9d..efca5651464d git log e52e2dbcdf9d..efca5651464d --date=short --first-parent --format='%ad %ae %s' 2020-04-14 bclayton@google.com Device: Rename RoutineCacheT to RoutineCache 2020-04-14 bclayton@google.com Device: Don't inherit [Vertex,Setup,Pixel]Processor. Created with: gclient setdep -r src/third_party/swiftshader@efca5651464d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id589d840907aec481bc032b3aaca8fa6b7788606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148889Reviewed-by:
-
Sam Bowen authored
See this part of the media feeds spec: https://wicg.github.io/media-feeds/#play-next-tv-episodes Some refactoring was necessary also. This is still missing the duration on TV episode and the live details. Because those require changes to the mojo structs, I will do them in a different CL. The general process is: 1) Find all episodes in the Item and get them as EpisodeCandidate 2) Pick main and play next episodes from list of EpisodeCandidate 3) If main episode is present, validate and store it on item->tv_episode 4) If play next is present, validate and store it on item->play_next_candidate It's OK for a TV series to have no EpisodeCandidates, but any it has should be valid. We should perhaps break this up into multiple files. Open to suggestions on that. Bug: 1068751 Change-Id: I37260ee8a905be347e764667921794bb845a4b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146072Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#758965}
-
Alex Moshchuk authored
Bug: 1005895 Change-Id: Ib94a49e4712cf7ff5a5f289f83f653dd8cce7745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147920Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#758964}
-
Raymond Toy authored
This node already supports inputs for the k-rate delayTime AudioParam. Just add a test for this. Bug: 1015760 Test: k-rate-delay-connections.html Change-Id: I0b1a2c5be2b04ca1e960670c82009c343d5699e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148152Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758963}
-
Elly Fong-Jones authored
This cancel override is essentially a no-op now. There is no cancel button on this dialog so the only call path is via CloseDialog, which always stops the timer before calling into Cancel, so Cancel was always returning true. This change removes the Cancel override and the explicit stop of the timer, which is no longer needed. Bug: 1011446 Change-Id: Ifa6d42591ebcb4063aae05aa959199f407e50df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148678Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758962}
-
Chris Cunningham authored
Many DB operations are user visible. Blocking DB read can delay the start of site video. Blocking DB clear can delay clearing history. Blocking DB initialize can delay both. UMAs indicate some DB operations take a long while. Hopefully this is the root of the issue. Bug: 1040098 Change-Id: I29c5173cf6d8795990664af0d4584edf6568a794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148120 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#758961}
-
danakj authored
Previously the events were expected to be absolute coordinates relative to the screen, but that made for awkward js in tests, having to pass around frame offsets. In that world it was impossible to find the right value in an OOPIF since the OOPIF can get its frame's position in the *document* from the parent frame, and can see where its frame is on the screen, but doesn't know the size of the browser window, or the position of the parent frame in the screen. This made for some hacky constants in tests. Now we give mouseMoveTo() coordinates relative to the current frame, which works identically in all frames, in process or out. This means that OOPIF tests with input events work in headless mode (as before) but now also work correctly in non-headless mode! Secondly, input events come from come from the browser in physical pixels when UseZoomForDSF is enabled. Similarly EventSender in web tests should scale events to physical pixels so that our events look the same. Web tests are written with device-scale-independent coordinates (which is good, js is this way), but the C++ code all expects physical pixels now when UseZoomForDSF is enabled. So we scale them at the earliest point possible. Fixes drag-drop-to-data-url.html to actually move the mouse onto the target location. It was using an undefined value and moving the mouse to NaN. Fixes tests that were trying to compute global coordinates to just use the element's local position in the frame. R=nasko@chromium.org Bug: 866140, 1069111 Change-Id: I08cd3802d21df25a96ab3adce9f16c256b0785aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141006Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#758960}
-
Brandon Jones authored
Recently added to the AR module, described here: https://immersive-web.github.io/webxr-ar-module/#xrinteractionmode-enum AR module intent to ship here: https://groups.google.com/a/chromium.org/g/blink-dev/c/BXxS2U5EaN0 Bug: 1066237 Change-Id: Iefd898c7bd65593812c3063874687fc3eff4efef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140779Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758959}
-
Jeff Yoon authored
Official GOMA enabled PGO phase 1 MB configs for PGO builders set under chromium.pgo. Bug: 1068818 Change-Id: Ifceaad778b6bdb929a8ca4a14b2abcab8cce5149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145256Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#758958}
-
Gil Dekel authored
Migrating the supported release branch for PrivacyScreenEnabled and DeviceLoginScreenPrivacyScreenEnabled into M83, instead of referencing to the defunct M82 release. BYPASS_POLICY_COMPATIBILITY_CHECK=tested on M83 Change-Id: I56c1cb918396f3c76030215458be56ebef1a8029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148842Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#758957}
-
Joshua Peraza authored
d9c1ca1216fc [ios] Bring up first draft system snapshot and iOS data collector faae6470cf89 [ios] Bring up first draft exceptions snapshot d3859d91fde0 mac: kern.nx is not present in 10.14.4 et seq, but NX is always enabled af62d7fcf61d Correct use of -[NSString UTF8String] 61a4f3d7d6f6 mac: kern.nx is not present in 10.14.5 et seq, but NX is always enabled e39aacbd66c7 Roll crashpad/third_party/mini_chromium/mini_chromium/ c426ff98e..731e08f06 (1 commit) 194e23910c13 Change for loops to use const references where they did not previously 9da2573ca993 linux: Patch for capget syscall error c4cc4e6ac92d android: initialize signal dispositions de5bc33b8b45 fuchsia: Include reference to zx library b2fd7d5307b0 [ios] Bring up first half of UncaughtExceptionHandler b71a4f1ca8f9 doc: Update buildbot URL 054f45724e68 Revert "fuchsia: Include reference to zx library" 380f2108dfb0 Roll crashpad/third_party/gtest/gtest/ eb78ee170..e3f0319d8 (232 commits) e621aaa13228 Make “gn check” pass 3c44556cf11e Replace ScopedClearErrno with ScopedClearLastError e5dbfa336351 Disable fuzzing without use_fuzzing_engine de43cd37232e Fix Chromium Roll b49dcdc48fd9 Mark static const class/struct members as constexpr Change-Id: I2253529764e48dcf15007ccd2caf9749940c03d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148966 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#758956}
-
Donn Denman authored
Speculative fix for the ContextualSearchManagerTest suite due to omnibox focus issue. Hoping OMNIBOX_SEARCH_ENGINE_LOGO is what's causing the trouble. BUG=1058362, 1063203, 1058663, 1058297 Change-Id: I1d71db509cfd858c0cc6f3733af64b61750ecb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134852Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#758955}
-
Mustaq Ahmed authored
Also enable regression notification (through issues). Change-Id: I3fe73831a5ceb1ee52df296b5a71349935b3be72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144898Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#758954}
-
Xiaohan Wang authored
Due to flakiness. See bug. Bug: 967588 Tbr: parastoog@google.com Change-Id: Ibdc010509e832ed17ef4a1d7439d01c1ed71d3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149391Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#758953}
-
Roman Sorokin authored
Checks that correct IME is loaded on different users unlocking Fixed: 1024563 Change-Id: Icbe8217c830e27aba421c08a4f460aff66c503ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142252Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758952}
-
Peter Kotwicz authored
This CL removes the redundant native check in WebappActivity#onNewIntent(). The native check is redundant because CustomTabIntentHandler#onNewIntent() delays the handling till the tab is added to the tab model - WebappActivityTabController#initializeState(). BUG=1069311 Change-Id: I0e00c6a797469af87701ad0d4ca86932fc422a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143114Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758951}
-
Moe Ahmadi authored
- Propagates the suggestions' group information, i.e., group IDs, associated headers, and current visibilities (determined by the prefs) to JS. - Renders grouped matches under their associated header. - Allows showing/hiding grouped suggestions and updates the prefs. screenshot/zHMaQioPKVF screenshot/6uiibJ6BLhm Bug: 1052514 Change-Id: I8982ca0f3ce4d84121fffc8054e9190742af73e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145954 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#758950}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Change-Id: Id6a5288d453e0e7d8bbe59cc1938f5a14f79d3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147674 Auto-Submit: Matt Menke <mmenke@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#758949}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62d5d8e82707..72036ead58ed Created with: gclient setdep -r src-internal@72036ead58ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1055164,chromium:1068818,chromium:912681 Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: I68843bd26b1d6ec86dcdcebbc7f945b0a1f73737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149386Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758948}
-
Gabriel Charette authored
R=etiennep@chromium.org, fdoray@chromium.org Bug: 885371 Change-Id: I751805a089cea779c11dc149c8b68a32b033ce9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135828Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#758947}
-
siashah authored
The default value for the card_issuer is set to ISSUER_UNKNOWN, which is a no-op. Please refer to bug for design doc. Bug: 1063426 Change-Id: Iadfab36e31f48549216346278863d08d1e025513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145970Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#758946}
-
Avi Drissman authored
Add a NSApplicationDelegate call that was introduced in 10.13, and add future notes for cleanup when 10.13 is the minimum. Bug: none Change-Id: I525960f7833332fcbd1f6190657251b62a1fe22e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147883Reviewed-by:
-
Matthew Mourgos authored
This cl changes the accessibility button on the marketing opt in screen to only show up when the gesture navigation screen was shown. This cl adds a function, was_shown(), to the gesture screen. This function can be called to check whether the the gesture screen was shown or skipped over. Bug: 1068686 Change-Id: I2f7808806bd795cc43c62ada40a9e3f830da8e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142148 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758944}
-
Stephen Roe authored
Logs are being collected on Arm64 FYI to check a problem with viz_unittests on Arm64 CQ dry runs before enabling log collection on CI. Bug: 1042512 Change-Id: Id92e3285fb826001a62c8d0a0c548c56411999b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149278Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#758943}
-
Nico Weber authored
Bug: 1070443 Change-Id: I48c8415cc72e03e87910a47ca07c38330e3dfa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148284Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#758942}
-
dpapad authored
GetRawDataResource assumes that underlying files are not compressed, whereas LoadDataResourceString automatically decompresses if necessary. This is one of many CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: Ic65f855b9ca988b9837d28290a0903e1142c0526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148117 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#758941}
-
Tommy Li authored
This CL just hooks up the toggle button to the preference service. Nothing more. Bug: 1052522 Change-Id: Ic58565b7f9420c76f0ec7fbff15346722ddc7626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147688 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#758940}
-
Eric Roman authored
Change-Id: If8a87cc74e7c157da5647b19829c00f7dd3a5db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147815 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#758939}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 34 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-10-11. TBR=bcwhite@chromium.org Change-Id: I6e806ea8dba29aa29f8f54336d593efd0f6d9896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143867Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#758938}
-
Charlie Hu authored
This CL let DocumentPolicyParser::Parse ignores unrecognized params when parsing a feature entry. Previously, unrecognized params would cause parse of feature entry fail. Now, unrecognized params are simply ignored and parse of feature entry will continue. Bug: 993790 Change-Id: I2fbbd243d82c94c97b077099723d7eec2e6cdb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142576 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#758937}
-
Noel Gordon authored
Compression level 0 selects deflate_stored. Allow it to be selected as using zlib_bench --compression 0 command line option. Bug: 798943 Change-Id: Ib2aac8e2c2c332350de334bca7c2dfde0cfe6a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148708 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#758936}
-
Daniel Libby authored
Reland now that M83 has forked. Also adjust DCHECK in picture_layer_impl.cc. crbug.com/1063358 points out that even if the aspect ratio matches, we can still end up with a scaled tile that does not exactly match the layer's bounds because of the raster scale adjustments that kick in inside RecalculateRasterScales when the desired scale is adjusted based on the ideal scale. > Original change's description: > > Add support for drawImageRect-based directly composited images > > > > Directly composited images is a feature that rasterizes images at their > > intrinsic size, when an image is the only thing drawn into a layer. > > However, this determination is today made prior to painting the image > > in blink, which can't be done with CompositeAfterPaint enabled. > > > > This CL adds support for detecting PictureLayers that qualify as directly > > composited images, by analyzing the paint ops of the display item list. > > If a single drawImageRect paint op is detected (with some facilities for > > detecting images for which orientation is respected), then we'll > > propagate the image's intrinsic size over to PictureLayerImpl on commit. > > PictureLayerImpl then uses that information to calculate a raster scale > > that results in the image being rasterized at its intrinsic size. > > > > There are a few additional changes needed outside that core calculation. > > If the aspect ratio of the layer bounds does not match the image's > > aspect ratio, we won't raster the image at the intrinsic size, but > > instead will choose the scale from one dimension. In these cases, we will > > choose to re-raster when the layer is resized until the layer bounds > > aspect ratio matches that of the image. > > If we do adjust the raster scale and add tilings to the active tree > > (as is seen in the default configuration for web_tests), we should drop > > the previous tilings (which are now non-ideal) since the max raster scale > > tile will be chosen when the SharedQuadState is created during > > AppendQuads. > > We also need to tell the LayerImpl if nearest neighbor should be used > > when the TileDrawQuad is scaled in the display compositor to preserve > > the same output of the original drawImageRect. > > > > Bug: 875110 > > > > Change-Id: I2cda143f483c2aa30a6ae1fb850e1c7ef1227882 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036542 > > Reviewed-by: vmpstr <vmpstr@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#751891} TBR=vmpstr@chromium.org,pdr@chromium.org,dlibby@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875110 Change-Id: I485e939ba08575a3e2af5a821558e54ce6132cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144398Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758935}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a0ab3490..1eaee939 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib8d6d0d619f17c690248a7bffdc67f0a2508e355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148766Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758934}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8c8d16a1c53f..37193aa3b306 git log 8c8d16a1c53f..37193aa3b306 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 zmo@chromium.org Roll glm 06f084063..bf71a8349 and turn on -Wextra-semi-stmt. Created with: gclient setdep -r src/third_party/dawn@37193aa3b306 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1064305 Tbr: cwallez@google.com Change-Id: I7bd81c50ea34c209c8148ac12d876cd131a3360b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148882Reviewed-by:
-
Wez authored
Add a set of owners for Fuchsia-specific security reviews, which will apply to CLs which have: - Changes to Chromium-defined FIDL APIs. - Changes to component sandbox specifications. - Changes to critical integration code, e.g. the sandbox policy. The new //fuchsia/SECURITY_OWNERS file is applied to specific files in //base, //fuchsia and //services, that are critical to the security of WebEngine and other Chromium packages published for use on Fuchsia. Bug: 1053551 Change-Id: I809cc07843ff06167b596f3fea21307e599803bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128079Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#758932}
-
Natalie Chouinard authored
Re-enable render test with updated goldens on API 23. Remove goldens for KitKat based on clank-frontend recommendation (see bug for more detail). Bug: 888129 Change-Id: Icb86ec7adc8975ec1d417aa2f0449d9b3256f861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148160Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#758931}
-
