- 30 Sep, 2019 38 commits
-
-
Yutaka Hirano authored
RespondToClosingHandshake can fail, and in that case we must stop using the net::WebSocketChannel instance. Bug: 994000 Change-Id: Ibaba2c552cfba59c3d95f63f0d9e807df4c4f564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830492 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#701047}
-
Jit Yao Yap authored
This is a reland of 04e92329 Original change's description: > Chrome OS Oobe: Show Ash dialog only if required > > When starting a managed guest session (with no Terms of Service), a > blank Ash dialog is shown for a brief moment before the session starts. > This is caused by the Ash dialog for Oobe being shown even when all the > Oobe screens are skipped. > > This CL changes the behavior of the Ash dialog to only show when > required by using a OobeUI::Observer. The dialog is not shown by > default, and will be shown when a Oobe screen is shown. > > OobeScreenWaiter now checks that the native window is visible by > default. A small number of tests had to be changed to either show the > native window or ignore the visibility check. The reasoning for the > changes are in the comments for their respective tests. > > The WebUI behavior is unchanged. > > Bug: 1000164 > Change-Id: I9995f4beba85d7c5af7b13f81f1a654e2d52f372 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790450 > Commit-Queue: Jit Yao Yap <jityao@google.com> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697539} Bug: 1000164 Change-Id: I3188791f20fc63c69e52a739ce0be28e972ea55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813334 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#701046}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/71c1138d6739..ceac3320975b git log 71c1138d6739..ceac3320975b --date=short --no-merges --format='%ad %ae %s' 2019-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 10951a7c9a13..85c67b5e08ee (4 commits) Created with: gclient setdep -r src/third_party/angle@ceac3320975b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:None Change-Id: I077c1bed902da7a55b7b075a7bc3d89e28f71f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831679Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701045}
-
Andreas Haas authored
The test uses WTF::ArrayBuffer as a replacement for a std::unique_ptr. Since we are refactoring ArrayBuffer right now, it is better to get rid of such uses. R=urvang@chromium.org Bug: chromium:1008840 Change-Id: Ib294217ecdf7a19c6eb1c19b07a0264c89841895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827403Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#701044}
-
Adam Rice authored
Permit any number of connect requests to be pending in the network service. Note that per-server WebSocket connection serialisation is still applied, so this doesn't permit denial-of-service attacks against servers. BUG=1006243 Change-Id: I31a10ec3384f32aa34ff0380f22738271bee0160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829629Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#701043}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/52bd6b7da6a7..55a00c7a1f9a git log 52bd6b7da6a7..55a00c7a1f9a --date=short --no-merges --format='%ad %ae %s' 2019-09-30 jiawei.shao@intel.com Set writemask to 0 when no fs output matches color state on Metal and Vulkan Created with: gclient setdep -r src/third_party/dawn@55a00c7a1f9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ib7613385713e1b29719648190d1520a3a87ae52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831677Reviewed-by:
-
Canon Mukai authored
This is behind a flag. And I added some JavaScript tests. Design Doc: https://docs.google.com/document/d/1TovyqqeC3HoO0A4UUBKiCyhZlQSl7jM_F7KbWjK2Gcs/edit#heading=h.7nki9mck5t64 Bug: 999091 Change-Id: I4c34d9b80fe50242c6547662040439a541b652b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810447Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: Ie4d5166b58097a4ab290a74dd1267b2276811682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831622 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701040}
-
Martin Robinson authored
Instead of firing the signal on the node which contains the selection focus, fire it on the first common ancestor of the anchor and focus nodes. This means that if the AT does a tree dive to get the full selection it won't first have to climb to find the full selection extents. Also, along with this new way of firing events we also take into account the anchor and focus nodes when deciding whether or not to avoid firing duplicate caret-changed events. Bug: 1003359 Change-Id: Ia4ac03be3e0548e9b435d6e21512c3c22459e6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816474Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#701039}
-
Shik Chen authored
The original formula misses the 4 bytes of APP1 header in [1] and might crash GPU process when encoding JPEG image due to heap overflow. [1] https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_jpeg_encoder.cc?l=156&rcl=42946e0e99026e840e2067e02ebfdd9f48fc2e2e Bug: b:140071851, b:138933987 Test: Take photo in CCA 20 times on Nocturne with an ASAN enabled Chrome. Change-Id: Ic1809cf5364640dc11b72891243b69b25c38f439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828720Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#701038}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f498f13b418e..c8a351eec4f9 Created with: gclient setdep -r src-internal@c8a351eec4f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0e5839d9400618099e55590737a82730aceb08d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701037}
-
Kenichi Ishibashi authored
This message was used for setting service worker V8 code caching outside install events. This feature was removed so remove the message too. Bug: 915081 Change-Id: I7cf79c6b59b16e3fc015806594bcb987a22c0b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829621Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
These methods were used for V8 code caching outside install events. The feature was removed so remove these methods too. Bug: 915081 Change-Id: If2635c0a978201c4d63dc697f7754f8e6de26f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829624 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
Originally, CreateGpuMemoryBufferHandle() function only takes one fd as argument, and assume each plane of the video frame stores at the same fd. This CL overloads CreateGpuMemoryBufferHandle() that takes multiple fds as arguments. Now we could pass different fd for each plane. BUG=b:127230761 TEST=autoninja components_unittests Change-Id: Ie6f132074c7125cf926786924dc30165de90ee24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826742 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#701034}
-
Ioana Pandele authored
The leak detection dialog is currently a tab modal, which allows interaction with the omnibox and tab switcher. This CL changes it to an app modal, which blocks interaction with the entire app until it's dismissed. Bug: 1008859, 986317 Change-Id: Ie12f3f2bd06c26860ae95ebc11bb7c97e6014571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825518 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#701033}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0081c0ff173c..286fb1607d36 git log 0081c0ff173c..286fb1607d36 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 vapier@chromium.org gclient: have git operations specify the git dir by default Created with: gclient setdep -r src/third_party/depot_tools@286fb1607d36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1000825 Change-Id: I61cdc381b5050050050a366060309db85caf7d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831480Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7aeabcfa6a73..59d894e2d057 git log 7aeabcfa6a73..59d894e2d057 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 996b3993..26279492 (443 commits) 2019-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6b4b8141e11d..faa2a365b5c0 (1 commits) 2019-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@59d894e2d057 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None,chromium:None Change-Id: I28214c0151c2b9958c48fa46081c0c9883834994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831348Reviewed-by:
-
Rika Fujimaki authored
Since we can't trace WorldSafeV8Reference on stack, we use Member<WorldSafeV8ReferenceWrapper>. WorldSafeV8ReferenceWrapper class wraps WorldSafeV8Reference. Note that we remove ScriptValue::ToWorldSafeV8Reference() for now, but revive this once we ensure that TraceWrapperV8Reference's copy assignment is not buggy. Bug: 1007881, 1008258, 1008215, 1007881, 1007868 Bug: 1007865, 1007341 Change-Id: Ief22c6138394a512df9454d3c5bfad0bf35f8425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828783 Commit-Queue: Rika Fujimaki <rikaf@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#701030}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 79-3904.12-1569231291-benchmark-78.0.3902.0-r1 to 79-3904.12-1569231291-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I43cb854f205ec49001bd7b13056e971843274d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831491Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/656e25f9..581e894f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3aed0a428d0b76a161811a84cf9e5d4529d1bc73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831557Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701028}
-
Hiroshige Hayashizaki authored
This CL migrates most of the wpt/upgrade-insecure-requests tests from upgrade-insecure-requests/support/generate.py into the /common/security-features generator framework. Actual file regeneration is done in https://chromium-review.googlesource.com/c/chromium/src/+/1788553 and the coverage will become larger than the current generator. Particularly, this (and the regeneration CL) adds the following cases: - `upgrade-insecure-requests` is delivered by HTTP response headers. Previously, only the delivery via <meta> was tested. - `upgrade-insecure-requests` isn't delivered and thus requests are blocked (as mixed-content or simply failing to connect the server). Previously, only successfully upgraded cases were tested. Bug: 1001422 Change-Id: I351f4dcc75c1008cf743b63dfb585ca82e199f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788551 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#701027}
-
Julie Jeongeun Kim authored
This CL converts FeatureStateObserverPtr and FeatureStateObserverRequest to new Mojo types using PendingRemote, PendingReceiver, ReceiverSet, RemoteSet, and Receiver. It also updates AddFeatureStateObserver from multidevice_setup.mojom. Bug: 955171 Change-Id: I94c6d61500a7f142c58153ce20d225f27f4e3135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827259 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#701026}
-
Nicholas Hollingum authored
Before the use of _NET_WM_STATE was common, windows would expect to be maximized on launch if their size was larger than the display working area. See https://github.com/linuxmint/muffin/blob/f5778ba1433c3ac86f5aeb8fa7443baf600eb9db/src/core/place.c#L977 This change emultes that behaviour for CrOS. We add a callback in widget initialization that we use to check the window size against the display area, and maximize if necessary. Bug: 994009 Change-Id: I0e6409a4c28eb9ea5071461c736a6fbf44f56606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788420 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#701025}
-
Kenichi Ishibashi authored
We've concluded that we won't actively pursue this feature as we weren't able to see performance improvements. Bug: 915081 Change-Id: I0a6a804b4fbc613dc8b8c7abff64e4d4d21419df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828726 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Now that the adding "Accept: */*" is clearly defined in the fetch spec, this patch make some cleanups to follow the spec algorithm, and remove a link to the issue thread. Bug: 995740 Change-Id: I5a8899f1a02254e95009c4202957e73e8e4ece31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828767 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Honglin Yu authored
This CL will not be submitted before http://crrev.com/c/1768811 is merged. This is the Chromium side CL to make ml-service support loading model from model string. Previously, ml-service has only one interface |LoadModel|. After upgrade of http://crrev.com/c/1768811, ml-service will have two interface functions, 1. |LoadBuiltinModel|: similar to |LoadModel|. 2. |LoadFlatBufferModel|: accept model string. And |LoadModel| will be deprecated. This CL make Chrome use the new APIs. BUG=chromium:990619 TEST=tested in conjunction with http://crrev.com/c/1768811 TEST=on device, TEST_MODEL works. TEST=./out_eve/test/chromeos_unittests Change-Id: I141e2bdae23323432f6afaee3f7b36deb134a41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771643Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701022}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07156a46610b..f498f13b418e Created with: gclient setdep -r src-internal@f498f13b418e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I97b53b048a0eec5527fb31d9ed00318b7fb293fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830505Reviewed-by:
-
Miguel Casas authored
This CL has a few cleanups that were punted during crrev.com/c/1772642 - Using UniqueID ISO int - Use base::small_map - cleanup includes - forward declare some classes - using base::Location in OnError() Bug: 998279 Change-Id: I654411ab5f7dbc6527e3805d76887eb202ddd40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819681 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#701020}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I5d6441a474e250fab7f15afbbb8d7c6265cda963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829578Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701019}
-
Adam Rice authored
ChildProcessSecurityPolicyImpl::CanAccessDataForWebSocket is no longer used. Remove it. Change-Id: I5fdd3577c5280aaf29b3b836c005e956f7a6188e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828768Reviewed-by:
-
Hiroshi Ichikawa authored
The app crashes if the method is called after |_webState| is deallocated. Change-Id: I8c06cddc8ea3a39fd2c8c5d05d4c17fa0bd071d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830251Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#701017}
-
Stephen McGruer authored
Previously additive composition was implemented as something close to accumulate, using a pairwise addition. This CL changes it to the by-spec behavior of concatenating the lists. Unfortunately due to underlying issues in the way Chromium handles 0%/100% Animations (we fast-path through the interpolation code), things get weird at those points and we end up dropping the addition - against spec. This could be a serious problem, for example for fill-forward animations, so will warrant further CLs to fix. See https://drafts.fxtf.org/filter-effects-1/#addition Bug: 1005828 Change-Id: I941c986627c57738c65fb67674bfbce6dc437155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822021 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701016}
-
Jay Harris authored
This is part of a series of CLs redesigning the Badging API based on TPAC feedback: https://github.com/WICG/badging/issues/55 In a followup CL, the scope member will no longer be exposed to the web: https://chromium-review.googlesource.com/c/chromium/src/+/1816002 Note: The scope parameter was ignored in a previous CL, which is why there are no unit/browser test changes. Bug: 1006665 Change-Id: I176dfc28abaf661aaeaa1622e059c2b8cc851e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818892 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#701015}
-
Tetsui Ohkubo authored
BUG=None TEST=None Change-Id: Ia27fc34352eee14d97f56e7af6a01fdd9274ae32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828777Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#701014}
-
Trent Apted authored
Bug: 996088 Change-Id: I4dcf297374afcb06abbd94b988ed39c0cad14967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828668 Auto-Submit: Trent Apted <tapted@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#701013}
-
Darren Shen authored
AltGr is a valid modifier state according to W3C [1]. Currently, the chrome.input.ime.KeyboardEvent does not provide the status of AltGr to extensions. This means that extensions has to manually track the status of AltGr. It would be much simpler for extensions if we provided the status of AltGr in the KeyboardEvent API, since we already do this for other modifier keys like Control and Alt. [1] https://w3c.github.io/uievents/#dom-eventmodifierinit-modifieraltgraph BUG=1005619 Change-Id: I420d3505a894e175fba70db2652175883ede25cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824697 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701012}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/945aedd37169..07156a46610b Created with: gclient setdep -r src-internal@07156a46610b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I425efc2995f3f5df25604e8f362dfa3278db7979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830591Reviewed-by:
-
Daniele Castagna authored
VAAPI usage in Chrome has a global lock that is acquired for each vaapi call. The assumption was that vaapi calls would not block on the CPU, but they do. In particular, vaEndPicture seems to take a significant amount of wall time during encoding. When multiple encodings are happening, we might end up interleaving parts of the encodings of different streams and serialize them. This causes wall time for one encoding to sometimes take into account wall time of other encodings too. This CL tries to mitigate that issue in a few different ways: - In VaapiVideoEncodeAccelerator::ReturnBitstreamBuffer the client is notified that the encoding is ready before destroying the surface, since destroying the surface reacquires the lock that might be taken by another vaapi call in another thread. - ExecuteAndDestroyPendingBuffers acquires the lock only once, so that another vaapi client can block in between execute and destroy. - DownloadFromVABuffer doesn't unlock and relock during the copy to shmem, since the copy takes in the order of .1ms for a VGA stream and gives the chances to another VAAPI client to acquire the lock once the encoding is done and before we notify the client. Bug: 1005592 Test: on meet.google.com, record average WebRTC encoding times, observe it drops by ~10% Change-Id: I807e281ba501b5d05d53902c8257010725730966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819518 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#701010}
-
- 29 Sep, 2019 2 commits
-
-
Kent Tamura authored
- Rename many things Use 'control' instead of 'form' to represent a form control element to avoid confusion with <form>. - Add some comments - Share code of RestoreControlStateFor() and RestoreControlStateIn(). This CL has no behavior changes. Change-Id: Ic03bce6c1052efd42edc93cb413c757c1bb88543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827275Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#701009}
-
Jinsuk Kim authored
This CL a partial revert of https://crrev.com/c/1771638 so that the removed vector drawable can be used on KitKat instead of 9-patch drawable. KitKit doesn't seem to handle scaling 9-patch drawable well. Using the vector drawable gets around the issue. Bug: 993506 Change-Id: Id7b8db13ea2e19e3e3e3fed83b42c84cea9a95d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826748 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#701008}
-
