- 07 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e61dbc5cf5aa..24a9cfc3d443 2021-01-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia24a36b4455d0d1f94316d32150ad8a9519e163b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614144Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840921}
-
Nicholas Verne authored
Bug: 1163003 Change-Id: I9b2b439007c80bc0385128da4817ac001ee7eb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610407 Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#840920}
-
Toby Huang authored
LoggedInUserMixin is not as easy to use as it could be. This CL maximizes the chances that LoggedInUserMixin just works out of the box, while minimizing the chances of mysterious time outs. The test developer can optimize for efficiency later by tweaking the options in LoggedInUserMixin. This CL improves the browser test login tools. Bug: None Change-Id: Ic5e597e68ba32e7f29daa4d5331d47298ef3fbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598044 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#840919}
-
Asami Doi authored
This CL adds 3 test cases for nested blob URL workers: 1. a blob URL worker (parent) creates a blob URL worker (child) 2. a blob URL worker (parent) creates a worker (child) 3. a worker (parent) creates a blob URL worker (child) When the PlzDedicatedWorker feature is enabled, the first and third tests fail now. Bug: 1017034 Change-Id: I8b2221be3233312cb4f3cf3983215f658a40830d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596490 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#840918}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72bc771d052e..ceb5ca2f26dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1145728 Tbr: horo@google.com Change-Id: I714bb43e65b7f5602ef2ffec47c395da02938dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613261Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840917}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f1fa60b91230..fac169113df7 2021-01-07 rharrison@chromium.org Remove HLSL & MSL SPIRV-Cross Fuzzers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I0bd39ace7f4c72604994b122dbf48a5fef913626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613928Reviewed-by:
-
Andrew Grieve authored
Changed versionCode from int to long, which apparently does not auto-convert. Bug: 1163674 Change-Id: Ia213c65d437adf6f98caee0ba44c084534360b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611975 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840915}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609966729-d2f14914e2dc3c551a62ea16c0e882a0a5ae75ef.profdata to chrome-win32-master-1609977525-c6db9a955637b88d5134fbbd1dcc888c0f8d0465.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7e9da06db9788ac374f0c386c5eb63ddbd21298d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613926Reviewed-by:
-
Allen Bauer authored
Related to the work of integrating fill layout behavior into views::View. Bug: 1159116 Change-Id: Iccf0a311536588c3ba3d141ee5c7e1f8450cd2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613591 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#840913}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b34cd6d8fa4d..1c3c93911966 2021-01-07 martiniss@google.com Revert "[git-cl] Use owners client when processing --[tb]r-owners." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Icd27516275bf597de8f674077008461bcd8aaf3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613259Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ia9bac476512d5dc3e592b5d30a7e94c536383ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614065Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840911}
-
David Bokan authored
TestExtensionsBrowserClient allows passing a factory callback that can be used to create UpdateClients. By nature of being a factory, this should be a repeating callback. We also pass it by value to indicate a transfer of ownership. No change to (the only) call site as it already uses BindRepeating. Bug: 1152268 Change-Id: Ib07a63a48614fe3bb52b8fc060dd3946f64ec42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605874Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840910}
-
Kenton Lam authored
This change adds the iconset and required files and adds them to the chrome://emoji-picker page as an example of usage. Icons currently do not do anything. Bug: 1156851 Change-Id: I88434cb6f8954272764da53c4e5163302a655d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595548Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#840909}
-
Giovanni Ortuño Urquidi authored
Continue to simplify PendingAppManager by moving the logic to decide if we should use InstallFromInfo into PendingAppInstallTask. Also adds unit tests for installing apps from a WebApplicationInfo. Bug: 1158722 Change-Id: I396f41b55d42d5183be60dab659fc6315c6147ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607085Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#840908}
-
Erik Chen authored
This CL deletes 1+ year old code for removing old prefs. Change-Id: Id56e4fc76f342933cef3116222587abe033f142f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611500 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#840907}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.143. R=jam@chromium.org, rmhasan@google.com Bug: 1041619 Change-Id: Ifc66319366287ee1f9e9ab388a370d1db6bceb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611677 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#840906}
-
Asami Doi authored
The following case should not pass the offline capability check: - manifest's scope: /banners/ - manifest's start_url: /banners/manifest_test_page.html?ignore - service worker's scope: /banners/ Bug: 1157242, 965802 Change-Id: I2832fbc102fd931aecc9d42394f5429e4c66e6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596902 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#840905}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f902efb9511c..7f2db542af0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2731b703a4b725a2a562b4c0c2870abb1bd140d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611569Reviewed-by:
-
Cattalyya Nuengsigkapian authored
- When user has only one desk, mode switching should be off and the tab slider should be hidden. - Add Ash unit tests to check visibility and existence of the interactive component when the number of desks changes. Bug: 1161243 Test: Manual test (see a video in crbug) and Ash unit tests `ash_unittests --gtest_filter=ModeSelectionWindowCycleControllerTest.SingleDeskHidesInteractiveMode` Change-Id: I32708306cd310d4075ee9bbb20991e3bad20531f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603854 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#840903}
-
Erik Chen authored
The API is unused. Change-Id: I32b21b8752234505daa52fe920e4322c8485ace1 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601047 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Mohammed Abdon authored
Using the new lockscreen profile as a browser context for WebUI displaying SAML page while re-authenticating users on lockscreen. Bug: 1102942 Change-Id: Ib870ab313cca1b8de83cfdd1e4b52fd489faa82a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606354Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Cr-Commit-Position: refs/heads/master@{#840901}
-
Nancy Wang authored
Add the callback function as the parameter of FullRestoreReadHandler::ReadFromFile, to get the restore data read from the restore data. Add unit tests to test FullRestoreReadHandler and FullRestoreSaveHandler to verify the full restore file read and write process. BUG=1146900 Change-Id: Id18405c1f68274726fe28008c196607bf759d2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612656 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e6e61974ed4..72bc771d052e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com,collinbaker@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1117773,chromium:1150459 Tbr: horo@google.com,collinbaker@google.com Change-Id: I036bbf310d6f5518869ad6c3170800215dc32b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612497Reviewed-by:
-
Jiewei Qian authored
After BMO launch, extension->from_bookmark() should always be false. This CL removes some non-reachable code in application_launch. Bug: 1065748 Change-Id: I679aff28857a5ffa0d2156d04d4d80c56c712d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612306Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
Glen Robertson authored
HostedApp metrics will eventually be removed (Chrome Apps are deprecated). BookmarkApp metrics will eventually be migrated to WebApp namespace (crbug.com/1014328). Expected to be in use long-term. Also adding phillis@ as an owner, for WebApp as they are leading web app metrics work. Bug: 1160812 Fixed: 1160812 Change-Id: I09cbc0a27bf6a13faee558c0d23a18927c48ed32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606879 Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
-
Glen Robertson authored
Same info is recorded as BookmarkAppLaunchContainer (which should be renamed, crbug.com/1014328). HostedAppLaunchContainer is still used for Hosted Apps. Bug: 1160812 Change-Id: Id77df80d16f3d85a6161a224700a5fbd0765e8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612286 Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/e6e704145b31..8144af91b4f9 2021-01-07 dneto@google.com spirv-reader: ignore PointSize builtin declared at module-scope 2021-01-06 bclayton@google.com wgsl: Treat // as comment 2021-01-06 bclayton@google.com Implement clamping of runtime array accesses 2021-01-06 bclayton@google.com Fix ast_clone_fuzzer tests 2021-01-06 bclayton@google.com src/transform: Reimplement tests in WGSL 2021-01-05 dneto@google.com Add --demangle option to command example 2021-01-05 dneto@google.com spirv-reader: support OpArrayLength 2021-01-05 bclayton@google.com reader/wgsl: Fix parsing of matrices. 2021-01-05 dneto@google.com spirv-reader: rename to isNan, isInf 2021-01-05 bclayton@google.com Validate that runtime arrays aren't used as parameters 2021-01-05 dneto@google.com spirv-reader: ImageQuerySize can be on readonly image 2021-01-05 bclayton@google.com cleanup: Refactor tests to use ast::Builder helpers 2021-01-05 bclayton@google.com reader/spirv: Move common test name to fixture name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I6518089addf52550bc7ad05115191910d19b5eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612574Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/5cb564b68580..7ca666453540 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 4cc0932495ec to a7825740f316 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: I3632ad2f899481d7cb05399081c854c87b768918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612568Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bd38fed1b9e..f902efb9511c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I61ae1e6c0f1a348165bcaea268eaabdfb76f4e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612383Reviewed-by:
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: Id54167a8b23b0e2cf0046de263510c7e3526f470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596711Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Shengsong Tan <sstan@google.com> Cr-Commit-Position: refs/heads/master@{#840892}
-
Mei Liang authored
Bug: 1163744 Change-Id: Ie2261964525e1ecf3ae274645ba7534510fcb6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613947 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#840891}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I4a9cb578e0cc7af1eb78d1af4f7c9c7b92926ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602959Reviewed-by:
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I4f9845c124968d4fa9e5a10683eadf24228e3868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603760Reviewed-by:
-
Evan Stade authored
TBR=estaab@chromium.org Bug: 1158928 Change-Id: I4cebb92b0e7b6520dd057d5714dd492e7fe38c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612204Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#840888}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d48aa437c9e8..b34cd6d8fa4d 2021-01-07 ehmaldonado@chromium.org Revert "[owners] Refactor OwnersClient." 2021-01-07 ehmaldonado@chromium.org Revert "presubmit: Don't print comments for missing reviewers." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1163731 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I71197fb9fcbbb077f560cf893fa02305fd0f3b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612572Reviewed-by:
-
Azeem Arshad authored
This CL moves qr_code_generator code from //chrome/common to //components/qr_code_generator. This move will allow the QRCodeGenerator class to be used in chromeos/services/cellular_setup/esim_manager service where a direct dependency to //chrome/common creates indirect DEPS violations. Bug: 1093185 Change-Id: I923d1613c46c2e1b194cb4eb3378db7aa5d51220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595199Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#840886}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a7b7964a237a..9730dc4041f5 2021-01-06 johnstiles@google.com Revert "Fix GPU improved noise impl and add to perlinnoise GM." 2021-01-06 bsalomon@google.com Fix GPU improved noise impl and add to perlinnoise GM. 2021-01-06 brianosman@google.com Use SkVM for (many) interpreter tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I70514c6db2f9a0d2e8e2668f3a41808ea784821b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612567Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609955739-6b0df8082f85d23ee00a8173801024bf5e32803c.profdata to chrome-linux-master-1609977525-bd4b14e8a3331d25b143eda6470a50c1959dbc36.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I54a96a1becb0611b45065b6ea5d6256aab6c3540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613791Reviewed-by:
-
Jeroen Dhollander authored
This could lead to the following chain of events: - (Browser thread) Starts Assistant, and calls mojom method |ServiceController::Start()|. - (Browser thread) Stops Assistant, and calls mojom method |ServiceController::Stop()|. - (Mojom thread) ServiceController::Start() - Creates |AssistantManager| - Publishes it through the singleton |LibassistantV1Api|. - Informs browser thread through mojom method |StateObserver::OnStateChanged(started)|. - Here we get an interwoven sequence of events between the mojom thread and the browser thread: - (Mojom thread) ServiceController::Stop() - Informs browser thread through mojom method |StateObserver::OnStateChanged(stopped)|. - (Here we are 'interrupted' by the browser thread) - (Browser thread) StateObserver::OnStateChanged(started) calls AssistantManagerServiceImpl::PostInitAssistant() which accesses the |LibassistantV1Api| which is not null yet. - (Mojom thread) now destroys |LibassistantV1Api| and |AssistantManager|. - (Browser thread) dereferences the (now deleted) |AssistantManager| object and crashes. Bug: 1162136 Test: Compiled and deployed Change-Id: I86b30c76c544a926e46e7817540f17f0910da192 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612402 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840883}
-
Alexander Cooper authored
Remove reference to needing to switch to the RBE backend now that it is default, and add current needed workaround. Change-Id: I52bcf7301c87f30258babba91ddbbff574dbd77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612218 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#840882}
-
