- 30 Oct, 2019 40 commits
-
-
Michael Spang authored
The default configuration of TestScreen is to create one display and one WindowTreeHost with the same size. X11 is now incompatible with this requirement as of b14e13fd ("Reland "X11 and Ozone: DWTHPlatform handles Show/Hide/Max/Restore/Full""). Several aura tests are only passing currently due to another bug in DisplayList::UpdateDisplay, which prevents X11Window from seeing the current display size and enforcing the constraint. Other tests only work because TestScreen resizes the display to match the WindowTreeHost /after/ X11Window deletes the last row and column. i.e., X11Window tries to adjust the size to not match the display, and then TestScreen re-adjusts the display to match the window. This behavior is not convergent and causes small changes in initialization order to affect the dimensions of test windows. This hack should likely be removed altogether and the bug it's addressing fixed another way, but for now disable it in the test harness because it is blocking other changes such as a fix for the UpdateDisplay bug noted above. Bug: 1019015 Change-Id: I79e830b9c35df3df29dc8af50ac424076682d180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889294 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#710955}
-
Mario Sanchez Prada authored
Convert the remaining bits referencing the video_capture::mojom::Device mojo interface using the old APIs to the new mojo types. Bug: 955171 Change-Id: Ieafd706caa4d9454fc308f10cd109139376253e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879260 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#710954}
-
Toni Barzic authored
Updates how device transitions to home when home button is tapped and when user clicks in empty space in overview grid when kHomerviewGesture feature is enabled. When overview is active, it should use kFadeOutExit transition (instead of slide out) - this also fixes a bug where transform was not cleared on item windows when bounds were updated without animations (which was causing item window misplacement when the grid was updated while minimizing active window before exiting overview). FadeOutWindowsAndMaybeSlideOnExit is updated to take "slide" as an argument instead of deducing it depending on the animation type, as OVERVIEW_ANIMATION_EXIT_TO_HOME_LAUNCHER should slide if and only if using slide out overview exit transition (the animation can also be used by fade out exit). When clicking home with a window active, the top window is minimized using transform to home screen (the same used during drag from shelf), while the rest of the windows are minimized with no animations. To make this easier, WindowTransformToHomeScreenAnimation is moved to a separate file, and is updated to better handle windows whose origin is not in the screen origin (which is useful for transforming top windows in split view). Is split view, the top windows are transformed to home screen as the split view ends. If overview session is active together with split view, the overview session is ended immediately to avoid showing overview just after ending split view (during duration of the exit transition). BUG=1005366 Change-Id: Ic23893866700f5e5580f4445915d815f188e8c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885972 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#710953}
-
sczs authored
Bug: 961343, 1019807 Change-Id: If56d88f4f2548b21fd341a4b2ca8f0bb6a1ea504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887431 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#710952}
-
Wenyu Fu authored
Part of the origin CL (1867431), adding MoreProgressButton class. It can be displayed as a button associated with a runnable, or a process spinner when executing the associated action. Bug: 1001286 Change-Id: I0ad5662690b193597f928de474f9cd303447c89b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880369Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710951}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9fae76312a94..4d322b9e167e git log 9fae76312a94..4d322b9e167e --date=short --no-merges --format='%ad %ae %s' 2019-10-30 dproy@chromium.org Print chrome debug logs Created with: gclient setdep -r src/third_party/catapult@4d322b9e167e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1015942 Change-Id: I2acb5a1526321d778959b306e9d31ad48983bac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710950}
-
Yuke Liao authored
The coverage builder doesn't run fuzzers anymore, and the corpus has been turned down, therefore, this CL removes the dependency between libfuzzer and the fuzzer corpus. Bug: 990387 Change-Id: I07cbec6629903aa3f2f5b53d3e7692a1e65acca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891010Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#710949}
-
shrekshao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/2701c13..dd55f3c TBR=kbr@chromium.org Bug: 455150, angleproject:4049, 776222, 891861, 890539 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I184a1a5fb3572f52cb5ac380dbd3a6fa3c981cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890983Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#710948}
-
Archana Simha authored
Move regular image to chrome/browser/resources/extensions Design Doc: go/extensionscheckup Bug: 1019296 Change-Id: Ic66c31a71751f2ea944ef9ee82e11617126ce418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877187 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#710947}
-
Stephen Roe authored
The tools are the Fuchsia SDK host tools, qemu, and the llvm-symbolizer. The paths to the tool locations are located in common.py. The x64 tools are used on linux-x64 test build and test run hosts. The arm64 tools are used on linux-arm64 test run hosts. qemu-kvm requires somewhat different arguments for arm64 than x64. For arm64: "-machine virt,gic_version=3" instead of "-machine virt" "-cpu host" instead of "-cpu host,migratable=no" Bug: 1000901 Change-Id: I5fa7fba7a7d556ed08d602fc864daa47c07b545a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885220Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#710946}
-
Bailey Berro authored
Also add some comments to describe the various sections Bug: none Change-Id: Ifbe892363fc4f6dfdaa730ce6058752540d94a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880577Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#710945}
-
Yulun Wu authored
Bug: 996006 Change-Id: I2d819b32177ad10da1ad07b5f266a25f4f25d200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762936 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#710944}
-
Kevin Marshall authored
The MIME sniffing code used by the Content Directory loading system has DCHECKs which prevent it from reading the contents of files larger than 1MB. Sniffing is now limited to the first 10KB of the file. Bug: 1018436 Change-Id: I0b6293ef08ebe7cd2bab30fb57ffd481819cf85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879684 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710943}
-
Junyi Xiao authored
Now this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1874670 has landed, fix the test and re-enable it. Bug: 842488 Change-Id: Ie436c7574de32e387db74697d2d205e296c4af09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890498Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#710942}
-
Avi Drissman authored
"alternateSelectedControlTextColor" is a name with non-obvious meaning, but it is (as per Apple header): > Foreground color inside emphasized and selected content: > table views rows, collection views, etc. Tested by checking non-selected and selected rows from 10.10 through 10.15 in both light and dark mode. Bug: 1018333 Change-Id: I38881d0e625ecce761f7e079d1346e5225bcc32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890475 Commit-Queue: Leonard Grey <lgrey@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#710941}
-
John Chen authored
Disabling four perf tests that are failing on all desktop platforms: * rendering.desktop/youtube_2018 * rendering.desktop/youtube_pinch_2018 * system_health.common_desktop/browse_accessibility:media:youtube * system_health.memory_desktop/browse_accessibility:media:youtube NOTRY=true TBR=crouleau@chromium.org Bug: 1017244 Change-Id: I4949d7db85f558ec0a74d2887428a3724e637d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891148Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#710940}
-
Klaus Weidner authored
The code was misusing the gfx::Transform initializer, it was supplying elements in column-major order but the constructor takes row-major order. Separately, it was then inverting this matrix to calculate a to_ray_space matrix. However, the mojo "pointer_offset" field is supposed to be an input_from_pointer transform. (The mojom comments are misleading, these need to be updated separately.) These two mistakes almost canceled each other out. The orientation part was correct (transpose followed by inverse), but the position component of the transform was in the wrong part of the matrix. This wasn't very noticeable since the position corresponded to a point on the near projection plane, so it was close to the origin, but applying the transform resulted in vectors with a "w" component that wasn't equal to 1.0. Change-Id: I73b2cc76a049af0d938f314992cdbf44df83319e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890989 Commit-Queue: Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#710939}
-
Tom McKee authored
Some of the Expect* methods of HistogramTester fail if the queried histogram has no data. Other methods allow querying empty histograms and treat them as a collection of empty buckets. Failing while inspecting empty histograms can make it awkward to verify certain test cases. For example, to check that a particular test case does not write to a particular bucket with ExpectBucketCount, a write to a separate bucket would be required. Alternatively, just asserting that the histogram is empty isn't quite right either because the test case would fail if an unrelated bucket happened to be updated. This CL changes HistogramTester to be consistent about what is queryable by treating empty histograms as collections of empty buckets. Change-Id: Id97356edb0bf983ff9487a2b749e028147400a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879608Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#710938}
-
Yuke Liao authored
CTI doesn't support fuzzers anymore, so this CL removes the fuzzer bits from the mb config file. Bug: 990387 Change-Id: Ie85659e03d4ef5b8c9f1529edf23da750504a78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890977Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#710937}
-
Anastasia Helfinstein authored
Bug: 1018327 Change-Id: I902c73eb55ce39dd3e44760848650c249278e97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881607Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#710936}
-
Vlad Tsyrklevich authored
Bug: 1018834 Change-Id: I7d2d95afa7baa51aa5305bc3e3f32583773553cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891014 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#710935}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f752e377..185ae4c0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42a2cb718db91d59d25efe3953f95cb1198daf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891070Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710934}
-
Robbie McElrath authored
This moves the template rules that generate WebView's AndroidManifests to //aw/apk/BUILD.gn since the templates live in //aw/apk/java. Test: ninja -C out/aw Bug: 934152 Change-Id: Ia00432d9bb9d4ae0a34755c40426916e1635d2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880964Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#710933}
-
Joe DeBlasio authored
This CL just updates enums.xml's definition of ChromeDownloadSource to match the one in the code. Change-Id: I0160d8986f6c542f58bac2891b55089d7f6e6a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891016 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710932}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d56bdc1447a..e15140656112 Created with: gclient setdep -r src-internal@e15140656112 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7fd0573620afe022d7c511452df1be04136aa114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890839Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710931}
-
Jasper Chapman-Black authored
This mirrors the JS SuperSize implementation in supporting two regex parameters, for whitelisting and blacklisting. std::regex is two orders of magnitude too slow, so I've brought in RE2 from /third_party/. The front-end has code to validate input regexes and display a user-facing error in case of invalid input - this justified squashing any regex-parsing errors encountered on the WebAssembly side. Bug: 1011921 Change-Id: I36b73815d4fd72142580b78cf5ff08fc595990bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891113 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#710930}
-
Ken MacKay authored
Change-Id: I300499d16e732092e206abb746146b25c3f224c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891135Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#710929}
-
Kaan Alsan authored
When scroll snapping occurs, the id(s) of the snapped element(s) will be recorded. The recorded ids are currently not used, but will be used in subsequent patches to re-snap to the same elements on layout changes. See doc for more information: https://docs.google.com/document/d/1OFJz43xrOsyeM0lqlhulfTGG_zfRJVQBmis7ZKzKIls/edit?usp=sharing Bug: 866127 Change-Id: If577e4a8302f98c5f96e246b9cb1410e90262ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845673Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kaan Alsan <alsan@google.com> Cr-Commit-Position: refs/heads/master@{#710928}
-
Kevin Marshall authored
Parses and properly handles values given to the "Range" HTTP request header. Fixes an issue which was preventing the playback of media files, which stream their input from at least one GET request. Test: playback of large media file now works well (Big Buck Bunny). Bug: 1018917 Change-Id: Ie09ab51485114bdb4d82aae6268f4dce4230f201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884574Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#710927}
-
Dominic Farolino authored
This CL is a re-land of https://crrev.com/c/1786260, which was reverted due to an increased number of cancelled requests, because requests with null initiator origins were treated as cross-origin when generating the referrer string. Parts of Chrome beyond the web platform (e.g., file downloads) relied on these requests being treated as same-origin. We reverted the CL to unblock the Dev build release, and this CL is a re-land with fixes (below). This CL preserves the old behavior for requests that have null-initiators (i.e., these are considered same-origin with their referrer), but corrects the behavior for requests with non-null initiators (i.e., the initiator origin is correctly used to determine same-origin-ness). This is important because the initiator origin may not always be same-origin with a request's referrer. More information on this change can be found in: https://docs.google.com/document/d/1WO9LpuLHWpRCMCN1obXVX277cDGAohpmsb7nkNCzCyg/. The original patch description: > This CL addresses a problem with SecurityPolicy::GenerateReferrer > when it comes to checking the same-origin-ness of a request. The > WebAppSec Referrer Policy Standard defines a same-origin request [1] as > one where the request's origin and current URL are same-origin with > each other. This comparison is done in "determine a request's referrer" > algorithm. > The analogous place in our implementation is > SecurityPolicy::GenerateReferrer. Before this CL, GenerateReferrer would > determine a request's same-origin-ness by comparing the origin of the > request's referrer string and the origin of the request's current URL. > Most of the time this was sufficient, as the request's referrer string > is almost always same-origin with the request's origin (initiator > in Blink). With descendant module scripts and worklets however, the > origin of the request's referrer string and request's origin (initiator) > could be different, which breaks the correctness of our GenerateReferrer > method. > This CL introduces a blink::SecurityOrigin parameter to the > GenerateReferrer method, so that correct same-origin comparisons can be > carried out. In all GenerateReferrer call-sites, an appropriate origin > is passed in. > The original CL [2] was reverted because the semantics of > SecurityPolicy::GenerateReferrer were not kept in sync with the similar > logic in net::URLRequestJob::ComputeReferrerForPolicy, which caused a > DumpWithoutCrashing bug seen in https://crbug.com/1000614, and request > cancellations. This reland updates the ComputeReferrerForPolicy logic > to match the corresponding Blink logic, and includes documentation > mentioning that changes to one section should be reflected in the other. > This CL also includes web platform tests for the scenario in the > aforementioned bug, which pass with this CL, as well as net unit tests > for RedirectInfo and URLRequestJob. > [1]: https://www.w3.org/TR/referrer-policy/#same-origin-request > [2]: https://crrev.com/c/1768501 TBR=caseq@chromium.org, kinuko@chromium.org, kouhei@chromium.org, lizeb@chromium.org, nhiroki@chromium.org, tbansal@chromium.org, yhirano@chromium.org Bug: 786862 Change-Id: Ic49d17bb8db923edb99d9ee952a18b0355cdb115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808663Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#710926}
-
Haiyang Pan authored
This reverts commit 4a486dbc. Reason for revert: Seeing the pending time high for try builders in the morning (http://shortn/_qkZuxYtEdz). Speculative revert this CL Original change's description: > infra: Migrate builders to Goma RBE (Week 14b) > > CI builders: > - Android ASAN (dbg) > - Android arm Builder (dbg) > - Android arm64 Builder (dbg) > > Try builders: > - android_clang_dbg_recipe > - android_compile_dbg > - android_n5x_swarming_dbg > - android_arm64_dbg_recipe > - android-oreo-arm64-dbg > - android-pie-arm64-dbg > > Schedule of migration: > https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 > > Bug: 950413 > Change-Id: Ib7db8b4b6e0712153b05bcc97e7dc82085e44b78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875857 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Simon Que <sque@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709935} Bug: 950413 Change-Id: I7e3312624913f7c154e2c14bb72ce8442e1aa239 No-Try: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890997Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#710925}
-
anthonyvd authored
This reverts commit 8229a222. Reason for revert: Tentatively reverting because it seems like a possible culprit for this tree-closing failure: https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg/2029 Original change's description: > platform_window: Fix component builds > > The platform_window target is used from multiple components and should > therefore be a component itself. This is needed to avoid ODR violations. > > One ODR problem that currently can happen is the duplication of the > global boolean backing UseTestConfigForPlatformWindows(). > > Bug: 1019015 > > Change-Id: I935df9a2fb2c6df1fec887c45c332bc833db91b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889293 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Michael Spang <spang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710905} TBR=sky@chromium.org,spang@chromium.org Change-Id: I2c39a3dd1655cd20273ee82778b2421628b6fac9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891330Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#710924}
-
Ana Salazar authored
This changes the InkDropMode of several buttons in the System Tray from ON to ON_NO_GESTURE_HANDLER to stop showing the ripple for gesture events. Fixed: 1012822 Change-Id: I4a004c7db4d45ce67f25f0f8de4257beb5d51d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877450Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#710923}
-
Ian Struiksma authored
Several sites were failing on windows autofill tests. The main issue seems to be the resolution on windows bot that causes the sites to sometimes render differently than when they were recorded. One site needs different behavior for a button click on replay so added a new action that will first check for a different element's presence before trying to find the button to click. Updated site recipes for 5 sites, so cipd version was updated: sephora (removed a visibility constraint) indigo (same) newegg (added extra clicks to reset phone/zip fields to verify) rue21 (rerecorded site on smaller resolution and used click fallback) crate_and_barrel (forced payment page load) Bug: 984664 Change-Id: Ic7d11082a2b4af53779281fcd27dce65753bac37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888742 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#710922}
-
Greg Thompson authored
The ScopedTempDir must outlive anything that holds file(s) open within it; otherwise, it is unable to delete itself. BUG=546640 Change-Id: Ibf96099cd1e14c165f84759f5b92b0de838a6e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890321 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#710921}
-
Francois Doray authored
Tab freezing will ship on all desktop platforms, so the enterprise policy to disable it should be available on all desktop platforms. Bug: 844426 Change-Id: I0e2cfc34a34297ae48fd539d9534d6e11f56fa3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883870Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#710920}
-
Regan Hsu authored
Currently, when you enter and exit the preview mode, the list items (each wallpaper thumbnail in the current collection) lose their tabIndex and aria-label. This CL adds these properties back in so that the user can tab through and the title is read out in chromevox. Bug: 1005633 Change-Id: I60a2b2b5ea714d37bac440e9327d95b4867bc112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888377Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#710919}
-
anthonyvd authored
This reverts commit e26a5125. Reason for revert: Breaks this bot: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/6141 Original change's description: > [WebLayer] Fix crash when top controls view has 0 height > > This happens because the adapter and layer for the top controls is only > created once height and width are > 0. We were assuming this had already > been created in setTopControlsOffset(). > > Change-Id: Idf104f9d5c951c1fa8719fa30661dceae59b4887 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890492 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710897} TBR=sky@chromium.org,cduvall@chromium.org Change-Id: I8304cc6583bdd606a4d52e8bd60cdf5957f7d384 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890795Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#710918}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5f48430f8789cfa7fc2d2a677970b5293388ae5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890509Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710917}
-
Yang Guo authored
TBR=hkamila@chromium.org Bug: 1018177 Change-Id: I19bd3d7e1ee71899a248c0896a254fb9e2fbeeae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890073Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#710916}
-