- 08 Aug, 2018 40 commits
-
-
Esmael El-Moslimany authored
Bug: 870270 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib19dd0974d318468d602e0b220c0cc5c46a2bc31 Reviewed-on: https://chromium-review.googlesource.com/1161445 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581710}
-
Christopher Cameron authored
Move the following from BridgedNativeWidget to BridgedNativeWidgetHostImpl: - ui::Compositor (as RecyclableCompositorMac) - ui::LayerDelegate subclass - ui::LayerOwner subclass - ui::AcceleratedWidgetMacNSView subclass Update BridgedNativeWidgetHost interface to include methods to indicate the desired size and visibility of the ui::Compositor. Add methods to BridgedNativeWidget which will in the future be transferred to the abstract interface (when BridgedNativeWidget is renamed to BridgedNativeWidgetImpl, which I'm still putting off for merge-ability sake). - OnCompositorCreated indicates that the compositor is created and should receive size and visibility updates - SetCALayerParams sends the parameters needed to display the compositor contents in another process Bug: 859152 Change-Id: I62209be44035f6b2b596afeb827cd951f30ef40c Reviewed-on: https://chromium-review.googlesource.com/1166196 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#581709}
-
Jennifer Apacible authored
This change updates the background icon supplied by the UX designer. Bug: 872097 Change-Id: I82ce3f9fd1509ecf42045bd0ebf0179f72736f6a Reviewed-on: https://chromium-review.googlesource.com/1166445Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#581708}
-
Chase Phillips authored
Bug: 717812 Change-Id: Ief0d69e6b676a8fd7456a16acd221851f70bc13f Reviewed-on: https://chromium-review.googlesource.com/1164471 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#581707}
-
Minh X. Nguyen authored
Because of a change in the way update client handles extensions that were remove during the update process UpdateService can crash when handling update events emitted from UpdateClient. Bug: 868906, 869663 Change-Id: I78cf5075fab84075f8472edcb2428348794307fe Reviewed-on: https://chromium-review.googlesource.com/1155749 Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581706}
-
Becky Zhou authored
There are a number of buttons that rely on the old Button style that sets text attributes. We need to change them to use the pre-defined text styles instead. Bug: 872223 Change-Id: I57c5e65892b064c2e4456e3323611a35228ce545 Reviewed-on: https://chromium-review.googlesource.com/1167747 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581705}
-
mrefaat authored
I added task_started time to RemovalTask structure, this was dropped when this class was ported from content. Bug: 796231, 759229 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I19f44ef3a72685b1fbe398e2915b8fd842307541 Reviewed-on: https://chromium-review.googlesource.com/1164571Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#581704}
-
Takuto Ikuta authored
Specify neccessary python protos instead. This is for deterministic tarballs sent to swarming for sync_integration_tests execution. Bug: 869348 Change-Id: Ifc873081056b7ee19f13a5d819829a05e3179d45 Reviewed-on: https://chromium-review.googlesource.com/1167343Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#581703}
-
Christian Fremerey authored
Bug: 872065 Change-Id: If0de2e5cb8470e604bc97f1c3689ae8972888e6c Reviewed-on: https://chromium-review.googlesource.com/1167968Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#581702}
-
Scott Violet authored
This allows for multiple Envs at the same time. BUG=847992 TEST=covered by tests Change-Id: I20dda0f7e3fde50027c9c867562718e49152d238 Reviewed-on: https://chromium-review.googlesource.com/1167654Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581701}
-
Jacob Dufault authored
Bug: 854453 Change-Id: Id5cb3abcc0d41238c9a8c760faa6b10235a3781b Reviewed-on: https://chromium-review.googlesource.com/1142234 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#581700}
-
Theresa authored
Center the EoC icon in its bounding box when Duet is enabled. BUG=859592 Change-Id: I7c1e016e2454ab5abb212c229b3b16450b553e7b Reviewed-on: https://chromium-review.googlesource.com/1166245Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581699}
-
Moe Ahmadi authored
Fixes the crash in ConfirmInfoBarController and potentially translate infobar controllers after the refactoring of infobars in crrev.com/c/1037640. It does so by setting |delegate| to nullptr on the InfoBarController instance before InfoBarIOS is destroyed. Bug: 870339 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I82cca094b9d0cc7fa01f19cae83aa1930fb71a64 Reviewed-on: https://chromium-review.googlesource.com/1161324Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581698}
-
Robbie McElrath authored
The NetworkConnectionTracker instance currently lives in g_browser_process, but we need the tracker in //content, which can't access //chrome. This adds a static getter in network_service_instance.h, which can be used in //content. Bug: 821009 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iaedb89cf2d27f75e0b896d7fd7389ceab3fe4682 Reviewed-on: https://chromium-review.googlesource.com/1162888Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#581697}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/94ec5e5e83b9..e41df534852b git log 94ec5e5e83b9..e41df534852b --date=short --no-merges --format='%ad %ae %s' 2018-08-08 dgarrett@google.com chromeos_config: Add eve-chrome-pfq. Created with: gclient setdep -r src/third_party/chromite@e41df534852b The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0dee8a6e981cbbb712efb0557e00979f8aebecb7 Reviewed-on: https://chromium-review.googlesource.com/1167822Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581696}
-
Dominik Laskowski authored
The set_bounds request, which supersedes set_window_geometry, allows the client to specify a target display such that window bounds are expressed in display rather than screen coordinates. Bug: b:77972398 Test: None Change-Id: I6c229e72bf2160b86067e768b31f1ac5148d4aff Reviewed-on: https://chromium-review.googlesource.com/1164553 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#581695}
-
Bill Orr authored
This change creates a service for hosting desktop VR devices so they can be run at the appropriate level of sandboxing required to ship. The browser process will consume this service to enable WebVR/WebXR support to ship on Windows. Currently the service runs in a utility process with no sandbox. A subsequent change will enable an appropriate sandbox behind a flag to enable testing. Bug: 795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5d602f4db91bcd1ddb5a3edf535f90e126004d4a Reviewed-on: https://chromium-review.googlesource.com/1155754Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581694}
-
Wei-Yin Chen (陳威尹) authored
Bug: 367595 Change-Id: I940257b49fce15310dc680c0b7c283f48ae681cf Reviewed-on: https://chromium-review.googlesource.com/1164580Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581693}
-
Ted Choc authored
This reverts commit f86a758d. Reason for revert: Breaks x86 bots https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20x64%20Builder%20%28dbg%29/28950 Original change's description: > [vr] Make VR Java android_library and separate VR JNI registration > > This CL does two things: > > - In order to move VR Java code into its own module move the code into a > separate android_library target. > > - As a result of the separate library target we may miss making the VR > JNI registrations (in case VR moves out of chrome_public_apk). Thus, > separate the JNI registration generation for VR and register VR JNI > calls in VR code. > > Bug: 862694 > Change-Id: I2b78cea7b30725d5f2b51afbcac1a6add555f355 > Reviewed-on: https://chromium-review.googlesource.com/1158715 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581576} TBR=mthiesse@chromium.org,agrieve@chromium.org,tiborg@chromium.org Change-Id: Iccac3c8981c21fe105799e045f1629dbd99fb7c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862694 Reviewed-on: https://chromium-review.googlesource.com/1168043Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#581692}
-
Ted Choc authored
BUG=800033 Change-Id: I0007ae432782e4222f1eed4aad03259a9e25a784 Reviewed-on: https://chromium-review.googlesource.com/1167556Reviewed-by:
-
Vlad Tsyrklevich authored
Bug: 864705 Change-Id: I8ebce1fd5911f90b8313a27f9d9e11e229ec0b6b Reviewed-on: https://chromium-review.googlesource.com/1162757 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
-
Adam Langley authored
This change drops GeoTrust from the pinning set and adds GIA G3 and another GTS intermediate, 1O1. GIA G2 remains in the pinning set because it's still valid until the end of 2018 and some Google properties may be using it. But the vast majority of Google properties are now using GlobalSign R2 and the GIA G3 and 1O1 intermediates. Change-Id: Ia4765525f419e654295199aa654e25c955affb47 Reviewed-on: https://chromium-review.googlesource.com/1166224Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#581689}
-
Weidong Guo authored
Background: There are several corner cases that home launcher is not shown: 1. Drag app list from shelf, meanwhile switch to tablet mode. 2. Drag app list to shelf after being opened, meanwhile switch to tablet mode. 3. Close app list and, during the close animation, switch to tablet mode. Changes: 1. Ignore drag event from both shelf or app list and reset dragging state when tablet mode is on. 2. Immediately stop close animation before reshow app list when tablet mode is on. Bug: 872072,871923 Change-Id: I5bd7dae242d84e2f0a82839693fbd36930f8e613 Reviewed-on: https://chromium-review.googlesource.com/1167658Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581688}
-
liberato@chromium.org authored
Previously, MediaCodecVideoDecoder would only release codec buffers when starting a drain if it wasn't going to elide the drain itself. However, since the drain (elided or not) is going to be followed by a codec flush or destruction, we still invalidate any unrendered output buffers. While this isn't techincally required, AVDA did it and seems to have much fewer codec hangs. Bug: 869365 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I903301950e190b64d8618b06689cbf9d184a96c9 Reviewed-on: https://chromium-review.googlesource.com/1167797Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#581687}
-
Clark DuVall authored
Bug: 729848 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I47030b560c2187c6cb48217338f071400539cd08 Reviewed-on: https://chromium-review.googlesource.com/1167801Reviewed-by:
-
Tessa Nijssen authored
Enabling the experimental UI flag, chrome://flags#upcoming-ui-features, will now enable the text suggestions touch bar. Bug: 717553 Change-Id: Ib78dc1298d548bd3548441667ab4f46e62f3b98a Reviewed-on: https://chromium-review.googlesource.com/1167800 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581685}
-
Min Qin authored
Seems no one is using these UMAs any more, removing them BUG=871462 Change-Id: Ifd8e4c3cb5af7dfe4866c97f1b2cdb279c4697ab Reviewed-on: https://chromium-review.googlesource.com/1166161Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581684}
-
David Tseng authored
This reverts commit a173bcea. Reason for revert: <INSERT REASONING HERE> Still hunting chromeos dbg failures. Original change's description: > Reland "Always build ChromeVox as compressed js" > > This reverts commit 9871f52a. > > Reason for revert: <INSERT REASONING HERE> > Was not the culprit of failing chromeos dbg SpokenFeedbackTests. > > > Original change's description: > > Revert "Always build ChromeVox as compressed js" > > > > This reverts commit 725ceeda. > > > > Reason for revert: Broke lots of tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg > > > > chromevox test: > > BackgroundTest.NavigationEscapesEdit > > > > interactive_ui_tests > > TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/1 > > LoggedInSpokenFeedbackTest.KeyboardShortcutViewer > > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1 > > GuestSpokenFeedbackTest.FocusToolbar > > > > > > Original change's description: > > > Always build ChromeVox as compressed js > > > > > > ChromeVox can be run as both compressed (minified js) and uncompressed. The latter facilitates faster development. > > > > > > It appears that in some instances, with the kevin board in particular, gn evaluates the ChromeVox build file incorrectly. > > > > > > The end result is we end up with both uncompressed and compressed js files in ChromeVox leading to duplicate js objects. > > > > > > Bug: 868579 > > > Test: clean build for > > > 1. prior to this patch > > > 2. after this patch > > > > > > Before each deployment, ensure we delete the chromevox folder on-device. This should be equilvanet to a new image. > > > > > > Change-Id: I64cf826bda9239edc7764ba598bfed6dd0572d56 > > > Reviewed-on: https://chromium-review.googlesource.com/1165787 > > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > > Commit-Queue: David Tseng <dtseng@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#581325} > > > > TBR=dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com > > > > Change-Id: Ifb3c2556f44b07161f491b18b49d556e364963fb > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 868579 > > Reviewed-on: https://chromium-review.googlesource.com/1167442 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: Avi Drissman <avi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581564} > > TBR=avi@chromium.org,dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com > > Change-Id: Ifb1ec50fd3cbaa1e0b97a5b5cfdb7b3b9712b353 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 868579 > Reviewed-on: https://chromium-review.googlesource.com/1167604 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581609} TBR=avi@chromium.org,dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com Change-Id: I8beec8a3003a2a7254fb987650410bd7289b4478 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868579 Reviewed-on: https://chromium-review.googlesource.com/1168042Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581683}
-
Nico Weber authored
Instead, copy the runtime to the build dir at build time and find it there at test time. Matches how things work on other platforms with the asan runtime in a shared library (mac/ios/win). This also makes things do the right thing with a custom clang_base_path. Bug: 872278 Change-Id: I930bd88206f973c10eb47bfd2f132e70167235f4 Reviewed-on: https://chromium-review.googlesource.com/1167465Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581682}
-
Oystein Eftevaag authored
This is needed to avoid duplicating the list of supported Perfetto platforms everywhere, and there's additionally situations where it's tricky to enable feature flags conditionally per platform (perf tests). Print out an error message instead, for debugging. R=primiano@chromium.org Change-Id: I4bdce82c4d8d8a9bad13aec482c06c78510cb360 Reviewed-on: https://chromium-review.googlesource.com/1162758 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#581681}
-
Muyuan Li authored
Ash uses 0 - 100 while assistant uses 0.0 - 1.0 for volume. We convert it in assistant platform volume control impl. Bug: b/111768214 Test: None Change-Id: I5e01c1512065e5711f7463662e4f286068599b65 Reviewed-on: https://chromium-review.googlesource.com/1166449Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#581680}
-
Christian Fremerey authored
This reverts commit 545410e6. Reason for revert: A different fix for the initialization had already landed by now, see https://chromium-review.googlesource.com/c/chromium/src/+/1158316. I need to remove the extra initialization changes from my CL. Original change's description: > Reland [Media Recorder] Fix video freeze on short recording. Fix tab crash on initialize. > > Patch Set 1 is the original CL that got reverted. > Patch Set 2 fixes the reason for the revert. > > Reason for the revert was a memory leak during a unit test. This was caused by > a newly added DeleteSoon() causing the test to exist before all objects had > been released. The fix is to add a ScopedTaskEnvironment::RunUntilIdle() at > test teardown. > > Original CL description: > > Fixes an issue where VideoTrackRecorder when used in combination with > VEAEncoder and very short recording durations (just 1 frame) would > occasionally hold on to video frames forever, causing frame buffers > from the buffer pool to become permanently blocked, eventually leading > to video capture freezing. > > The cause was a circular ownership that would happen if only 1 frame > is recorded. > > This CL additionally fixes a crash that could happen on initialization > of VEAEncoder. This issue was revealed during testing of the above fix. > Since it is not 100% if this crash was masked by the other issue, and > would only start occurring with the above fix, I am making a fix for that > part of this CL as well. > > The cause for the crash issue was that class VEAEncoder, which uses > RefCountedThreadSafe<>, would post an asynchronous task from its > constructor. If this task would finish executing before the newly > constructed instance was assigned to a scoped_refptr<> by however > called the constructor, the instance would destroy itself, because > of the AddRef() and subsequent Release() done by the posting and > running of the asynchronous task. > > The fix for this is to use a new method Initialize() instead of > posting a task from the constructor. > > TBR=emircan@chromium.org > > Bug: 859610 > Change-Id: I120b60b4b5cdf7462e38a74b7c757af6b5e1a7d6 > Reviewed-on: https://chromium-review.googlesource.com/1167742 > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581672} TBR=emircan@chromium.org,chfremer@chromium.org Change-Id: I4794d8d76b78bd1ab86860230bc01f0f20d3bd18 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859610 Reviewed-on: https://chromium-review.googlesource.com/1167768Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#581679}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c93eeaab1526..c86c8b0cecf0 git log c93eeaab1526..c86c8b0cecf0 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 jmadill@chromium.org D3D9: Use angle::Result error pattern. Created with: gclient setdep -r src/third_party/angle@c86c8b0cecf0 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ifd7d79a2fab4fd8f5ccce36d8ebb8277dbd9ef4e Reviewed-on: https://chromium-review.googlesource.com/1167584Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581678}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f90277e7f4bd..6d9897b103ae git log f90277e7f4bd..6d9897b103ae --date=short --no-merges --format='%ad %ae %s' 2018-08-08 rharrison@chromium.org Limit size of expression list in FormCalc parser Created with: gclient setdep -r src/third_party/pdfium@6d9897b103ae The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:870385 TBR=dsinclair@chromium.org Change-Id: Ib8c25301849b63f476191caa4b969b013dec8deb Reviewed-on: https://chromium-review.googlesource.com/1167702Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581677}
-
Xida Chen authored
From the stack trace of the current crash report, we are not able to tell the gesture sequence, which makes it hard to debug. This CL adds a CrashKeyString in TouchActionFilter, and push necessary events into that string. When it crashes, we should be able to retrieve the gesture sequence from that crash key. Bug: 869375 Change-Id: Ieb7cf0839e4a062c23ec48cbaca72bd641f28a30 Reviewed-on: https://chromium-review.googlesource.com/1165586Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581676}
-
James Cook authored
There isn't a separate "classic" mode for ash anymore. Bug: 842365 Test: ash_unittests Change-Id: I52d758904cb0dc579e69e84c8ebd259e81aef7e2 Reviewed-on: https://chromium-review.googlesource.com/1167748Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#581675}
-
Mohamed Heikal authored
This cl provides an implementation of ViewStub that inflates the view on a background thread. It also has an implementation of AsyncViewProvider which is basically a promise of a view to allow deferring code to run until after the view is inflated. Bug: 762120 Change-Id: I1f01fbfde5a2717f2a0daacd7ec6a1421f81f3c6 Reviewed-on: https://chromium-review.googlesource.com/1159226 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#581674}
-
Christopher Cameron authored
Bug: 869570, 871948 Change-Id: I92312b385c7e38610aa92ad2e25a1b2fa0f192ff Reviewed-on: https://chromium-review.googlesource.com/1166205Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#581673}
-
Christian Fremerey authored
Patch Set 1 is the original CL that got reverted. Patch Set 2 fixes the reason for the revert. Reason for the revert was a memory leak during a unit test. This was caused by a newly added DeleteSoon() causing the test to exist before all objects had been released. The fix is to add a ScopedTaskEnvironment::RunUntilIdle() at test teardown. Original CL description: Fixes an issue where VideoTrackRecorder when used in combination with VEAEncoder and very short recording durations (just 1 frame) would occasionally hold on to video frames forever, causing frame buffers from the buffer pool to become permanently blocked, eventually leading to video capture freezing. The cause was a circular ownership that would happen if only 1 frame is recorded. This CL additionally fixes a crash that could happen on initialization of VEAEncoder. This issue was revealed during testing of the above fix. Since it is not 100% if this crash was masked by the other issue, and would only start occurring with the above fix, I am making a fix for that part of this CL as well. The cause for the crash issue was that class VEAEncoder, which uses RefCountedThreadSafe<>, would post an asynchronous task from its constructor. If this task would finish executing before the newly constructed instance was assigned to a scoped_refptr<> by however called the constructor, the instance would destroy itself, because of the AddRef() and subsequent Release() done by the posting and running of the asynchronous task. The fix for this is to use a new method Initialize() instead of posting a task from the constructor. TBR=emircan@chromium.org Bug: 859610 Change-Id: I120b60b4b5cdf7462e38a74b7c757af6b5e1a7d6 Reviewed-on: https://chromium-review.googlesource.com/1167742Reviewed-by:
-
Wez authored
Disable the ControllerHandlesTouchscreenGestureFling and ControllerSendsWheelEndWhenTouchpadFlingIsOver tests, which appear to have timing-dependent flakiness. Bug: 836996 Change-Id: I42b7b23489b4cf2dbb2fdacf89c77bd102ac03a8 Reviewed-on: https://chromium-review.googlesource.com/1166328Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
-
