- 04 Aug, 2017 40 commits
-
-
Patti authored
Make the Site Details web UI update the default permission strings when they change without needing to reload the Site Details page. Manual test - With #enable-site-details on, open https://permission.site. Open the Page Info bubble, click "Site settings" to open the Site Details page. Make sure the 'Location' setting is set to 'Ask (default)'. In a new window, open chrome://settings/content/location and put the two windows side by side. On chrome://settings/content/location, click the toggle to block location access by default, and verify the Site Details page drop-down value for location changes to 'Block (default)'. Bug: 656758 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id1c03acd9b636ea8463e382ae21cc646161267d9 Reviewed-on: https://chromium-review.googlesource.com/597030 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#491982}
-
Georg Neis authored
Bug: v8:6649 Change-Id: I79555121ce72bef536ca99365cc5b12c3a6496df Reviewed-on: https://chromium-review.googlesource.com/590369 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#491981}
-
Vasilii Sukhanov authored
Disable BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestBeforeUnloadAndDownloads/1 TBR=chrisha@chromium.org Bug: 749098 Change-Id: Ia814e450c72b65017025bb3eb11db49c31b1498e Reviewed-on: https://chromium-review.googlesource.com/601968Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491980}
-
Philip Jägenstedt authored
Based on the "Expected to timeout, but passed" and "Expected to fail, but passed" sections of a full run of LayoutTests/external/wpt on Linux Debug. Bug: 310004, 679742, 698256 Change-Id: Ifc5966c6e8d611b2deb67c56bf2fb06fe35e71d9 Reviewed-on: https://chromium-review.googlesource.com/599728Reviewed-by:
Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#491979}
-
Dominik Röttsches authored
Allow ranges for font-style in @font-face, compare https://drafts.csswg.org/css-fonts-4/#font-prop-desc and support the oblique <angle> style property of CSS Fonts Level 4. Bug: 749091 Change-Id: I7888f2f01f3cda8ec1b8d5c13b884f75b1790e50 Reviewed-on: https://chromium-review.googlesource.com/600228 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#491978}
-
Julien Brianceau authored
Bug: 750830 Change-Id: I98830d02a56b733dc5e631a8e10d9e55e2a5a6fb Reviewed-on: https://chromium-review.googlesource.com/600327Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Julien Brianceau <jbriance@cisco.com> Cr-Commit-Position: refs/heads/master@{#491977}
-
Vasilii Sukhanov authored
This reverts commit e03b42cc. Reason for revert: both tests timeout quite reliably on Win10 Tests x64 (https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/14362) Original change's description: > Enable WebNavigationApiTest.CrossProcess(History|Fragment). > > Bug: 708139 > Change-Id: Idb9eb18755219be4164b6fc2585aa43ed9798dc1 > Reviewed-on: https://chromium-review.googlesource.com/601027 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491836} TBR=nasko@chromium.org,alexmos@chromium.org Change-Id: Iee6a4124181b0e7761a5c77e1f65ea3cda23d4d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 708139 Reviewed-on: https://chromium-review.googlesource.com/601948Reviewed-by:
-
Philip Jägenstedt authored
Bug: 734121 Change-Id: I3393aeda531cde0b4d12644a362a8ba299e0aafe Reviewed-on: https://chromium-review.googlesource.com/597849 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#491975}
-
Thiemo Nagel authored
We'll never ship an update to x86-{alex, mario, zgb} again thus there's no use in keeping the special cases around. Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I150a4b50d3347767f94dbc0e01019cef979a134f Reviewed-on: https://chromium-review.googlesource.com/581188Reviewed-by:Valery Arkhangorodsky <varkha@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491974}
-
Adam Rice authored
The ReadableStream constructor uses the String function. However, the implementation was failing to take a copy of the function. This meant that the version from the Javascript environment was used. If it had been modified then it could result in incorrect behaviour. Use a copy of the original value of the String function in ReadableStream. This change also includes a regression test. BUG=752177 Change-Id: I52f36244a9d87131219958837e3cee00a8fc5fb4 Reviewed-on: https://chromium-review.googlesource.com/601668Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#491973}
-
Shuhei Takahashi authored
This function will be used in Recent. As a bonus, unit tests are added. Bug: 742722 Test: unit_tests Change-Id: I0c5d6271e7845fb0d7f86047414f652e049348f3 Reviewed-on: https://chromium-review.googlesource.com/588811 Commit-Queue: Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491972}
-
Vasilii Sukhanov authored
TBR=dtseng@chromium.org Bug: 719930 Change-Id: I98bb00242238f059b7a43fc26147751fdc3e1168 Reviewed-on: https://chromium-review.googlesource.com/601908Reviewed-by:
-
gambard authored
The privacy setting strings for the suggestions is confusing. This CL disambiguate them. Bug: 751731 Change-Id: I1e91133b085b73d35553337c9341fda15234f7d1 Reviewed-on: https://chromium-review.googlesource.com/599870Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#491970}
-
Georg Neis authored
Bug: chromium:748544 Change-Id: I9458ea9c25d65bc31ff34dc8101936468ed2bf81 Reviewed-on: https://chromium-review.googlesource.com/589434Reviewed-by:
-
Shuhei Takahashi authored
This change introduces core concepts of Recent file system: RecentModel: The most important class owning RecentSources. The only API it provides is GetRecentFiles() which queries RecentSources for recently modified files and build a list of recently modified files across file systems, and also caches the result for better file system operation performance. Files are represented as FileSystemURL. RecentSource: Interface class for a source of recent files. This interface will be implemented for several sources such as local storages and cloud storages so that they appear in Recent file system. RecentContext: Holds several "context" objects necessary for operations in RecentModel and RecentSource. Bug: 742722 Test: unit_tests Change-Id: I2a2ff1fa28e8cf5c705ad1ee6bc75a39b49b2f0b Reviewed-on: https://chromium-review.googlesource.com/588950Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#491968}
-
Yusuke Sato authored
This ends up sending two D-Bus messages to session_manager, and it is guaranteed that the message for starting ARC instance is always sent first. This is because Chrome (with crrev.com/488879) sends the D-Bus method directly in StartArc() without any thread hops. BUG=b:64327302 TEST=try, manually went through ARC opt-in Change-Id: I97c4779b2ed5827b46559f9f7571a1090b4ced68 Reviewed-on: https://chromium-review.googlesource.com/601768 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/bad5ad7d601b..5910ed347a63 $ git log bad5ad7d6..5910ed347 --date=short --no-merges --format='%ad %ae %s' 2017-08-03 mtklein 15-bit lowp is dead, long live 8-bit lowp 2017-08-04 skia-deps-roller Roll skia/third_party/externals/angle2/ 13c0dd463..53440f39c (1 commit) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Ic2866ec9c147d544e2185748dd9adaced0c5096b Reviewed-on: https://chromium-review.googlesource.com/601371Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491966}
-
tzik authored
Change-Id: Icb8f3be6610108b08ea111f60f59e7f914dfc1fe Reviewed-on: https://chromium-review.googlesource.com/599142Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#491965}
-
Marc Treib authored
Bug: 690467 Change-Id: Icd90a52d66d7d6b8734398de6707f18e762cd06b Reviewed-on: https://chromium-review.googlesource.com/600309Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#491964}
-
Kent Tamura authored
The following tests are removed because they are covered by html/dom/reflection-forms.html in WPT. - fast/dom/HTMLInputElement/input-size-attribute.html - fast/dom/HTMLInputElement/size-as-number.html - fast/dom/HTMLInputElement/size-attribute.html TBR=kochi@chromium.org Bug: 685886 Change-Id: I4afaa32bffb9e6ff377a5c734a9bb4c758d27d24 Reviewed-on: https://chromium-review.googlesource.com/601693 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#491963}
-
jgruber authored
Coverage information has changed granularity. Bug: v8:6000 Change-Id: Ic18d82e9523145d4323807598e05943ff2d4bfd3 Reviewed-on: https://chromium-review.googlesource.com/596049 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#491962}
-
Eddy Mead authored
We don't use files with the extension ".in" any more, as they have been replaced with the more standard ".json5" format. Change-Id: I54b8acf9d93b0711d54baf9685baaeeeeea8715c Reviewed-on: https://chromium-review.googlesource.com/601769Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#491961}
-
Xiaohan Wang authored
Some DemuxerStream could hit non-recoverable fatal errors. For example, DecryptingDemuxerStream cannot decrypt a buffer because the CDM was crashed. This CL adds a new kError status to DemuxerStream::Status to indicate such conditions. BUG=730766 TEST=New unittests added. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia07e14662d7da852f712076dcc94aed1900aaba3 Reviewed-on: https://chromium-review.googlesource.com/598702 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#491960}
-
Xiaocheng Hu authored
This patch makes idle time spell checker consider the possibility of typing in a partial word even with closed typing command, so that we won't be marking partial words due to JS closing typing command in the middle of typing. Bug: 749934 Change-Id: I426392adf69c30803a5c6de475680c2c9d55cfc5 Reviewed-on: https://chromium-review.googlesource.com/592789 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491959}
-
Takeshi Yoshino authored
Source/web/WebExport.h was deleted in https://chromium-review.googlesource.com/c/599139. It's no longer needed. It could be used to follow what tkent@ said in https://chromium-review.googlesource.com/c/593515#message-691de0a91dadbd213f5e762b32917f796c3e4aae but given Onion Soup 2.0 is ongoing, we can just skip it. Bug: Change-Id: I0abdbfa7a94a2bf25363daddec2417e461110dda Reviewed-on: https://chromium-review.googlesource.com/600567 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#491958}
-
Vitalii Iarko authored
Bug: Change-Id: I0a82da04c6c197b41eb4ac2f9e0e5246c4b6261b Reviewed-on: https://chromium-review.googlesource.com/599048 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#491957}
-
Vitalii Iarko authored
GCM token may become invalid (it is stored on disk and may be corrupted). Therefore, this CL adds a periodical check (at least 24 hours, without waking up) of the current token validity. If it is invalid, then a new token is retrieved and used to resubscribe to our server. Bug: 742240 Change-Id: I27d873049c6dbc7ff8c3ad0471cf20ca7f754d53 Reviewed-on: https://chromium-review.googlesource.com/574232Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491956}
-
Trent Apted authored
Apple doesn't ship a MEDIUM weight font in 10.11 or 10.9. The font system will upgrade it to BOLD (this is covered by tests in platform_font_mac_unittests.mm). BOLD is too bold for buttons in UI, so use a NORMAL weight. Bug: 751414 Change-Id: I5dbac5a165120c919a92476f9fce6747c7e733c1 Reviewed-on: https://chromium-review.googlesource.com/597511 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#491955}
-
Renee Wright authored
First change for Ribbonizing CSSPropertyMetadata. Splits up the existing CSSPropertyAPI groups based on different behavior for CSSPropertyMetadata methods IsInterpolableProperty, IsInheritedProperty, PropertySupportsPercentage, PropertyIsRepeated & RepititionSeparator. IsDescriptor, IsEnabledProperty and FilterEnabledCSSPropertiesIntoVector will be handled later. CSSPropertyAPIs have been split as follows - CSSPropertyAPIColor - CSSPropertyAPIColor - CSSPropertyAPIBackgroundColor - CSSPropertyAPIColorNoQuirks - CSSPropertyAPIColorNoQuirksInherited - CSSPropertyAPIColorNoQuirksNonInherited - CSSPropertyAPIWekbitTextStrokeColor - CSSPropertyAPIWebkitBorderColor - CSSPropertyAPIFragmentation - CSSPropertyAPIOrphansOrWidows - CSSPropertyAPIWebkitBoxOrdinalGroup - CSSPropertyAPIImage - CSSPropertyAPIImageSource - CSSPropertyAPIListStyleImage - CSSPropertyAPIMargin - CSSPropertyAPIMargin - CSSPropertyAPIOffset - CSSPropertyAPIMarker - CSSPropertyAPIMarker - CSSPropertyAPIMask - CSSPropertyAPIOpacity - CSSPropertyAPIOpacityInherited - CSSPropertyAPIOpacityNonInherited - CSSPropertyAPIStrokeOrLength - CSSPropertyAPIStrokeDashoffsetOrStrokeWidth - CSSPropertyAPILength - CSSPropertyAPITextDecorationLine - CSSPropertyAPITextDecorationLine - CSSPropertyAPIWebkitTextDecorationsInEffect - CSSPropertyAPIWidthOrHeight - CSSPropertyAPIWidthOrHeight - CSSPropertyAPIMinWidthOrHeight BUG=751373 Change-Id: I299b8b9051adae3dac74a2eb905916fbb906b7dc Reviewed-on: https://chromium-review.googlesource.com/597369 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#491954}
-
Nicholas Verne authored
Delete the last web/ cpp file. Bug: 712963 Change-Id: I2a8f5d514285121fa5b3512718baddc9ccaf2e24 Reviewed-on: https://chromium-review.googlesource.com/601609 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
Yusuke Sato authored
This CL depends on crrev.com/488879. See CL:601768 for more details. BUG=b:64327302 TEST=try Change-Id: I7158787dcb852d84ed78032ea51c97e3dce8cea0 Reviewed-on: https://chromium-review.googlesource.com/601772Reviewed-by:
-
Daichi Hirono authored
The CL lets Surface observe drag and drop events and delegates the events to DataDevice thorugh DataDeviceManager. Bug: b:31988797 Test: None Change-Id: I9574cd86137922d7527bd297d182a7b45e632c9e Reviewed-on: https://chromium-review.googlesource.com/579250 Commit-Queue: Daichi Hirono <hirono@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491951}
-
Darren Shen authored
Currently, when a CSSTokenizer is created from a String, the string is completely tokenized in the constructor. In order to make the css parser tokenize on demand, we do not tokenize everything in the constructor. Instead, we introduce a new class called CSSParserTokenStream that acts a streaming interface to the tokenizer. Eventually, this will have methods such as "Next" and "Peek" that tokenize on demand. For now, it just has a method to fully tokenize the input and returns the range. Hence, this patch simply moves full string tokenization from CSSTokenizer constructor to CSSParserTokenStream::MakeRangeToEOF(). The plan is to eventually replace (most) CSSParserTokenRanges with CSSParserTokenStreams. This patch replaces some of the top level parsing functions to use a CSSParserTokenStream. To call lower level parsing functions that use ranges, we convert these streams to ranges, which triggers a full tokenization. This is a temporary fallback to the current range system. Future patches will change those level parsing functions to use streams as well, layer by layer, so we won't need to trigger full tokenizations. Note that only one of the two constructors are affected by this patch. The other constructor uses observers and is more difficult to change. This patch does not change observable behaviour, and should not have any performance impacts (since we're just delaying when the string gets fully tokenized). Bug: 661854 Change-Id: I6f20269835d806106e95740f8dcee6744d0de944 Reviewed-on: https://chromium-review.googlesource.com/595025Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
-
Mark Cogan authored
This CL fixes a couple of common crashes in CSChromium. - Entering a URL on the NTP caused a crash because the webState wasn't enabled when it was navigating. This is fixed by setting webUsageEnabled during -loadGURLFromLocationBar:transition: - Tapping some buttons in the toolbar would cause a crash in the tab container VC's -canPerformAction:withSender:, which was creating an array with objects that might be nil. This method was only needed to plumb responder chain events into contained view controllers, which has long since been replaced by dispatchers. Also, per the ObjC style guide, the exception raised in -subviewConstraints is replaced with a NOTREACHED(). Bug: Change-Id: Ic22bc6decfde97530434c95f318b72cf637aaf24 Reviewed-on: https://chromium-review.googlesource.com/594947Reviewed-by:
Ed Chin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#491949}
-
Kinuko Yasuda authored
Bug: 740070 Change-Id: I1b0983d8f4e0c49466edf176bc4a1c7f73105539 Reviewed-on: https://chromium-review.googlesource.com/599252 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#491948}
-
Daichi Hirono authored
DragDropObserver will be used by DataDevice instances to observe drag drop events. Bug: b:31988797 Test: None Change-Id: I67d15f81a59730f0d78da3d56f120a16d84a43b3 Reviewed-on: https://chromium-review.googlesource.com/578748 Commit-Queue: Daichi Hirono <hirono@chromium.org> Reviewed-by:
-
Walter Korman authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I100467a0c95efe3c686ae5e79e1e6e8da32b39ec Reviewed-on: https://chromium-review.googlesource.com/600823Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491946}
-
Peter Kasting authored
XXXTaskRunner xxx_thread_ -> xxx_task_runner_ RunOnXXXThread() -> RunOnXXXSequence() Follows https://chromium-review.googlesource.com/c/566181/ . Bug: None Change-Id: I87531313b20b3a8ec155f6dde4d066de3b3d802b Reviewed-on: https://chromium-review.googlesource.com/586387 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491945}
-
Jia authored
This cl also refactors util functions and moves them from CSSPropertyParser to CSSPropertyGridUtils and moves functions from CSSPropertyGridTemplateAreasUtils to CSSPropertyGridUtils as the functions are used by multiple grid-related properties, and we won't have to call one util file from another util file. The old version of several util functions parse property values and also add parsed values to the parsed-property-set, which means these util functions need to take shorthand property id as an input. A major change in this cl is splitting parsing and adding values. Adding property values will be handled by property API classes. The benefits of this refactoring are (i). util functions no longer need to take shorthand id as input, and thus become pure util functions. (ii). it is now more obvious which property values are added. Previously property values are added at different places, but now they are only added in the property API files. Functions below have major changes mentioned above. 1. ConsumeGridTemplateRowsAndAreasAndColumns - The old version parses and adds property values. - The new version only parses values and returns values to the caller. 2. ConsumeGridTemplateShorthand - The old version parses and adds property values (by calling ConsumeGridTemplateRowsAndAreasAndColumns for some cases). - The new version only parses values and returns values to the caller. It is shared by both grid and grid-template APIs. 3. ConsumGridShorthand - The old version is replaced by grid's parseShorthand method. - The old version parses property values both directly and indirectly (by calling ConsumeGridTemplateShorthand), and adds property values at different places. - The new version calls util functions for parsing only, and explicitly adds property values itself. Bug: 668012 Change-Id: I4808bd1f169bcad5b3d46a83fc897567f18a0e7e Reviewed-on: https://chromium-review.googlesource.com/595293 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Ken Rockot authored
BUG=740044 TBR=jcivelli@chromium.org Change-Id: Idaabb8ac8b1880987ab670bdde7216f06be88dee Reviewed-on: https://chromium-review.googlesource.com/601419Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#491943}
-
