- 24 Dec, 2019 29 commits
-
-
Eugene But authored
TBR=jlebel@chromium.org Bug: 1037676,1036840 Change-Id: I552d7cec1cab40b5ef9dae9271bb956a625fd71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981141Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#727312}
-
Eugene But authored
TBR=ajuma@chromium.org Bug: 1037663 Change-Id: I1fa106686e7cfedbbd43be0dc8b67917f74555b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981137 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Peter K. Lee authored
Reduce dependencies on Translate internals - Refactored some constants out into their own targets - Stopped using LanguageDetectionDetails where simple alternatives exist - Use url.SchemeIs() - Use executeJavaScript:error: from ChromeEarlGreyAppInterface - TranslateAppInterface setUp needs to be passed switch for HttpServer Bug: 987646 Change-Id: I4c47b9abca4a64d09a267b526dadc87cb10fe76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979768 Commit-Queue: Peter Lee <pkl@chromium.org> Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by:
-
Ian Struiksma authored
Test sign_in_pass/yahoo is failing on the bot. The log trace says: [25304:1:1220/102408.382835:FATAL:vector.h(1673)] Check failed: Allocator::IsAllocationAllowed(). Cannot reproduce locally, but crbug.com/1036593 looks like it is related. Disabling this test case with reference to the bug. Bug: 984664,1036593 Change-Id: I16a0f95af24b639f6fca0c5a0fc760980889c4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981121Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#727309}
-
Eugene But authored
TBR=olivierrobin@chromium.org Bug: 1036840,1037681 Change-Id: Ie0800e1856562015fe143e42bf8bc13140d981b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981144Reviewed-by:
-
Kurt Horimoto authored
The previous implementation of these tests relied on asynchronous view controller presentation as well as implementation details of InfobarCoordinator and InfobarContainerIOS. This CL updates these tests to instead directly call the public API of the tab helper. It also uses FakeInfobarIOS so that full InfobarCoordinator objects no longer need to be constructed for the tests to operate. Bug: none Change-Id: I09bc28758761d2c2c5068300b965cf565557e39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974579 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727307}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I7aa4c8198669e5597517be0ebe63ca2a8c43310c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980750Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#727306}
-
Oystein Eftevaag authored
NOTRY=true TBR=crouleau@chromium.org BUG=1037687 CC=rmcilroy@chromium.org Change-Id: Ic8f9c6ec9cd23636b024fba277ae25bb8d7cc193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980615Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#727305}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I342f8d52f6adc86ae6eb53ead89a56a50085e05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981034Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727304}
-
Gyuyoung Kim authored
This CL replaces .mojom.h with .mojom-forward.h in some sub-directories of chrome/browser/chromeos to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - chrome/browser/chromeos/chrostini - chrome/browser/chromeos/extensions - chrome/browser/chromeos/file_manager This CL has no behavior changes. Bug: 1001360 Change-Id: I328a62f1b269139a0138d8e7fbaf677e9590bddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974307Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#727303}
-
Jason Lin authored
Bug: 999950 Change-Id: I03ce5446f7eb0468a9c24b084b37b039a6fe2fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952045Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#727302}
-
Oystein Eftevaag authored
This pageset has been failing since it got added. NOTRY=true TBR=crouleau@chromium.org BUG=1037687 CC=rmcilroy@chromium.org Change-Id: I6e34c9f1f61276ab0715bc022d04afd37d777b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980215Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/07f0f019e397..e2fc92ca28ef git log 07f0f019e397..e2fc92ca28ef --date=short --first-parent --format='%ad %ae %s' 2019-12-23 syoussefi@chromium.org Vulkan: Fix swiftshader device selection Created with: gclient setdep -r src/third_party/angle@e2fc92ca28ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I1fe26e778b49e35fcc9ea4d5f80a24e7b6e9f2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980935Reviewed-by:
-
Demetrios Papadopoulos authored
The rule disallows == in favor of ===, and != in favor of !==, which matches the Google JS styleguide (which Chromium's JS styleguide inherits from). Bug: 720034 Change-Id: Id257bce33e681ad227ff5bd4212b1f8d3c28b867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980214Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#727299}
-
http://browserbench.org/SpeedometerOystein Eftevaag authored
Fails on all perf bots. TBR=crouleau@chromium.org NOTRY=true Bug: 1037682 Change-Id: I9aba42d9cd45b6f250cf6d7ff86fe31148ca9aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980179 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
During dragging, if a window needs to be scaled down to the shelf, the corresponding shelf item bounds is calculated based on a extended hotseat, thus the window actually scaled down to the shelf item in a kExtended hotseat, not in a kShown hotseat. In order to scale down to a kShown hotseat, we need to adjust the shelf item bounds. Bug: 1036951 Change-Id: Iacf630727f69839cef1f7b402d51d7af2f29038c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981136Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#727297}
-
Hiroki Sato authored
In ARC++, when Select-to-Speak is enabled, |AccessibilityFilterType| is set ALL, and focus highlight didn't work with it. This CL fixes it by keeping track of whether the focus highlight is enabled, and makes focus highlight work with S2S. Bug: b:146473345 Test: manual. Enable S2S and "highlight object with keyboard focus" and input focus is highlighted as expected. Change-Id: I1b3b156038479b9c41c8aca9574a38304895b609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972743Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#727296}
-
Gyuyoung Kim authored
This CL removes unnecessary Create() factory functions in //third_partyb/blink/renderer/modules only when it meets the policy of removing Create() so that we support only one of Create() methods or public constructors in a class. Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below Create() functions, - BackgroundFetchManager::Create - PeriodicSyncManager::Create - SyncManager::Create - IDBAny::CreateUndefined() - IDBAny::CreateNull() - PaymentManager::Create - WebGLVertexArrayObjectOES::Create - WebGLCompressedTextureASTC::Create - WebGLDrawInstancedBaseVertexBaseInstance::Create Bug: 939691 Change-Id: Idf930e7ba073b110c90803e2ba509695480d12bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980527Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#727295}
-
Gyuyoung Kim authored
This CL removes unnecessary Create() factory functions in //third_partyb/blink/renderer/core only when it meets the policy of removing Create() so that we support only one of Create() methods or public constructors in a class. Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below Create() functions, - InsertIncrementalTextCommand::Create - InspectorStyleSheetForInlineStyle::Create - NetworkResourcesData::Create Bug: 939691 Change-Id: I003a97c5dfe37f780f25af9f9a36138cffb76a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980525Reviewed-by:
-
Fabrice de Gans-Riberi authored
The test is flaky. TBR=fdegans@chromium.org Bug: 1036570 Change-Id: If7d2f42c1a320692768b5fe6872e7df47313c590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980760Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727293}
-
Sam McNally authored
Bug: 912281 Tbr: fukino@chromium.org Change-Id: I339af2344343ee668d3e54e83542707d4e215b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945947 Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#727292}
-
Demetrios Papadopoulos authored
It has been enabled by default, and no longer need to support the case where the flag is off. Moreover, the flag is already not honored by several codepaths that used to honor it, as the cleanup work has already begun. Bug: 1026455 Change-Id: I49c2f37d5cfefe551f575481c91774b7d6995aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977203Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#727291}
-
Robert Liao authored
BUG= TBR=pkasting@chromium.org clang-tidy changes. Change-Id: Ib794e79c79afac80147e0477c25d34098da0cee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980316Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#727290}
-
Mike Dougherty authored
Breadcrumbs need to be attached to crash reports before upload. Ideally, |BreadcrumbPersistentStorageKeyedService| instances would store breadcrumbs associated with each browser state in their respective storage directories. However, this would then require using |BreadcrumbController setParametersToAddAtUploadTime:| which must be called before breakpad is started and the state of the |kLogBreadcrumbs| feature flag is not yet available for use before breakpad is started. Attaching breadcrumbs in this way would also require merging and sorting multiple breadcrumb files during the primary launch flow of the application which may impact time to cold launch performance. Therefore, in order to attach beadcrumb events to breakpad crash logs, create a |CrashReporterBreadcrumbObserver| crash report helper object. Although it is not ideal that this object is a singleton, it follows the pattern of other similar classes defined in crash_report_helper.mm. The class was added to its own file to allow for the creation of some minimal unittests. In order to support this class a BreadcrumbManagerObserverBridge was added. This process can be improved once crashpad is adopted as it supports upload streaming of files on disk. Bug: 1003922 Change-Id: I9eb21d390a27a0c69e64397fbb82cabcc1ea2979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979449Reviewed-by:
-
Fabrice de Gans-Riberi authored
fast/forms/number/number-input-event-composed.html fails consistently on the WebKit Linux Leak bot. Sample failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/8620 TBR=fdegans@chromium.org Bug: 1035582 Change-Id: I047a6d73371d14b51c77384a6054bbf5a2f11f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981123Reviewed-by:
-
Jason Lin authored
CrostiniInstaller incorrectly reports "mount container error" when: 1. installation failed at "creating container" step, and 2. some rare issues (e.g. vm shuts down during installation) happened and the installer received the error only from the finish callback but not the observer callback. This CL fixes these by 1. handling "creating container" failure correctly (reporting SetupResult::kErrorOffline or the new kErrorCreateContainer); 2. reporting the new SetupResult::kErrorUnknown if the rare issues happen. The installer UI will also display corresponding error messages. See the discussion in the bug for more details. Bug: 1026199 Change-Id: Id6c73d4f603c69b08adb2038cacf8380c3a59b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965784 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#727287}
-
Kurt Horimoto authored
The wrong class selector was mistakenly used when refactoring. This CL updates to use the correct selector that is queried by the presentation context. Bug: none Change-Id: Iff711ef6f5f7261edcb37bca87922ef7ae729238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981116 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727286}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9ad288ade0a9..dda54b59351e git log 9ad288ade0a9..dda54b59351e --date=short --first-parent --format='%ad %ae %s' 2019-12-23 fdegans@chromium.org Disable TracingControllerTest.testFlushTracing on Mac. Created with: gclient setdep -r src/third_party/catapult@dda54b59351e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:947675 Tbr: oysteine@google.com Change-Id: I453bc3d60e64c1bafbecac7083dc2dd28c330285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980936Reviewed-by:
-
Natalie Chouinard authored
Use of java_files is being deprecated in favor of sources. Update documentation that still references java_files. TBR=aluo,bialpio,dpranke,pasko Bug: 1035082 Change-Id: Ibcab73a9d90e010cdffd3018d3fd238662945f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980981Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727284}
-
- 23 Dec, 2019 11 commits
-
-
Andrew Xu authored
(1) In shelf_view_unittest.cc, the test waits until the shelf app removal animation finishes. (2) In power_button_controller_unittest.cc, tap location is changed to fix the test. TBR=xiyuan@chromium.org Bug: 1032702 Change-Id: Iab90a15618dcf7c014770f24b25e69c7530e1f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981132Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727283}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e5d36ed0a1f0..070d459567f5 Created with: gclient setdep -r src-internal@070d459567f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I39dc5e7cb5d191d77a356410705f5183d88b28a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980978Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727282}
-
Ted Meyer authored
MediaError will take advantage of this change, (which will help explain the separation of media_serializers_base.h). In the followup CL. Change-Id: I0048b1d8e8670e62f895d4519bc81ddb6aaf18f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979354 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#727281}
-
Mikhail Khokhlov authored
Trace processor shell has limited command line parsing capabilities on Windows; currently it supports only a subset of flags and only in specific order. This CL brings the order of flags in accordance with how the TP shell expects it. Bug: 1028612 Change-Id: If8046d43e82bb55570a1ab2422286e336ce5bfc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980611Reviewed-by:
-
Robert Woods authored
In this CL: - Save FileHandlers to WebAppDatabase - Implement GetAllFileHandlers in WebAppFileHandlerManager Bug: 938103 Change-Id: I64a2115dc800b8216f7899d9f83ae19586b45db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958297 Commit-Queue: Robert Woods <robertwoods@google.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#727279}
-
David Munro authored
Bug: None Test: None Change-Id: I0f6945b91d4a5597928b472804a3b01cddb49663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980333 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#727278}
-
sczs authored
Change-Id: I31e619bc9a063e2410c7dca505dcd3506ae4c342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981089Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727277}
-
Jing Wang authored
Change the error format with function name, now put function at front. Also avoid multiple-line error message. Bug: 1024606 Change-Id: I23f4db9cdec469eede696a1a5c730b072d6f786f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971042 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#727276}
-
Khushal authored
This marks a few tests as RetryOnFailure which are flaky on this bot. R=kbr@chromium.org Bug: 1037650 Change-Id: I08d873bc0a4f579ebba27edc3c34adaf21b8f477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981111 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727275}
-
Eugene But authored
EG2 version of the test is failing on the bots. TBR=stkhapugin@chromium.org Bug: 1037651 Change-Id: I05a0b8b986e7dcf8c424ad4e090485a167b357e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981114Reviewed-by:
-
Kurt Horimoto authored
This CL updates InfobarBadgeTabModel to use InfoBarIOS::Observer callbacks to detect infobar accept/revert events, deprecating the public API previously used to relay this information. Additionally, this CL decomposes observer functionality into internal classes in order to allow easily hooking up multiple scoped observers. Using nested classes also helps to minimize the publicly-accessible InfobarBadgeTabHelper API, preventing it from being misused. This CL also updates the badge models to be stored in an std::map to avoid the extra step of converting the InfobarType to an NSNumber to use for NSDictionary lookups. Bug: 1030357 Change-Id: I5f22f81fc8f1838b1cf235584390f7d5af54ea30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977026 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
