GitLab

Network Quality Estimator (NQE) encapsulates int32_t as a
base::Optional<int32_t> at some of the places. This happens
on-the-fly. This is confusing, and may also be the
cause of some of the crashes.

Change-Id: I66142aa5047d9da577d60e17b3186c37b0c9a149
Bug: 887162
Reviewed-on: https://chromium-review.googlesource.com/1237730Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593251}

Fix the sizing of the print destinations list so that it is always set
to the maximum of the available space and 3 destinations of height.

This will ensure there is no double scrollbar unless the dialog is
extremely short.

Bug: 884741
Change-Id: Ieba1a4e634d667b2e6e5567cf6f80f5962bd0fde
Reviewed-on: https://chromium-review.googlesource.com/1235120Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593250}

2 bugs in the scaling section:
(1) Fix a pre-existing bug where the scaling input incorrectly displayed
0 and an error when fit to page was checked for a non-uniform page
size PDF
(2) Prevent cr-input from expanding to the full row to try
to fix a bug with touch on Windows.

Bug: 874226, 886854
Change-Id: I8cb8785129f125a17a2ea8715ec85af3b467cad8
Reviewed-on: https://chromium-review.googlesource.com/1237516
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593249}

The flag was enabled by default and no longer needed.

Bug: 885301
Change-Id: I84ec4557a1ca4c2f1eb70213c7bc56cd67512611
Reviewed-on: https://chromium-review.googlesource.com/1236287
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593248}

Bug: 871738
Change-Id: Ibdc024e5dce12dc1ca9d8280d4144d3576522016
Reviewed-on: https://chromium-review.googlesource.com/1179895
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593247}

This test breaks up OmniboxViewTest.PreserveDisplayTextOnFocusSearch,
which was a browser test, into three smaller unit tests.

OmniboxViewTest.PreserveDisplayTextOnFocusSearch is flaky, and the
whole set of OmniboxViewTest.* browser tests have been flaky for at
least a year.

Bug: 751031
Change-Id: I6e7a8fc88f55fee706cdfc1ee0617ce4a27f5103
Reviewed-on: https://chromium-review.googlesource.com/1232525Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593246}

Bug: 882892
Change-Id: I91d2cf5b46b8ef3b790b5e00692a053686ba17d1
Reviewed-on: https://chromium-review.googlesource.com/1236460
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593245}

This reverts commit 1eee7cc0.

Reason for revert: These tests are not run on Android; I meant to change the ones in content/

Original change's description:
> Disable FrameSizeChange tests on Android KitKat. They're flaky.
> 
> BUG=778245
> TEST=none
> TBR=xhwang
> 
> Change-Id: Ib27cef70fe4519678dfc4b0446ee4c734c31225a
> Reviewed-on: https://chromium-review.googlesource.com/1237265
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592977}

TBR=dalecurtis@chromium.org,xhwang@chromium.org

Change-Id: I7df83977706f0e90affa616b5546e1066f76c429
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 778245
Reviewed-on: https://chromium-review.googlesource.com/1239000Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593244}

With SlimNavigationManager enabled, a placeholder page is rendered at the start
of the navigation stack. Prevent this placeholder page from being registered as
a frame.

Bug: 869884
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I09907135bf48720ef4b25fb7ddaa607db4f03a27
Reviewed-on: https://chromium-review.googlesource.com/1234268
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593243}

Change-Id: I57c51a878d7d1112e4ed69db0a23008e346e670b
Reviewed-on: https://chromium-review.googlesource.com/1237556Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593242}

Also fixing focus issue with cr-policy-pref-indicator. Need to pass
make a function that returns the iron-icon that is the focusable
element and is within the shadow DOM.

Bug: 878331
Change-Id: I4c04aae355e713a086e69df3dd480193005b72b3
Reviewed-on: https://chromium-review.googlesource.com/1195674
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593241}

QuicLockImpl's methods had various lock annotations (e.g.
EXCLUSIVE_LOCK_FUNCTION), but the class itself wasn't annotated as
LOCKABLE.  After a recent clang change this was causing compiler errors
like the one reported in https://crbug.com/887610.

This CL fixes this by adding LOCKABLE annotation to QuicLockImpl.

I've searched for other files under //net/third_party/quic that include
LOCK_FUNCTION substring but do not include LOCKABLE substring.  It seems
that quic_mutex_impl.h was the only one.

Merge internal change 213866214

Bug: 887610
Change-Id: Iddedd166a97cfe1f77ea2c14a6e98a836bdb08d8
Reviewed-on: https://chromium-review.googlesource.com/1237716Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593240}

generate_milestone_report.py intendes to list all existing .ndjson
files in the given --size-file-bucket gs://bucket/subdir link, and only
generate missing .ndjson files. However, the command line used:
  gsutil ls -r gs://chrome-supersize/milestones/

is incorrect (-r means reverse). This tends to return an empty list,
and the logic is ineffective, and everything gets generated.

The correct command to list files recursively is:
  gsutil ls -R gs://chrome-supersize/milestones/*

This CL fixes the problem. However, since we're used to regenerating
everything, so we're making this the default behavior. This CL also
adds '--skip-existing' switch to only generated missing .ndjson files.

As unrelated clean-up, also add new line to end of milestones.json.

Bug: 880671
Change-Id: I2a21b59c7d7f5b1b8765ea260030814bb8188139
Reviewed-on: https://chromium-review.googlesource.com/1238814Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593239}

Multiple CachingPermutedEntropyProvider objects would all try to cache
their values in the same pref store, overwriting each other's.

BUG=866722

Change-Id: I42efd8b4eaf5f0dfec9e2b1be1fcac51e2b481ab
Reviewed-on: https://chromium-review.googlesource.com/1236290Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593238}

Original CL intention was:
This CL uses ScopedBlockingCall to mark blocking calls in /components/bookmarks.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 874080
Change-Id: I8ca5da34968b9b94659c189b02e982f51399ab49
Reviewed-on: https://chromium-review.googlesource.com/1191799Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593237}

As above, move similar tests into subdirectory, and apply minor
documentation cleanups.

Adds two new tests checking that setting an invalid (negative) available
size, clamps it to zero.

Bug: 726125
Change-Id: Id5bdfa25970a4e4bfe359377b88176043ab1f6c3
Reviewed-on: https://chromium-review.googlesource.com/1236266
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593236}

Strip out non-default download notification icons when in incognito mode
for privacy reasons.

Bug: 880359
Change-Id: I92a06923672e4f581389f56e17a2f9c0d05b8bc3
Reviewed-on: https://chromium-review.googlesource.com/1233753Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593235}

With the recent changes in the Download Service, we should use the
response headers and request url chain provided when the download is
complete.

Bug: 881314
Change-Id: I3291186c9b867130683b3b09ef9c1d226d0089f1
Reviewed-on: https://chromium-review.googlesource.com/1236274Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593234}

http://crrev.com/c/1192062 made it so that we don't enable accessibility
as often. The idea was to only enable accessibility if we get a call to
IAccessible2, or to both get_accName and a response to our alert message
on a honeypot window.

However, this only worked if we constructed at least one
BrowserAccessibilityManager. In cases where the external client
never explored and discovered a BrowserAccessibilityManager, the
IAccessible2UsageObserver wasn't registered yet.

As a fix, move the IAccessible2UsageObserver code to part of
BrowserAccessibilityStateImpl.

Bug: 878072
Change-Id: Iadcbd032fa1d6f635bbb99c1e130d384efe0d9b1
Reviewed-on: https://chromium-review.googlesource.com/1234267Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593233}

This reverts commit dad5078a.

Reason for revert: crbug.com/887868

Original change's description:
> Fix that cookies with long names can't be deleted
> 
> This change fix settings css to access expand and delete icons.
> As a Result, cookies with long names can be deleted.
> 
> Bug: 871639
> Change-Id: Ic3c090d8593ea78b61be656a316b49e240fe6b42
> Reviewed-on: https://chromium-review.googlesource.com/1202362
> Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592760}

TBR=stevenjb@chromium.org,jinho.bang@samsung.com,jdragon.bae@gmail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 871639
Change-Id: I3a2f8c3d75a91ddd54b406f2e4ca37e0f20db3cc
Reviewed-on: https://chromium-review.googlesource.com/1238813Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593232}

This method was only used by the BrowsingDataCookieHelper unit tests,
which this change converts to using the network::mojom::CookieManager
interface.

Bug: 721395
Change-Id: Ia4f5a54221d0ce902a42e8f910230ad0d732b7ee
Reviewed-on: https://chromium-review.googlesource.com/1236289Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593231}

- Migrate //mash and //ui/views examples off QuitCurrent*Deprecated().
- Migrate //net mock off it as well.

These are the final remaining call-sites that codesearch identifies as
not-test-specific (even though the mock is a mock ;).

Bug: 859095
Change-Id: I417f9c93aa6ef6eaae4cf22948e07750d176d83d
Reviewed-on: https://chromium-review.googlesource.com/1226455
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593230}

MixerServiceConnection is a component that connects
to MixerService via Socket.

Bug: internal b/29571387
Test: build and run on an audio device and verify the
assistant works fine.


Change-Id: Iae323943909167fe247666ffd2c319efcf34c3ac
Reviewed-on: https://chromium-review.googlesource.com/1231813Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593229}

There exist the following to endpoints that need to be hooked up
- NativeWidgetMac::InitWidget can use a views::BridgeFactoryHost
- AppShimHost has a views::BridgeFactoryHost that can create Cocoa UI
  in the app shim process

Hook these two up by
- Adding a virtual method NativeWidgetMac::GetBridgeFactoryHost
- Overriding this in the BrowserFrameMac sub-class
- Calling into apps::ExtensionAppShimHandler to find the
  apps::AppShimHandler::Host for the browser window
- Adding an apps::AppShimHandler::Host::GetBridgeFactoryHost method
- Overriding this in AppShimHost to return its views::BridgeFactoryHost

This involves adding the helper function
apps::ExtensionAppShimHandler::FindHostForBrowser. Most similar functions
are implemented as a static function that call GetInstance to effectively
make the function non-static. Because this is confusing, change such
instances to be non-static functions, and make public the GetInstance
method as apps::ExtensionAppShimHandler::Get.

Also do a little bit of cleanup in BridgedNativeWidgetHostImpl so that
we don't crash immediately
- Make GetBoundsOffsetForParent not dereference null and add a comment
  that its logic needs updating
- Remove |has_received_window_geometry_| because the approach that it
  assumed will not work

R=tapted
TBR=avi (for chrome/ OWNERship)

Bug: 859152
Change-Id: I9873e0c70b07468fefa90a574606cca1ed54a951
Reviewed-on: https://chromium-review.googlesource.com/1235221
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593228}

We should call
AppCacheStorage::CancelDelegateCallbacks() in DeliverNetworkResponse().
because otherwise we could call SendResponseInfo() without having a
valid URLLoaderClient.

No test since AppCacheURLLoaderJob has special casing for testing
and it's difficult to work around it.

Bug: 882538
Change-Id: I0c4661a08532d0891fc1696464b675eeb4ce6cde
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1237893
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593227}

This reverts commit 63cb63c9.

Reason for revert: Crashing in debug builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7920

Original change's description:
> More OfflineItemModel implementation
> 
> This CL makes OfflineItemModel inherit from DownloadUIModel
> 
> Bug: 881499
> Change-Id: Ic7591f5ce7f5f5243cfeb8ff89ad1e77aa1b78db
> Reviewed-on: https://chromium-review.googlesource.com/1237134
> Commit-Queue: Min Qin <qinmin@chromium.org>
> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593030}

TBR=qinmin@chromium.org,shaktisahu@chromium.org

Change-Id: I6fb1e7e1ed50df3147efdfa2e57e38577cffacf8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 881499
Reviewed-on: https://chromium-review.googlesource.com/1238859Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593226}

I discovered a small bug playing around with the new Previews Omnibox
badge that sometimes it fails to show up for certain previews that are
not fully "decided" on until page load finish.

This change updates the security icon, and therefore the verbose status
view if the page is a preview at its finish.

Bug: 871839
Change-Id: I9e5b01def3bb9548422956eed869b0820854b803
Reviewed-on: https://chromium-review.googlesource.com/1236854Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593225}

Change-Id: Ic80a13781c3a2145329f36f5c843ca6b16061587
Reviewed-on: https://chromium-review.googlesource.com/1237053Reviewed-by: Ben Wagner <bungeman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Hal Canary <halcanary@google.com>
Cr-Commit-Position: refs/heads/master@{#593224}

There is a lot of flipping going on when using the
GL_MESA_framebuffer_flip_y extension.  toDataURL and
LowLatency have competing requirments when calling
CopyToPlatformTexture.

https://codepen.io/miguelao/full/WKZaqd
https://www.khronos.org/registry/webgl/sdk/tests/conformance/canvas/to-data-url-test.html

BUG=883362

Change-Id: Iafe11c23591a79f696b652a57f2d083258d3aa9c
Reviewed-on: https://chromium-review.googlesource.com/1237248Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593223}

- CdmProxy::SetKey takes a key type. This should be used to manage
  possibly different key blobs for different key types.
- Calling CdmProxyContext::GetD3D11DecryptContext requires passing in
  a key type as well, to specify which key type it's requesting for.
- Moved CdmProxyContext from media/base to media/cdm because 1) it
  doesn't need to be in media/base and 2) it depends on cdm_proxy.h
  now, to access CdmProxy::KeyType.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4064e9426bc8efac3fe667806a9f3713881b31ac
Reviewed-on: https://chromium-review.googlesource.com/1234332
Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593222}

solid color quads used scale = 1 for non-mask layer, so when
use-zoom-for-dsf is enabled, it generates a lot more solid color
quads, which causes a bunch of rendering performance regression.

This CL makes the scale = 1 / dsf when use-zoom-for-dsf is enable,
so we generate same amount solid color quads as before.
This should not break solid color quad as it doesn't count dsf before.

Bug: 871347
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7f30ebf51fbd9bfe8800aa34f228b98985358c39
Reviewed-on: https://chromium-review.googlesource.com/1234362Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Xianda Sun <sunxd@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593221}

Because DeviceReenroller now uses the DeviceSyncClient in the destructor
to remove itself as a DeviceSyncClient::Observer, DeviceReenroller needs
to be destroyed before the DeviceSyncClient in the unit tests.

Bug: 887953, 887557, 887758
Change-Id: I23e8f150ef08e6ad3d388f4ed86d47123077f71a
Tested: Unit tests with ASAN on
Reviewed-on: https://chromium-review.googlesource.com/1238818
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593220}

Bug: 878390
Change-Id: I94ff2c90bca4434f311b042d3265df881ad8f69e
Reviewed-on: https://chromium-review.googlesource.com/1222695
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593219}

Changes the behavior of instrumentation tests to automatically
restore any shared preference files modified by
--shared-prefs-file. Also adds a simple script for manually
applying a shared preference JSON file for cases where settings
that are normally only used during automated testing are
needed for manual use.

Change-Id: I94006c1a8e48d910ed2f7e0742f001d8d62b7b15
Reviewed-on: https://chromium-review.googlesource.com/1220557Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593218}

gn.el used to be in the chromium source tree until gn moved
elsewhere. Now it lives somewhere else,
https://gn.googlesource.com/gn/+/master/tools/gn/misc/emacs/gn-mode.el
which makes it less useful.

This is a copy of that file as of today. The file is not updated
often, and when it is, it's just to add more keywords so
nothing critical.

Bug: 887937
Change-Id: I39335815a2cc8ecfe2b0e1728443f6abe84a85fa
Reviewed-on: https://chromium-review.googlesource.com/1238462Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#593217}

Jumbo is a unity build system for Chromium where many files are
compiled together. Since so much code is in headers and templates
this is much more efficient, and depending on your hardware, can
significantly speed up builds.

The headless module needs 26 CPU minutes to compile without jumbo.
With jumbo for everything, it needs 3.1 CPU minutes. Half of that
is already on master through the jumbo support in mojo. This patch
adds jumbo support for the rest, changing the compilation effort
from 15 CPU minutes to 3.

In real world time, this saves about 1.5 minutes on a full build on an
8 thread machine.

Bug: 883727
Change-Id: I3ede4805064344574c314d03904208110fdcb462
Reviewed-on: https://chromium-review.googlesource.com/1225702Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#593216}

In some jumbo build configurations, two ClampBufferSize functions
in services/network ended up in the same translation unit which
caused compilation errors.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I6b7ea9c226b114a10d59fa9891e67f83537c5ec6
Reviewed-on: https://chromium-review.googlesource.com/1238219Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#593215}

The fling unittests are using mock clock to make sure that the tests are
stable.

Bug: 868381
Change-Id: I4bafbb71edd668ea553507c00a8784c994f49597
Reviewed-on: https://chromium-review.googlesource.com/1157291Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593214}

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/22defe0965adddaa09eebc13df7fa6c64e2abba3..54d332dd9b0263821376161cdffb60ffb3c7847f

Bug: 887943
Change-Id: I1a6eed501cc396f4dff8a057b2cf958d808c7869
Reviewed-on: https://chromium-review.googlesource.com/1238467Reviewed-by: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593213}

This reverts commit 555dcba9.

Reason for revert: probably the cause of compile failures (e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-uirefresh-simulator/3246 )

Original change's description:
> [iOS][MF] Secure filling
> 
> Observe the last focused field to validate it is secure before filling a password
> 
> Bug: 878388
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
> Change-Id: Ide4407ea51b315c68c50fa010f256cde93f5eb26
> Reviewed-on: https://chromium-review.googlesource.com/1221217
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593194}

TBR=mahmadi@chromium.org,gambard@chromium.org,javierrobles@chromium.org

Change-Id: Ie272d2622baeda172a802feaf552b1771e436bc5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878388
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1238822Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593212}