GitLab

BUG=None
TEST=Manual


Review URL: http://codereview.chromium.org/9582022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124769 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9581028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124768 0039d316-1c4b-4281-b951-d872f2087c98

This is a minimal starting point for merging our upstream android
ntp resource changes into a somewhat clean slate.  Based on how little of the
shared resource cache code we used, it seems cleaner to start our own and
not muddle that file with a ton of ifdefs.

This is all in the hopes of getting sync_unit_tests linking upstream.

BUG=113487
TEST=


Review URL: http://codereview.chromium.org/9558014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124767 0039d316-1c4b-4281-b951-d872f2087c98

Page content often isn't completely loaded or laid out when
the tab is first rendered.  This makes the class
additionally notify about subsequent renders so the delegate
can hold off until it sees one after it's e.g. received
notification via a WebUI message that the page is truly
ready.

BUG=chromium-os:26210
TEST=manual; also un-disabled the tests and checked that they still pass
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/9582012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124765 0039d316-1c4b-4281-b951-d872f2087c98

Update strings.


BUG=106636
TEST=


Review URL: http://codereview.chromium.org/9433054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124764 0039d316-1c4b-4281-b951-d872f2087c98

Split out from https://chromiumcodereview.appspot.com/9363008/

BUG=110400
TEST=NONE


Review URL: http://codereview.chromium.org/9580018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124763 0039d316-1c4b-4281-b951-d872f2087c98

This is addition to http://codereview.chromium.org/9477021/

BUG=chromium-os:26646
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9584026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124762 0039d316-1c4b-4281-b951-d872f2087c98

Changing some highlight / autocomplete colors


BUG=115861
TEST=Visually tested


Review URL: http://codereview.chromium.org/9585015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124761 0039d316-1c4b-4281-b951-d872f2087c98

This removes an animation that adds a bit of jank at
startup.  It doesn't have a significant effect on boot time
in either direction, from my measurements.

BUG=chromium-os:26210
TEST=manual: booted and checked that animation is gone


Review URL: http://codereview.chromium.org/9568044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124760 0039d316-1c4b-4281-b951-d872f2087c98

Adding this message all the time prevents us from processing other command buffers when there really isn't anything left to do.

BUG=112349
TEST=


Review URL: http://codereview.chromium.org/9583021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124759 0039d316-1c4b-4281-b951-d872f2087c98

Make everything use this instead of rolling their own.

BUG=113723
TEST=

Review URL: https://chromiumcodereview.appspot.com/9562037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124758 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/9569032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124757 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:26939
TEST=--allow-webui-compositing no longer needed to get HW-accelerated decode & render on ARM crosbook.


Review URL: http://codereview.chromium.org/9583022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124756 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9569029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124755 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=build using the command line on Windows, piping through sed, see less extraneous output


Review URL: http://codereview.chromium.org/9423018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124754 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jochen
BUG=
TEST=cookies.CookiesTest.testCookiesHttps

Review URL: https://chromiumcodereview.appspot.com/9584029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116458
R=ben
TBR=davemoore

Review URL: http://codereview.chromium.org/9570044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116501

Review URL: http://codereview.chromium.org/9582020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124751 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124748 0039d316-1c4b-4281-b951-d872f2087c98

TBR=haraken@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9583028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124747 0039d316-1c4b-4281-b951-d872f2087c98

It includes:
* intoducing -z commandline option to show/not-show issue details
* fix the issues discovered by gpylint
* adding bug link and flakiness dashboard link to test expection file display

BUG=109008,107773
TEST= unit test passes and run script locally.

Review URL: https://chromiumcodereview.appspot.com/9476021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124746 0039d316-1c4b-4281-b951-d872f2087c98

(1) User types something that doesn't look at all like a keyword (e.g. "go om") and gets a non-default dropdown result that does look like a keyword ("google.com").  Arrowing down to this result, the user then presses space after the keyword name.
(2) Similar to the case above, but this time the non-default result in question looks like a keyword + some more text, with no whitespace between ("google.comxxx").  The user arrows to this result, arrows back to just after the keyword, and presses space.

Item (2) was happening because ShouldAllowExactKeywordMatch() (which has now been renamed) was always looking at the old |user_text_| as the "before change" text, which was wrong if there was temporary text, since the user text was not visible at that point.  Fixed by getting the actual displayed text in that case.

Item (1) was happening for similar reasons, but in MaybeAcceptKeywordBySpace() instead.  This could have been fixed by the same change as above.  However, I elected to change this function to look at the |keyword_| instead of the previously-displayed text, as in https://chromiumcodereview.appspot.com/9289034/ patch set 1.  Not only is this slightly simpler, it is more robust against future changes.  Let's say that someday we want to allow a provider to show a keyword hint for keyword "foobar" on input of "foo ".  By checking against |keyword_| in this function, we ensure that in that future case, the space after "foo" will never trigger keyword search mode for "foobar".  (If we ever bother to fix our bugs with keywords containing spaces, this might apply today for those as well.)

I also tried to change the naming and comments of some things for clarity.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9570064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124745 0039d316-1c4b-4281-b951-d872f2087c98

* New window frames, still behind a flag as there's more refinement to do for incognito, popups, and maximized windows.
* Translucent frames now only require a single layer the size of the window instead of two.  We may be able to cut the layer size in the future to the area of the window header + toolbar
* Rewrite BrowserNonClientFrameViewAura
* Use updated art assets from crrev.com/124602
* Allow windows optionally to specify that hit tests should include a region a few pixels outside the window. For Aura browser windows this area acts as non-client area resize handles which we need because the window frame borders are now very thin or not present at all.

BUG=113075
TEST=manual, visual inspection of browser active, inactive, incognito, popup, hosted, and app windows.  Updated aura_unittest for Window to check the expanded bounds.

Review URL: https://chromiumcodereview.appspot.com/9580001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124743 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:26961
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9580016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124742 0039d316-1c4b-4281-b951-d872f2087c98

Bug 111139: Deprecate HOMEPAGE option, remove the UI for it, migrate users away from it

BUG=111139
TEST=SessionStartupPrefTest.HomePageMigration
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9559002

TBR=tbreisacher@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9583025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124740 0039d316-1c4b-4281-b951-d872f2087c98

Before this CL the contract of SetMaxTime was unsatisfiable; a clock client
could check that the max_time it was about to set wasn't greater than Elapsed()
before calling SetMaxTime(), but between the time that check was done and the
DCHECK inside SetMaxTime, time could move forward!
After this CL, SetMaxTime() is allowed to move the media_time_ backward and set
the underflow_ bit if the pipeline is slow enough.

BUG=113037,chromium-os:26939
TEST=A Debug binary on an underpowered ARM crosbook with no audio device plays back correctly.


Review URL: http://codereview.chromium.org/9582017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124739 0039d316-1c4b-4281-b951-d872f2087c98

Also make it possible to run the test against other hosts by specifying the environment variables COOKIES_TEST_HOST

BUG=none
TEST=pyauto


Review URL: http://codereview.chromium.org/9584012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124738 0039d316-1c4b-4281-b951-d872f2087c98

If script text is in right-to-left directionality, it got truncated because the width calculated in SizeStringInt() and DrawStringInt() are different since they are passed in different flags. DrawStringInt() was passed in an extra flag DT_RTLREADING through FORCE_RTL_DIRECTIONALITY.

Fix by passing in the same flag for size calculation and drawing.

BUG=104117
TEST=manual. JS alert a text begins with Hebrew letter followed by a punctuation, such as "A?". It should not be truncated.

Review URL: http://codereview.chromium.org/9569025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124736 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=password saving should continue to work


Review URL: http://codereview.chromium.org/9564001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124735 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jochen
BUG=116515
TEST=


Review URL: http://codereview.chromium.org/9582016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124734 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nsylvain@chromium.org
BUG=109517
TEST=sync_integration_tests is properly run.
NOTRY=true

Review URL: http://codereview.chromium.org/9513008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124732 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114914
TEST=load a page that triggers the compositor and uses rAF but doesn't
cause damage. the callback rate should still be ~60fps


Review URL: http://codereview.chromium.org/9567038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124731 0039d316-1c4b-4281-b951-d872f2087c98

not in the headers.

BUG=116574

Review URL: https://chromiumcodereview.appspot.com/9584020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124730 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93427
TEST=See bug, comment 112


Review URL: http://codereview.chromium.org/9565045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124729 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62854
TEST=See bug.

Review URL: http://codereview.chromium.org/9568046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124727 0039d316-1c4b-4281-b951-d872f2087c98

Change-Id: I518e0c91a5f48ae1f5909d1e86a8fabfb97d1ec4

BUG=none
TEST=record chrome events using about:tracing simultaneous with kernel events; check the resulting kernel event log for a trace_event_clock_sync record


Review URL: http://codereview.chromium.org/9474023

TBR=sleffler@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9581019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124726 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:26646
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9582019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124725 0039d316-1c4b-4281-b951-d872f2087c98

R=erg@chromium.org


Review URL: http://codereview.chromium.org/9570059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124724 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115350
TEST=Everything looks the same.

Review URL: https://chromiumcodereview.appspot.com/9586016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124723 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116318,115952
TEST=Verify above issues.

Review URL: https://chromiumcodereview.appspot.com/9567027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124722 0039d316-1c4b-4281-b951-d872f2087c98