- 24 May, 2019 11 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e2cb4e0573e3..48c8a180b599 git log e2cb4e0573e3..48c8a180b599 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 bclayton@google.com CMakeLists: Pass sanitizer flags to the linker too. 2019-05-23 bclayton@google.com Reimplement vk::Query using sw sync primitives. Created with: gclient setdep -r src/third_party/swiftshader@48c8a180b599 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133127573,chromium:b/133127573 TBR=swiftshader-team+autoroll@google.com Change-Id: Idc02c0d54a445b5fb231e8250c66f3adf4ccec2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627865Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662913}
-
Alan Cutter authored
This is a simple reordering of the omnibox icons to better match UX mocks. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394824&signed_aid=nOrbTUMOlIuDq7tSR80dhA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394825&signed_aid=QDyPSKCoGB59hyh48HHkcQ==&inline=1 Bug: 966304 Change-Id: I612f63f0c39ef923dc6f327f4921ca57e8b9d4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626202Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#662912}
-
François Degros authored
Bug: 778674 Change-Id: I3a5f6665970cf92cd881926271a00e4bf4a537ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627731Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#662911}
-
about://gpuMaggie Chen authored
Some gpu bugs are related to the monitor refresh rate. Adding this display information will help us on gpu debugging. This CL is for Windows only. Bug: 964095 Change-Id: Ic00471897f0f7c655dbe29e3b33b5b7782cab6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621328Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662910}
-
wutao authored
This patch fixes the placement and color of image buttons in search_box_view. Previously, the right padding was not calculated and close button was using search box color. Bug: 941524 Test: manual Change-Id: I201b21257a11e188490136b05ac68dc5e15cebcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626735Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#662909}
-
Jia authored
Adapter now keeps track of number of model iterations and only starts changing brightness based on min_model_iteration_count. Bug: 881215 Change-Id: Ie9dcf15090f2e808630ad82a2bd2cfebad7cf00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621477 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662908}
-
Kyle Horimoto authored
This CL: (1) Adds a base OtaActivator class along with an OtaActivatorImpl implementation and a FakeOtaActivator for tests. (2) Adds a test for OtaActivatorImpl. (3) Updates some definitions from cellular_setup.mojom; specifically, this CL changes the ActivationResult enum. (4) Updates cellular_setup_service_unittest.cc to reflect the changes in part 3 above. Bug: 961084 Change-Id: I2d4bd9cd454014106f120144e28238f07b32a318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604213Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#662907}
-
Caleb Rouleau authored
I checked if you run like this: ./run_benchmark ... --pageset-repeat=3 --pageset-repeat=1 then the second argument overrides the first. Bug: 894254 Change-Id: Ib7138966dfa5336697a7a5c02084557f315aac4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628161Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#662906}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4163317283be..c1c0d6d8ad74 git log 4163317283be..c1c0d6d8ad74 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b82a5015..8b25075e (662691:662811) Created with: gclient setdep -r src/third_party/webrtc@c1c0d6d8ad74 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8c0f1f2eb978777187fac23c0c1c27f9abb906bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662905}
-
Maggie Cai authored
Currently we will create app navigation throttle for both main frame and iframe navigations. This causes a issue where if there is a subframe navigation it will overwrite the intent picker icon status that is shown for the main frame. Previously a CL is landed (https://chromium-review.googlesource.com/c/chromium/src/+/1609750) to fix the issue by not showing the icon when there is a iframe. However if a iframe navigation happens it will hide the icon even when the main frame navigation request the icon to show. This CL fixs the issue and adds tests for it. BUG=964802 Bug: b/132641354 Change-Id: Ic7ce20daf4c7c7bd96eb48f112db2fd59214a14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624073Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#662904}
-
Caroline Rising authored
Make tab hover cards not focus traversable from their anchoring tabs. Bug: 963537 Change-Id: I881099b8fb289d15fe29ada24495d737695a5626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627214 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#662903}
-
- 23 May, 2019 29 commits
-
-
John Williams authored
Change-Id: If36c8e11912078057c8143d2c8ed8ecbc86c9f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606969 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#662902}
-
David Tseng authored
TBR=nektar@chromium.org Change-Id: I15de5ee774e138ce74a6d0b12430992d7f7b0a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627705Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#662901}
-
Esmael El-Moslimany authored
Bug: 966404 Change-Id: I58caaf3a80d99945dd430eeff9d18610d07c79e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626680Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#662900}
-
Jimmy Gong authored
- Fixes a regression where users were able to type in >63 characters, exceeding the maximum length allowed for a printer address. - According to RFC, 63 characters is the max length allowed for a hostname. Bug: 963856 Test: End to End manual Change-Id: I0d2e8a224755037a027422c11b9b5e4f5d05fa92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620600Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#662899}
-
tby authored
In M75, we used the EnableAdaptiveResultRanker flag for the QBNA model. Change this to EnableQueryBasedMixedTypesRanker for M76 for consistency with our other flags. This CL will be followed with a corresponding change to the Finch GCL file. Since we don't use the EnableAdaptiveResultRanker flag for anything else, this CL also removes it. Bug: 931149 Change-Id: I130b19b0d5f2a6b18e074ac1945a4df861577967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623727Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#662898}
-
Kyle Horimoto authored
The <internet-config> element is used in two situations: (1) When attempting a connection to an unconfigured network. In this case, once the user fills in the information needed to configure the network (e.g., Wi-Fi password) and clicks "Connect", a connection is attempted to that network. (2) When attempting to configure a network without connecting. In this case, once a user clicks "Save", the network is configured, but no connection attempt occurs. Currently, the dialog title reads "Configure <networkName>" as long as the network has a name. However, for parity with InternetConfigDialog, the title should read "Join <networkType>" in the first case listed above. This CL accomplishes this goal by piggybacking on top of the "showConnect" property of <internet-config>. Bug: 963841 Change-Id: I542b1adef3edc1e7cbd4c9dea1ebe63c8af2b7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628108 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#662897}
-
Caroline Rising authored
Bug: 910739, 965642 Change-Id: Ifd32508bab312dcb9ec9e9bcd86ac98b755725f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625844Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#662896}
-
Esmael El-Moslimany authored
Bug: 966300 Change-Id: I4106b1d83ed27574cdb8b6257ffbc9973736634c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626677Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#662895}
-
Kenichi Ishibashi authored
Before this CL, WebSharedWorkerImpl didn't call SelectAppCacheID() after the main script fetch when off-the-main-thread script fetch is enabled. This CL moves the callsite of SelectAppCacheID() to DidFetchScript(). DidFetchScript() is called in both "on" and "off" the main thread script fetch so it will get called in both code paths. For off-the-main-thread script fetch, the appcache ID is plumbed from WorkerClassicScriptLoader in SharedWorkerGlobalScope. Also there could be a potential race between IPC messages for appcache selection and subresource requests if we evaluate the top-level script immediately after script fetch. To avoid the race this CL introduces a callback to SelectAppCacheID(). The callback is invoked when the browser process sends AppCacheFrontend::CacheSelected mojo IPC. SharedWorkerGlobalScope evaluates the top-level script after the callback is invoked. This fixes shared worker related tests in wpt/html/browsers/offline/appcache/workers/appcache-worker.https.html Bug: 945673 Change-Id: I03c965bff166d6265e9a8479745fa7c1ae1a976c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614656 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#662894}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6bb193c86a9a..d2683459da1d git log 6bb193c86a9a..d2683459da1d --date=short --no-merges --format='%ad %ae %s' 2019-05-23 ynovikov@chromium.org Skip Texture2DIntegerTestES3.IntegerTextureNonZeroBaseLevel Created with: gclient setdep -r src/third_party/angle@d2683459da1d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: Iaf3be37c76b6db484600485088724c55d23d6239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627963Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662893}
-
siashah authored
Bug: 965651 Change-Id: Iae94513290b3821935ba7f13df387d951bbb5fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623285Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#662892}
-
Matthew Jones authored
This only applies if the content does not have a custom lifecycle. This patch also adds a test for this functionality. Change-Id: Ia5f2d87e3d3d0b8d83b7181e23e3b403fbd8b0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624813 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#662891}
-
Min Qin authored
This will help analyze the user complaints about download restart issue. BUG=965215 Change-Id: Idc9191a5a5e76a6ad779f3afa3f5f8fd80f7b8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626678 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#662890}
-
Lei Zhang authored
The PrintMsg_Print_Params parameter being passed in is always the same PrintRenderFrameHelper member variable. Just use that. Change-Id: I425dc94f2fad3a85349493919a27d425b2172e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626994Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#662889}
-
Tom McKee authored
Change-Id: Ib623320193e083bad0080f1a1ab09a855c1a6078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625018 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#662888}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7817cf48888aeb185bb7210cd9406ff96ddd6c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662887}
-
Etienne Bergeron authored
This CL is modifying the font-settings API on Windows. The goal of this CL is to remove the gfx::PlatformFontWin::GetLocalizedFontName(...) calls since the gfx::PlatformFontWin will be replaced by gfx::PlatformFontSkia. The GDI API was listing the system fonts by using the system locale which means the font-name was the localized name. The DWrite API allows the caller to specify the locale and is not forced to be the system one. The font-settings API is shipping a list of pair of string to extensions when the GetList is called (e.g fontId and displayName). The fontId is used as an identifier for other font-settings API. The DisplayName is the name that is displayed to the user. On windows, both string were used to be the Localized name since the GDI API was returning the localized name. A extra conversion was needed when an other windows API returns a non-localized name to be sure it will be the same FontID. By enforcing fontId to be non-localized, these extra conversion are now useless. And only the displayName is localized. Bug: 944227 Change-Id: Iab1bff832504fbf9abc8860ece31357148c01cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606661 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#662886}
-
Avery Musbach authored
See Comment 2 here: https://bugs.chromium.org/p/chromium/issues/detail?id=961170#c2 Test: manual Bug: 961170 Change-Id: I42509d8f4ff4cffa84441ea392b56a68ac8d608b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627910 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#662885}
-
Steve Kobes authored
Also rename keys in the TracedValue to avoid the word "jank". Bug: 963474 Change-Id: I598a9f80cdd873474292785a081f40cc923f9772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627936 Auto-Submit: Steve Kobes <skobes@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#662884}
-
Jordan Bayles authored
This patch rolls the third_party openscreen repository to its latest head. Change-Id: I9e624db30b40901b4cda67b334bdd5d341639fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627700Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#662883}
-
Justin DeWitt authored
The IPH should be shown when the button is: * Fully rendered * Has not been shown today * Has not been shown more than 3 times. Change-Id: Iafbb56c313e6dff21c99ca12167cf67ecca994ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625367 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#662882}
-
Junyi Xiao authored
Accessibility testing revealed the following within the tool: 1. an empty heading for clear storage button section This change adds: 1. hide section heading element if title is empty 2. group the check boxes underneath Application/Storage/Cache sections to deliver a better experience for keyboard/SR users 3. add test coverage Bug: 963183 Change-Id: Ic7ceae7fa513fe959aa45e041c7064e650afa720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601573Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#662881}
-
Harley Li authored
Bug: 818855 Change-Id: I9f626a01d9188ae25e82bc4d2a6201f20c90e621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622714Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#662880}
-
Paul Jensen authored
Some ~NetworkChangeNotifier overloads post destruction to other threads, which races ~NetworkChangeNotifier's clearing of g_network_change_notifier. Clear g_network_change_notifier at the begining of ~NetworkChangeNotifier overloads to prevent this. Bug: 965660 Change-Id: If6d792ea0f1badd7c816308646104e0f72ca5b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625307Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662879}
-
Maksym Onufriienko authored
Added testBookmarkHelpers in smoke_egtest. Bug: 922813 Change-Id: I59b2348545e737c2b756abcc58eb77e07c491c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626012 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#662878}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d2e8e116faf1..94515755316b git log d2e8e116faf1..94515755316b --date=short --no-merges --format='%ad %ae %s' 2019-05-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@94515755316b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I996b19cda40dd28e8fb90af3b2111f1341884048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662877}
-
Zhenyao Mo authored
This aligns with WebGL's powerPreference semantic. More importantly, discrete/integrated GPUs might be a good description of Mac dual GPU situation, but it's incorrect on Windows. BUG=966251 TEST=bots R=kbr@chromium.org Change-Id: I2c7f073f06be3c2b2444bf0a81f56f71e656a713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626458Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#662876}
-
Luum Habtemariam authored
These files encapsulate useful libCUPS-dependent utils for the CupsProxyService. Also renames type_conversions.cpp -> *.cc. Bug: chromium:495409 Test: TBA Change-Id: If55498960da9608438face8e6b8c4e1cfebfbb42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608720 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#662875}
-
Yuwei Huang authored
* Fix a bug in MuxingSignalStrategy such that it keeps waiting for both strategies to connect instead of giving up and using whatever is available. This essentially rewrites the state transition logic. * Add unittest for MuxingSignalStrategy. Bug: 966632 Change-Id: Ic94b1ef47b5109acd5d603f02cb8659353c02a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628130 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#662874}
-