GitLab

PaymentRequest.canMakePayment() should return true if user has a payment
app with an instrument or a credit card with valid name and number.

BUG=674926

Review-Url: https://codereview.chromium.org/2558993003
Cr-Commit-Position: refs/heads/master@{#439486}

R.java and R.txt files for an AAR were generated by extracting all
resources from the AAR and its dependencies and running aapt on these
resources. This approach turned out to be problematic for AARs of
GMS (Play Services).

GMS is shipped as a bunch of AARs with dependencies between them.
However the way it deals with resources is rather unusual. GMS code
references all resources via com.google.android.gms.R class that
corresponds to the "basement" AAR. This AAR has R.txt with entries for
all resources of the GMS but contains only a small subset of the
resources. All other resources are provided by other AARs: they have
different packages and no R.txt files though.

The consumer of the GMS must generate com.google.android.gms.R class
with entries for all resources provided by used GMS AARs. Entries for
resources that belong to the unused AARs may be ommited. This is what
Gradle plugin for Android does.

However AAR support in Chromium discarded R.txt from "basement" then
generated very small com.google.android.gms.R without essential entries
and this caused crashes in runtime.

This CL changes processing of the AARs resources. If R.txt is present in
AAR then aapt-generated R.txt is discared. The one from AAR is used to
generate R.java for java dependencies of the AAR target and to generate
final R.java file during APK build which is compiled and included into
the final APK.

During obfuscation Proguard checks that all entries that are referenced
in code were in fact generated. This check cannot be done during resource
processing because "basement"'s R.txt lists resources that aren't
included in Chromium and this is because code that uses these resources
isn't included either.

BUG=670368
R=agrieve@chromium.org,dgn@chromium.org

Review-Url: https://codereview.chromium.org/2570313002
Cr-Commit-Position: refs/heads/master@{#439485}

Partition Alloc, which has been recently moved to base/, has tests
that rely on the ability to successfully make large (512 MB)
allocations. Turns out this is not possible on small devices like
ChromeCast, that seem to either have little overcommit margins or
a heavily fragmented address space.

This CL skips those tests on devices that have < 2 GiB of physical
memory. For the same reason, it lowers down the chunk size of the
RepeatedReturnNullDirect test. The rationale of the test is to check
that repeated failures are handled consistently when performing
directly mapped allocations. The chunk size is irrelevant as long as
it is big enough to hit the directly-mmap codepaths (current
threshold = 1 MB).

BUG=675255

Review-Url: https://codereview.chromium.org/2589813002
Cr-Commit-Position: refs/heads/master@{#439484}

The media controls are (at least sometimes) painted twice. The second
time after figuring out how many buttons fit into the available width.
At least one of the fullscreen tests were flaky because the first paint
was dumped instead of the second one. Adding a layoutAndPaintAsyncThen
in the full-screen-test.js framework seems to fix the issue.

Although the issue was filed after landing changes for issue 567021,
the flakiness is also seen locally without those changes running the
test with --repeat-each=30 in debug.

R=fs@opera.com
TEST=virtual/android/fullscreen/full-screen-stacking-context.html
BUG=675055

Review-Url: https://codereview.chromium.org/2586243002
Cr-Commit-Position: refs/heads/master@{#439483}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4fc181694898..f394e56d2888

$ git log 4fc181694..f394e56d2 --date=short --no-merges --format='%ad %ae %s'
2016-12-19 jbudorick [py_utils] Add temporary directory context manager.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2590503002
Cr-Commit-Position: refs/heads/master@{#439482}

This will allow code to be reused to initialize TaskScheduler based on
variation params in renderers.

To avoid breaking ios-internal, this CL keeps existing
components/task_scheduler_util APIs. Code in ChromeContentBrowserClient
and ios-internal will be migrated to the new APIs in separate CLs.
Then, old components/task_scheduler_util APIs will be deleted.

TBR=blundell@chromium.org
BUG=664996

Review-Url: https://codereview.chromium.org/2565013002
Cr-Commit-Position: refs/heads/master@{#439481}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/events/,
fetch/, fileapi/, and frame/. There are too many references to change
them all at once, so this CL is part 6 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2585283002
Cr-Commit-Position: refs/heads/master@{#439480}

Fixes compilation failure introduced by c3ac4fc0.

fgetc() returns its result as an _unsigned_ char and defines EOF as -1, and
gives the result as an int.  If char is unsigned it's impossible for EOF to
match, and this results in a compilation error.  If char is signed then
potentially valid input could match EOF.

BUG=674765
R=altimin@chromium.org, skyostil@chromium.org

Change-Id: I979a8401e8c33d8983e7d1bee96b81bc555863ec
Review-Url: https://codereview.chromium.org/2579773003
Cr-Commit-Position: refs/heads/master@{#439479}

Recent change caused passphrase dialog to show "On - sync everything" instead
of "Signed in as <email>" on Passphrase dialog on android. I'm reverting this
behavior.

R=maxbogue@chromium.org
BUG=674733

Review-Url: https://codereview.chromium.org/2584973002
Cr-Commit-Position: refs/heads/master@{#439478}

Use use_partition_alloc=false GN arg in Cronet

BUG=674570
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2577173002
Cr-Commit-Position: refs/heads/master@{#439477}

https://skia.googlesource.com/skia.git/+log/a8b1e6d0688c..746cc0b92290

$ git log a8b1e6d06..746cc0b92 --date=short --no-merges --format='%ad %ae %s'
2016-12-18 update-skps Update SKP version
2016-12-17 reed simplify generatescaledpixels

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2580393002
Cr-Commit-Position: refs/heads/master@{#439476}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2580333003
Cr-Commit-Position: refs/heads/master@{#439475}

Sk{Dilate,Erode}ImageFilter::Make take the radii as integers (int), so
make sure to convert the float FEMorphology stores avoiding overflow.

BUG=675164

Review-Url: https://codereview.chromium.org/2585233002
Cr-Commit-Position: refs/heads/master@{#439474}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2588733002
Cr-Commit-Position: refs/heads/master@{#439473}

This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL)

The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566 on 12/9/2016.

BUG=672527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2573803002
Cr-Commit-Position: refs/heads/master@{#439472}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2587023002
Cr-Commit-Position: refs/heads/master@{#439471}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a9c4767f..af5c10c8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2587913003
Cr-Commit-Position: refs/heads/master@{#439470}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2589583003
Cr-Commit-Position: refs/heads/master@{#439469}

Instead of having a 2 seconds timeout, using a combination of setTimeout
of 0 and requestAnimationFrame.

BUG=513398
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2586223002
Cr-Commit-Position: refs/heads/master@{#439468}

For all sensors new reading values are read and 'onchange' notfication is send from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.

Before this change a timers were used and this could unnecessarily drain CPU and battery.

BUG=668052
BUG=606766

Review-Url: https://codereview.chromium.org/2551223003
Cr-Commit-Position: refs/heads/master@{#439467}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2589803002
Cr-Commit-Position: refs/heads/master@{#439466}

This patch fixes a bug introduced by r438239 where the
ui::PlatformEventSource was destroyed before entering the GPU message
loop.

BUG=674350

Review-Url: https://codereview.chromium.org/2584513002
Cr-Commit-Position: refs/heads/master@{#439465}

https://skia.googlesource.com/skia.git/+log/64b70b096ac2..a8b1e6d0688c

$ git log 64b70b096..a8b1e6d06 --date=short --no-merges --format='%ad %ae %s'
2016-12-19 rmistry Revert of Generate Signed Distance Field directly from vector path (patchset #23 id:440001 of https://codereview.chromium.org/1643143002/ )

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2586983002
Cr-Commit-Position: refs/heads/master@{#439464}

Metric added in: https://codereview.webrtc.org/2530393003/

BUG=

Review-Url: https://codereview.chromium.org/2540323006
Cr-Commit-Position: refs/heads/master@{#439463}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2590473002
Cr-Commit-Position: refs/heads/master@{#439462}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2588713002
Cr-Commit-Position: refs/heads/master@{#439461}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2586993002
Cr-Commit-Position: refs/heads/master@{#439460}

crrev.com/2543163002 added a potential performance fix to remove extra
layouts of positioned children of grids. The problem that was instead of
just avoiding an extra layout, it was also preventing the code positioning
the children from running. The main consecuence was that all positioned
children were always painted in cell (0,0) of the grid.

BUG=273898

Review-Url: https://codereview.chromium.org/2582363002
Cr-Commit-Position: refs/heads/master@{#439459}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/13995c3e..a9c4767f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2582353002
Cr-Commit-Position: refs/heads/master@{#439458}

Review-Url: https://codereview.chromium.org/2586173003
Cr-Commit-Position: refs/heads/master@{#439457}

Headless Shell is a command line application so it has a good excuse to
print out console messages.

BUG=546953

Review-Url: https://codereview.chromium.org/2581643004
Cr-Commit-Position: refs/heads/master@{#439456}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking the downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2580363002
Cr-Commit-Position: refs/heads/master@{#439455}

Upstream part of Chrome on iOS source code. Nothing is build yet,
just new files added. The file will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2585233003
Cr-Commit-Position: refs/heads/master@{#439454}

In the resource_prefetch_predictor, the maximum number of concurrent
prefetches is set to 24. This is too high, as:
- It defeats the prioritization of resources in the database
- It was shown to slow down page loads in some case on slow connections
  by starving the page load resource fetches. (local testing using WPR
  and tools in tools/resource_prefetch_predictor)

BUG=631966,655980

Review-Url: https://codereview.chromium.org/2589713002
Cr-Commit-Position: refs/heads/master@{#439453}

This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.

This change also removes the requirement on having {asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.

BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots:
mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng
linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng
linux_chromium_asan_rel_ng

Review-Url: https://codereview.chromium.org/2580313002
Cr-Commit-Position: refs/heads/master@{#439452}

This CL:
1) Adds CategoryRanker interface;
2) Adds a default constant category ranker implementation (based on
   CategoryFactory);
3) Replaces CategoryFactory with a new ranker;
4) Factory methods are moved to Category.

This is the initial step of moving to personalised section order.

BUG=673659

Review-Url: https://codereview.chromium.org/2568033005
Cr-Commit-Position: refs/heads/master@{#439451}

It's unused

BUG=610176

Review-Url: https://codereview.chromium.org/2589653002
Cr-Commit-Position: refs/heads/master@{#439450}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/78033db9..13995c3e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2584393002
Cr-Commit-Position: refs/heads/master@{#439449}

Currently, the update prompt only refers to password manager as "Smart Lock" if
the PasswordBranding experiment group is SmartLockBranding. The save prompt and
both prompts on all other platforms (desktop + iOS) also accept the group
SmartLockBrandingSavePromptOnly.

This CL fixes the Android update prompt to follow the rest.

R=dvadym@chromium.org
BUG=674969

Review-Url: https://codereview.chromium.org/2582613003
Cr-Commit-Position: refs/heads/master@{#439448}

ActiveDOMobjects were renamed to SuspendableObjects.
This CL updates the comment accordingly.

BUG=610176

Review-Url: https://codereview.chromium.org/2584383002
Cr-Commit-Position: refs/heads/master@{#439447}