GitLab

Convert the implementation and all users of the
chrome_cleaner::mojom::CleanerEngineRequests interface.

Bug: 955171
Change-Id: Ic89e56e567b1d357fb994f5636cd62adbfb4c8c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855922
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711539}

Bug: 1019252
Change-Id: I92e73ae5f587fc50a05676f7c3eb5502d0caaf64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887891Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711538}

- This CL added a interface for controllers and use factory
to create the instance based on the feature flag.
- Registered this client into system.
- Added UpdateNotificaitonScheduleCoordinator in Java side.
- In Java side, moved all notifications related code under
omaha/notifications.


Bug: 1013685
Change-Id: I791d590e9c3b5d03a842e818e902ee630f588031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888115Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711537}

This splits the libxml_utils helper classes into xml_reader and
xml_writer targets. The xml_writer can be safely used from any target.
The xml_reader has strictly limited visibility to locations that are
audited by the Security Team. Direct access to the libxml target is now
also limited.

Bug: 699306
Change-Id: I141de7d855f5cb8e886e99403e048cf331f7320c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884750Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711536}

This CL cleans up old Mojo types for mojom::Receiver using
Receiver.

Bug: 955171
Change-Id: I5ad59189f2759a6df51d768dedf78d1dd95d18c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890382Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711535}

- add a README.chromium for the Speech Rule Engine
- move all files out of ...chromevox/[injected|background] to chromevoxclassic (which is the only user).
- add a gni file for liblouis library generation (for classic)

TBR=dmazzoni@chromium.org

Change-Id: I7e0c38a360438845edc39f0b34aeda502c0a4aab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892553
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711534}

Ran 100 times locally w/o flaking.  This does add @RetryOnFailure
to be consistent with the test above, which does this only a single
time.

BUG=516018

Change-Id: I233166bb2ca9004a02dd81a9a3b32cc5a72545f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893977Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Yun Liu <yliuyliu@google.com>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711533}

Bug: 1006268, 860467
Change-Id: I98ee82f2a672ba09f9e06f27f8a7164f729c4719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816511
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711532}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b0434c1ced7a..fa2b7d8d16c4


Created with:
  gclient setdep -r src-internal@fa2b7d8d16c4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:1019931,chromium:1018879,chromium:1018879
Change-Id: I9bb27ed76585fb82533f66dd2fae0fe4f30da5aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894056Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711531}

This fixes a crash when building with _LIBCPP_DEBUG=0. This function
returned true for nullopt < nullopt when it should return false.

Bug: 923166
Change-Id: I904566ad19ca4ac6e1405db15851ffa79b3a4836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894099
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711530}

This CL cleans up old Mojo types for network::mojom::NetworkContext using
ReceiverSet.

Bug: 955171
Change-Id: I6b368a65a42d9441c56aaea4e2c5692e2b361c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890522Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711529}

This prevents a browser crash when a page attempts to use the Web
Speech API.

Bug: 1019511
Change-Id: Ie369adc51dc4fa8228bd9df5a1b102dffd44daa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888105Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711528}

Change-Id: I06d29a268b5c1b0526dc04c2980b116a987d54c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890403Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711527}

Convert the implementation and all users of the
chrome_cleaner::mojom::EngineRequests interface.

Bug: 955171
Change-Id: I32b6bc3f8d1e1f7c55f688c8dca5df85b9097472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855980
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711526}

Now DEVICE_LOGS_PROVIDER_PACKAGE is a CSV and the first successfully resolved one would be used.


Bug: b/143482167
Change-Id: Ieaa204b1ea4ca8002f2711d60d103fc54178a51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887846Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Chunlei Niu <niuchl@google.com>
Auto-Submit: Chunlei Niu <niuchl@google.com>
Cr-Commit-Position: refs/heads/master@{#711525}

https://pdfium.googlesource.com/pdfium.git/+log/0fa7fef72b53..dd9ef1c0d58f

git log 0fa7fef72b53..dd9ef1c0d58f --date=short --no-merges --format='%ad %ae %s'
2019-10-31 thestig@chromium.org Add a pixel test for a JPEG2000 decoding issue.

Created with:
  gclient setdep -r src/third_party/pdfium@dd9ef1c0d58f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: chromium:1012369
Change-Id: I2260c1ee58d61a4eeb4ebad6961844d9e32a2e6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894371Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711524}

Avoid creating a default virtual authenticator if the browser is not
running layout or WPT tests under content shell. This is not necessary
and confusing for anyone using the ChromeDriver API.

Fixed: 1019934
Change-Id: I4fc9f8a997df1f3c8bbf9120b6c1c1268259858c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891466
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#711523}

To support for RAPPOR metrics is being removed.

Bug: 1016906
Change-Id: Iec73c63fff60ce9c28b9428dd283ed48bec805dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891820Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711522}

Using wpt-import in Chromium e752660f.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
igrigorik@chromium.org, yoavweiss@chromium.org:
  external/wpt/preload

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Ia1626d4fbed3578da0217995975f7081368aee86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893753Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711521}

Isolated contexts are designed for "web UI" content, which should only
require basic audio and rendering features.

Bug: b/143575823
Change-Id: I83c3cea67de8c61b2a85f0f05729c1674c38ae76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893525Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711520}

This test frequently fails on win7.

Tbr: jrummell@chromium.org
Bug: 1019187
Change-Id: I6da53e240c90d6f510419398f770396f79cf2112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894436Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711519}

This reverts commit 0a8ea251.

Reason for revert:
This CL is causing the text in the bar to be drawn smaller,
and is suspected as the cause of issue 1020081.

BUG=1012835, 1020081

Original change's description:
> [TTS] Fix elippsis overlap with Bar icon mangle.
> 
> Fixes a drawing problem where the ellipsis on contracting
> text does not erase when it contracts and the icon is drawn
> over the older version of the text image.
> 
> This only happens on one brand of devices.
> 
> Renames the OverlayPanelRepaddingTextView.java file to
> OverlayPanelAdjustingTextView.java and the actual adjustment
> is done in native code now (which is not ideal -- see bug for
> details).
> 
> BUG=1012835
> 
> Change-Id: I4c1068743a54e7970d12dfa5cce23dd1f1733235
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883113
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Auto-Submit: Donn Denman <donnd@chromium.org>
> Commit-Queue: Donn Denman <donnd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710559}

TBR=donnd@chromium.org,twellington@chromium.org,mdjones@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1012835
Change-Id: I381b03a4af00e827930529f92a22d8bcbb4fd0cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894398Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711518}

With committed interstitials, this callback is no longer used.

Also remove OnProceed and OnDontProceed from some SSL pages (which
have been superseded by handling in SSLErrorControllerClient), and
DCHECK that the blocking page ready callback is non-null.

Bug: none
Change-Id: Ibbc7f07827ec9c2bd68bae5a7505bd44a9bf94f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888743
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711517}

* Basic support: a generic SSL interstitial is used for all SSL
  error types

* Interaction: the user can interact with the page (proceed or
  back out). As with WebView, decisions are not saved across
  sessions.

* Minimal impact: much code that we would like to refactor and
  share is instead copied for now to minimize changes outside
  of //weblayer.

This builds on the work of blundell@chromium.org at
https://chromium-review.googlesource.com/c/chromium/src/+/1872091

Testing is facilitated by badssl.com.

Binary-Size: Increase is due to translations and so cannot be avoided.
Change-Id: I68edba70ee8e0ca1078be13d9ab8bc0d96c0321c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885227Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711516}

Move fast/forms/controls-new-ui tests to virtual/controls-refresh, so that
virtual/controls-refresh/fast/forms/controls-new-ui now becomes
virtual/controls-refresh.

Move fast/forms/controls-new-ui/color-scheme-validation to
virtual/controls-refresh-high-contrast, so that
virtual/controls-refresh-high-contrast/fast/forms/controls-new-ui/color-scheme-validation
becomes virtual/controls-refresh-high-contrast.

Bug: 1014162
Change-Id: Ie97ee4f55d8fb2d6372dbec5b43f32531fd7b15a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892153Reviewed-by: Sanket Joshi <sajos@microsoft.com>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711515}

Currently, drag and hold gesture for transition from home to overview is
handled by SwipeHomeToOverviewController owned by
HomeLauncherGestureHandler, which means that shelf layout manager's
drag_status_ indicates app list drag while the home-to-overview drag is
in progress.
This causes hotseat not to change its state while the
drag is handled, the behavior which is suboptimal given that home screen
can transition to overview while the gesture pointers are still down
(the shelf should update to reflect the state change immediately).

This cl introduces new drag status type, that enables the shelf layout
manager to treat shelf updates differently while home to overview
gesture is active than when app list drag is active.

BUG=1005366

Change-Id: I555b344a57df0830b5380d48ce98237673aad2d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894136
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711514}

Bug: b/136496918
Change-Id: Icce31ca74fb93d94553ef35bf9164192dddb71af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894051
Auto-Submit: Jie Dai <jied@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Jie Dai <jied@google.com>
Cr-Commit-Position: refs/heads/master@{#711513}

This is a reland of 849315dd

Original change's description:
> Make AppMenuModel keep most submenus in a vector.
> 
> They are only needed for ownership, so no need to give them names and concrete
> types. Removes some forward declarations from the header and serendipitously
> happens to remove GOOGLE_CHROME_BUILD from the header as well.
> 
> No intended behavior change.
> 
> Bug: 961769
> Change-Id: Ibaaf3375bd9d367b4cc83b9a8ec3e64193750a69
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894032
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711431}

Bug: 961769
Change-Id: Ic076b82d89cdcb4dcf97e88a4e04b88e22e7e504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893003
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711512}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/925e218b..10d5ae79

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iba61344a3128d6a360674f0b2e9a6cce9744a304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893752Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711511}

This updates a temporarily disabled network tool test to expect
timeouts. The test will be rebaselined and re-enabled after
has landed and DEPS has rolled


https: //chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881592
Bug: 963183
Change-Id: Id1abfbc2b032c75d37011991a61912f8015a48c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893508Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#711510}

This reverts commit 411235fc.

Reason for revert: Introduced a flaky test case. See issue 1020342.

Original change's description:
> WebUI Tab Strip: Only track thumbnails for visible tabs
> 
> - Track thumbnails only if they are currently in view or are
> just a standard finger swipe away.
> - Do not track thumbnails for pinned tabs.
> - Do not track thumbnails when the tab strip is closed.
> 
> Note that this CL does not implement actually untracking thumbnails.
> It merely calls the method in the C++ side that will eventually do it.
> 
> Bug: 1015132
> Change-Id: I86f7a8ea284395fc97dfed60fbb0452a0dfaa8ca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885504
> Commit-Queue: John Lee <johntlee@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711109}

TBR=dpapad@chromium.org,johntlee@chromium.org

Bug: 1015132
Change-Id: Ibf55975b9009734f58a744faa0bbea069ea9986c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894326Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711509}

There's a few NOTIMPLEMENTED in BinaryFCMService that really should
just do nothing. This CL removes them.

Fixed: 1019875
Change-Id: I6b63e687b69d2da268d4dd12bcf0d892556f45f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893524
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711508}

This test has recently started flaking consistently on linux. Disabling for now.
This is failing locally due to receiving valid paint updates for the main frame,
which is not expected for a seamless iframe. Indicates the problem may be coming
from blink. Test is only flaking 1/100 times, making a fix hard to verify quickly.

TBR=csharrison@chromium.org

Bug: 986642
Change-Id: Icc55950e549361169a8d07a1764c6ed06490e301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894106Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Auto-Submit: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711507}

This fixes an ambiguous reference when building against MSSTL:

In file included from ../../content/browser/webauth/virtual_authenticator.cc:5:
In file included from ../..\content/browser/webauth/virtual_authenticator.h:16:
In file included from ../..\device/fido/virtual_fido_device.h:17:
../..\base/containers/span.h(501,21): error: call to 'data' is ambiguous
  return span<T, N>(data(container), size(container));
                    ^~~~
../../content/browser/webauth/virtual_authenticator.cc(148,29): note: in instantiation of function template specialization 'base::make_span<32, std::vector<unsigned char, std::allocator<unsigned char> >, unsigned char, void>' requested here

                      base::make_span<device::kRpIdHashLength>(
                            ^
_NODISCARD constexpr auto data(_Container& _Cont) -> decltype(_Cont.data()) { // get data() for container
                          ^
../..\base/stl_util.h(116,16): note: candidate function [with Container = std::vector<unsigned char, std::allocator<unsigned char> >]
constexpr auto data(Container& c) -> decltype(c.data()) {
               ^
_NODISCARD constexpr auto data(const _Container& _Cont)
                          ^
../..\base/stl_util.h(133,16): note: candidate function [with Container = std::vector<unsigned char, std::allocator<unsigned char> >]
constexpr auto data(const Container& c) -> decltype(c.data()) {
               ^
1 error generated.

C: \projects\src\out\Default\..\..\..\..\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\xutility(1168,27): note: candidate function [with _Container = std::vector<unsigned char, std::allocator<unsigned char> >]
C: \projects\src\out\Default\..\..\..\..\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\xutility(1173,27): note: candidate function [with _Container = std::vector<unsigned char, std::allocator<unsigned char> >]
Change-Id: Icf64aecbc5501a9aa3a9938befef0a703745d5ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894264
Commit-Queue: Jeremy Apthorp <jeremya@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Jeremy Apthorp <jeremya@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711506}

Check all testable files, not just source files.

Bug: 1018801
Change-Id: I94e1fe78e57304dacaa59bb12d4004cffc7d6580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893503Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711505}

Implemented the tab swithcer longpress menu on the bottom.
In the meanwhile, decreased the menu width to match the design spec.

Bug: 1011012
Change-Id: If1edc83bf9b10d332fc7627e9b88b2aed191a201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856729Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#711504}

This reverts commit 8657999c.

Reason for revert: Caused crash crbug.com/1020181.

Original change's description:
> Don't create GraphicsLayers for VisualViewport
> 
> Now VisualViewport creates cc::Layers instead of GraphicsLayers, and
> creates foreign layers directly during painting instead of by collecting
> GraphicsLayers. This makes VisualViewport use the same code for CAP and
> pre-CAP.
> 
> PaintLayerScrollableArea still uses GraphicsLayers which are created by
> PaintLayerCompositor/CompositedLayerMapping.
> 
> GraphicsLayers created by PaintLayerCompositor/CompositedLayerMapping
> no longer need to attach to VisualViewport which no longer creates
> GraphicsLayers.
> 
> Bug: 1012594
> Change-Id: I5ce76a3b5728d3810d85d536357cb437eea5fc4f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869126
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710881}

TBR=wangxianzhu@chromium.org,bokan@chromium.org,pdr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1012594, 1020181
Change-Id: I3e0f5fa0b3698d8af7cd9f6d6f81e34f40c8b30d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894110
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711503}

Provide developers with guidance on how to adapt to the changes
introduced in manifest version 3.

Change-Id: Ie25a3bc6e09e3621e3c78a736057006cf954c9f9
Bug: 1018443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880695
Commit-Queue: Simeon Vincent <simeonv@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711502}

This change adds a PredictionModelFetcher to the PredictionManager
to update the models and host model features it manages. The
models returned from the fetch are stored in the in-memory maps
owned by the prediction manager.

Future changes will asynchronously store the models in a leveldb store
and create a schedule of when fetch attempts should be made.

and I've already spent a non-trivial amount of time trying
to reduce its size that is mostly due to a new proto being added.

Bug: 1001194
Change-Id: I38d8e6f69f469e0d83e9e6e3910325e4da9b913a
Binary-Size: Increase needed to implement a new feature,
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846561
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711501}

- Change the dialog title.

Bug: 1020283
Change-Id: I794834076f17bf95880f737f30598a4bc234f9fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894172
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711500}