- 27 Nov, 2018 40 commits
-
-
Wenzhao Zang authored
This CL changes the behavior. Another CL (https://crrev.com/c/1341158) removes the resources, but for now we don't want to land the second one because the resources will be used by Discover. Bug: 903577 Change-Id: I004abeb0541f64c5ab8ba655cf8c7cf6736a7cb6 Reviewed-on: https://chromium-review.googlesource.com/c/1341149Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611025}
-
Kent Tamura authored
This CL renames the following md files: - layout_tests_linux -> web_tests_linux.md - how_to_extend_layout_test_framework.md -> how_to_extend_web_test_framework.md - testing/layout_test_baseline_fallback.md -> testing/web_test_baseline_fallback.md - testing/layout_test_expectations.md -> testing/web_test_expectations.md - testing/layout_tests.md -> testing/web_tests.md - testing/layout_tests_in_content_shell.md -> testing/web_tests_in_content_shell.md - testing/layout_tests_tips.md -> testing/web_tests_tips.md - testing/layout_tests_with_manual_fallback.md -> testing/web_tests_with_manual_fallback.md - testing/writing_layout_tests -> testing/writing_web_tests.md No-Try: true Change-Id: Ied34815c92e449888b20818540a5ed0a76107bd1 Bug: 843412 Reviewed-on: https://chromium-review.googlesource.com/c/1350559 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#611024}
-
Xi Cheng authored
Change-Id: I0ff4dbdf64ae3d2176a2e5bd1afe0ed353ebe223 Reviewed-on: https://chromium-review.googlesource.com/c/1343559Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#611023}
-
Kent Tamura authored
third_party/blink was forked from WebKit, so we should credit for WebKit. Move third_party/WebKit/LICENSE_FOR_ABOUT_CREDITS to third_party/blink. Remove third_party/WebKit/OWNERS because third_party/WebKit doesn't have files any longer. No-Try: true Bug: 622551 Change-Id: Icdf9b5a08e78848925cd4a7db48d076c1baa328a Reviewed-on: https://chromium-review.googlesource.com/c/1350011 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#611022}
-
Josh Pratt authored
Assigns owners for the following Crostini flags: crostini-usb-support disable-crostini-files enable-experimental-crostini-ui Bug: 897809 Change-Id: I077743a15cb65e552d38e23f189401193723006f Reviewed-on: https://chromium-review.googlesource.com/c/1345673Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Josh Pratt <jopra@chromium.org> Cr-Commit-Position: refs/heads/master@{#611021}
-
Collin Baker authored
This moves GetTab{Foreground,Background}Color() and ShouldDrawStrokes() to TabStrip. This also plumbs other necessary functions through TabStripController. Change-Id: Iff487d3d228ae4ea3101b713df16c79183fe53cf Reviewed-on: https://chromium-review.googlesource.com/c/1343255Reviewed-by:Bret Sepulveda <bsep@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#611020}
-
Devlin Cronin authored
There's not really much point in the distinction between page and browser actions anymore, and we'd like to merge them. Make the declarativeContent.showPageAction API work with browser actions. A follow-up will introduce declarativeContent.showAction. Bug: 893375 Change-Id: Ib4651c225099c62070239f0c37cb4b075d124b1c Reviewed-on: https://chromium-review.googlesource.com/c/1270006Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611019}
-
dpapad authored
Bug: 847729 Change-Id: I31ab35f815a578d236eff6a75fdfa45a3a6df89f Reviewed-on: https://chromium-review.googlesource.com/c/1351507Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#611018}
-
Scott Violet authored
The client is notified of changes to the window owner. BUG=756085,875111 TEST=covered by test Change-Id: I8cec4fe2b547bb1f9f31899e2bc2a9437c186d27 Reviewed-on: https://chromium-review.googlesource.com/c/1343507 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#611017}
-
Kent Tamura authored
PRESUBMIT.py existed just for linting LayoutTest/TestExpectations. It's unnecessary now. No-Try: true Bug: 622551 Change-Id: I4e3d801ecfa829f3a99e187eb2058fa326aa7c67 Reviewed-on: https://chromium-review.googlesource.com/c/1350430 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#611016}
-
Yutaka Hirano authored
Bug: 891131 Change-Id: I00c96a302291e4df79810e67e3a50cdf96a7c104 Reviewed-on: https://chromium-review.googlesource.com/c/1350384Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#611015}
-
Ted Choc authored
BUG= Change-Id: I11d351d4681554741a961cd2d54c9de102192bd8 Reviewed-on: https://chromium-review.googlesource.com/c/1345273Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#611014}
-
Abhishek Bhardwaj authored
This changes removes the deprecated GetNetworks API. BUG=907245 TEST=Boot and test ARC++ WiFi apps. Change-Id: Iec0f9e18ba6a709af6e40d205503e5c1bf2545cb Reviewed-on: https://chromium-review.googlesource.com/c/1344991Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#611013}
-
Yoshifumi Inoue authored
This patch removes //third_party/WebKit/Tools/.gitattributes to make the directory empty as follow-up of the patch[1]. [1] http://crrev.com/c/1338583 Remove //third_party/WebKit/Tools and //blink No-Try: true Bug: 829697 Change-Id: Icae6924a6365e9b32c274dbb063914c03f052279 Reviewed-on: https://chromium-review.googlesource.com/c/1350560 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#611012}
-
Alex Newcomer authored
Change-Id: Ifee152ae16c133e0d2dcf7f334e1ff7700a47167 Reviewed-on: https://chromium-review.googlesource.com/c/1341068Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#611011}
-
Carlos Knippschild authored
This change adds a base::Clock pointer to the base TaskQueue tasks and updates all time related calls in tasks and tests in: components/offline_pages/core/prefetch/tasks/ Bug: 906903 Change-Id: Ia701af7d49dcd5376c903598e61f490721149df2 Reviewed-on: https://chromium-review.googlesource.com/c/1344829Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#611010}
-
Robert Ma authored
Add a list of skipped commits when looking for exportable commits. Currently, there is only one commit in the list: the great LayoutTests->web_tests move. Bug: 908445 Change-Id: Ia5cf4f66b93966e2a510a0d04932643a9e6fadaf Reviewed-on: https://chromium-review.googlesource.com/c/1351451Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#611009}
-
Alex Newcomer authored
Remove code that is dead now that touchable app menus are enabled by default. Bug: 906684 Change-Id: I28bb46da596ba93e0bbc01c0685ed1cc1b7ec0ac Reviewed-on: https://chromium-review.googlesource.com/c/1341064 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#611008}
-
Sergey Ulanov authored
This reverts commit 48d32d67. Reason for revert: FDIO doesn't handle overrides as expected. Original change's description: > [Fuchsia] Allow namespace overrides in base::LaunchProcess > > Previously base::LaunchProcess didn't allow paths_to_transfer to be used > with the FDIO_SPAWN_CLONE_NAMESPACE flag. This meant that to override > directories the test launcher had to avoid FDIO_SPAWN_CLONE_NAMESPACE > flag. This is not ideal because of the added complexity in the test > launcher and also because the launcher was changing test environment > by not cloning all entries in the namespace (i.e. some tests would behave > differently when started with --single-process-tests flag). This change > updates LaunchProcess() to allow individual dirs transfer while cloning > the rest of the namespace. Also updated test launcher to use this new > feature. > > This CL should unbreak the tests currently broken in > https://crrev.com/c/1341243 > > Change-Id: I3c30497222ffd33d6240f478523d3e767fad90f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1345236 > Reviewed-by: Scott Graham <scottmg@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610042} TBR=thakis@chromium.org,kmarshall@chromium.org,sergeyu@chromium.org,scottmg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Iecb39de51037b41cc4b75914c688e1b412dcce71 Reviewed-on: https://chromium-review.googlesource.com/c/1351788Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611007}
-
David Bertoni authored
Change-Id: I1ad110c817b75e62116dfcb0fabe17eb9f40088f Reviewed-on: https://chromium-review.googlesource.com/c/1351598Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#611006}
-
Noel Gordon authored
- change ProgressCenter externs file to be an @interface class - rename background page ProgressCenter to ProgressCenterImpl, and make it @implement the {ProgressCenter} interface - use ProgressCenterImpl as the implementation for Files App. - make MockProgressCenter @implement ProgressCenter for tests - add missing ProgressCenter methods to MockProgressCenter to make it Closure compile. - BUILD rules for progress_center, and mock_progress_center, were added in CL:1349139, and CL:1349147, respectively. No change in test behavior, no new tests. Bug: 908379 Change-Id: I087b72abce9221d464761724e3fcf2ccdb2dfad5 Reviewed-on: https://chromium-review.googlesource.com/c/1350563Reviewed-by:Stuart Langley <slangley@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#611005}
-
Max Moroz authored
Bug: 907693 Change-Id: I3514c9aa5aacf68e7b9964b637ac79c5fbe29b50 Reviewed-on: https://chromium-review.googlesource.com/c/1351286Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#611004}
-
Michael Ludwig authored
Bug: 908573 Change-Id: I13cbff6aae855aebe0194e71308b0c97faed3680 Reviewed-on: https://chromium-review.googlesource.com/c/1351505Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#611003}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/15992bef28d8..5552cdf032dd git log 15992bef28d8..5552cdf032dd --date=short --no-merges --format='%ad %ae %s' 2018-11-26 syoussefi@chromium.org Vulkan: Create buffer view for BufferHelper 2018-11-26 geofflang@chromium.org Vulkan: Implement ANGLE_translated_shader_source 2018-11-26 syoussefi@chromium.org Vulkan: Implement vk::BufferView 2018-11-26 jmadill@chromium.org Update clang-format settings. 2018-11-26 geofflang@chromium.org GL: Work around Qualcomm sRGB ReadPixels driver bug. 2018-11-26 geofflang@chromium.org GL: Implement GL_NV_fence on top of GLsync objects. 2018-11-26 matavenrath@nvidia.com Don't generate TypeInfo objects as static objects within GetTypeInfo function 2018-11-26 tobine@google.com Debug: Add Systrace Markers Created with: gclient setdep -r src/third_party/angle@5552cdf032dd The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:882580 TBR=fjhenigman@chromium.org Change-Id: Ifb31c9d8ba778ce1fa9528b3981749391828e293 Reviewed-on: https://chromium-review.googlesource.com/c/1351471Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611002}
-
Nico Weber authored
Bug: none Change-Id: I698f0ddd7625b432bbb8ae75f4574181d30f991b Reviewed-on: https://chromium-review.googlesource.com/c/1351385Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#611001}
-
Noel Gordon authored
- remove device_handler_unittest.html - add BUILD rule to auto-generate this unit test - add BUILD rule to Closure compile this unit test - rename handler -> deviceHander, use mockChrome everywhere and also install it during Setup() - remove unused timeoutCallbacks var - fix Closure errors, js code auto-format No change in test behavior, no new tests. Bug: 908673 No-try: true Change-Id: I46535df1c77a57c488e40f9c410ca4a62ad73ac5 Reviewed-on: https://chromium-review.googlesource.com/c/1351336 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#611000}
-
Joel Hockey authored
The first time when FilesApp is started in a session, it should show a toast displaying the number of folders currently shared with crostini, and a link to manage sharing. * Added state to crostini::CrostiniSharePath keyed profile service for whether the GetPersistedSharedPaths function has been called in a session. * Change FileManagerPrivateInternalGetCrostiniSharedPathsFunction to call file_manager::util::ExtractMountNameAndFullPath which allows Entry to be set sync rather than async via file_manager::util::ConvertFileDefinitionListToEntryDefinitionList * Changed CommandHandler.recordMenuItemSelected to be public to allow us to record UMA when user selects 'Manage sharing' in the startup toast. Bug: 878324 Change-Id: I283eb49b61bafdde414a7d1b7aa0723997687742 Reviewed-on: https://chromium-review.googlesource.com/c/1350375Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#610999}
-
Nico Weber authored
The non-pnacl gcc-based nacl compilers embed absolute paths in their debug info. This is bad for goma usage and build determinism. Since I've never seen a stack in nacl-built code and neither the code nor the toolchain are changing much anymore, just disable symbols for nacl-built code. (The same code when built with a non-gcc nacl toolchain of course still has symbols, including the nacl-clang-built IRT where we archive the symbols for production builds.) Bug: 899438,906741,429358 Change-Id: I3062a26f25281759cc240f1967ab670f28e562a6 Reviewed-on: https://chromium-review.googlesource.com/c/1351492Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#610998}
-
Victor Vasiliev authored
R=bnc@chromium.org Change-Id: I4645a737b8554c86ab4f21361e44cadae84f2d4b Reviewed-on: https://chromium-review.googlesource.com/c/1347213Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#610997}
-
Dmitry Titov authored
ExploreSitesService is a lightweight object that lazily initiates heavier resources on demand. Currently, it is created by UI (NTP page being open), however it starts subsequent background activities (refreshing the catalog of sites, and collectingusage statistics) so it should be started even if UI does not require it. This CL adds the service to dependency manager list so it is created early in the initialization of Profile. Bug: 905120 Change-Id: I63c30decd2bc9e70729438cc06a596089efcd585 Reviewed-on: https://chromium-review.googlesource.com/c/1334936 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#610996}
-
ziyangch authored
-Change VLOG(1) and VLOG(2) to LOG(INFO). -Change VLOG(3) and VLOG(4) to DVLOG. -Remove the usage of CMALOG(kLogControl) BUG=internal b/73490388 Test=locally build. Change-Id: I27976d42ef57346c348b496690a79b870655e9d1 Reviewed-on: https://chromium-review.googlesource.com/c/1343560Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#610995}
-
Koji Ishii authored
The out-of-flow code assumed that all fragments for a LayoutInline has the same height, but the change for crbug.com/903578 (WIP CL:1251142) breaks the assumption. This patch fixes by computing the rect and uniting them, instead of taking the max of heights. No behavior changes until the WIP CL lands. Change-Id: I9fe6b35d25836fde10dd88dd90ca2a810f5c9863 Bug: 636993, 903578 Reviewed-on: https://chromium-review.googlesource.com/c/1351189Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610994}
-
Nick Harper authored
This domain was submitted via hstspreload.org, but since it's in the Google section of the preload list, I'm processing it manually. Bug: b/67939706, crbug.com/867024 Change-Id: I9007c6bf02b5e2871a4e398dc1388b5cf37932bb Reviewed-on: https://chromium-review.googlesource.com/c/1345213Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610993}
-
Moja Hsu authored
Cyan device doesn't support 4160*3120 resoltuion, removes this resolution since not all devices support it. TEST=ran jpeg encode tests on cyan BUG=b:119928581 Change-Id: I2593e57f1478cfbd9806e8879b77925e851ccf23 Reviewed-on: https://chromium-review.googlesource.com/c/1350446Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610992}
-
Ken MacKay authored
Move playout channel selection and mono mixing to StreamMixer to simplify the logic. Bug: internal b/118685514 Change-Id: I6c2d871d23958d615c4bf828b5b6013929e3bea0 Reviewed-on: https://chromium-review.googlesource.com/c/1347207Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610991}
-
Kunihiko Sakamoto authored
This feature is behind the Experimental Web Platform feature flag. Spec PR: https://github.com/whatwg/html/pull/4048 Bug: 813452 Change-Id: I84c58035789b64a311637cebc4672d16661980c2 Reviewed-on: https://chromium-review.googlesource.com/c/1350558Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#610990}
-
Etienne Pierre-Doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowBaseSyncPrimitives in non-test files * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=satorux@chromium.org Bug: 766678 Change-Id: I6855a1ea8732e053ad687cfc2318bf001a9a4b6f Reviewed-on: https://chromium-review.googlesource.com/c/1325207Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#610989}
-
Koji Ishii authored
`is8_bit` was renamed to `is_8bit` in r610457 (CL:1347430). This patch matches `webkit.natvis` to the new naming. Tested with natvis warning enabled in VS2017 15.7.1. Bug: 834780 Change-Id: I7b4dc417e195c530aa36ec387ed6c5f111782d4a Reviewed-on: https://chromium-review.googlesource.com/c/1350387Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610988}
-
Min Chen authored
Should consider whether the dragged window can be snapped when trying to get the snap position on the drag position. Then in multi-tabs drag, drag one tab out of the source window will not put the source window to the snapped window's position during drag. Note, browser window may can't be snapped on different display bounds or scales. Bug: 905924 Change-Id: I9166092af4252ca44b221da082be1fdb0297f034 Reviewed-on: https://chromium-review.googlesource.com/c/1345425Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#610987}
-
gogerald authored
Since we expect this feature has positive impact, so it would better to not asking again and again. Bug: 806868 Change-Id: I4dd50a60a9dc350cb0710d333f1489d3a4967a5d Reviewed-on: https://chromium-review.googlesource.com/c/1351582Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#610986}
-